[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1400 + if (ResultType.isUnsigned()) { +LHS.From().uadd_ov(RHS.From(), HasMinOverflowed); +LHS.To().uadd_ov(RHS.To(), HasMaxOverflowed); Using `uadd_ov`

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 354154. manas added a comment. Fix issues involving cases for unsigned type and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

gnossier added a comment. Is this ready to merge soon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

jsji created this revision. jsji added reviewers: PowerPC, lkail, w2yehia. Herald added subscribers: shchenz, jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype int __compare_and_swap (volatile int*

[PATCH] D94355: [Passes] Add relative lookup table converter pass

pcc added inline comments. Herald added a subscriber: ormris. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:73 + return false; + +// If an operand in the lookup table is not dso_local, In the version of the patch that you committed,

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

tstellar added a comment. I'm curious, what kind of system are you running on where you need to use --gcc-toolchain x86_64-redhat-linux-gnu is required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104831/new/ https://reviews.llvm.org/D104831

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a comment. In D104777#2837347 , @brunodefraine wrote: > In D104777#2836669 , @dblaikie > wrote: > >> Yeah, all that sounds reasonable to me - @brunodefraine could you look into >> supporting

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104822/new/ https://reviews.llvm.org/D104822

[PATCH] D104505: [HIP] Defer operator overloading errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG82e03e494f98: [HIP] Defer operator overloading errors (authored by yaxunl). Herald added a project: clang.

[clang] 82e03e4 - [HIP] Defer operator overloading errors

Author: Yaxun (Sam) Liu Date: 2021-06-23T23:39:59-04:00 New Revision: 82e03e494f9884e03b1ab4dfd3b55e6aa2161ade URL: https://github.com/llvm/llvm-project/commit/82e03e494f9884e03b1ab4dfd3b55e6aa2161ade DIFF:

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added a comment. Thanks for the revert, I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 ___ cfe-commits mailing list

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. In D99487#2832079 , @modimo wrote: > In D99487#2821343 , @TaoPan wrote: > >> I checked the microsoft SEH tests with >> >> 1. cl.exe >> >> a. x4ptcu.c: build error >> 2. clang-cl.exe + lld

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

zequanwu added a comment. Hi, this caused compiler crash: "Assertion `materialized_use_empty() && "Uses remain when a value is destroyed!"'" on chromium build https://ci.chromium.org/ui/p/chromium/builders/try/linux-official/151/overview. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

MaskRay added a comment. > Adding the platform tripplet x86_64-redhat-linux-gnu the while list of > supported x86_64 triplets so that it can be used with the --gcc-toolchain > option to bypass this process and force-pick a given gcc install. Did you set `--target=x86_64-redhat-linux-gnu`? With

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe655e74a318e: AST: Create __va_list in the std namespace even in

[clang] e655e74 - AST: Create __va_list in the std namespace even in C.

Author: Peter Collingbourne Date: 2021-06-23T18:59:10-07:00 New Revision: e655e74a318e0b4140391ae18725300c7f0629f6 URL: https://github.com/llvm/llvm-project/commit/e655e74a318e0b4140391ae18725300c7f0629f6 DIFF:

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy updated this revision to Diff 354135. hoy added a comment. Updating D104831 : [clang] Add x86_64-redhat-linux-gnu as a platform triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104831/new/

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

hoy created this revision. Herald added subscribers: modimo, wenlei, pengfei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang requires a valid/compatible installation of gcc from which it includes some internal headers.

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

JojoR added a comment. Thanks for your commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104822/new/ https://reviews.llvm.org/D104822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

pcc updated this revision to Diff 354130. pcc added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/ https://reviews.llvm.org/D104830 Files: clang/lib/AST/ASTContext.cpp clang/test/CodeGen/aarch64-varargs.c

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

pcc created this revision. pcc added reviewers: rsmith, eugenis. pcc requested review of this revision. Herald added a project: clang. This ensures that the mangled type names match between C and C++, which is significant when using -fsanitize=cfi-icall. Ideally we wouldn't have created this

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

This revision was automatically updated to reflect the committed changes. Closed by commit rGab244db1fa0b: [AIX] Emitting diagnostics error for profile options (authored by Whitney). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/

[clang] ab244db - [AIX] Emitting diagnostics error for profile options

Author: Whitney Tsang Date: 2021-06-24T00:23:28Z New Revision: ab244db1fa0b72f3c0ac928158569fdcc6db0236 URL: https://github.com/llvm/llvm-project/commit/ab244db1fa0b72f3c0ac928158569fdcc6db0236 DIFF: https://github.com/llvm/llvm-project/commit/ab244db1fa0b72f3c0ac928158569fdcc6db0236.diff

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

HsiangKai updated this revision to Diff 354117. HsiangKai added a comment. Split vlseg and vlseg_ff tests in two different files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103527/new/ https://reviews.llvm.org/D103527 Files:

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG42b99e094c4f: [Clang] Check for returns_nonnull when deciding to add allocation null checks (authored by modimo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 42b99e0 - [Clang] Check for returns_nonnull when deciding to add allocation null checks

Author: modimo Date: 2021-06-23T17:15:12-07:00 New Revision: 42b99e094c4f57b52807c56641c0a545b4a9a600 URL: https://github.com/llvm/llvm-project/commit/42b99e094c4f57b52807c56641c0a545b4a9a600 DIFF: https://github.com/llvm/llvm-project/commit/42b99e094c4f57b52807c56641c0a545b4a9a600.diff LOG:

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but pls wait for 1 or 2 days to see if there is any more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics lkail wrote: > hubert.reinterpretcast wrote: > > Can you add a link to something

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://reviews.llvm.org/D104803

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

Whitney updated this revision to Diff 354108. Whitney added a comment. move code later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/ https://reviews.llvm.org/D104803 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:786 +<< PGOGenerateArg->getSpelling() << "-flto"; +if (ProfileGenerateArg) + D.Diag(diag::err_drv_unsupported_opt_for_target) Isn't this block of

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a comment. Unfortunately I don't think In D104797#2836475 , @pmatos wrote: > @tlively Do you think it would be ok to re-add the code removed in `ac81cb7e` > but only error if the pointer is to an **opaque** non-integral type?

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:41 +void InitThreads() { + uptr alloc_size = UINT64_C(1) << kShadowBaseAlignment; + uptr thread_start = reinterpret_cast(

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 354098. leonardchan marked 7 inline comments as done. leonardchan edited the summary of this revision. leonardchan added a comment. Rebased against recent refactoring commits and addressed some comments. I think I can omit some functions like

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

Whitney updated this revision to Diff 354096. Whitney marked an inline comment as done. Whitney added a comment. Updated one of the test cases to use `--target=powerpc64-ibm-aix`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104803/new/

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine added a subscriber: probinson. brunodefraine added a comment. In D104777#2836669 , @dblaikie wrote: > Yeah, all that sounds reasonable to me - @brunodefraine could you look into > supporting nodebug in a similar way as @aaron.ballman has

[PATCH] D104822: [RISCV] Add vget/vset intrinsics for inserting and extracting between different lmuls.

craig.topper created this revision. craig.topper added reviewers: frasercrmck, rogfer01, kito-cheng, khchen, arcbbb, HsiangKai, evandro. Herald added subscribers: StephenFan, vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/unsupported-option.c:14 + +// RUN: not %clang -fprofile-generate --target=powerpc-ibm-aix %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=AIX-PROFILE-LTO Worthwhile to use the 64-bit

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang updated this revision to Diff 354082. NeHuang added a comment. - Rebased the patch with ToT and the patch https://reviews.llvm.org/D102875 - Create the patch with all contexts. (Thanks @qiucf) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 354081. NeHuang added a comment. - Added Sema check for the pwr9 only builtins and updated the test cases. - Rebased the patch with ToT. - Cleaned up the test cases and address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

mstorsjo added a comment. In D104556#2837104 , @rnk wrote: > In D104556#2837006 , @MaskRay wrote: > >> Is it possible to ask MSVC to add the 64-bit `IMAGE_REL_AMD64_REL64` and >> `IMAGE_REL_ARM64_REL64`? >>

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple abandoned this revision. varungandhi-apple added a comment. Herald added a subscriber: ormris. Combined changes into D95561 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 354073. varungandhi-apple added a comment. Herald added a subscriber: ormris. Combined D95984 into this patch since all necessary LLVM patches have landed, so having the patches separated out is not helpful.

[PATCH] D104381: [analyzer] Added a test case for PR46264

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Cool, thanks! Comment at: clang/test/Analysis/diagnostics/PR46264.cpp:7-8 +// `3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc` from 24.05.2020. +namespace ns1 { +namespace a { +class b

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

rnk added a comment. In D104556#2837006 , @MaskRay wrote: > Is it possible to ask MSVC to add the 64-bit `IMAGE_REL_AMD64_REL64` and > `IMAGE_REL_ARM64_REL64`? > Newer compiler metadata techniques can benefit from using the same mechanism > for all

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. In D104808#2836991 , @kripken wrote: > In D104808#2836942 , @sunfish wrote: > >> Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or >> wasm32-wasi eventually?

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

arphaman added a comment. I've started testing this change. I'll let you know how it looks in a few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 ___

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#2836900 , @rnk wrote: > In D104556#2831787 , @MaskRay wrote: > >> Hmm, IMGREL (`IMAGE_REL_AMD64_ADDR32NB`) looks useful and is an alternative >> solution to PC-relative

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 11 inline comments as done. mibintc added a comment. some inline replies. I think this is all set now. Comment at: clang/lib/Sema/SemaExpr.cpp:4026 + !E->isLValue() && + (ExprTy->isFloatingType() || (ExprTy->isComplexType( { +return

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354061. mibintc marked 2 inline comments as done. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files:

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

kripken added a comment. In D104808#2836942 , @sunfish wrote: > Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or > wasm32-wasi eventually? This is talking a step away from that. I definitely think we should unify them as much

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sunfish added a comment. Do we still intend to unify Emscripten's ABI with wasm32-unknown-unknown or wasm32-wasi eventually? This is talking a step away from that. One of the assumptions behind this is that it would be ok for malloc to be 16-byte aligned anyway, because SIMD use cases benefit

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay added a comment. `lock` and `using` will be considered identifiers where as if and while will be seens as if/while M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=99 Name=identifier L=66 PPK=2 FakeLParens= FakeRParens=0 II=0x1fdc7a0 Text='lock' From what I can tell they will be handled by

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/deferred-oeverload.cu:55 callee3(); // dev-error {{no matching function for call to 'callee3'}} callee4(); // com-error {{no matching function for call to 'callee4'}} + S

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, well, this does look cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97224/new/ https://reviews.llvm.org/D97224

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

rsmith added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:954-956 +// Keeping the alignment of long double to 8 bytes even though its size is +// 16 bytes alows emscripten to have an 8-byte-aligned max_align_t which +// in turn gives is a 8-byte

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

rnk added a comment. In D104556#2831787 , @MaskRay wrote: > Hmm, IMGREL (`IMAGE_REL_AMD64_ADDR32NB`) looks useful and is an alternative > solution to PC-relative relocations in ELF / relocation subtraction in Mach-O. > But leveraging it seems to need

[PATCH] D104804: [AMDGPU] Add gfx1035 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. Do you have any interest in seeing if gdb could/would be fixed to handle the imported declaration style? Might be worth knowing if that's feasible, if they have some ideas about if/why that would be a bad idea, etc. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 added a comment. @sunfish what do you think about doing this for all WebAssembly targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104808/new/ https://reviews.llvm.org/D104808 ___

[PATCH] D104808: [clang][emscripten] Reduce alignof long double from 16 to 8 bytes

sbc100 created this revision. Herald added subscribers: wingo, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This means `max_align_t` is 8 bytes which also sets the alignment malloc. Since this is technically and

[PATCH] D103184: Reland "[AArch64] handle -Wa,-march="

jcai19 added a comment. In D103184#2831542 , @nickdesaulniers wrote: > Thanks for following up on a fix! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/

[PATCH] D103184: Reland "[AArch64] handle -Wa,-march="

This revision was automatically updated to reflect the committed changes. Closed by commit rG0eac975b51cc: Reland [AArch64] handle -Wa,-march= (authored by jcai19). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/

[clang] 0eac975 - Reland "[AArch64] handle -Wa,-march="

Author: Jian Cai Date: 2021-06-23T12:01:57-07:00 New Revision: 0eac975b51cca5b54a1f516d05a233c215375eda URL: https://github.com/llvm/llvm-project/commit/0eac975b51cca5b54a1f516d05a233c215375eda DIFF: https://github.com/llvm/llvm-project/commit/0eac975b51cca5b54a1f516d05a233c215375eda.diff

[PATCH] D104804: [AMDGPU] Add gfx1035 target

aakanksha555 created this revision. aakanksha555 added reviewers: kzhuravl, msearles, rampitec. Herald added subscribers: foad, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

exv requested changes to this revision. exv added a comment. This revision now requires changes to proceed. Oops, didn't mean to accept, see my other comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/ https://reviews.llvm.org/D104388

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

exv accepted this revision. exv added a comment. This revision is now accepted and ready to land. I have a few concerns about this implementation: - If the incorrect formatting is due to `lock` and `using` not being recognized correctly, shouldn't we instead fix how those keywords are parsed? -

[PATCH] D104505: [HIP] Defer operator overloading errors

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCUDA/deferred-oeverload.cu:55 callee3(); // dev-error {{no matching function for call to 'callee3'}} callee4(); // com-error {{no matching

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06fbdeae752: [compiler-rt][hwasan] Add InitState options to thread initialization (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

HazardyKnusperkeks added a comment. I have basically no idea about C#, thus not much to say. I think if the old tests pass and the new are as expected it is good. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:647 + "Function(Val, (Action)(() =>

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. That was fast. I personally like it better to give others a chance to look at. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774

[PATCH] D104803: [AIX] Emitting diagnostics error for profile options

Whitney created this revision. Whitney added reviewers: hubert.reinterpretcast, etiotto, bmahjour, kbarton, daltenty. Whitney added a project: LLVM. Whitney requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only LLVM-based instrumentation

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

craig.topper added a comment. We may want to update the code in X86ISelLowering getAVX2GatherNode and getGatherNode to replace freeze+poison on Src with a zero vector. We already do this when the Src is undef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl added a comment. In D104800#2836594 , @yaxunl wrote: > I am not quite sure about whether "-fdeclare-opencl-builtins" should be kept > when input is preprocessor output. Suggestions? Thanks. The question is that whether those builtins declared

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. In D104082#2835496 , @fhahn wrote: > In D104082#2835080 , @zequanwu > wrote: > >> Hi, this caused compiler crash with error "Assertion >> `cast(Scope)->describes(>getFunction())'

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie added a comment. In D104777#2836327 , @aaron.ballman wrote: > In D104777#2835965 , @dblaikie > wrote: > >> @aaron.ballman Do we have attributes/infrastructure for attributes that have >> to be the

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/deferred-oeverload.cu:55 callee3(); // dev-error {{no matching function for call to 'callee3'}} callee4(); // com-error {{no matching function for call to 'callee4'}} + S s; tra wrote: > If we're

[clang] 4a14206 - [AIX] Emitting diagnostics error for profile options

Author: Whitney Tsang Date: 2021-06-23T18:17:40Z New Revision: 4a14206522384f5868227145a6598f41710e6c91 URL: https://github.com/llvm/llvm-project/commit/4a14206522384f5868227145a6598f41710e6c91 DIFF: https://github.com/llvm/llvm-project/commit/4a14206522384f5868227145a6598f41710e6c91.diff

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d24b45b8f8: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/test/AST/arithmetic-fence-builtin.c:34 + + v = (a + b); + aaron.ballman wrote: > Does the `(a + b)` still have an AST node for the `ParenExpr`? Nevermind, it won't, it'll have the `CallExpr` node. I think

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl added a comment. I am not quite sure about whether "-fdeclare-opencl-builtins" should be kept when input is preprocessor output. Suggestions? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104800/new/ https://reviews.llvm.org/D104800

[PATCH] D104800: [OpenCL] Do not include default header for preprocessor output as input

yaxunl created this revision. yaxunl added a reviewer: Anastasia. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. When clang driver is used with -save-temps to compile OpenCL program, clang driver first launches clang -cc1 -E to generate

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag aaron.ballman wrote: > > Should this option also be exposed to clang-cl (should it be a > > `CoreOption`)? > I don't know the

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/ https://reviews.llvm.org/D104388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a subscriber: reames. pmatos added a comment. Adding @reames to subscribers since he's the author of https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b and might have something to add to the discussion. Repository: rG LLVM Github Monorepo

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. This patch would have fixed the problems with AArch64 caused by D95425 . However, since that was landed and reverted, this landed: https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b This breaks the test

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

rsmith added a comment. I've given this some more thought, and I think it's only the "constant evaluated" check that we want to bypass in this case. It's common to use `sizeof` or `decltype` with a comma operator in order to put an expression in a SFINAE context, and I don't think we should

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

craig.topper added a comment. In D104790#2836253 , @aqjune wrote: > I couldn't find end-to-end tests for checking assembly generation. > To check whether this is working ok, which tests should I write and how would > it look like? There are tests like

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos created this revision. pmatos added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM.

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 9 inline comments as done. mibintc added a comment. A couple inline replies to go along with the updated patch Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag Should this option also be exposed to

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354009. mibintc added a comment. The patch I uploaded for review yesterday wasn't correct, not sure what happened. This one looks better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov added a comment. I'll update tommorow. Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:120 + + template const llvm::APSInt (T X) { +static llvm::APSInt Int = APSIntTy.getZeroValue(); vsavchenko wrote: > Default to `BaseType`?

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

aaron.ballman added a comment. In D104777#2835965 , @dblaikie wrote: > @aaron.ballman Do we have attributes/infrastructure for attributes that have > to be the same from their first declaration or at least from their first > call? I'm wondering if it

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

vsk added a comment. A one-time exception to the .profraw compatibility policy sounds reasonable to me. A little more context: llvm has historically rev'd the .profraw format with abandon to deliver performance/size improvements (as David & co. did with name compression) and new functionality

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added a comment. In D100118#2833864 , @mibintc wrote: > This patch addresses almost all the review comments, not yet sure about > @aaron.ballman 's question about CoreOptions FWIW, I'm fine addressing that comment in a follow-up. Also, it

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should land this only after we accept D100118 because it's only needed for that functionality. Repository: rG LLVM Github

  1   2   >