[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

cor3ntin updated this revision to Diff 359677. cor3ntin added a comment. Fix cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-

[PATCH] D106252: Implement P2092

cor3ntin updated this revision to Diff 359676. cor3ntin added a comment. Fix cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106252/new/ https://reviews.llvm.org/D106252 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/l

[PATCH] D106252: Implement P2092

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Simple requierements in requierement body shall not start with requires. A warning was already in place so we just turn this warning into an error. In

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001 ___

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

khchen updated this revision to Diff 359670. khchen added a comment. rebase on D105168 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 Files: clang/lib/Basic/Targets/

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

HsiangKai updated this revision to Diff 359667. HsiangKai added a comment. Add else and llvm_unreachable() for unhandled floating types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105001/new/ https://reviews.llvm.org/D105001 Files: clang/incl

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 359666. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Rename -fnormalize-whitespace to -felide-unnecessary-whitespace - error when used without -E - Reabse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur marked an inline comment as done. Meinersbur added a comment. In D104601#2877855 , @aaron.ballman wrote: > In D104601#2848366 , @Meinersbur > wrote: > >> In D104601#2847400

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added a comment. This all looks good to me except some tidy warning. wait for others comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:460 + +addExtension("e"); + } nit: add `break;` to avoid the implicit-fallthrough warning. ===

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. In D94098#2886319 , @labrinea wrote: > Firstly, the information that the load/store comes from an inline asm operand > gets lost by the time the SelectionDAG processes those nodes, and so we > cannot use a target hook to select

[PATCH] D104854: Introduce intrinsic llvm.isnan

efriedma added a comment. > The options '-ffast-math' and '-fno-honor-nans' imply that FP operation > operands are never NaNs. This assumption however should not be applied > to the functions that check FP number properties, including 'isnan'. If > such function returns expected result instead of

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

mbenfield updated this revision to Diff 359655. mbenfield added a comment. Rebased and addressed comments. - Renamed ComputeCheckVariantSize. - const Expr *. - Changed existing test case to write only one excess byte. - Added new, non-diagnosing test case. Repository: rG LLVM Github Monore

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

MaskRay updated this revision to Diff 359654. MaskRay added a comment. fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/arch

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. Ok, I've tried a few things. If we add a couple of new target hooks we can make clang pass both input and output asm operands by value as `type { [8 x i64] }` avoiding the integer conversion. One issue with that is that the inline asm verifier asserts if an inline asm

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e649f8ef187: [openmp][nfc] Simplify macros guarding math complex headers (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHAN

[clang] 3e649f8 - [openmp][nfc] Simplify macros guarding math complex headers

Author: Jon Chesterfield Date: 2021-07-18T23:30:35+01:00 New Revision: 3e649f8ef1875f943537b5fcecdb132c9442cb7d URL: https://github.com/llvm/llvm-project/commit/3e649f8ef1875f943537b5fcecdb132c9442cb7d DIFF: https://github.com/llvm/llvm-project/commit/3e649f8ef1875f943537b5fcecdb132c9442cb7d.di

[PATCH] D106130: [PowerPC] Implemented mtmsr, mfspr, mtspr Builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106130/new/ https://reviews.llvm.org/D106130 __

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946 __

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a very minor nit. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4990 case ISD::INTRINSIC_WO_CHAIN: { +// We emit the ppc_fsels intrinsic

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

namazso added a comment. i'd prefer it as just namazso with email ad...@namazso.eu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://reviews.llvm.org/D106210 ___ cfe-commits mailing list

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

MaskRay added a comment. High-level comments: I'd use a bottom-up patch order. llvm patches are before clang patches. The clang driver patch is the last - having the user-facing option requires the functionality to be fully available. llvm-objdump patch is orthogonal to clang patches, so its ord

[PATCH] D106243: [Utils] Support class template specializations in update_cc_test_checks

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106243/new/ https://reviews.llvm.org/D106243 _

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1420 + +if (CodeGenOpts.CallGraphSection) { + MPM.addPass(CGSectionFuncComdatCreatorPass()); https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-stateme

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

craig.topper added a comment. In D106210#2885538 , @namazso wrote: > I don't have commit access, could someone commit this for me? Thanks in > advance. I can commit it. How would you like your name to appear in the author line of the git log? Reposit

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

tianshilei1992 added a comment. This patch causes wrong arguments in nested parallel regions. `openmp/libomptarget/test/offloading/bug49779.cpp` fails and after reverting this patch, it passed. You can easily find out the wrong pointer with a tiny change of the test case: void work(int *C) {

[PATCH] D106243: [Utils] Support class template specializations in update_cc_test_checks

jrtc27 updated this revision to Diff 359643. jrtc27 added a comment. Drop the --llvm-bin test; only basic-cplusplus.test does that (which happened to be the one I used as a reference), and that only needs to be done for one file as it has no relation to the input. Repository: rG LLVM Github

[PATCH] D106243: [Utils] Support class template specializations in update_cc_test_checks

jrtc27 created this revision. jrtc27 added reviewers: arichardson, jdoerfert. jrtc27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. ClassTemplateSpecializationDecl not within a ClassTemplateDecl represents an explicit ins

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor accepted this revision. fodinabor added a comment. This revision is now accepted and ready to land. LGTM as well :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 __

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a comment. @fodinabor? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD closed this revision. RedDocMD added a comment. For some reason this revision did not get automatically closed after commit, manually merging it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd825309352b4: [analyzer] Handle std::make_unique (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] d825309 - [analyzer] Handle std::make_unique

Author: Deep Majumder Date: 2021-07-18T19:54:28+05:30 New Revision: d825309352b4c5c01da7c935e49994f8f257 URL: https://github.com/llvm/llvm-project/commit/d825309352b4c5c01da7c935e49994f8f257 DIFF: https://github.com/llvm/llvm-project/commit/d825309352b4c5c01da7c935e49994f8f257.diff

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359627. RedDocMD added a comment. Marked test with FIXME notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/PathS

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359625. RedDocMD added a comment. Fixed up tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValB

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 359605. RedDocMD added a comment. Post-rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd98bef1b6f: [analyzer] Handle std::swap for std::unique_ptr (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 0cd98be - [analyzer] Handle std::swap for std::unique_ptr

Author: Deep Majumder Date: 2021-07-18T14:38:55+05:30 New Revision: 0cd98bef1b6feec067a4c60df4df4d44a842811d URL: https://github.com/llvm/llvm-project/commit/0cd98bef1b6feec067a4c60df4df4d44a842811d DIFF: https://github.com/llvm/llvm-project/commit/0cd98bef1b6feec067a4c60df4df4d44a842811d.diff

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 359600. RedDocMD added a comment. Post rebase cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h clang/l