[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361079. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

hubert.reinterpretcast added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t craig.topper wrote: > jacquesguan wrote: > > kito-cheng wrote: > >

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t jacquesguan wrote: > kito-cheng wrote: > > I guess you want to

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t kito-cheng wrote: > I guess you want to verify `vfredsum.vs` and

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4ed93cb25ac: [PowerPC] Implement XL compatible behavior of __compare_and_swap (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES

[clang] e4ed93c - [PowerPC] Implement XL compatible behavior of __compare_and_swap

Author: Kai Luo Date: 2021-07-23T01:16:02Z New Revision: e4ed93cb25acc624a1d32e77d2c63c8c25fddbae URL: https://github.com/llvm/llvm-project/commit/e4ed93cb25acc624a1d32e77d2c63c8c25fddbae DIFF: https://github.com/llvm/llvm-project/commit/e4ed93cb25acc624a1d32e77d2c63c8c25fddbae.diff LOG:

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

bnbarham added a comment. In D95159#2897941 , @mibintc wrote: > Can you suggest how to find the problem? Thanks a lot. @mibintc the test is reusing the module cache directory and that's causing some issues between runs, sorry about that. You could add

[PATCH] D106620: [Clang][LLVM] generate btf_tag annotations for func parameters

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman, ast. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang,

[PATCH] D106614: [Clang] add btf_tag attribute

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, probinson, aprantl, aaron.ballman, ast. yonghong-song added a project: debug-info. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898350 , @vitalybuka wrote: > In D105703#2898343 , @vitalybuka > wrote: > >> fix crash > > weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert abandoned this revision. aaronpuchert added a comment. In D101566#2896911 , @aaron.ballman wrote: > Off-by-default warnings are generally discouraged unless there's a very > compelling reason to have them. There are IMO valuable warnings

[PATCH] D106315: [HIP] Preserve ASAN bitcode library functions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. One question -- does it have to be a function calling other functions just for the sake of preserving them? Can it be a flat array of pointers to the functions you need to keep

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481084f669e1: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9 (authored by tlively). Repository: rG LLVM Github Monorepo

[clang] 481084f - [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

Author: Thomas Lively Date: 2021-07-22T16:31:12-07:00 New Revision: 481084f669e10beb89b2e1a75bc67e7fb8125941 URL: https://github.com/llvm/llvm-project/commit/481084f669e10beb89b2e1a75bc67e7fb8125941 DIFF: https://github.com/llvm/llvm-project/commit/481084f669e10beb89b2e1a75bc67e7fb8125941.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96c63492cb95: [hwasan] Use stack safety analysis. (authored by fmayer, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[clang] 96c6349 - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-22T16:20:27-07:00 New Revision: 96c63492cb952431fd9732146663fe227f8c52c1 URL: https://github.com/llvm/llvm-project/commit/96c63492cb952431fd9732146663fe227f8c52c1 DIFF: https://github.com/llvm/llvm-project/commit/96c63492cb952431fd9732146663fe227f8c52c1.diff

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added a comment. Oh, technically none of the clang changes belong in this patch. Those are for the Clang driver and preprocessor, not the MC layer which is purely llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added a comment. I can't help but feel the assembly syntax for the register pair instructions shouldn't include both registers (perhaps in curly braces). The implicit use of the other register when reading the source is rather ugly, and particularly hard to remember when the RV64

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 361014. cjdb marked 12 inline comments as done. cjdb added a comment. - applies all of @aaron.ballman's suggested changes - turns warnings into errors and deletes warning group - replaces `interleave` with `join` - properly abandons LF transmuting The only

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit db7efcab7dd9

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361005. ivanmurashko added a comment. LIT test was updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898343 , @vitalybuka wrote: > fix crash weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however exact cmake from bot does Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh added a comment. Some Android developers and legacy code care less about clang-tidy warnings. Newer developers spend a lot of time to get lint-free new code. So Android source tree has a lot of clang-tidy flags like header-filter, checks, and warnings-as-errors to select checks for different

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 361002. vitalybuka added a comment. fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

craig.topper added a comment. I think this looks good to me. @luismarques or @jrtc27 any further feedback? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko updated this revision to Diff 361001. ivanmurashko added a comment. The LIT test was added: build] ./bin/llvm-lit -v ../clang/test/SemaCXX/pr51171-crash.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); rnk wrote: >

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ad26b08a2: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing (authored by akhuang). Repository: rG LLVM Github Monorepo

[clang] 3e2ad26 - [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

Author: Amy Huang Date: 2021-07-22T14:52:36-07:00 New Revision: 3e2ad26b08a23e786e64e8e47547d25a1b5a7f28 URL: https://github.com/llvm/llvm-project/commit/3e2ad26b08a23e786e64e8e47547d25a1b5a7f28 DIFF: https://github.com/llvm/llvm-project/commit/3e2ad26b08a23e786e64e8e47547d25a1b5a7f28.diff

[clang] 8322593 - PR51158: Don't emit -Wswitch or -Wcovered-switch-default for empty enums

Author: David Blaikie Date: 2021-07-22T14:51:56-07:00 New Revision: 83225936af317e6bdd7103a8a039c51a29ce9f57 URL: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57 DIFF: https://github.com/llvm/llvm-project/commit/83225936af317e6bdd7103a8a039c51a29ce9f57.diff

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. PTAL, now merge outside of DocumentOutline although the algorithm I've used is roughly the same Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360980. dgoldman added a comment. Misc vector changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Because of how large the switch construct would have been, I created a new function `types::isDerivedFromC` together with the other functions. These commonly have default-cases so compilers would not warn when `Types.def` is amended, but `isDerivedFromC` can be

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk updated this revision to Diff 360978. rnk added a comment. - move Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106585/new/ https://reviews.llvm.org/D106585 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); dblaikie wrote: > Is the

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360977. Meinersbur added a comment. - Introduce types::isDerivedFromC - Print input type in error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Files:

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 360972. dgoldman added a comment. Merge pragmas outside of the DocumentOutline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files:

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360970. kbobyrev added a comment. Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev updated this revision to Diff 360968. kbobyrev added a comment. Add another 7% compared to the patched version: cache Child->peek() in the loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://reviews.llvm.org/D106528

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a subscriber: jmorse. akhuang added a comment. In D106582#2897815 , @dblaikie wrote: > In D106582#2897678 , @akhuang wrote: > >> In D106582#2897599 ,

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91 /// sync. void sync() { ReachedEnd |= Children.front()->reachedEnd(); sammccall wrote: > I stared at this for a while and this change makes me think about

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

morehouse accepted this revision. morehouse added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Verifier/operand-bundles.ll:91 + %l = load i32, i32* %ptr + call void @g() [ "type"(metadata !"_ZTSFvE.generalized"), "type"(metadata

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @MaskRay I experience that the failing test clang/test/Index/preamble-reparse-changed-module.m is non-deterministic and currently I cannot reproduce the fail. I added details in D95159 . Are you able to reproduce if you clean your

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: MaskRay. mibintc added a comment. More info about the test failure I'm seeing for clang/test/Index/preamble-reparse-changed-module.m It appears it might be a non-deterministic failure, perhaps some test dependencies are missing? Yesterday before I pushed my clang

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb marked 2 inline comments as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:307-310 +def pp_pragma_include_instead_unexpected_token : Warning< + "'#pragma include_instead' expects '%0' as its next token; got '%1' instead">, +

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

erichkeane added a comment. In D106583#2897783 , @ivanmurashko wrote: > @erichkeane, is it OK if the reproducer be added as the LIT test? That is a typical mechanism way to go, but that reproducer is a little long. You should hopefully be able to

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert added a comment. you need to squash your commits locally and update this revision with a single commit/diff. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6323-6327 + if (S.hasClausesOfKind() && + !(S.getSingleClause() || +S.getSingleClause() || +

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. Thanks for the first pass @aaron.ballman! Some clarifying questions, but I think I have enough of your other comments to work on while you ponder these. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:303 InGroup>; +def

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3117 +llvm::APSInt Value = Enum->getInitVal(); +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); Is the value already

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2896091 , @aaron.ballman wrote: > I think there is, but I'm an eternal optimist. :-) This LGTM, but you should > wait a day or two before landing it in case @dblaikie or @rsmith have > concerns. Of course.

[PATCH] D106173: [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

This revision was automatically updated to reflect the committed changes. flx marked an inline comment as done. Closed by commit rGcb4c12b6117a: [clang-tidy] performance-unnecessary-copy-initialization: Create option to… (authored by flx). Changed prior to commit:

[clang-tools-extra] cb4c12b - [clang-tidy] performance-unnecessary-copy-initialization: Create option to exclude container types from triggering the check.

Author: Felix Berger Date: 2021-07-22T16:20:20-04:00 New Revision: cb4c12b6117a6f2989d5745854a94c75cb6a09ba URL: https://github.com/llvm/llvm-project/commit/cb4c12b6117a6f2989d5745854a94c75cb6a09ba DIFF: https://github.com/llvm/llvm-project/commit/cb4c12b6117a6f2989d5745854a94c75cb6a09ba.diff

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

dblaikie added a comment. In D106582#2897678 , @akhuang wrote: > In D106582#2897599 , @dblaikie > wrote: > >> Looks alright to me. (bit awkward having a documented cc1 option - since the >> cc1 options aren't

[PATCH] D106585: Fix clang debug info irgen of i128 enums

mizvekov added a comment. Small nit but otherwise LGTM :) Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3118 +Value.setIsSigned(IsSigned); +Enumerators.push_back(DBuilder.createEnumerator(Enum->getName(), Value)); } Comment at:

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko added a comment. @erichkeane, is it OK if the reproducer will be added as the LIT test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/ https://reviews.llvm.org/D106583 ___

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46667a10039b: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR (authored by pmatos). Changed prior to commit:

[clang] 46667a1 - [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

Author: Paulo Matos Date: 2021-07-22T22:07:24+02:00 New Revision: 46667a10039b664b953eb70534c27627b35a267d URL: https://github.com/llvm/llvm-project/commit/46667a10039b664b953eb70534c27627b35a267d DIFF: https://github.com/llvm/llvm-project/commit/46667a10039b664b953eb70534c27627b35a267d.diff

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil marked an inline comment as done. necipfazil added inline comments. Comment at: llvm/include/llvm/IR/LLVMContext.h:97 OB_clang_arc_attachedcall = 6, // "clang.arc.attachedcall" +OB_type = 7, // "type" }; morehouse wrote:

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b52e9bac207: [AIX] Define __LONGDOUBLE64 macro (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105477/new/

[clang] 1b52e9b - [AIX] Define __LONGDOUBLE64 macro

Author: Jake Egan Date: 2021-07-22T16:05:14-04:00 New Revision: 1b52e9bac207cd4bdcd9091178527aa39049c270 URL: https://github.com/llvm/llvm-project/commit/1b52e9bac207cd4bdcd9091178527aa39049c270 DIFF: https://github.com/llvm/llvm-project/commit/1b52e9bac207cd4bdcd9091178527aa39049c270.diff

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 360942. necipfazil added a comment. Verify type operand bundle usage - Check if type operand bundle id is drifted - Verify and complain if multiple type operand bundles are used - Add type operand bundle test to operand bundle verifier tests Repository:

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

aaron.ballman added a comment. Pragmas and magic comments both have ergonomic issues, so it's really about the tradeoffs. Personally, I think it's more reasonable to support this as a pragma than as a magic-comment. Pragmas are a mystery to users, but they're less of a mystery than comments

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by what libc

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang added a comment. In D106582#2897599 , @dblaikie wrote: > Looks alright to me. (bit awkward having a documented cc1 option - since the > cc1 options aren't meant to be user facing - hadn't really thought > about/noticed that when reviewing the

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2897588 , @aaron.ballman wrote: > In D106577#2897522 , @jyknight > wrote: > >> I'm not sure we should be populating this. >> >> The _value_ is determined by what libc

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk added subscribers: dblaikie, MaskRay, LemonBoy. rnk added a comment. I decided it would be faster and more convenient to respond in the form of a code review for clang, so here it is: D106585 Assuming that goes through, go ahead and rebase onto that after

[clang] 7d669e6 - [AIX] Generate large code model relocations when mcmodel=medium on AIX

Author: Anjan Kumar Guttahalli Krishna Date: 2021-07-22T15:47:22-04:00 New Revision: 7d669ec1d67c1b4aecd90687013636d8037c URL: https://github.com/llvm/llvm-project/commit/7d669ec1d67c1b4aecd90687013636d8037c DIFF:

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d669ec1: [AIX] Generate large code model relocations when mcmodel=medium on AIX (authored by anjankgk, committed by hubert.reinterpretcast).

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk created this revision. rnk added reviewers: mizvekov, dblaikie, MaskRay. Herald added subscribers: dexonsmith, hiraditya. rnk requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. DIEnumerator stores an APInt as of April 2020, so now

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

erichkeane added a comment. This seems appropriate of a fix, but it needs a lit test. I'm not particularly sure I know the repercussions of this patch, however perhaps that would help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106583/new/

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright to me. (bit awkward having a documented cc1 option - since the cc1 options aren't meant to be user facing - hadn't really thought about/noticed that when reviewing the

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2897522 , @jyknight wrote: > I'm not sure we should be populating this. > > The _value_ is determined by what libc supports, so it probably needs to be > left up to libc to define it. Why is the value

[clang] f719dff - [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

Author: Anjan Kumar Guttahalli Krishna Date: 2021-07-22T15:32:48-04:00 New Revision: f719dff043962832f221dd8e28af2344a0ab80e0 URL: https://github.com/llvm/llvm-project/commit/f719dff043962832f221dd8e28af2344a0ab80e0 DIFF:

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf719dff04396: [AIX] Clangs library integration support for 128-bit long double is incomplete… (authored by anjankgk, committed by scui).

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

ivanmurashko created this revision. ivanmurashko added reviewers: rsmith, DmitryPolukhin. ivanmurashko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a SIGSEGV at DeduceTemplateArgumentsByTypeMatch. See BUG description and

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang updated this revision to Diff 360926. akhuang added a comment. Herald added a subscriber: dang. add actual flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106582/new/ https://reviews.llvm.org/D106582 Files: clang/docs/UsersManual.rst

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[PATCH] D106582: [DebugInfo] Add -fno-ctor-homing for as counterpart to -fuse-ctor-homing

akhuang created this revision. akhuang added reviewers: dblaikie, probinson. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an opt out flag for constructor homing. Repository: rG LLVM Github Monorepo

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. I'm not sure we should be populating this. The _value_ is determined by what libc supports, so it probably needs to be left up to libc to define it. In glibc, this define is set by the file /usr/include/stdc-predef.h, which GCC implicitly includes into all TUs

[PATCH] D106011: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00edae9203c9: [clang-tidy] performance-unnecessary-copy-initialization: Disable check when… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 00edae9 - [clang-tidy] performance-unnecessary-copy-initialization: Disable check when variable and initializer have different replaced template param types.

Author: Felix Berger Date: 2021-07-22T15:17:24-04:00 New Revision: 00edae9203c9a4f50da058d4bd25dc2e6a4930c1 URL: https://github.com/llvm/llvm-project/commit/00edae9203c9a4f50da058d4bd25dc2e6a4930c1 DIFF: https://github.com/llvm/llvm-project/commit/00edae9203c9a4f50da058d4bd25dc2e6a4930c1.diff

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. David wrote: > think what I'm missing here: If -fno-standalone-debug is already in use/the > default and is causing missing types because parts of the program are bulit > without debug info, then I'm not sure what the rationale is for slicing > -fstandalone-debug into

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D106577#2897450 , @cor3ntin wrote: > In D106577#2897312 , @aaron.ballman > wrote: > >> Can

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360918. akhuang added a comment. Remove fno-use-ctor-homing flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files:

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); probinson wrote: > No... you want to

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin updated this revision to Diff 360914. cor3ntin added a comment. Remove braces, improve comment (Thanks Aaron) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106577/new/ https://reviews.llvm.org/D106577 Files:

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2897312 , @aaron.ballman wrote: > Can you also add a test that explicitly uses `-fshort-wchar` to verify that > we don't predefine the macro? There is one already! (init.c L288) Comment at:

[clang] 178c2b4 - Correctly diagnose taking the address of a register variable in C

Author: Aaron Ballman Date: 2021-07-22T14:53:23-04:00 New Revision: 178c2b4c1eb12b2153adb384ac7f22a8791edc86 URL: https://github.com/llvm/llvm-project/commit/178c2b4c1eb12b2153adb384ac7f22a8791edc86 DIFF: https://github.com/llvm/llvm-project/commit/178c2b4c1eb12b2153adb384ac7f22a8791edc86.diff

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

anjankgk added a comment. Since Whitny and Chris are busy, I have requested Shimin to commit this in. Thanks Shimin! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074 ___ cfe-commits mailing list

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk added a comment. Since Hubert is busy, I have requested Shimin to commit this in. Thanks Shimin! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106371/new/ https://reviews.llvm.org/D106371 ___ cfe-commits mailing list

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:507 +CurFn->addFnAttr( +llvm::Attribute::getWithVScaleRangeArgs(getLLVMContext(), 0, 16)); } Thinking about this more, maybe these values should be returned from

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. Looks good, could you also add a note in the relasenotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list

  1   2   3   >