[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 369024. modimo marked 2 inline comments as done. modimo added a comment. Use prevailing for linkonce/weak. Add hasUnknownCall to model virtual and indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo marked 3 inline comments as done. modimo added a comment. In D36850#2964293 , @tejohnson wrote: > Good point on indirect calls. Rather than add a bit to the summary, can the > flags just be set conservatively in any function containing an indirect

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. need a test for non-template static member function as kernel. also need codegen tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; qiucf wrote: > rjmccall wrote: > > This is necessary because it's possible to derive this type from a mode > > attribute? > Yes,

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; rjmccall wrote: > This is necessary because it's possible to derive this type from a mode > attribute?

[PATCH] D108797: [WIP][compiler-rt] Build fuzzer tests

leonardchan created this revision. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108797 Files:

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:13640 +(v4f32 (OpNode VR128X:$src1, VR128X:$src2)), +0, 0, 0, X86selects, "@earlyclobber $dst">, Sched<[sched.XMM]>; +defm rm : AVX512_maskable

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:1852 + { X86::VFCMULCPHZrr, X86::VFCMULCPHZrm, 0 }, + { X86::VFCMULCSHZrr, X86::VFCMULCSHZrm, TB_NO_REVERSE }, { X86::VFMADDPD4Yrr,

[PATCH] D108794: Fully qualify template template parameters when printing

dblaikie created this revision. dblaikie added reviewers: aaron.ballman, rtrieu. Herald added a subscriber: arphaman. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I discovered this quirk when working on some DWARF - AST

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:1852 + { X86::VFCMULCPHZrr, X86::VFCMULCPHZrm, 0 }, + { X86::VFCMULCSHZrr, X86::VFCMULCSHZrm, TB_NO_REVERSE }, { X86::VFMADDPD4Yrr,

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:1852 + { X86::VFCMULCPHZrr, X86::VFCMULCPHZrm, 0 }, + { X86::VFCMULCSHZrr, X86::VFCMULCSHZrm, TB_NO_REVERSE }, { X86::VFMADDPD4Yrr,

[clang] 5c24a1e - [CUDA] update constraints on NVPTX builtins to include PTX73 and 74.

Author: Artem Belevich Date: 2021-08-26T16:01:57-07:00 New Revision: 5c24a1e1db63f1ac3a956458df5edf87fac7be49 URL: https://github.com/llvm/llvm-project/commit/5c24a1e1db63f1ac3a956458df5edf87fac7be49 DIFF:

[PATCH] D108792: [M68k] Update pointer data layout

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Comments could perhaps be clearer about highlighting that 32-bit integers/pointers are only 16-bit aligned in the ABI as that's the weird bit, not the 32-bit preferred alignment Repository:

[PATCH] D108792: [M68k] Update pointer data layout

ricky26 created this revision. ricky26 added reviewers: myhsu, jrtc27, nickdesaulniers, craig.topper. Herald added a subscriber: hiraditya. ricky26 requested review of this revision. Herald added projects: clang, LLVM. Fixes PR51626. The M68k requires that all instruction, word and long word

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

a.elovikov added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108423/new/ https://reviews.llvm.org/D108423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 7bd92f5 - [AST] Pick last tentative definition as the acting definition

Author: Benson Chu Date: 2021-08-26T16:49:54-05:00 New Revision: 7bd92f5911dc7ec54200d37552d364f87ad03dfb URL: https://github.com/llvm/llvm-project/commit/7bd92f5911dc7ec54200d37552d364f87ad03dfb DIFF: https://github.com/llvm/llvm-project/commit/7bd92f5911dc7ec54200d37552d364f87ad03dfb.diff

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6eed1fb349de: [clang][NewPM] Mention that legacy PM flags are deprecated (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[clang] 6eed1fb - [clang][NewPM] Mention that legacy PM flags are deprecated

Author: Arthur Eubanks Date: 2021-08-26T14:42:55-07:00 New Revision: 6eed1fb349de8710fba0d12a4289ac0519f23fb3 URL: https://github.com/llvm/llvm-project/commit/6eed1fb349de8710fba0d12a4289ac0519f23fb3 DIFF:

[clang] 82d9cb3 - [DebugInfo] convert btf_tag attrs to DI annotations for func parameters

Author: Yonghong Song Date: 2021-08-26T14:27:58-07:00 New Revision: 82d9cb34a2782df04975abb5a86365546ffae867 URL: https://github.com/llvm/llvm-project/commit/82d9cb34a2782df04975abb5a86365546ffae867 DIFF: https://github.com/llvm/llvm-project/commit/82d9cb34a2782df04975abb5a86365546ffae867.diff

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108789/new/ https://reviews.llvm.org/D108789

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108789 Files:

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

This revision was automatically updated to reflect the committed changes. Closed by commit rGa42bd1b56052: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/

[clang] a42bd1b - [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

Author: Fangrui Song Date: 2021-08-26T14:25:31-07:00 New Revision: a42bd1b560524905d3b9aebcb658cf6dc9521d26 URL: https://github.com/llvm/llvm-project/commit/a42bd1b560524905d3b9aebcb658cf6dc9521d26 DIFF: https://github.com/llvm/llvm-project/commit/a42bd1b560524905d3b9aebcb658cf6dc9521d26.diff

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/ https://reviews.llvm.org/D108774

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/ https://reviews.llvm.org/D108775 ___ cfe-commits mailing list

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

MaskRay added a comment. The Fuchsia change is quite obvious. Committing. If stable for some time, will push to release/13.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/ https://reviews.llvm.org/D108775

[PATCH] D106620: [Clang][LLVM] generate btf_tag annotations for func parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bebc31c617d: [DebugInfo] generate btf_tag annotations for func parameters (authored by yonghong-song). Changed prior to commit:

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Thanks, Art. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra created this revision. tra added reviewers: jlebar, yaxunl. Herald added subscribers: bixia, inglorion. tra requested review of this revision. Herald added a project: clang. Otherwise, we fail to compile calls to CUDA kernels that are static members. Repository: rG LLVM Github Monorepo

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert added a comment. I think I addressed your concerns with the 2 additional checks and more test coverage, as always, return 0 are the functions it should call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert updated this revision to Diff 368978. jdoerfert added a comment. Add OpenMP check, add L/RValue check, add tests for multiple combinations of & vs && Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

aeubanks added a comment. lg, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/ https://reviews.llvm.org/D108775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

NoQ added a comment. In D108695#2967885 , @Szelethus wrote: > It should! But you have a point, I don't have the code to prove it right > away. Maybe if I factored out the symbol part into > NoStateChangeToSymbolVisitor, as teased in D105553#2864318 >

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

NoQ accepted this revision. NoQ added a comment. Thanks, all clear now! Comment at: clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:325-326 + if (ReferrerMemSpace && ReferredMemSpace) { +if (ReferredFrame == PoppedFrame && +

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73093599287c: [analyzer] Fix scan-build report deduplication. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM

[clang] 7309359 - [analyzer] Fix scan-build report deduplication.

Author: Artem Dergachev Date: 2021-08-26T13:34:29-07:00 New Revision: 73093599287cc6d546ac46652ee781789d7de61f URL: https://github.com/llvm/llvm-project/commit/73093599287cc6d546ac46652ee781789d7de61f DIFF:

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. What about: `unsigned`? And enum or struct types such as `BracketAlignmentStyle`, `ArrayInitializerAlignmentStyle`, ...? Should we add something like: `Enum BracketAlignmentStyle` and `Dictionnary BraceWrapping`? The complete list: 53 bool

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3f413962627: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

stuart added a comment. > Unfortunately I cannot look at this in detail right now, but I'll reply > quickly for a heads up: The problem was not how to detect kernels, but the > ABI/CC mismatch to the > clSetKerneArg() with (user facing) arguments that get split to multiple args > or vice

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

JonChesterfield added a comment. That is a surprising root cause. It turns out std::cexp does in fact take the complex argument by const reference. The C versions take it by value. Shall we guard this with if (openmp) or similar to avoid it changing semantics for other languages? Repository:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-optimize-callbacks.ll:6 +; RUN: FileCheck %s --check-prefixes=LOAD-KERNEL,STORE-KERNEL + +target

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

ABataev added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9691 // the expression is a function call (possibly inside parentheses). + if (LHS->getAs() && RHS->getAs()) +return mergeTypes(LHS->getAs()->getPointeeType(), Does it matter if it

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368962. ricejasonf added a comment. I moved the test to CodeGenCXX and actually test output with FileCheck. I used the code from a non-template function as the expected output. Some minor formatting changes are also addressed. Repository: rG LLVM

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368959. kstoimenov added a comment. Fixed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1890 -if (auto FD = dyn_cast(D)) - return CGM.GetAddrOfFunction(FD); +if (auto FD = dyn_cast(D)) { + auto *C = CGM.GetAddrOfFunction(FD); fix linter

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. In D108695#2967540 , @NoQ wrote: > Would this work correctly when the property is changed but then reverted to > its original state? This probably can't happen to MallocChecker (what has > been freed cannot be unfreed) but it

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin updated this revision to Diff 368958. cor3ntin added a comment. - Add tests and fix existing tests (again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108742/new/ https://reviews.llvm.org/D108742 Files: clang/lib/Basic/CharInfo.cpp

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. As the one who wrote that: 1. Yes that part is not auto generated, because it is not in the `format.h`. 2. I'm more in favor of removing the `std::` from the documentation. 3. It is for the YAML

[PATCH] D108752: [clang-format] Group options that pack constructor initializers

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18472 + FormatStyle::PCIS_Never); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_LogicalBlock;

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

cor3ntin added inline comments. Comment at: clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173 ASSERT_FALSE( - minimizeSourceToDependencyDirectives("#define MACRO(a\\\n" + minimizeSourceToDependencyDirectives("#define MACRO(a

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. this is good, but IMO it's not clear enough in the description that this is a breaking change in terms of CMake flags (use -DLLVM_ENABLE_NEW_PASS_MANAGER instead of

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert updated this revision to Diff 368943. jdoerfert added a comment. Clang format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/ https://reviews.llvm.org/D108774 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

MaskRay created this revision. MaskRay added reviewers: aeubanks, phosek, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. LLVM_ENABLE_NEW_PASS_MANAGER is set to

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert updated this revision to Diff 368940. jdoerfert added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new/ https://reviews.llvm.org/D108774 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, pdhaliwal, aaron.ballman. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Reference types in

[clang] d2d7a90 - [DebugInfo] convert btf_tag attrs to DI annotations for DIGlobalVariable

Author: Yonghong Song Date: 2021-08-26T10:36:33-07:00 New Revision: d2d7a90ceded94251905b7adcd5eb2ac5191896f URL: https://github.com/llvm/llvm-project/commit/d2d7a90ceded94251905b7adcd5eb2ac5191896f DIFF: https://github.com/llvm/llvm-project/commit/d2d7a90ceded94251905b7adcd5eb2ac5191896f.diff

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. Thanks for uploading this. I tried it locally and it is missing proper parsing +sema of the cond-expr-stmt and cond-update-stmt as indicate in the openmp 5.1 spec's. I am sure you are aware of this and this is still WIP. Do you plan to add support for that? The

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

jyknight added a comment. Ping. Any comment from Apple folks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/ https://reviews.llvm.org/D108243 ___ cfe-commits mailing list

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! This is a very nice clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108693/new/ https://reviews.llvm.org/D108693

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108704/new/ https://reviews.llvm.org/D108704

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c288489ae5: [DebugInfo] generate btf_tag annotations for DIGlobalVariable (authored by yonghong-song). Changed prior to commit:

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

Anastasia added a comment. In D107769#2960441 , @svenvh wrote: > I have done an alternative spin of this patch: instead of introducing > `RequireDisabledExtension`, simply always make the `private`, `global`, and > `local` overloads available. This

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

weiwang added a comment. In D70172#2964118 , @sugak wrote: > Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. > I noticed on average 10% compilation speed regression that seems to be caused > this change. We use Clang

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

NoQ added a comment. In D105167#2949521 , @ASDenysPetrov wrote: > Nice work! Unfortunately I'm not able to run tests on my Windows env, but > I've run you tests files manually. It works for me. > > P.S. BTW, is there any workarounds to make current

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

NoQ updated this revision to Diff 368917. NoQ marked 4 inline comments as done. NoQ added a comment. Address review comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105167/new/ https://reviews.llvm.org/D105167 Files: clang/include/clang/Analysis/PathDiagnostic.h

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

NoQ added a comment. Would this work correctly when the property is changed but then reverted to its original state? This probably can't happen to MallocChecker (what has been freed cannot be unfreed) but it may happen to eg. PthreadLockChecker or to, well, Stores. In such cases it would be

[PATCH] D108742: Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

dexonsmith added a comment. Thanks for looking at this — I'm just reviewing the test changes in the minimizer (assuming the code change is the right thing to do). Comment at: clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:170-173 ASSERT_FALSE( -

[clang] a233f03 - Typo fix; NFC

Author: Aaron Ballman Date: 2021-08-26T12:53:52-04:00 New Revision: a233f0350d4790227f138e2118c0d18c2b45f855 URL: https://github.com/llvm/llvm-project/commit/a233f0350d4790227f138e2118c0d18c2b45f855 DIFF: https://github.com/llvm/llvm-project/commit/a233f0350d4790227f138e2118c0d18c2b45f855.diff

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, krasimir, sammccall, curdeius, klimek. MyDeveloperDay added a comment. In D108765#2967363 , @FederAndInk wrote: > Thank you for your explanations, I understand now. > > But as I look into

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint());

[clang] 0cf4f81 - Adding an assertion back.

Author: Aaron Ballman Date: 2021-08-26T12:51:14-04:00 New Revision: 0cf4f81082e9fa052e60450b8cbb10007e59931c URL: https://github.com/llvm/llvm-project/commit/0cf4f81082e9fa052e60450b8cbb10007e59931c DIFF: https://github.com/llvm/llvm-project/commit/0cf4f81082e9fa052e60450b8cbb10007e59931c.diff

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG34e055d33e37: [Clang][RISCV] Implement getConstraintRegister for RISC-V (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/

[clang] 34e055d - [Clang][RISCV] Implement getConstraintRegister for RISC-V

Author: Luís Marques Date: 2021-08-26T17:43:43+01:00 New Revision: 34e055d33e37cd87b9f6f4b0431a4c061628d036 URL: https://github.com/llvm/llvm-project/commit/34e055d33e37cd87b9f6f4b0431a4c061628d036 DIFF: https://github.com/llvm/llvm-project/commit/34e055d33e37cd87b9f6f4b0431a4c061628d036.diff

[PATCH] D108624: [Clang][RISCV] Implement getConstraintRegister for RISC-V

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Looks good to me - I'm surprised only Arm, AArch64, and X86 implement this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108624/new/

[PATCH] D107756: [analyzer] Extend the documentation of MallocOverflow

steakhal added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2159-2160 +It tries to catch ``malloc(n * c)`` patterns, where: + - ``n``: a variable or member access of an object + - ``c``: a constant foldable integral + steakhal wrote: > Am I

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint());

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint());

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Test setup can be fixed independently (and possibly should be). D102043 is newly simplified. It looks for plugins next to libomptarget.so, which means it can find them even when the application uses a non-transitive method to

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov updated this revision to Diff 368905. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Reworked the patch according to the discussion and taking UB into account. Moved `Expr::getExprForConstArrayByRawIndex` to `RegionStoreManager`. CHANGES SINCE

[clang] af79f1b - [analyzer] Extend the documentation of MallocOverflow

Author: Balazs Benics Date: 2021-08-26T18:15:10+02:00 New Revision: af79f1bff90bee957ec9f963b68226e0b33eb169 URL: https://github.com/llvm/llvm-project/commit/af79f1bff90bee957ec9f963b68226e0b33eb169 DIFF: https://github.com/llvm/llvm-project/commit/af79f1bff90bee957ec9f963b68226e0b33eb169.diff

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

mlychkov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1065-1068 assert(TC && "TPL must have a template type parameter with a type constraint"); auto *Constraint = + cast(TC->getImmediatelyDeclaredConstraint());

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 368903. kstoimenov added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[clang] 2de051b - [DebugInfo] convert btf_tag attrs to DI annotations for DISubprograms

Author: Yonghong Song Date: 2021-08-26T08:54:11-07:00 New Revision: 2de051ba124d92de953ac2420668407f458bcec6 URL: https://github.com/llvm/llvm-project/commit/2de051ba124d92de953ac2420668407f458bcec6 DIFF: https://github.com/llvm/llvm-project/commit/2de051ba124d92de953ac2420668407f458bcec6.diff

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

amyk added a comment. Please update the patch with full context. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1546 + // into a select. + if (Register::isPhysicalRegister(Cond[1].getReg())) { +return false; nit: `uses a physical register`

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

lei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15833 + // without the need for the programmer to swap operands. + if (IsLE) { +SmallVector RevOps; doesn't look like we need the interm var `IsLE`. Just use the call

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Thank you for your explanations, I understand now. But as I look into `clang/docs/tools/dump_format_style.py` I see that it does not entirely generate `clang/docs/ClangFormatStyleOptions.rst` it replaces the lines between `{START,END}_FORMAT_STYLE_OPTIONS` I

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

lebedev.ri added a reviewer: spatel. lebedev.ri added a comment. In D101759#2967331 , @masoud.ataei wrote: > In D101759#2967250 , @lebedev.ri > wrote: > >> Do we *really* need `-enable-approx-func-fp-math`? >>

[PATCH] D106618: [Clang][LLVM] generate btf_tag annotations for DISubprogram types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd383df32c0d5: [DebugInfo] generate btf_tag annotations for DISubprogram types (authored by yonghong-song). Changed prior to commit:

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked an inline comment as done. masoud.ataei added a comment. In D101759#2967250 , @lebedev.ri wrote: > Do we *really* need `-enable-approx-func-fp-math`? > I'm pretty sure we are moving away from such global options, onto relying > only

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

whisperity added a comment. @Sockke Sorry to circle back here, but it seems to me that Clang now has a flag `-Wuninitialized`. Could you check how it behaves, compared to this check? If there are overlaps, what should we do, @aaron.ballman? Should parts of the check be deprecated?

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86InstrFoldTables.cpp:1852 + { X86::VFCMULCPHZrr, X86::VFCMULCPHZrm, 0 }, + { X86::VFCMULCSHZrr, X86::VFCMULCSHZrm, TB_NO_REVERSE }, { X86::VFMADDPD4Yrr,

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3902 + case X86::VFCMADDCSHZr: + case X86::VFCMADDCSHZrb: + case X86::VFCMADDCSHZrbk: LuoYuanke wrote: > "b" means rounding. Right? broadcasting

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

kiranchandramohan added a comment. I have a few minor questions. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055 +/// Attach loop metadata \p Properties to the loop described by \p Loop. If the +/// loop already has metadata, the loop properties are appended.

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Thank you for your submission, but... 1. This is not the way to change this file, its autogenerated from clang/include/Format/Format.h using

[PATCH] D107900: [clang-tidy] Add a new clang-tidy check for trivially copyable types passed by const reference

jmarrec updated this revision to Diff 368881. jmarrec added a comment. documentation updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107900/new/ https://reviews.llvm.org/D107900 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

xbolva00 added a comment. >> I had a look at the LowerSwitch pass as suggested by @junparser, and I did >> find that running it before vectorisation transforms the switch and allows >> the same loops to be vectorised. However, I did find that if the loop is not >> vectorised then the switch is

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

lebedev.ri added a comment. Do we *really* need `-enable-approx-func-fp-math`? I'm pretty sure we are moving away from such global options, onto relying only on the per-instruction fast-math flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

xbolva00 added a comment. >> I could try to change LowerSwitch to create branches which SimplifyCFG will >> be able to recognise and replace with a switch, or try to change SimplifyCFG >> to recognise this pattern of compares & branches. 2. option is better. Repository: rG LLVM Github

  1   2   >