[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. In D36850#2990907 , @tejohnson wrote: > In D36850#2990847 , @modimo wrote: > >> In D36850#2990771 , @tejohnson >> wrote: >> >>> In D36850#2968536

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi added a comment. In D109531#2992721 , @hoy wrote: > In D109531#2992702 , @wenlei wrote: > >> The change makes sense given instr PGO also happens for O0. But practically, >> if a file is being built with O0,

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. But please wait to see whether @aprantl has any comments. Thanks. Comment at: clang/test/Modules/ExtDebugInfo.cpp:27 +#line 50 using DebugCXX::Struct;

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

ChuanqiXu added a comment. In D108905#2975806 , @rjmccall wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371772. jhuber6 added a comment. Adding global regex to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files:

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin abandoned this revision. peixin added a comment. Abandon this PR since this is not right fix. Continuing discussion will be on openmp-dev mail list. This bug should be fixed if `ordered simd` is processed correctly in frontend and vectorization pass. Repository: rG LLVM Github

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern created this revision. csmulhern added a reviewer: MyDeveloperDay. csmulhern requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This style can be used to control the alignment of closing brackets. For prior work on a similar

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. @MyDeveloperDay is it all good? I'm sorry for all the misunderstanding, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 ___

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. haowei marked an inline comment as done. Closed by commit rG38a5bd4115af: [clang_format] Add fallback-style flag to clang-format-diff.py (authored by haowei).

[clang] 38a5bd4 - [clang_format] Add fallback-style flag to clang-format-diff.py

Author: Haowei Wu Date: 2021-09-09T16:36:39-07:00 New Revision: 38a5bd4115afbe022a99334c7880f30a8ffd7c4a URL: https://github.com/llvm/llvm-project/commit/38a5bd4115afbe022a99334c7880f30a8ffd7c4a DIFF: https://github.com/llvm/llvm-project/commit/38a5bd4115afbe022a99334c7880f30a8ffd7c4a.diff

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', + help='The name of the predefined

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei updated this revision to Diff 371749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109550/new/ https://reviews.llvm.org/D109550 Files: clang/tools/clang-format/clang-format-diff.py Index: clang/tools/clang-format/clang-format-diff.py

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. I'm seeing crashes in this area when running OvO, e.g. 0. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_float_complex_float.cpp 1.

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371740. jhuber6 added a comment. Forgot to format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371737. jhuber6 added a comment. Addressing Comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', +

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei created this revision. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fallback-style is a frequently used flag in clang_format, however, it was not supported by clang-format-diff.py script. This change adds this flag.

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2992702 , @wenlei wrote: > The change makes sense given instr PGO also happens for O0. But practically, > if a file is being built with O0, do we care about its profile given we're > not really optimizing it anyways?

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s __enable_if_t as well.

Quuxplusone added a comment. In D109411#2990494 , @dblaikie wrote: > Looks like most of the testing for the enable_if custom dialog was added in > `clang/test/SemaTemplate/overload-candidates.cpp` in > rG6f8d2c6c9c3451effdf075a7034bbe77045bfeba >

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wenlei added a comment. The change makes sense given instr PGO also happens for O0. But practically, if a file is being built with O0, do we care about its profile given we're not really optimizing it anyways? Functions from O0 modules are not supposed to be inlined into O1

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jdoerfert added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3895 + Opts.OpenMPTargetDebug = 1; + } + CUDANumSMs? Don't check for NVPTX/AMDGCN but only if the new runtime is used, if not emit a warning that the flag is useless

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: dexonsmith, dang, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch

[PATCH] D109470: Add "profiling" to the list of absl libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe976fc61ecd9: Add profiling to the list of absl libraries. (authored by nilayvaish, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e976fc6 - Add "profiling" to the list of absl libraries.

Author: Nilay Vaish Date: 2021-09-09T20:31:06Z New Revision: e976fc61ecd9c789783129c1294e096f8b4b11b0 URL: https://github.com/llvm/llvm-project/commit/e976fc61ecd9c789783129c1294e096f8b4b11b0 DIFF: https://github.com/llvm/llvm-project/commit/e976fc61ecd9c789783129c1294e096f8b4b11b0.diff LOG:

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109541 Files: clang/test/Modules/ExtDebugInfo.cpp Index:

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov created this revision. Herald added subscribers: dexonsmith, dang. mizvekov updated this revision to Diff 371538. mizvekov edited the summary of this revision. mizvekov added a comment. mizvekov updated this revision to Diff 371539. mizvekov edited the summary of this revision. mizvekov

[PATCH] D105876: OMPIRBuilder for Interop directive

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, please rebase on top of trunk and use ` ConstantInt::get(Int32, 0)` instead of the APInt way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106674: Runtime for Interop directive

jdoerfert added a comment. We need a runtime test. Synchronizing the asyn info object and signal out dependences will happen in the next revision. So will minor edits as requested. I commented below on some things. Comment at: openmp/libomptarget/src/interop.cpp:13 +static

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic updated this revision to Diff 371693. asavonic added a comment. - Reworded the diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109315/new/ https://reviews.llvm.org/D109315 Files:

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wlei accepted this revision. wlei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109531/new/ https://reviews.llvm.org/D109531

[PATCH] D109470: Add "profiling" to the list of absl libraries.

ymandel added a comment. In D109470#2992275 , @nilayvaish wrote: > ymandel@, I do not have commit access to the repo. Can you commit this for > me? Thanks! Sure! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

aaron.ballman added inline comments. Comment at: clang/test/Frontend/attr-availability-fuchsia.c:2 +// Test that `-mfuchsia-version` is propagated to cc1. +// RUN: %clang -target x86_64-unknown-fuchsia -mfuchsia-version=16 -c %s -### |& FileCheck %s +// Is `|&`

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

RKSimon added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``. + saiislam wrote: >

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy created this revision. Herald added subscribers: modimo, wenlei, hiraditya. hoy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Pseudo probe instrumentation was missing from O0 build. It is needed in cases where some

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``.

[clang] 543604f - [clang-nvlink-wrapper][docs][NFC] Fix sphinx warning about asterisk

Author: Saiyedul Islam Date: 2021-09-09T23:55:15+05:30 New Revision: 543604f30eddc5c9390d0fb01b0ac67937cbba0e URL: https://github.com/llvm/llvm-project/commit/543604f30eddc5c9390d0fb01b0ac67937cbba0e DIFF:

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2992274 , @dexonsmith wrote: > 4. One or more commits: > 1. Migrate in-tree callers to MemoryBuffer. > 2. Delete MemoryBufferErrorAPI alias. > 5. Delete MemoryBufferErrorCodeAPI wrappers. (Potentially

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2990612 , @dblaikie wrote: > Given the amount of churn this means, though - reckon it's worth it? Reckon > it needs more llvm-dev thread/buy-in/etc? I think the churn is worth since my intuition is that it has

[PATCH] D109497: [X86][AVX] Update _mm256_loadu2_m128* intrinsics to use _mm256_set_m128* (PR51796)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea685e1028c6: [X86][AVX] Update _mm256_loadu2_m128* intrinsics to use _mm256_set_m128*… (authored by RKSimon). Repository: rG LLVM Github

[clang] ea685e1 - [X86][AVX] Update _mm256_loadu2_m128* intrinsics to use _mm256_set_m128* (PR51796)

Author: Simon Pilgrim Date: 2021-09-09T19:15:48+01:00 New Revision: ea685e1028c6fe9e2b0f9eb5858bcb867f75bdc8 URL: https://github.com/llvm/llvm-project/commit/ea685e1028c6fe9e2b0f9eb5858bcb867f75bdc8 DIFF: https://github.com/llvm/llvm-project/commit/ea685e1028c6fe9e2b0f9eb5858bcb867f75bdc8.diff

[PATCH] D109470: Add "profiling" to the list of absl libraries.

nilayvaish added a comment. ymandel@, I do not have commit access to the repo. Can you commit this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109470/new/ https://reviews.llvm.org/D109470

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:431 +VALUE_LANGOPT(FuchsiaVersion, 32, 0, "Fuchsia Version") + This is more consistent with other options. Comment at:

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

sammccall added a comment. Oops, forgot one thing: you probably want to instrument the preamble-building in TUScheduler (or in Preamble.cpp?), the background indexing, and code completion. Those all run the clang parser and should be a rich source of clang bugs. Testing idea: `yes '[' | head

[PATCH] D109470: Add "profiling" to the list of absl libraries.

ymandel added a comment. In D109470#2992161 , @nilayvaish wrote: > In D109470#2992119 , @ymandel wrote: > >> Any idea if there's a test for this matcher that should be updated? > > I looked at the commit that

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

sammccall added a comment. Thanks for doing this, I think this is incredibly useful for debugging. But also subtle, so please forgive a bunch of comments! I don't think we're strictly in defined-behavior territory in much of what these signal handlers are doing, but neither is clang's existing

[PATCH] D109470: Add "profiling" to the list of absl libraries.

nilayvaish added a comment. In D109470#2992119 , @ymandel wrote: > Any idea if there's a test for this matcher that should be updated? I looked at the commit that most recently added a directory to this file: 114c9fa0e46f7bf1d05d92da70da116b19f16911

[PATCH] D109470: Add "profiling" to the list of absl libraries.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Any idea if there's a test for this matcher that should be updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109470/new/

[PATCH] D109526: [OpenCL][Docs] Added ref to libclcxx

olestrohm accepted this revision. olestrohm added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109526/new/ https://reviews.llvm.org/D109526 ___ cfe-commits mailing list

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. I'll take care of the DAG.getAllOnesConstant change, but i'd appreciate it if you could look at the NOT cases. Running tests on the DAG.getAllOnesConstant patch now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. Thank you for the detailed review Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ cfe-commits mailing list

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483

[PATCH] D109526: [OpenCL][Docs] Added ref to libclcxx

Anastasia created this revision. Anastasia added a reviewer: olestrohm. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Linked in libclcxx GitHub project page with C++ libraries for OpenCL on OpenCLSupport page. https://reviews.llvm.org/D109526 Files:

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

SjoerdMeijer added reviewers: t.p.northover, ab. SjoerdMeijer added a comment. Some first comments after just looking at the plumbing for these new options. Didn't check yet the architecture extensions for the different version. Comment at:

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3243 "Don't know how to expand this subtraction!"); -Tmp1 = DAG.getNode(ISD::XOR, dl, VT, Node->getOperand(1), -

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

hjl.tools added a comment. >> The choice that high bits are unspecified rather than extended is an >> interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, >> <<, and narrowing conversions, but bad for ==, <, /, >>, and widening >> conversions. > > I've added @hjl.tools

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { aaron.ballman wrote: > +1

[PATCH] D109497: [X86][AVX] Update _mm256_loadu2_m128* intrinsics to use _mm256_set_m128* (PR51796)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109497/new/ https://reviews.llvm.org/D109497

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a581710c194: [openmp] No longer use LIBRARY_PATH to find devicertl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2a58171 - [openmp] No longer use LIBRARY_PATH to find devicertl

Author: Jon Chesterfield Date: 2021-09-09T17:16:41+01:00 New Revision: 2a581710c1942b265b271e230368b1596132f242 URL: https://github.com/llvm/llvm-project/commit/2a581710c1942b265b271e230368b1596132f242 DIFF:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a reviewer: hjl.tools. aaron.ballman added a subscriber: hjl.tools. aaron.ballman added a comment. In D108643#2965852 , @rjmccall wrote: > In D108643#2964740 , @aaron.ballman > wrote: > >> In

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. armv9-a, armv9.1-a and armv9.2-a can be targeted using the -march

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371614. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D109485: [clang-scan-deps] Add an API for clang dependency scanner to perform module lookup by name alone

This revision was automatically updated to reflect the committed changes. Closed by commit rG17c2948d0443: [clang-scan-deps] Add an API for clang dependency scanner to perform (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 17c2948 - [clang-scan-deps] Add an API for clang dependency scanner to perform

Author: Akira Hatanaka Date: 2021-09-09T08:52:50-07:00 New Revision: 17c2948d04431e94376e8d7883b5d89fbe705b5e URL: https://github.com/llvm/llvm-project/commit/17c2948d04431e94376e8d7883b5d89fbe705b5e DIFF:

[PATCH] D103088: [clang] pre-0388 array parm list initialization

xbolva00 added a comment. Commited without approval? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103088/new/ https://reviews.llvm.org/D103088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/ClangScanDeps/resource_directory.c:3 +// RUN: cp %S/Inputs/resource_directory/* %t +// RUN: sed -e "s|CLANG|/our/custom/bin/clang|g" -e

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/resource_directory.c:3 +// RUN: cp %S/Inputs/resource_directory/* %t +// RUN: sed -e "s|CLANG|/our/custom/bin/clang|g" -e "s|DIR|%/t|g" %S/Inputs/resource_directory/cdb_tu.json > %t/cdb.json +

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM. It's good to go if the test is green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/

[PATCH] D109498: [clang][deps] Stop using `ClangTool` for virtual files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one nit. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:98 + /// The in-memory filesystem laid on top the

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371605. JonChesterfield added a comment. - Add test checking LIBRARY_PATH is used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files:

[PATCH] D103088: [clang] pre-0388 array parm list initialization

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbb3f5f5d788d: [clang] Array list initialization (pre-p0388) (authored by urnathan). Herald added a project: clang. Herald

[clang] bb3f5f5 - [clang] Array list initialization (pre-p0388)

Author: Nathan Sidwell Date: 2021-09-09T08:30:04-07:00 New Revision: bb3f5f5d788dd9375ab260f77612fab4a707a1ac URL: https://github.com/llvm/llvm-project/commit/bb3f5f5d788dd9375ab260f77612fab4a707a1ac DIFF:

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 371597. jansvoboda11 added a comment. Fix CI pls? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files:

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

RKSimon added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:405 +// Tests to check compatibility between Bundle Entry ID formats i.e. between presence/absence of extra hyphen in case of missing environment field +// RUN: clang-offload-bundler -unbundle

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

RKSimon added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``. + @saiislam The

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D109498: [clang][deps] Stop using `ClangTool` for virtual files

jansvoboda11 updated this revision to Diff 371570. jansvoboda11 added a comment. Updating diff to re-trigger CI... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109498/new/ https://reviews.llvm.org/D109498 Files:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:153 -/// bitcode library and add it to the LIBRARY_PATH. -// RUN: env LIBRARY_PATH=%S/Inputs/libomptarget %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \ -// RUN:

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 371568. jansvoboda11 added a comment. Attempt to fix CI again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files:

[PATCH] D108526: [clang][nfc] Mark as P0692R1 as implemented.

aaron.ballman closed this revision. aaron.ballman added a comment. I committed this on your behalf in 7fc743ff84f60b12bb12f47d48ceb6f268106e45 , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7fc743f - Mark as P0692R1 as implemented; NFC

Author: Corentin Jabot Date: 2021-09-09T08:45:47-04:00 New Revision: 7fc743ff84f60b12bb12f47d48ceb6f268106e45 URL: https://github.com/llvm/llvm-project/commit/7fc743ff84f60b12bb12f47d48ceb6f268106e45 DIFF:

[PATCH] D108526: [clang][nfc] Mark as P0692R1 as implemented.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108526/new/ https://reviews.llvm.org/D108526

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Anastasia added inline comments. Comment at: clang/test/Preprocessor/predefined-macros.c:139 // RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++ \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=CHECK-CLCPP +// RUN: %clang_cc1 %s -E -dM -o - -x cl -cl-std=clc++1.0

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. I've no objections to this - it seems to be orthogonal to the isnan ir intrinsic conversation. Do we have test-suite buildbot coverage on anything other than x86? Cross platform uses of long double is always fun Any other comments? Repository: rT

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8ff4032e2b: [OptParser] NFC: Remove unused template arg name from bool opt (authored by c-rhodes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6c8ff40 - [OptParser] NFC: Remove unused template arg 'name' from bool opt

Author: Cullen Rhodes Date: 2021-09-09T12:04:40Z New Revision: 6c8ff4032e2bcf7dd381633b7e6294f23f0173a9 URL: https://github.com/llvm/llvm-project/commit/6c8ff4032e2bcf7dd381633b7e6294f23f0173a9 DIFF: https://github.com/llvm/llvm-project/commit/6c8ff4032e2bcf7dd381633b7e6294f23f0173a9.diff

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. In D106804#2956881 , @RKSimon wrote: > Something I noticed is that we don't have much test coverage in > clang/test/codegen for the fpclass intrinsics - including no constexpr > testing afaict (although I don't think

[PATCH] D109460: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

thakis added a comment. This is a nice idea. One drawback is that if you don't pass `-isysroot`, things just wouldn't work before but now every clang invocation will call xcrun, so things will work but will be slower than if you passed `-isysroot`. But the convenience for one-off invocations

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rGc58c7a6ea053: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check (authored by mgartmann, committed by whisperity). Changed prior to commit:

[clang-tools-extra] c58c7a6 - [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

Author: Marco Gartmann Date: 2021-09-09T13:23:38+02:00 New Revision: c58c7a6ea0535a75e382752b37cb68ccea43cde3 URL: https://github.com/llvm/llvm-project/commit/c58c7a6ea0535a75e382752b37cb68ccea43cde3 DIFF:

[PATCH] D109489: [OptParser] NFC: Remove unused template arg 'name' from bool opt

c-rhodes added a comment. In D109489#2991261 , @jansvoboda11 wrote: > LGTM. > > To give more background, I think my intention was to add an assertion that > `name` and `other_name` are the same (except for the `no_` part) and I was > waiting for

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper added a comment. I think I read this patch too closely. I'll leave it up to you how much of this you want to do. Comment at: llvm/include/llvm/IR/Constants.h:206 /// Determine if the value is all ones. bool isMinusOne() const { return Val.isAllOnesValue();

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner marked an inline comment as done. lattner added inline comments. Comment at: llvm/include/llvm/ADT/APInt.h:384 /// value for the APInt's bit width. bool isMaxValue() const { return isAllOnesValue(); } craig.topper wrote: > isAllOnes()? Yep, good

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

craig.topper added inline comments. Comment at: llvm/include/llvm/ADT/APInt.h:384 /// value for the APInt's bit width. bool isMaxValue() const { return isAllOnesValue(); } isAllOnes()? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109483: [APInt] Normalize naming on keep constructors / predicate methods.

lattner added a comment. This patch has a lot of noise, the important part is APInt.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109483/new/ https://reviews.llvm.org/D109483 ___ cfe-commits mailing

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2990577 , @dexonsmith wrote: > In D109345#2990527 , @dblaikie > wrote: > >> (were there other regressions I mentioned/should think about?) > > I don't have specific

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#2990527 , @dblaikie wrote: > (were there other regressions I mentioned/should think about?) I don't have specific concerns; I was just reading between the lines of your description... >> 1. Add `using

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. In D109345#2987565 , @dexonsmith wrote: > This seems like the right direction to me! Especially like the > look-through-the-ErrorInfo change for `FileError` -- I hit this before and > found it annoying. Thanks for taking a

  1   2   >