[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. If nobody objects, I would commit this change, as it would be useful in the forthcoming return of `llvm.isnan`. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 372866. achieveartificialintelligence added a comment. Updating D93298 : [RISCV] add the MC layer support of Zfinx extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 372863. achieveartificialintelligence added a comment. support zfinx-1.0-rc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D108567: Implement #pragma clang final extension

beanz updated this revision to Diff 372862. beanz added a comment. Updates based on feedback from @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108567/new/ https://reviews.llvm.org/D108567 Files:

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635

[PATCH] D108567: Implement #pragma clang final extension

beanz added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3968-3984 +Final Macros + + +Clang supports the pragma ``#pragma clang final``, which can be used to +mark macros as final, meaning they cannot be undef'd or re-defined. For example: + +..

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Any feedback? I think this patch is good enough to be accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372852. mizvekov added a comment. add another FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h

[PATCH] D109865: [NFC] `goto fail` has failed us in the past...

beanz created this revision. beanz added reviewers: rsmith, harlanhaskins, bkramer. beanz requested review of this revision. Herald added a project: clang. This patch replaces reliance on `goto failure` pattern with `llvm::scope_exit`. Repository: rG LLVM Github Monorepo

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372849. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372846. mizvekov added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372845. mizvekov added a comment. Add a couple more test cases where we don't perform copy-elision on a returned prvalue in pre-C++17 modes, and the corresponding FIXMEs in the source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov added a comment. I can have a look on what is happening with that test case. At best if we figure out what is wrong, we could add some FIXMEs and circle back to it after we make this whole thing work again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

rsmith added a comment. There might be some tooling out there that cares about `CXXConstructExpr`s that might be elided due to NRVO being marked as elidable. But it's probably OK to lose that marking if nothing in-tree is relying on it, and use `isElidable` only for copy elision from rvalues

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372843. cchen added a comment. Add tests and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 372841. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. I think the test fix is all that's needed for now. This is somewhat urgent for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris updated this revision to Diff 372839. ormris added a comment. - Downgrade to C11 and C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 Files: clang/test/Lexer/char-escapes-delimited.c

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

mbenfield created this revision. mbenfield added a reviewer: dblaikie. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This applies to -Wunused-but-set-variable and -Wunused-but-set-parameter. This addresses bug 51865.

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov created this revision. mizvekov updated this revision to Diff 372616. mizvekov added a comment. mizvekov updated this revision to Diff 372828. mizvekov retitled this revision from "test commit." to "[clang] don't mark as Elidable CXXConstruct expressions used in NRVO". mizvekov edited

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. I bet my issue is due to D108243 and not this change. Sorry for the noise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002862 , @thakis wrote: > Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't > yet verified it's definitely due to this change, but it's the most > related-looking change in the regression

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + HazardyKnusperkeks wrote: > Could you also add tests

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372827. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Yes, https://bugs.chromium.org/p/chromium/issues/detail?id=1250052 I haven't yet verified it's definitely due to this change, but it's the most related-looking change in the regression range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Okay, what's happening is that utf literals are only available for c++11 onward and the tests do not account for that. Would you mind dropping the minimum version to C++11 and C11? I think that would be reasonable. I could do a more extensive fix but I don't know how

[clang] 699da98 - PR51874: Fix diagnostics for defaulted, implicitly deleted 'operator!='.

Author: Richard Smith Date: 2021-09-15T15:43:02-07:00 New Revision: 699da98739b0f88c27f75adbe8295c7e1dfd0188 URL: https://github.com/llvm/llvm-project/commit/699da98739b0f88c27f75adbe8295c7e1dfd0188 DIFF: https://github.com/llvm/llvm-project/commit/699da98739b0f88c27f75adbe8295c7e1dfd0188.diff

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. We saw this failure for our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow. Repository: rG LLVM Github

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Should this checker remain in alpha in its current form? WDYT? @all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

cor3ntin added a comment. Thanks! For which platforms did you had issue? This is suppose to work in all language modes (we might want to use C99/C++98 to make sure that's the case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris created this revision. ormris added reviewers: cor3ntin, aaron.ballman. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify the C and C++ standards explicitly for this test. This avoids failures for drivers that default

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG8025c03f70ee: [clang-format] Top-level unwrapped lines dont follow a left brace (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8025c03 - [clang-format] Top-level unwrapped lines don't follow a left brace

Author: owenca Date: 2021-09-15T14:52:07-07:00 New Revision: 8025c03f70ee9b92e8599519b5ee34b54c9a80da URL: https://github.com/llvm/llvm-project/commit/8025c03f70ee9b92e8599519b5ee34b54c9a80da DIFF: https://github.com/llvm/llvm-project/commit/8025c03f70ee9b92e8599519b5ee34b54c9a80da.diff LOG:

[PATCH] D109841: Fix vtbl field addr space

rjmccall accepted this revision. rjmccall added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan added a comment. It will prevent them from even being checked in `parseStructuralElement` as `IsTopLevel` is now `false`: case tok::l_paren: { parseParens(); // Break the unwrapped line if a K C function definition has a parameter // declaration. if (!IsTopLevel ||

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov added a comment. In D109654#3002632 , @thakis wrote: > Is it possible that this disabled this for Objective-C++ too? As far as I understand, CPlusPLus will be set on ObjectiveC++ as well, and I think we do have test coverage there, but I

[PATCH] D109854: Support Unicode 14 identifiers This update the UAX tables to support new Unicode 14 identifiers

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109854 Files: clang/lib/Lex/UnicodeCharSets.h Index:

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

thakis added a comment. Is it possible that this disabled this for Objective-C++ too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654 ___ cfe-commits mailing

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov added a comment. In D105756#3001045 , @NoQ wrote: > I guess I'm confused about the exact meaning of the AST. I'm not sure whether > it's actively incorrect or just changed meaning. I'll definitely be debugging > this further. > > My backstory

[clang] 8264846 - Senticify some comments - post-commit review for e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e

Author: David Blaikie Date: 2021-09-15T13:59:11-07:00 New Revision: 8264846c0ef847adeacca9b8fe0f867a8a378c5e URL: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e DIFF: https://github.com/llvm/llvm-project/commit/8264846c0ef847adeacca9b8fe0f867a8a378c5e.diff

[clang-tools-extra] d249200 - Revert "Re-Revert "clang-tidy: introduce readability-containter-data-pointer check""

Author: Saleem Abdulrasool Date: 2021-09-15T20:52:55Z New Revision: d249200fa7d540fb0b3ddc065575293e1da11107 URL: https://github.com/llvm/llvm-project/commit/d249200fa7d540fb0b3ddc065575293e1da11107 DIFF: https://github.com/llvm/llvm-project/commit/d249200fa7d540fb0b3ddc065575293e1da11107.diff

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Tue, Sep 14, 2021 at 10:04 AM Richard Smith wrote: > On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: David Blaikie >> Date: 2021-09-13T19:17:05-07:00 >> New Revision: 2bd84938470bf2e337801faafb8a67710f46429d >> >> URL: >>

[PATCH] D109841: Fix vtbl field addr space

yaxunl updated this revision to Diff 372792. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: jrtc27. fix comments and casts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 Files:

[clang] 40acc0a - Improve type printing of size-dependent const arrays to normalize array-of-const and const-array

Author: David Blaikie Date: 2021-09-15T13:46:37-07:00 New Revision: 40acc0adad59ac39e9a7a02fcd93161298500c00 URL: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00 DIFF: https://github.com/llvm/llvm-project/commit/40acc0adad59ac39e9a7a02fcd93161298500c00.diff

[PATCH] D109841: Fix vtbl field addr space

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D109841#3002404 , @arichardson wrote: > Thanks, I can confirm that this fixes the assertions we were seeing after > merging D103835 . A few minor

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis added a comment. In D109828#3002114 , @hans wrote: > The /winsysroot part makes sense to me, but what's the case for the new > /diasdkdir flag? - If you do have a vcvars shell, you don't need the full sysroot path and it's kind of useful (see

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

sfertile accepted this revision as: sfertile. sfertile added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis updated this revision to Diff 372782. thakis marked an inline comment as done. thakis added a comment. move arch functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109828/new/ https://reviews.llvm.org/D109828 Files: clang/include/clang/Driver/Options.td

[PATCH] D109841: Fix vtbl field addr space

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the assertions we were seeing after merging D103835 . A few minor suggestions below: There's a typo in the

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 372770. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @Mordante Alfonso Gregory gfunni...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dgoldman I did it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 372766. gAlfonso-bit added a comment. git-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman added a comment. In D108469#2957652 , @jfb wrote: > I worry that changing the general `static_assert` printing (adding a colon, > and dropping the quotes) will get @hwright's law to drop on us. We can try > and see if e.g. users of clang

[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + Could you also add tests for `false`, even though they are spread over the other test

[PATCH] D109841: Fix vtbl field addr space

rjmccall added a comment. The following line is always just making a bitcast, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109841/new/ https://reviews.llvm.org/D109841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. https://reviews.llvm.org/D109841 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835/new/ https://reviews.llvm.org/D103835 ___ cfe-commits mailing list

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin planned changes to this revision. cor3ntin added a comment. I'll fix the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 ___ cfe-commits mailing

[PATCH] D109841: Fix vtbl field addr space

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arichardson. yaxunl requested review of this revision. vtbl filed of an object should have same addr space of the object. Currently it is assumed to be addr space 0 but this may not be true. This caused issue for some out of

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

rjmccall added a comment. I see. Yes, in that case, that sounds right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835/new/ https://reviews.llvm.org/D103835 ___ cfe-commits mailing list

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

hans added a comment. The /winsysroot part makes sense to me, but what's the case for the new /diasdkdir flag? Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:66 +static const char *llvmArchToLegacyVCArch(llvm::Triple::ArchType Arch); + Maybe move the arch

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. In D103835#3001011 , @rjmccall wrote: > Hmm. I think "v-tables are in the address space of the object pointer" is > not a good assumption. Probably this ought to be determined by the C++ ABI > for the target. In principle it

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3000152 , @HazardyKnusperkeks wrote: > I haven't looked too much into it, my main point is that there should be > tests for both variants of that option for braces, parenthesis, and angular > braces, if they are

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372749. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files:

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372748. csmulhern retitled this revision from "Adds an AlignCloseBracket option" to "Adds a BreakBeforeClosingParen option". csmulhern edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1423-1426 +ObjCMethodList InstanceMethods; +ObjCMethodList FactoryMethods; +llvm::DenseSet AddedInstanceMethods; +llvm::DenseSet AddedFactoryMethods; Do these two sets

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108787/new/ https://reviews.llvm.org/D108787 ___ cfe-commits mailing list

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand accepted this revision. uweigand added a comment. This LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab5f2b505a07: [HIP] Diagnose -fopenmp-targets for HIP programs (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[clang] ab5f2b5 - [HIP] Diagnose -fopenmp-targets for HIP programs

Author: Yaxun (Sam) Liu Date: 2021-09-15T13:03:57-04:00 New Revision: ab5f2b505a0751bce41f4cec9afa3c1541d485d0 URL: https://github.com/llvm/llvm-project/commit/ab5f2b505a0751bce41f4cec9afa3c1541d485d0 DIFF:

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added a comment. In D106393#3000122 , @sfertile wrote: > I suggest we separate the clang change and testing into a standalone patch, > and the llvm backend tests into a standalone patch which we can commit > separately. LLVM tests added in

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

weiwang added a comment. In D109175#2989997 , @yaxunl wrote: > In D109175#2989823 , @weiwang wrote: > >> In D109175#2987048 , @jdoerfert >> wrote: >> >>> In

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372737. anirudhp added a comment. - Update to the documentation as well in account for the update to the global prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 372736. ZarkoCA added a comment. - Removed llc tests - Added a helper function to combine the PPC64_SVR4ABI and AIXABI treatment of complex types less than register size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added inline comments. Comment at: llvm/docs/LangRef.rst:2596 * ``e``: ELF mangling: Private symbols get a ``.L`` prefix. +* ``l``: GOFF mangling: Private symbols get a ``.L`` prefix. * ``m``: Mips mangling: Private symbols get a ``$`` prefix.

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. In D109362#3001294 , @uweigand wrote: > In D109362#3000284 , @anirudhp > wrote: > >> In D109362#2999688 , @uweigand >> wrote: >> >>> Looking

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp updated this revision to Diff 372733. anirudhp added a comment. - Introduce separate label prefix for `MM_GOFF` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 Files:

[PATCH] D109836: [Analyzer] ConversionChecker: track back the cast expression

martong created this revision. martong added reviewers: steakhal, Szelethus, NoQ. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this revision.

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:28 +// The first Unroll loop pass is the createSimpleLoopUnrollPass that unrolls and peels +// loops with small constant trip counts. Only the second one is handled by ThinLTO. +//

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

This revision was automatically updated to reflect the committed changes. Closed by commit rG210d72e9d6b4: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM

[PATCH] D108138: [WIP] Remove switch statements before vectorization

lebedev.ri added a comment. Hi. I'm personally still not very okay with the approach as it currently is. Do you need to run LoopRotate after lowering switches? Anything else? But then you don't actually know that after spending all this compile time, the vectorization will actually happen, and

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. In D104556#3001497 , @catenacyber wrote: > Should we still bump `INSTR_PROF_RAW_VERSION ` so that we are able to > distinguish profraw files produced by clang13 and the ones produced by > clang14 ? > > Right now, both produce

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 372720. sherwin-dc added a comment. - Modify test to correctly indicate old/new PM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files:

[PATCH] D108138: [WIP] Remove switch statements before vectorization

kmclaughlin added a comment. Hi all, I've updated this to take a different approach - the new patch runs LowerSwitch just before the vectoriser, where it will only consider simple switches which are part of a loop. For these switches, the pass will create a series of branches and compares

[PATCH] D108138: [WIP] Remove switch statements before vectorization

kmclaughlin updated this revision to Diff 372706. kmclaughlin retitled this revision from "[SimplifyCFG] Remove switch statements before vectorization" to "[WIP] Remove switch statements before vectorization". kmclaughlin edited the summary of this revision. kmclaughlin added a comment. Herald

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:3 +// RUN: %clang_cc1 -mllvm -debug-pass=Structure -O2 -fno-experimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -flto=thin -o -

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109812/new/ https://reviews.llvm.org/D109812 ___ cfe-commits mailing

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3925e25ae0: [clang][driver][AIX] Add system libc++ header paths to driver (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1f3925e - [clang][driver][AIX] Add system libc++ header paths to driver

Author: David Tenty Date: 2021-09-15T10:41:18-04:00 New Revision: 1f3925e25ae010c30273501d24b2bd4e0318fe7a URL: https://github.com/llvm/llvm-project/commit/1f3925e25ae010c30273501d24b2bd4e0318fe7a DIFF: https://github.com/llvm/llvm-project/commit/1f3925e25ae010c30273501d24b2bd4e0318fe7a.diff

[PATCH] D109828: [clang-cl] Add a /diasdkdir flag and make /winsysroot imply it

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dang, pengfei. thakis requested review of this revision. D109708 added "DIA SDK" to our win sysroot for hermetic builds that use LLVM_ENABLE_DIA_SDK. But the build system

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but pls wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109607/new/

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. > The option of adding sm_XX in Bundle Entry ID when user hasn't used -march > flag, comes under command line simplification. I have a bunch of upcoming > patches which will significantly simplify OpenMP command line for GPU > offloading. But, don't you think this

[clang] 274adcb - Implement delimited escape sequences.

Author: Corentin Jabot Date: 2021-09-15T09:54:49-04:00 New Revision: 274adcb866343cb505408d8f401840ea814522c8 URL: https://github.com/llvm/llvm-project/commit/274adcb866343cb505408d8f401840ea814522c8 DIFF:

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM added a comment. In D109825#3001622 , @dmgreen wrote: >> As I did the downstream work for this, I'm happy with it to go in in this >> form. > > This doesn't seem.. wise. Please make sure the reviews you do are at a > sufficient quality,

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 372698. mubashar_ added a comment. Updated release notes to solve a merge conflict. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

  1   2   >