[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

2021-09-18 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6. Herald added subscribers: ormris, guansong, hiraditya, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added

[PATCH] D109799: [RISCV] add Half-precision test for clang

2021-09-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. This patch is really large and touches tests for integer operations. Can you just pre-commit the removal of lines with just comment characters. No need to review for that. That should reduce the noise in this patch. Repository: rG LLVM Github Monorepo CHANGES

[clang] 000875c - OpenMP 5.0 metadirective

2021-09-18 Thread via cfe-commits
Author: alokmishra.besu Date: 2021-09-18T13:40:44-05:00 New Revision: 000875c127c7f2ae10a954bd592c1658e5912cf1 URL: https://github.com/llvm/llvm-project/commit/000875c127c7f2ae10a954bd592c1658e5912cf1 DIFF:

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

2021-09-18 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 373416. salman-javed-nz marked 2 inline comments as done. salman-javed-nz added a comment. `shouldSuppressDiagnostic()`: - Changed to take a container of diagnostics as an argument. If it finds any stray `NOLINTBEGIN`/`NOLINTEND` markers, it creates

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

2021-09-18 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz marked 5 inline comments as done. salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:6 + +// NOLINTEND +class B1 { B1(int i); }; aaron.ballman wrote: > salman-javed-nz wrote: >

[PATCH] D109557: Adds a BreakBeforeClosingParen option

2021-09-18 Thread Cameron Mulhern via Phabricator via cfe-commits
csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" MyDeveloperDay wrote: >

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

2021-09-18 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added a comment. In D109607#3007860 , @Meinersbur wrote: > This patch seem to have broken `GCC-C-execute-pr44575` from the > llvm-test-suite. See http://meinersbur.de:8011/#/builders/76/builds/761 (this > builder compiles with Polly, but it

[PATCH] D91944: OpenMP 5.0 metadirective

2021-09-18 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. Also, when this lands again, please ensure that all the tests don't accidentally dump build artifacts into the source directory. Specifically, the following test was missing `-o -`: clang/test/OpenMP/metadirective_messages.cpp Repository: rG LLVM Github

[PATCH] D91944: OpenMP 5.0 metadirective

2021-09-18 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. (Reverted for now since mac bots have been broken for 16 hours now.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 ___ cfe-commits

[clang] 31cca21 - Revert "OpenMP 5.0 metadirective"

2021-09-18 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-09-18T09:10:37-04:00 New Revision: 31cca215654ac5eca01796248696b8d710a5cffc URL: https://github.com/llvm/llvm-project/commit/31cca215654ac5eca01796248696b8d710a5cffc DIFF: https://github.com/llvm/llvm-project/commit/31cca215654ac5eca01796248696b8d710a5cffc.diff

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. @aaron.ballman, since this is reintroducing some warnings after the relaxation in D102026 , should we bring this to Clang 13? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

2021-09-18 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D109951#3007425 , @guitard0g wrote: > When looking at test case suggestions, I happened upon another problem that > occurs when handling preprocessor directives. The following code is properly > formatted

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106715/new/ https://reviews.llvm.org/D106715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b889f826ff5: Thread safety analysis: Warn when demoting locks on back edges (authored by aaronpuchert). Repository: rG LLVM Github Monorepo

[clang] 9b889f8 - Thread safety analysis: Warn when demoting locks on back edges

2021-09-18 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2021-09-18T13:46:55+02:00 New Revision: 9b889f826ff587e9758c80823419512d502e457d URL: https://github.com/llvm/llvm-project/commit/9b889f826ff587e9758c80823419512d502e457d DIFF: https://github.com/llvm/llvm-project/commit/9b889f826ff587e9758c80823419512d502e457d.diff

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

2021-09-18 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. This patch seem to have broken `GCC-C-execute-pr44575` from the llvm-test-suite. See http://meinersbur.de:8011/#/builders/76/builds/761 (this builder compiles with Polly, but it also crashes without Polly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108469: Improve handling of static assert messages.

2021-09-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 373408. cor3ntin added a comment. Properly comment isFormatting/isPrintable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files:

[PATCH] D108469: Improve handling of static assert messages.

2021-09-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D108469#3002209 , @aaron.ballman wrote: > In D108469#2957652 , @jfb wrote: > >> I worry that changing the general `static_assert` printing (adding a colon, >> and dropping the

[PATCH] D108469: Improve handling of static assert messages.

2021-09-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 373405. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D108469: Improve handling of static assert messages.

2021-09-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 373404. cor3ntin marked 5 inline comments as done. cor3ntin added a comment. - Fix tests, cland tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: