[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1118 + llvm::GlobalValue::WeakAnyLinkage, + llvm::ConstantInt::get(CGM.Int8Ty, Mode ? 0x2 : 0x1), + Twine(Name, "_exec_mode")); The magic constants need to go

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Absolutely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110032/new/ https://reviews.llvm.org/D110032

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 373483. salman-javed-nz added a comment. Minor update to function signatures - Remove arguments that are not absolutely required - Added `const`s This really should have been incorporated in my previous patch, so sorry about the double

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. In D110037#3008292 , @pengfei wrote: > What do you think? The test-suite is an end-to-end/integration test while tests monorepository are unit/regression tests. They have different purposes. (Personally, I would prefer to

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3008290 , @pengfei wrote: > By the way, does this bot send notification to authors when it fails? I > didn't receive this fail, so I'm not aware of it at the first time. This is my personal staging buildbot server

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie created this revision. dblaikie added reviewers: aaron.ballman, rtrieu. dblaikie requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This improves diagnostic (& important to me, DWARF)

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

dim added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9937 + if (E->isElidable() && !ZeroInit) { +// FIXME: This only handles the simples case, where the source object +//is passed directly as the first argument to the constructor.

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

fcambus created this revision. fcambus added a reviewer: JDevlieghere. fcambus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110041 Files:

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/X86/va-arg-sse.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // RUN: %clang_cc1 %s -O2 -emit-llvm -o - -triple x86_64-unknown-unknown | FileCheck %s Please

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei added a comment. I'm wondering whether the test case is required or not for this patch. Reasons: 1. We have a test in llvm-test-suite can cover this and the test is just a snippet of it; 2. The test case can not reflect the direct effect of this change; 3. There're many variables in IR

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3007860 , @Meinersbur wrote: > This patch seem to have broken `GCC-C-execute-pr44575` from the > llvm-test-suite. See http://meinersbur.de:8011/#/builders/76/builds/761 (this > builder compiles with Polly, but it

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei created this revision. pengfei added reviewers: LuoYuanke, Meinersbur, craig.topper, RKSimon. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D109607 results in a regression in

[PATCH] D110036: [TargetInfo][LangOpts] Refactor target info and language options adjustment.

azabaznov created this revision. azabaznov added reviewers: aaron.ballman, Anastasia, svenvh. Herald added subscribers: dexonsmith, kerbowa, sunfish, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. azabaznov requested review of this revision. Herald added subscribers:

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

RedDocMD created this revision. RedDocMD added reviewers: NoQ, teemperor, xazax.hun, vsavchenko. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this revision.