[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. In D109967#3044464 , @rnk wrote: > Thanks for doing this, this approach looks like it incorporated my feedback > on the previous approach. Yeah, listened to the wise men... and struggled a lot doing so ;-)

[PATCH] D111207: Driver: Add a gcc equivalent triple to the list of triples to search

tstellar created this revision. tstellar added reviewers: aaronpuchert, hvdijk, MaskRay. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. There are some gcc triples, like x86_64-redhat-linux, that provide the same behavior as a clang

[clang] cb89d37 - Revert "[clang] Allow printing 64 bit ints in diagnostics"

Author: Arthur Eubanks Date: 2021-10-05T22:24:16-07:00 New Revision: cb89d3739db746ea50eb50b7208e689126394391 URL: https://github.com/llvm/llvm-project/commit/cb89d3739db746ea50eb50b7208e689126394391 DIFF:

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

tstellar added a comment. This patch should depend on D109837 , otherwise clang builds will be broken on SUSE if you don't pass -DLLVM_DEFAULT_TARGET_TRIPLE to cmake when configuring, and I don't think we should require users to pass this option.

[PATCH] D111178: Fix clang postMerge logic based on System V ABI Standard

pengfei added a comment. Testcase? Can this patch fix the problem in D107965 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78/new/ https://reviews.llvm.org/D78

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedfff2f8b043: [clang] Allow printing 64 bit ints in diagnostics (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] edfff2f - [clang] Allow printing 64 bit ints in diagnostics

Author: Arthur Eubanks Date: 2021-10-05T22:07:16-07:00 New Revision: edfff2f8b0435bc4af94bd3b41bf57244d84d993 URL: https://github.com/llvm/llvm-project/commit/edfff2f8b0435bc4af94bd3b41bf57244d84d993 DIFF:

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377421. jyu2 added a comment. Adding check for map type in test. Thanks Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files:

[PATCH] D109967: Simplify handling of builtin with inline redefinition

rnk added a comment. Thanks for doing this, this approach looks like it incorporated my feedback on the previous approach. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3177 + // PR9614. Avoid cases where the source code is lying to us. An available // externally

[PATCH] D111205: [driver] Explicitly specify `-fbuild-session-timestamp` in seconds.

vsapsai created this revision. vsapsai added a reviewer: benlangmuir. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Representation of the file's last modification time depends on the file system and isn't guaranteed to be in

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D05#3043734 , @aeubanks wrote: > update test > I checked to make sure that we're not accepting -clear-ast-before-backend as > a driver

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

HsiangKai added a comment. Herald added a subscriber: achieveartificialintelligence. I think we could restart to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. @aaron.ballman We discussed internally and I think your concern of mixing type attribute and decl attribute is valid. In the long run, having two separate attributes, one for type (btf_type_tag) and another for decl (btf_decl_tag) seems clean and better. I have

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. Herald added subscribers: dexonsmith, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Commit [1] introduced

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Also, I don't have push access so someone would need to push this for me assuming it is approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377389. haowei edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei commandeered this revision. haowei added a reviewer: leonardchan. haowei added a comment. Herald added a subscriber: abrachet. I am commandeering this work as original author stopped working this project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Note that I found this due to a report of a crash in clangd , but I don't actually use that so just looked through the code for what was messing with paths. Users on that bug report confirmed that this fixed

[libunwind] 54a8a0d - [runtimes] Allow FOO_TEST_CONFIG to be a relative path

Author: Louis Dionne Date: 2021-10-05T19:45:50-04:00 New Revision: 54a8a0d09a572a0581c0755541847e016274e15c URL: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c DIFF: https://github.com/llvm/llvm-project/commit/54a8a0d09a572a0581c0755541847e016274e15c.diff

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 created this revision. jeremyd2019 added reviewers: mstorsjo, rsmith. jeremyd2019 added a project: clang. jeremyd2019 requested review of this revision. Herald added a subscriber: cfe-commits. Previously it only used Windows command lines for MSVC triples, but this was causing issues

[PATCH] D110436: Add %n format specifier warning

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning<

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

NoQ added a comment. Hey, I brought you some regressions! const int arr[]; const int arr[3] = {1, 2, 3}; void foo() { if (arr[0] < 3) { } } test.c:6:14: warning: The left operand of '<' is a garbage value [core.UndefinedBinaryOperatorResult] if (arr[0] < 3) {

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

aaronpuchert added a comment. In D110216#3041117 , @mizvekov wrote: > In D110216#3040748 , @craig.topper > wrote: > >> Looks like this fixes PR51282. > > I guess it does fix it, but the underlying implementation

[PATCH] D110436: Add %n format specifier warning

Jaysonyan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning<

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. Herald added a subscriber: arphaman. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These should be all the commands from [1] except

[PATCH] D111187: [Clang] Add information about partially implemented features

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Desccribe in cxx_status.html the missing parts of the partially implemented proposals described in cxx_status.html. Uses blocks so the information

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added a comment. Tests with modifiers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377357. jyu2 added a comment. Thanks Alexey! Fix missing Modifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + Hello, I encountered crashes on Windows targets, related to this line, when rebasing

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we're limited to 32 bit ints in diagnostics. With support for 4GB alignments coming soon, we need to report 4GB as the max alignment

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

This revision was automatically updated to reflect the committed changes. mtrofin marked an inline comment as done. Closed by commit rG7d541eb4d49a: [inliner] Mandatory inlining decisions produce remarks (authored by mtrofin). Changed prior to commit:

[clang] 7d541eb - [inliner] Mandatory inlining decisions produce remarks

Author: Mircea Trofin Date: 2021-10-05T14:01:25-07:00 New Revision: 7d541eb4d49b6a51a3568b9214fd8691e2d3 URL: https://github.com/llvm/llvm-project/commit/7d541eb4d49b6a51a3568b9214fd8691e2d3 DIFF: https://github.com/llvm/llvm-project/commit/7d541eb4d49b6a51a3568b9214fd8691e2d3.diff

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8451-8454 + ArrayRef MapModifiers; + ArrayRef MotionModifiers; + return getMapTypeBits( + I->getSecond(), MapModifiers, MotionModifiers, false, ABataev

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377344. jyu2 added a comment. Address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D15 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. The change looks ok to me, but I think it'd be good to have a testcase for finding these paths (IIRC there are a bunch of simulated sysroots under clang/test/Driver). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081

[clang] 9397127 - Fix some Sphinx warnings in the static analyzer docs

Author: Aaron Ballman Date: 2021-10-05T16:43:55-04:00 New Revision: 939712734a563dd4d12b88f875d9c8e2b0fa6219 URL: https://github.com/llvm/llvm-project/commit/939712734a563dd4d12b88f875d9c8e2b0fa6219 DIFF: https://github.com/llvm/llvm-project/commit/939712734a563dd4d12b88f875d9c8e2b0fa6219.diff

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks accepted this revision. aeubanks added a comment. lg, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 ___ cfe-commits mailing list

[clang] 1ddcb80 - Update the release notes for consteval if support; NFC

Author: Aaron Ballman Date: 2021-10-05T16:39:23-04:00 New Revision: 1ddcb804f7e4883bda1877d0e5f9cfda70edc803 URL: https://github.com/llvm/llvm-project/commit/1ddcb804f7e4883bda1877d0e5f9cfda70edc803 DIFF: https://github.com/llvm/llvm-project/commit/1ddcb804f7e4883bda1877d0e5f9cfda70edc803.diff

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377335. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update some clang uses to fix errors/warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks updated this revision to Diff 377333. aeubanks added a comment. update test I checked to make sure that we're not accepting -clear-ast-before-backend as a driver flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/

[PATCH] D111178: Fix clang postMerge logic based on System V ABI Standard

vsoch created this revision. vsoch added reviewers: LLVM, llvm.org. vsoch created this object with edit policy "Only User: vsoch (Vanessasaurus)". vsoch added a project: LLVM. Herald added a subscriber: pengfei. vsoch requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie requested changes to this revision. dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. This revision now requires changes to proceed. Oh, looking at this ab it further I do have some things to discuss. Comment at:

[PATCH] D109557: Adds a BreakBeforeClosingParen option

gracicot added a comment. In D109557#3021667 , @HazardyKnusperkeks wrote: > In D109557#3021312 , > @MyDeveloperDay wrote: > >> FYI, this is a very aggressive change, I highly recommend you run this over >> a

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems like a good place to start with experimentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/

[PATCH] D110436: Add %n format specifier warning

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning<

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937 +// Extract map information. +for (const auto *C : Dir.getClausesOfKind()) { + if (C->getMapType() != OMPC_MAP_to) +continue; + for (auto L :

[PATCH] D110436: Add %n format specifier warning

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning< FWIW,

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin created this revision. Herald added a subscriber: jeroen.dobbelaere. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement P2360R0 in C++23 mode and as an extension in older languages mode. Repository: rG LLVM

[PATCH] D110436: Add %n format specifier warning

aaron.ballman added a comment. The trouble with this diagnostic is that it throws the baby out with the bathwater. It is possible to securely use `%n`, so we can't have this warning be on by default because it will have too high of a false positive rate. However, we typically don't introduce

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937 +// Extract map information. +for (const auto *C : Dir.getClausesOfKind()) { + if (C->getMapType() != OMPC_MAP_to) +continue; + for (auto L : C->component_lists()) {

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae updated this revision to Diff 377323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/annotations-global.c

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377316. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fix up c++ version in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. @jdoerfert: Ping. I think you're the best match for reviewing the code related to interaction between CUDA and the system include files, even if this particular header does not have much to do with OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 377309. vabridgers added a comment. This revision is now accepted and ready to land. Refactor compare a little bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:102 + } catch (...) { +printf("Unknown exception\n"); + } karies wrote: > How is that provoking a test failure? What about `exit(1)` or

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377307. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/examples/CMakeLists.txt

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan updated this revision to Diff 377306. Jake-Egan added a comment. Updated to preserve blank lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69/new/ https://reviews.llvm.org/D69 Files:

[PATCH] D110436: Add %n format specifier warning

Jaysonyan added a comment. Since no discussion came out of the RFC I'll leave the warning under the `-Wformat-n-specifier` flag under `-Wformat` unless there's other ideas brought up. Would appreciate any reviews at this points! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377303. v.g.vassilev added a comment. Upload the newest version of this patch. It has several improvements that came from various bot failures. We just need to outline the `llvm::consumeError` to be able to call it from exceptions land and fix the last

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, emaste. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7104e506619: [Sema] Allow comparisons between different ms ptr size address space types. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c7104e5 - [Sema] Allow comparisons between different ms ptr size address space types.

Author: Amy Huang Date: 2021-10-05T10:56:29-07:00 New Revision: c7104e506619b551ee7ab888a040114f260e8cb5 URL: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5 DIFF: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5.diff

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8451-8454 + ArrayRef MapModifiers; + ArrayRef MotionModifiers; + return getMapTypeBits( + I->getSecond(), MapModifiers, MotionModifiers, false, No need to

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377288. jyu2 added a comment. Thanks Alexey's review. This patch is address Alexe's comments by adding new field LambdasMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers planned changes to this revision. vabridgers added a comment. I'm refactoring the code change a bit. I'll push another update soon. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/

[clang-tools-extra] 0c14e27 - [clangd] Revert unwanted change from D108194

Author: Kirill Bobyrev Date: 2021-10-05T18:44:43+02:00 New Revision: 0c14e279c7294cb354e803ba5f2557425fee7c59 URL: https://github.com/llvm/llvm-project/commit/0c14e279c7294cb354e803ba5f2557425fee7c59 DIFF:

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 377283. jsji added a comment. Herald added a subscriber: kbarton. Address comments -- adding AIX triples to more existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/

Re: [PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

You're welcome :) Yeah, I think there's even `arc land` that's _intended_ for this but I'm just using the patch option. And it pulls from Phabricator (name, email etc). On Tue, Oct 5, 2021 at 6:17 PM Matt Beardsley via Phabricator < revi...@reviews.llvm.org> wrote: > mattbeardsley added a

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM thanks for the update. This looks like it follows the same format as the other -none-elf toolchains, and AArch64 can benefit from the bare-metal driver for easier access to

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley added a comment. Works for me!  I didn't realize you can pull the info automatically from arc. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

ASDenysPetrov added a comment. Thanks for mentioning me. I'll make a review of this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 ___ cfe-commits

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32ab79ebc496: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column… (authored by mattbeardsley, committed by kbobyrev).

[clang-tools-extra] 32ab79e - [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

Author: Matt Beardsley Date: 2021-10-05T18:09:53+02:00 New Revision: 32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 URL: https://github.com/llvm/llvm-project/commit/32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 DIFF:

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

kbobyrev added a comment. Sure! I'm just using the credentials from the arc, mostly, i.e. `arc patch --nobranch D110600 && git push`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGebfcd06d4222: [clangd] IncludeCleaner: Mark used headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/

[clang-tools-extra] ebfcd06 - [clangd] IncludeCleaner: Mark used headers

Author: Kirill Bobyrev Date: 2021-10-05T18:08:24+02:00 New Revision: ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb URL: https://github.com/llvm/llvm-project/commit/ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb DIFF:

[clang] 9503ad3 - [clang] FatalErrorHandler.cpp - add explicit include

Author: Simon Pilgrim Date: 2021-10-05T17:03:17+01:00 New Revision: 9503ad3b533cb84b51cfc80c51d262da50435013 URL: https://github.com/llvm/llvm-project/commit/9503ad3b533cb84b51cfc80c51d262da50435013 DIFF: https://github.com/llvm/llvm-project/commit/9503ad3b533cb84b51cfc80c51d262da50435013.diff

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

frasercrmck added a comment. LGTM in general. My comments are all about comments. I know the old names are kept as aliases but I still think it's better to reference the "real" instructions where we can. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2468

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6831c1d8689b: [clangd] Include refs of base method in refs for derived method. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 6831c1d - [clangd] Include refs of base method in refs for derived method.

Author: Utkarsh Saxena Date: 2021-10-05T17:39:49+02:00 New Revision: 6831c1d8689bebe745aac1fdd7354c2e2f692c1a URL: https://github.com/llvm/llvm-project/commit/6831c1d8689bebe745aac1fdd7354c2e2f692c1a DIFF:

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377264. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Thank you for the review! Looks much better now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.h:65 SrcMgr::CharacteristicKind FileKind = SrcMgr::C_User; + unsigned ID = std::numeric_limits::max(); //

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3042913 , @daltenty wrote: > Good point, but the std::chrono::file_clock interface hasn't shipped yet on > the platform libc++, since it's currently still at a bit of a backlevel, so I > don't think

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

daltenty added a comment. > Making a change to whether a platform has __int128 affects the ABI of > libc++'s std::chrono::file_clock. We should make sure the mitigation patch is > posted and accepted. Good point, but the std::chrono::file_clock interface hasn't shipped yet on the platform

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

crayroud added a comment. Thank you for your inputs. I will work on the changes and update the patch once it is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

aaron.ballman added a comment. In D110656#3034971 , @beanz wrote: > In D110656#3034083 , @xbolva00 > wrote: > >> Why just no special case "= {0};" pattern and do not warn in that case? > > This case did show up,

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: hubert.reinterpretcast wrote: > Confirming that this case matches GCC on AIX: > ``` > ld 4,8(3) > ld

[PATCH] D110455: DebugInfo: Use clang's preferred names for integer types

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Seems like a good simplification. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110455/new/ https://reviews.llvm.org/D110455

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a reviewer: mstorsjo. mstorsjo added a subscriber: cfe-commits. mstorsjo added a comment. (I’ll have a look and comment on the patch later.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377197. kbobyrev marked 10 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files:

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:158 + +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, sammccall wrote: > sammccall wrote: > > Why are we passing around Inclusions by value? > Sorry, should

[clang] f4f9ad0 - Reland "[clang-repl] Allow loading of plugins in clang-repl."

Author: Vassil Vassilev Date: 2021-10-05T13:04:01Z New Revision: f4f9ad0f5d8e8994c677c3712dff7585bf8bd963 URL: https://github.com/llvm/llvm-project/commit/f4f9ad0f5d8e8994c677c3712dff7585bf8bd963 DIFF: https://github.com/llvm/llvm-project/commit/f4f9ad0f5d8e8994c677c3712dff7585bf8bd963.diff

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub marked an inline comment as done. kamaub added a comment. Updated an existing test for the backend with pwr8 and pwr9 be/le targets during commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109599/new/ https://reviews.llvm.org/D109599

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

This revision was automatically updated to reflect the committed changes. Closed by commit rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units (authored by kamaub). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang] 8737c74 - [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

Author: Kamau Bridgeman Date: 2021-10-05T07:59:32-05:00 New Revision: 8737c74fab3aee833d85b7d235d2c47ebb4eed2e URL: https://github.com/llvm/llvm-project/commit/8737c74fab3aee833d85b7d235d2c47ebb4eed2e DIFF:

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24/new/ https://reviews.llvm.org/D24

[PATCH] D107141: [Inline-asm] Add structure type handling when they are tied in input and output constraints

pengfei updated this revision to Diff 377168. pengfei added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/Sema/SemaStmtAsm.cpp

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:159 +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, + const IncludeStructure , EntryPoint is unused Comment at:

  1   2   >