[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. Fixed windows build bot errors after landing this patch with 06404d5488ea505b00f711393973db3ae32d01e9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 06404d5 - [Clang][OpenMP] Fix windows buildbot failure for D105191

Author: Saiyedul Islam Date: 2021-10-07T05:54:56Z New Revision: 06404d5488ea505b00f711393973db3ae32d01e9 URL: https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9 DIFF: https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9.diff

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

rjmccall added a comment. This patch seems to be confused. You're making two changes. In one of them, you're trying to prevent `addrspacecast`s from being interleaved with the sequence of `alloca`s in the function prologue. In the other, you're moving the store emitted by `InitTempAlloca`

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

kgk added a comment. Will the new macros in this patch also be useful for supporting the surface-related methods that also use __nv_tex_surf_handler (from surface_indirect_functions.h)? I gave this new code a try with surf2Dread and surf2Dwrite, and based on the errors, it look like it may

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 377742. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c4117089599: [Clang][OpenMP] Add partial support for Static Device Libraries (authored by saiislam). Repository: rG LLVM Github Monorepo

[clang] 4c41170 - [Clang][OpenMP] Add partial support for Static Device Libraries

Author: Saiyedul Islam Date: 2021-10-07T04:45:19Z New Revision: 4c4117089599cb5b6c6fa5635c28462ffd1bddf4 URL: https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4 DIFF: https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4.diff

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya added a comment. Still working on adding the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111286/new/ https://reviews.llvm.org/D111286 ___ cfe-commits mailing list

[PATCH] D111286: Add no_instrument_function attribute to Objective C methods as well

hiraditya created this revision. hiraditya added a reviewer: rjmccall. Herald added a reviewer: aaron.ballman. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are several methods where we do not want function

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

rjmccall added a comment. I assume we rebuild an AILE and OVE when we process the initializer and see it's a structured binding? In that case, this should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Patch looks good to me now, thanks. I don't think `always_inline` should strictly be necessary vs. just `static inline`, because in either case the function definition containing the

[clang] 393581d - [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

Author: hsmahesha Date: 2021-10-07T09:05:39+05:30 New Revision: 393581d8a5cb017da1b4c27456c92290751bdfae URL: https://github.com/llvm/llvm-project/commit/393581d8a5cb017da1b4c27456c92290751bdfae DIFF: https://github.com/llvm/llvm-project/commit/393581d8a5cb017da1b4c27456c92290751bdfae.diff

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393581d8a5cb: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests (authored by hsmhsm). Repository: rG LLVM Github Monorepo

[clang] 40ec1c0 - [IR][NFC] Rename getBaseObject to getAliaseeObject

Author: Itay Bookstein Date: 2021-10-06T19:33:10-07:00 New Revision: 40ec1c0f16cb23f8b83fb3d28b195e83991defd9 URL: https://github.com/llvm/llvm-project/commit/40ec1c0f16cb23f8b83fb3d28b195e83991defd9 DIFF:

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

thakis added a comment. Fixed in 6707a7d7e96ac23ba66f16bdb44927082d2fd4d3 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089

[PATCH] D111283: [clang] WIP: template / auto deduction deduces common sugar

mizvekov created this revision. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements deducing the common sugar between two types, and uses it to establish the result when checking deduced template arguments.

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song updated this revision to Diff 377727. yonghong-song added a comment. - Instead of piggyback on existing AttributedType, create a new child class AttributedBTFType. The code is reorganized to avoid intrusive to existing AttributedType. - Hack: the AttributedBTFType still not

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia";

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 377726. haowei marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. These are interesting results. I'm curious to measure the time spent in `ASTReader::ReadMethodPool`. I'm planning to preserve the order of methods roughly by `s/InstanceMethods.append/InstanceMethods.prepend/` in `ReadMethodPoolVisitor`. `isAcceptableMethodMismatch`

[clang] 6707a7d - [CUDA] remove unneeded includes from CUDA-related headers.

Author: Artem Belevich Date: 2021-10-06T17:20:21-07:00 New Revision: 6707a7d7e96ac23ba66f16bdb44927082d2fd4d3 URL: https://github.com/llvm/llvm-project/commit/6707a7d7e96ac23ba66f16bdb44927082d2fd4d3 DIFF:

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/19372/step_7.txt Please take a look :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG. Always including string (probably) won't hurt given the stuff we do here already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110252: Added note about Whatstyle and Unformat

Volker-Weissmann added a comment. I understand your concerns, it isn't meant as an endorsement. I took me quite a while too find them with google, so I thought I make it faster for the next one after me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110455: DebugInfo: Use clang's preferred names for integer types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6a561c4d675: DebugInfo: Use clangs preferred names for integer types (authored by dblaikie). Herald added subscribers: llvm-commits, lldb-commits,

[clang] f6a561c - DebugInfo: Use clang's preferred names for integer types

Author: David Blaikie Date: 2021-10-06T16:02:34-07:00 New Revision: f6a561c4d6754b13165a49990e8365d819f64c86 URL: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86 DIFF: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86.diff

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h:61 uptr mem = (uptr)MmapOrDie(allocsz, "stack depot"); +atomic_fetch_add(_size, allocsz, memory_order_relaxed);

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377714. vitalybuka added a comment. fixed size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377711. vitalybuka added a comment. remove duplicate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccfb0555f76b: [CUDA] Implement experimental support for texture lookups. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ccfb055 - [CUDA] Implement experimental support for texture lookups.

Author: Artem Belevich Date: 2021-10-06T15:15:53-07:00 New Revision: ccfb0555f76b865cf50bd354558dd00bfa7b2762 URL: https://github.com/llvm/llvm-project/commit/ccfb0555f76b865cf50bd354558dd00bfa7b2762 DIFF:

[clang] 141df74 - Add missing diagnostic for use of _reserved name in extern "C"

Author: Richard Smith Date: 2021-10-06T15:13:06-07:00 New Revision: 141df744564822b8d8250fe1bcec15cdbd5f213e URL: https://github.com/llvm/llvm-project/commit/141df744564822b8d8250fe1bcec15cdbd5f213e DIFF: https://github.com/llvm/llvm-project/commit/141df744564822b8d8250fe1bcec15cdbd5f213e.diff

[clang] 7063b76 - PR50644: Do not warn on a declaration of `operator"" _foo`.

Author: Richard Smith Date: 2021-10-06T15:13:05-07:00 New Revision: 7063b76b02484f93104f1c79496ad216b9bf5b87 URL: https://github.com/llvm/llvm-project/commit/7063b76b02484f93104f1c79496ad216b9bf5b87 DIFF: https://github.com/llvm/llvm-project/commit/7063b76b02484f93104f1c79496ad216b9bf5b87.diff

[clang] 7ebcb7c - PR50641: Properly handle AttributedStmts when checking for a valid

Author: Richard Smith Date: 2021-10-06T15:13:05-07:00 New Revision: 7ebcb7ce78f6abb73c5a29e7c8b9dd360acb65bc URL: https://github.com/llvm/llvm-project/commit/7ebcb7ce78f6abb73c5a29e7c8b9dd360acb65bc DIFF: https://github.com/llvm/llvm-project/commit/7ebcb7ce78f6abb73c5a29e7c8b9dd360acb65bc.diff

[clang] a625fd2 - Revert "Reland "[clang][Fuchsia] Re-enable compiler-rt tests in runtimes build""

Author: Leonard Chan Date: 2021-10-06T15:09:40-07:00 New Revision: a625fd26cea579853bfe6c00f8fd8e6e88388630 URL: https://github.com/llvm/llvm-project/commit/a625fd26cea579853bfe6c00f8fd8e6e88388630 DIFF: https://github.com/llvm/llvm-project/commit/a625fd26cea579853bfe6c00f8fd8e6e88388630.diff

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 377703. tra added a comment. Use `int` for string hash calculations to avoid dealing with char signedness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files:

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin planned changes to this revision. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:553 +def err_expected_alias_after_using_in_init_statement : Error< + "expected alias declaration after using in init statement">; +def

[PATCH] D106191: [clang] Option control afn flag

lebedev.ri added reviewers: aaron.ballman, erichkeane. lebedev.ri added subscribers: erichkeane, aaron.ballman. lebedev.ri added a comment. Looks reasonable to me. @aaron.ballman @erichkeane does it seem complete or are we missing some infra piece? Comment at:

[PATCH] D106191: [clang] Option control afn flag

masoud.ataei added a comment. Reminder for reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4743eba3c13: Fix assert of Unable to find base lambda address from (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/

[clang] a4743eb - Fix assert of "Unable to find base lambda address" from

Author: Jennifer Yu Date: 2021-10-06T14:14:28-07:00 New Revision: a4743eba3c13799e66764554fd44ccc6a33a URL: https://github.com/llvm/llvm-project/commit/a4743eba3c13799e66764554fd44ccc6a33a DIFF: https://github.com/llvm/llvm-project/commit/a4743eba3c13799e66764554fd44ccc6a33a.diff

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

morehouse added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h:61 uptr mem = (uptr)MmapOrDie(allocsz, "stack depot"); +atomic_fetch_add(_size, allocsz, memory_order_relaxed); atomic_store(_end, mem + allocsz,

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 377687. tra added a comment. Removed obsolete comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

zequanwu created this revision. zequanwu added reviewers: rnk, phosek. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we only delete lines that are outer block statements (if, while, etc), clang-format-diff.py can't format the

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie added a comment. In D05#3046631 , @aeubanks wrote: > In D05#3046585 , @dblaikie > wrote: > >>> This is similar to perf testing which we don't really have in tree tests >>> for. Typically these

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks added a comment. In D05#3046585 , @dblaikie wrote: >> This is similar to perf testing which we don't really have in tree tests >> for. Typically these things are mostly monitored separately (e.g. >> llvm-compile-time-tracker). > > Except

[clang] c7e7278 - [clang][Fuchsia] Add -static-libgcc to TSAN tests

Author: Leonard Chan Date: 2021-10-06T14:01:39-07:00 New Revision: c7e72784aef9ee5f32e438e4d2d09a9710d5538b URL: https://github.com/llvm/llvm-project/commit/c7e72784aef9ee5f32e438e4d2d09a9710d5538b DIFF: https://github.com/llvm/llvm-project/commit/c7e72784aef9ee5f32e438e4d2d09a9710d5538b.diff

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai added a comment. Are there any comments regarding this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110280/new/ https://reviews.llvm.org/D110280 ___ cfe-commits mailing list

[PATCH] D110452: [modules] Fix tracking ObjCInterfaceType decl when there are multiple definitions.

vsapsai added a comment. Ping. Failing ORC tests seem to be unrelated, seen the same failed tests in other code reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110452/new/ https://reviews.llvm.org/D110452

[clang] c52d60e - Reland "[clang][Fuchsia] Re-enable compiler-rt tests in runtimes build"

Author: Leonard Chan Date: 2021-10-06T13:57:24-07:00 New Revision: c52d60ec3b9202eaa9e109be539f1d2a03fbad70 URL: https://github.com/llvm/llvm-project/commit/c52d60ec3b9202eaa9e109be539f1d2a03fbad70 DIFF: https://github.com/llvm/llvm-project/commit/c52d60ec3b9202eaa9e109be539f1d2a03fbad70.diff

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai updated this revision to Diff 377677. vsapsai added a comment. Adhere to clang-format requirements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110280/new/ https://reviews.llvm.org/D110280 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/RecursiveASTVisitorTest.cpp:130 +TEST(RecursiveASTVisitorTest, EnumDeclWithBase) { + /// Check attributes are traversed inside

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie added a comment. > This is similar to perf testing which we don't really have in tree tests for. > Typically these things are mostly monitored separately (e.g. > llvm-compile-time-tracker). Except in this case it isn't tested at all because it's behind a flag. Unless we're bringing

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks updated this revision to Diff 377675. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 377674. keith added a comment. Remove debug comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith created this revision. Herald added a reviewer: JDevlieghere. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building a multiarch MachO binary, previously the intermediate output file names would contain random

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:636 -Matcherhttps://clang.llvm.org/doxygen/classclang_1_1Decl.html;>DeclblockDeclMatcherhttps://clang.llvm.org/doxygen/classclang_1_1BlockDecl.html;>BlockDecl...

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6522b7cc3240: [clang] Add option to clear AST memory before running LLVM passes (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] 6522b7c - [clang] Add option to clear AST memory before running LLVM passes

Author: Arthur Eubanks Date: 2021-10-06T13:42:22-07:00 New Revision: 6522b7cc3240626952ebc271d8714043a805911d URL: https://github.com/llvm/llvm-project/commit/6522b7cc3240626952ebc271d8714043a805911d DIFF:

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6400 +/// pointerTypeLoc(hasPointeeLoc(loc(asString("int" +/// matches `int*`.

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks updated this revision to Diff 377669. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://reviews.llvm.org/D05 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend.c:2-3 +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S -### 2>&1 |

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3044102 , @aaronpuchert wrote: > Unless I'm missing something, alignment on aliases is itself fragile. Let's > say you have some template, then the instantiation with the alias is of > course the same as the

[PATCH] D111242: Add `TypeLoc`-related matchers.

jcking1034 marked an inline comment as not done. jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6358 +/// \code +/// int* x = 0; +/// \endcode ymandel wrote: > I think you need a const here (to the right) to be

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

nemanjai added a comment. Please change the condition as Jinsong suggested and change the leading comment to: // On AIX, only emit the extended mnemonics for dcbt and dcbtst if // the "modern assembler" is available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110451: [IR] Increase max alignment to 4GB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05392466f02b: Reland [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; MaskRay wrote: > You may switch to namespace scope/global

[PATCH] D111267: [clang] Fix darwin REQUIRES test annotation (NFC)

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some subprojects like compiler-rt define the `darwin` feature in their lit config, but clang does not do that, so we need to use the global `system-darwin`

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

saudi added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:677 + SwapOpts(Res); + bool Success2 = Parse(Res, GeneratedArgs1, Diags); + jansvoboda11 wrote: > saudi wrote: > > Hello, > > > > I encountered crashes on Windows targets,

[PATCH] D111266: Comment AST: Add support for variable templates

aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We treat them as variables of course, though if they have function pointer type we treat

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were doing this already for type aliases, and it deduplicates the code looking through

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111262 Files:

[PATCH] D111260: [clang] Visit enum base specifiers in libIndex

kadircet updated this revision to Diff 377654. kadircet added a comment. - Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111260/new/ https://reviews.llvm.org/D111260 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D111260: [clang] Visit enum base specifiers in libIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes

[PATCH] D111224: [clang] Traverse enum integer-base specifiers in RAV

kadircet updated this revision to Diff 377652. kadircet marked 3 inline comments as done. kadircet added a comment. - split changes in libindex - fix the issue with non-traversal of forward-decls - add unittests into RAV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111259: [clang] Fix range for forward-declared enums

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to span just the `[[enum foo]] : bar;` in the absence of a body. This patch expands the range to cover

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377650. vitalybuka added a comment. update a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Thanks for working on this. Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:161 // where th can be omitted when it is 0. dcbtst is the same. -

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

Conanap created this revision. Conanap added reviewers: nemanjai, jsji, PowerPC. Conanap added projects: clang, LLVM, PowerPC. Herald added subscribers: kbarton, hiraditya. Conanap requested review of this revision. On AIX, the system assembler does not support the extended mnemonics `dcbtt` and

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka created this revision. vitalybuka added reviewers: morehouse, eugenis. Herald added a subscriber: mgorny. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This way is easier to

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

phosek added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:893 Builder.defineMacro("_GNU_SOURCE"); +Builder.defineMacro("FUCHSIA_API_LEVEL", Twine(Opts.FuchsiaAPILevel)); +this->PlatformName = "fuchsia"; aaron.ballman wrote: > I

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel added a comment. Also, please list the new matchers in the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111242/new/ https://reviews.llvm.org/D111242 ___ cfe-commits mailing

[PATCH] D111242: Add `TypeLoc`-related matchers.

ymandel added a comment. Nice! Just some minor notes. Comment at: clang/docs/LibASTMatchersReference.html:636 -Matcherhttps://clang.llvm.org/doxygen/classclang_1_1Decl.html;>DeclblockDeclMatcherhttps://clang.llvm.org/doxygen/classclang_1_1BlockDecl.html;>BlockDecl...

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

erichkeane added a comment. I agree with aaron, the ParseUsingDeclaration bit should be aware of the DeclaratorContext and emit the error there, rather than try to parse it as whatever and THEN error. The problem is the user-interface at that point, which is to spend a few cycles correcting

[PATCH] D110451: [IR] Increase max alignment to 4GB

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; You may switch to namespace scope/global `constexpr` while touching

[PATCH] D110252: Added note about Whatstyle and Unformat

HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added a comment. I too think this should not directly mentioned in clang-format documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110252/new/

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:553 +def err_expected_alias_after_using_in_init_statement : Error< + "expected alias declaration after using in init statement">; +def ext_alias_in_init_statement : ExtWarn<

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377633. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGCall.cpp

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377631. aeubanks added a comment. more types changed throughout the codebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

aaron.ballman added reviewers: erichkeane, rsmith. aaron.ballman added a comment. Thank you for this new feature work! Adding a few more reviewers to the mix. Can you also add a release note for the new functionality? Comment at:

[clang] 569346f - Revert "Reland [IR] Increase max alignment to 4GB"

Author: Arthur Eubanks Date: 2021-10-06T11:38:11-07:00 New Revision: 569346f27418e4cdde95e0f803fb2799049a53d1 URL: https://github.com/llvm/llvm-project/commit/569346f27418e4cdde95e0f803fb2799049a53d1 DIFF:

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks created this revision. aeubanks added reviewers: hans, rsmith. Herald added a reviewer: aaron.ballman. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Followup to D110451 which set

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3045883 , @bader wrote: > In D109144#3042247 , @Anastasia > wrote: > >> 1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we >> add `spirv` triple

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a comment. I think this is missing changes to the documentation as well. In D111228#3045319 , @balazske wrote: > These options are added to make the configuration more comfortable if only > functions are to be added or removed from

[clang] 8d64314 - Reland [IR] Increase max alignment to 4GB

Author: Arthur Eubanks Date: 2021-10-06T11:03:51-07:00 New Revision: 8d64314ffea55f2ad94c1b489586daa8ce30f451 URL: https://github.com/llvm/llvm-project/commit/8d64314ffea55f2ad94c1b489586daa8ce30f451 DIFF:

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191

[clang] a2796f1 - [Driver][test] Add Debian multiarch lib/clang/14.0.0/x86_64-linux-gnu and include/x86_64-linux-gnu/c++/v1 tests

Author: Fangrui Song Date: 2021-10-06T10:49:25-07:00 New Revision: a2796f1e86555fc0848b060a3bc0fe03e4ecf93b URL: https://github.com/llvm/llvm-project/commit/a2796f1e86555fc0848b060a3bc0fe03e4ecf93b DIFF: https://github.com/llvm/llvm-project/commit/a2796f1e86555fc0848b060a3bc0fe03e4ecf93b.diff

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. In D110781#3045280 , @jdoerfert wrote: > I first had to read up on pop_macro -.-. Still unsure if it is OK to push it > once and pop it twice, that works fine? Good catch. > Can't we move the string include earlier, grouped with

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133 + + if (Triple.getVendor() != llvm::Triple::UnknownVendor) +return false; Is vendor check necessary? Comment at: clang/test/Driver/baremetal.cpp:105

[clang] 72cf8b6 - Revert "[IR] Increase max alignment to 4GB"

Author: Arthur Eubanks Date: 2021-10-06T10:21:35-07:00 New Revision: 72cf8b60445441635745ee65ff0c1f9c1a4418fe URL: https://github.com/llvm/llvm-project/commit/72cf8b60445441635745ee65ff0c1f9c1a4418fe DIFF:

  1   2   >