[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

ASDenysPetrov added a comment. In D111640#3058622 , @martong wrote: > In D111640#3058304 , @steakhal > wrote: > >> It looks good. >> Do you think we could remove the `RangedConstraintManager` abstraction? > >

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1609-1612 + const SymExpr *LHS = Sym->getLHS(); + const llvm::APSInt = + Builder.getBasicValueFactory().getValue(0, LHS->getType()); + State =

[PATCH] D111529: Specify Clang vector builtins.

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating both inputs and pairing adjacent elements. + fhahn wrote: > craig.topper wrote:

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

martong added a comment. In D111640#3058304 , @steakhal wrote: > It looks good. > Do you think we could remove the `RangedConstraintManager` abstraction? Definitely. What's more, we could split out cohesive implementation details like `RangeSet`,

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz added a comment. Hi Nathan Would you mind reviewing this change? It's related to your https://reviews.llvm.org/D85503 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz created this revision. adamcz added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously we would call

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1603-1604 + template + bool handleRem(const SymT *Sym, RangeSet Constraint) { +// a % b != 0 implies that a != 0. ASDenysPetrov wrote: > steakhal wrote:

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379039. martong marked 11 inline comments as done. martong added a comment. - Handle a % b == 0 implies that a == 0. - Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 379034. jozefl added a comment. Rebase onto new base revision to fix pre-merge tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files:

[PATCH] D103908: [clang] p0388 array list initialization overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG444ec0957c58: [clang] p0388 array list initialization overloads (authored by urnathan). Herald added a project: clang. Herald added a subscriber:

[PATCH] D102645: [clang] p0388 conversion to incomplete array

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcd74716f9d1: [clang] p0388 conversion to incomplete array (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 444ec09 - [clang] p0388 array list initialization overloads

Author: Nathan Sidwell Date: 2021-10-12T07:35:21-07:00 New Revision: 444ec0957c58492ecce0569bb20b7d3ad59d37bb URL: https://github.com/llvm/llvm-project/commit/444ec0957c58492ecce0569bb20b7d3ad59d37bb DIFF:

[clang] dcd7471 - [clang] p0388 conversion to incomplete array

Author: Nathan Sidwell Date: 2021-10-12T07:35:20-07:00 New Revision: dcd74716f9d18444a17de852a760cc85bd16f825 URL: https://github.com/llvm/llvm-project/commit/dcd74716f9d18444a17de852a760cc85bd16f825 DIFF:

[PATCH] D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unused-return-value.rst:16 + By default the following functions are checked: + ``std::async, std::launder, std::remove, std::remove_if, std::unique, +

[PATCH] D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

This revision was automatically updated to reflect the committed changes. Closed by commit rGa76cfc2e840f: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC]. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a76cfc2 - [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

Author: Balázs Kéri Date: 2021-10-12T16:43:45+02:00 New Revision: a76cfc2e840ff373b80e3a5f84fc48c5f1f90d8a URL: https://github.com/llvm/llvm-project/commit/a76cfc2e840ff373b80e3a5f84fc48c5f1f90d8a DIFF: https://github.com/llvm/llvm-project/commit/a76cfc2e840ff373b80e3a5f84fc48c5f1f90d8a.diff

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. Looking at the behaviour of gcc it looks like there -march=armv8-r enables instructions that are present in 8-r but not 8-a, but doesn't disable any instructions. So e.g. it will accept the dcps3 instruction when compiling with -march=armv8-r whereas clang won't.

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan abandoned this revision. Jake-Egan added a comment. Abandoning this patch because D97184 is already committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69/new/ https://reviews.llvm.org/D69

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've commit on your behalf in 40546cb38189e438a81faa6400c103d159600f9e . CHANGES SINCE LAST ACTION

[clang-tools-extra] 40546cb - Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

Author: Carlos Galvez Date: 2021-10-12T10:08:08-04:00 New Revision: 40546cb38189e438a81faa6400c103d159600f9e URL: https://github.com/llvm/llvm-project/commit/40546cb38189e438a81faa6400c103d159600f9e DIFF: https://github.com/llvm/llvm-project/commit/40546cb38189e438a81faa6400c103d159600f9e.diff

[PATCH] D111566: [SYCL] Fix function pointer address space

yaxunl added a comment. need a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111566/new/ https://reviews.llvm.org/D111566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp updated this revision to Diff 379023. carlosgalvezp added a comment. Removed `RUN` line and put the check in the existing one, to speed up the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 Files:

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. Ping @hubert.reinterpretcast Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 ___ cfe-commits mailing list

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG564e082d0954: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers (authored by saghir). Repository: rG LLVM Github

[clang] 564e082 - [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

Author: Ahsan Saghir Date: 2021-10-12T08:51:50-05:00 New Revision: 564e082d0954e0beebfff994ac03471d926cd1d1 URL: https://github.com/llvm/llvm-project/commit/564e082d0954e0beebfff994ac03471d926cd1d1 DIFF: https://github.com/llvm/llvm-project/commit/564e082d0954e0beebfff994ac03471d926cd1d1.diff

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#3057417 , @rjmccall wrote: > I think the immediate way forward is that we can continue to document this as > an experimental feature with an unstable ABI, just with a new name. We do > not need to tie these

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379017. martong added a comment. - Rebase on top of new Parent (Use ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/ https://reviews.llvm.org/D110357 Files:

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It looks good. Do you think we could remove the `RangedConstraintManager` abstraction? It shouldn't be hard to get rid of it. Regardless, it's good to go, but let's wait for the child

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. I realized I can speed up the test by removing the extra `RUN` line and simply add the new check to the list of checks, let me fix that before merge :) Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp:56

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. In D108643#3057417 , @rjmccall wrote: > In D108643#3055244 , @erichkeane > wrote: > ! In D108643#3054443 , @rjmccall wrote:

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 379011. jozefl added a comment. Rebase onto new base revision to fix pre-merge tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files:

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp:56 virtual ~SimpleCases(); - // CHECK-MESSAGES: :[[@LINE-1]]:11:

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong

[PATCH] D111639: [PR51855] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf created this revision. brunodf added a reviewer: jeroen.dobbelaere. brunodf added a project: clang. brunodf requested review of this revision. Herald added a subscriber: cfe-commits. The invocation of a unary or binary operator for type-dependent expressions is represented as a

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 updated this revision to Diff 379003. jansvoboda11 added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111543/new/ https://reviews.llvm.org/D111543 Files: clang/include/clang/Lex/ModuleMap.h

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 added a comment. In D111543#3056115 , @dexonsmith wrote: > Are you sure this is only for Objective-C interfaces? Doesn't also happen if > you name a module after a C++ class or something, and reference it from an > attribute? From my

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

aaron.ballman added a comment. LGTM, thank you @thakis! Comment at: clang/lib/Analysis/CFG.cpp:2407 + return hasSpecificAttr(A->getAttrs()) && + isa(A->getSubStmt()); +} hans wrote: > thakis wrote: > > hans wrote: > > > Can fallthrough statements ever

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc74ab84ea23f: [clang] Omit most AttributedStatements from the CFG (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github

[clang] c74ab84 - [clang] Omit most AttributedStatements from the CFG

Author: Nico Weber Date: 2021-10-12T09:15:45-04:00 New Revision: c74ab84ea23f497ac83501473220cd9cfefe81e8 URL: https://github.com/llvm/llvm-project/commit/c74ab84ea23f497ac83501473220cd9cfefe81e8 DIFF: https://github.com/llvm/llvm-project/commit/c74ab84ea23f497ac83501473220cd9cfefe81e8.diff

[PATCH] D111529: Specify Clang vector builtins.

fhahn marked 4 inline comments as done. fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + T __builtin_elementwise_rint(T x) return the integral value nearest to x (according to the floating point types +

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis updated this revision to Diff 378996. thakis added a comment. rename param; assert isa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111568/new/ https://reviews.llvm.org/D111568 Files: clang/lib/Analysis/CFG.cpp clang/test/SemaCXX/switch-implicit-fallthrough.cpp

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong added inline comments. Comment at: clang/test/Analysis/solver-sym-simplification-concreteint.c:22 + // c == 0 --> 0 + 1 == 0 contradiction + clang_analyzer_eval(c == 0);// expected-warning{{FALSE}} + martong wrote: > steakhal wrote: > > Could we

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/CFG.cpp:2407 + return hasSpecificAttr(A->getAttrs()) && + isa(A->getSubStmt()); +} thakis wrote: > hans wrote: > >

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong updated this revision to Diff 378994. martong marked an inline comment as done. martong added a comment. - Make the test case way simpler (and independent from other solver patches) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110913/new/

[PATCH] D110913: [analyzer][solver] Handle simplification to ConcreteInt

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2104 + const llvm::APSInt = CI->getValue(); + const RangeSet *ClassConstraint = getConstraint(State, Class); + // We have

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 378992. fhahn added a comment. Try to be more precise about how the reduction steps are performed and replace _round and _rint by roundeven. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2407 + return hasSpecificAttr(A->getAttrs()) && + isa(A->getSubStmt()); +} hans wrote: > Can fallthrough statements ever have children? If not,

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Sounds good to me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111570/new/ https://reviews.llvm.org/D111570 ___ cfe-commits mailing list

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

aaron.ballman added a comment. Can you add a test case that shows we've fixed the issue? (Note, you cannot include iostream directly in a test because that will use the platform STL and we want our tests to have consistent behavior regardless of platform.) Repository: rG LLVM Github

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

thakis added a comment. Yes, that's my understanding. (I'm not super familiar with this code either.) The line was added in the change that added -Wimplicit-fallthrough (84837d5b5aa0d), and all the -Wimplicit-fallthrough tests still pass with this. Chances are it was unnecessary back then too.

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 updated this revision to Diff 378980. jansvoboda11 added a comment. Leave existing cache, create new cache indexed by module names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111543/new/ https://reviews.llvm.org/D111543 Files:

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378979. saiislam added a comment. clang-format(ed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/ https://reviews.llvm.org/D111488 Files: clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam updated this revision to Diff 378978. saiislam marked 5 inline comments as done. saiislam added a comment. Thanks, Michael and Artem! 1. Changed nvlink-command to nvlink-path. 2. Answered queries and done refactoring as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111623/new/ https://reviews.llvm.org/D111623 ___ cfe-commits mailing list

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

hans added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:545 CFGBlock *VisitAddrLabelExpr(AddrLabelExpr *A, AddStmtChoice asc); + CFGBlock *VisitAttributedStmt(AttributedStmt *C, AddStmtChoice asc); CFGBlock *VisitBinaryOperator(BinaryOperator *B, AddStmtChoice

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD =

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

hans added a comment. I guess I don't have enough context here. Why is AttributedStmtClass special here? Is it because it's a statement and the others are expressions, and so wouldn't go through CFGBlock::addStmt()? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111570/new/

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/index.rst:314 +are ignored here, as they would effectively re-activate the warning, causing +confusion to the users. There's something about this "causing confusion to the

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349 + // Allow specifying a few checks with a glob expression. + GlobList Globs(ChecksStr); + if (!Globs.contains(CheckName))

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 378957. saiislam added a comment. Used comment style for named parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files:

[clang] 6a1f50b - [clang][deps] Prune unused header search paths

Author: Jan Svoboda Date: 2021-10-12T12:39:23+02:00 New Revision: 6a1f50b84ae8f8a8087fcdbe5f27dae8c76878f1 URL: https://github.com/llvm/llvm-project/commit/6a1f50b84ae8f8a8087fcdbe5f27dae8c76878f1 DIFF: https://github.com/llvm/llvm-project/commit/6a1f50b84ae8f8a8087fcdbe5f27dae8c76878f1.diff

[PATCH] D102488: [clang][deps] Prune unused header search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a1f50b84ae8: [clang][deps] Prune unused header search paths (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D102488?vs=378285=378953#toc Repository: rG LLVM Github

[PATCH] D111560: [clang][modules] Cache loads of modules imported by PCH

jansvoboda11 added a comment. I implemented the alternative approach, which now seems more straightforward than going through the `ModuleManager` and working with `serialization::ModuleFile`. WDYT @dexonsmith? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG477f5f4fca2b: [RISCV][Clang] Fix RISCV vector header comment. (authored by jacquesguan, committed by benshi001). Repository: rG LLVM Github

[clang] 477f5f4 - [RISCV][Clang] Fix RISCV vector header comment.

Author: jacquesguan Date: 2021-10-12T10:26:25Z New Revision: 477f5f4fca2b1d994045a0cb821ffb3873519243 URL: https://github.com/llvm/llvm-project/commit/477f5f4fca2b1d994045a0cb821ffb3873519243 DIFF: https://github.com/llvm/llvm-project/commit/477f5f4fca2b1d994045a0cb821ffb3873519243.diff LOG:

[PATCH] D102923: [clang][lex] Remark on search path usage

This revision was automatically updated to reflect the committed changes. Closed by commit rG444513510999: [clang][lex] Remark on search path usage (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/

[clang] 4445135 - [clang][lex] Remark on search path usage

Author: Jan Svoboda Date: 2021-10-12T12:20:55+02:00 New Revision: 444513510999e4c1ea23253654196793834d53bf URL: https://github.com/llvm/llvm-project/commit/444513510999e4c1ea23253654196793834d53bf DIFF: https://github.com/llvm/llvm-project/commit/444513510999e4c1ea23253654196793834d53bf.diff

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 updated this revision to Diff 378945. jansvoboda11 added a comment. Implemented alternative approach: attach the caching listener to PCH reading as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111560/new/

[PATCH] D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I checked the list, now it's complete. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111623/new/ https://reviews.llvm.org/D111623

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG544d89e847d4: [OpenCL] Add atomic_half type builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D109740?vs=376467=378938#toc Repository: rG LLVM Github Monorepo CHANGES

[clang] 544d89e - [OpenCL] Add atomic_half type builtins

Author: Sven van Haastregt Date: 2021-10-12T10:45:30+01:00 New Revision: 544d89e847d42ce8856296752b0fb279aa89aace URL: https://github.com/llvm/llvm-project/commit/544d89e847d42ce8856296752b0fb279aa89aace DIFF:

[PATCH] D111625: [clang-tidy] bugprone-argument-comment: SourceLocation valid judgment avoid emitting coredump in isInSystemHeader

Sockke created this revision. Sockke added reviewers: aaron.ballman, njames93, george.burgess.iv, hokein. Herald added a subscriber: xazax.hun. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. If the Node has an invalid

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

balazske abandoned this revision. balazske added a comment. Checker configuration can be solved in reusable way by introducing "configuration variables" and manipulation of these with set operations. https://reviews.llvm.org/D111623 was created to update the checker documentation.

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:923 + + const RVVIntrinsicInfo *Intrinsic = std::find_if( + std::begin(RVVIntrinsicInfos), std::end(RVVIntrinsicInfos), rogfer01 wrote: > Not for this patch: I think this table may

[PATCH] D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC].

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The list of checked functions was

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

rogfer01 added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:923 + + const RVVIntrinsicInfo *Intrinsic = std::find_if( + std::begin(RVVIntrinsicInfos), std::end(RVVIntrinsicInfos), Not for this patch: I think this table may be a bit large so

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 added a comment. Thanks for the review, I handled the header map case and added tests. I'll commit once the CI passes. Comment at: clang/lib/Lex/HeaderSearch.cpp:473 + // The case where the target file **does not exist** is handled here: +

[PATCH] D102923: [clang][lex] Remark on search path usage

jansvoboda11 updated this revision to Diff 378922. jansvoboda11 added a comment. Report matched header maps even when target file does not exist, add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added inline comments. Comment at: clang/docs/BitIntABI.rst:90 +width. e.g., a ``signed _BitField(7)`` whose representation width is ``8`` bits +cannot store values less than ``-64`` or greater than ``63``. + It might be worthwhile to pull these

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111597/new/ https://reviews.llvm.org/D111597

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp:56 virtual ~SimpleCases(); - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual'

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. > Just an FYI, but we usually only ping when there's been about a week of no > traffic on the review Thanks, I'll keep it in mind for next time! Really appreciate your time reviewing :) I have updated the patch based on your feedback. CHANGES SINCE LAST ACTION

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349 + // Allow specifying a few checks with a glob expression. + GlobList Globs(ChecksStr); + if

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 378913. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Remove support for negative globs. Keep unit tests to ensure that negative globs are ignored. Update documentation. CHANGES SINCE LAST ACTION

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

nikic added a comment. I noticed this a few time in the past already, but this is the worst one yet: Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f=97f0c63783f52389bd8842df205379ceade7a89d=instructions Max-rss:

[PATCH] D111517: [X86] Remove little support we had for MPX

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111517/new/ https://reviews.llvm.org/D111517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai created this revision. HsiangKai added reviewers: khchen, craig.topper, rogfer01, kito-cheng. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, frasercrmck, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[clang] 1341a2c - [clang][modules] Default `SourceLocation` parameter in `HeaderSearch::lookupModule`

Author: Jan Svoboda Date: 2021-10-12T09:58:54+02:00 New Revision: 1341a2c19e54cec77ccb35e3b4ee3924870b2e6a URL: https://github.com/llvm/llvm-project/commit/1341a2c19e54cec77ccb35e3b4ee3924870b2e6a DIFF: https://github.com/llvm/llvm-project/commit/1341a2c19e54cec77ccb35e3b4ee3924870b2e6a.diff

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:115 +if (AllocaInsertedAtAllocaInsertPt) + AllocaAddrSpaceInsertPt = dyn_cast(V)->getIterator(); } Shouldn't this use `cast` instead? Repository: rG LLVM Github Monorepo

[clang] 3e7cf33 - [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

Author: Victor Campos Date: 2021-10-12T08:41:07+01:00 New Revision: 3e7cf33a83764514bd613dfb5b1a0bb36f13e69a URL: https://github.com/llvm/llvm-project/commit/3e7cf33a83764514bd613dfb5b1a0bb36f13e69a DIFF: https://github.com/llvm/llvm-project/commit/3e7cf33a83764514bd613dfb5b1a0bb36f13e69a.diff

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7cf33a8376: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang (authored by vhscampos). Repository: rG LLVM Github

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. In D108643#3055244 , @erichkeane wrote: >>> ! In D108643#3054443 , @rjmccall >>> wrote: >>> ! In D108643#3027473 , @erichkeane

[PATCH] D111557: [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch::lookupModule`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG638c673a8c3e: [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch… (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 638c673 - [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch::lookupModule`

Author: Jan Svoboda Date: 2021-10-12T09:31:51+02:00 New Revision: 638c673a8c3e27b6532049ac17ac9bc96640fc45 URL: https://github.com/llvm/llvm-project/commit/638c673a8c3e27b6532049ac17ac9bc96640fc45 DIFF: https://github.com/llvm/llvm-project/commit/638c673a8c3e27b6532049ac17ac9bc96640fc45.diff

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. In D110258#3055488 , @dmgreen wrote: > If D111551 was folded into this patch, > would it be possible to add tests for -tune-cpu enabling/disabling features > at the correct times? Similar

<    1   2