[clang] 9aa6c72 - Fix lit test failures in clang-ppc* and clang-x64-windows-msvc

Author: Juneyoung Lee Date: 2021-10-16T14:33:59+09:00 New Revision: 9aa6c72b92b6c89cc6d23b693257df9af7de2d15 URL: https://github.com/llvm/llvm-project/commit/9aa6c72b92b6c89cc6d23b693257df9af7de2d15 DIFF: https://github.com/llvm/llvm-project/commit/9aa6c72b92b6c89cc6d23b693257df9af7de2d15.diff

[clang] 705387c - Resolve lit failures in clang after 8ca4b3e's land

Author: Juneyoung Lee Date: 2021-10-16T13:51:50+09:00 New Revision: 705387c5074bcca36d626882462ebbc2bcc3bed4 URL: https://github.com/llvm/llvm-project/commit/705387c5074bcca36d626882462ebbc2bcc3bed4 DIFF: https://github.com/llvm/llvm-project/commit/705387c5074bcca36d626882462ebbc2bcc3bed4.diff

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aheejin added a comment. After this patch, `-print-stats` started erroring out. I filed a bug at https://bugs.llvm.org/show_bug.cgi?id=52193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80dba72a669b: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune, committed by hyeongyukim). Changed

[clang] 80dba72 - [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

Author: Juneyoung Lee Date: 2021-10-16T12:01:37+09:00 New Revision: 80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a URL: https://github.com/llvm/llvm-project/commit/80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a DIFF: https://github.com/llvm/llvm-project/commit/80dba72a669b5416e97a42fd2c2a7bc5a6d3f44a.diff

[PATCH] D111923: [RISCV] Split RISCV vector builtins into their own file and namespace.

craig.topper created this revision. craig.topper added reviewers: HsiangKai, khchen, arcbbb, kito-cheng. Herald added subscribers: achieveartificialintelligence, ctetreau, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

tlively closed this revision. tlively added a comment. I forgot to include the revision URL in the commit message, but this has been landed as rGda07942834fe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380125. keith added a comment. Improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[clang] da07942 - [WebAssembly] Add prototype relaxed laneselect instructions

Author: Zhi An Ng Date: 2021-10-15T17:45:09-07:00 New Revision: da07942834fe3ea575d7f7b980940d938411afe5 URL: https://github.com/llvm/llvm-project/commit/da07942834fe3ea575d7f7b980940d938411afe5 DIFF: https://github.com/llvm/llvm-project/commit/da07942834fe3ea575d7f7b980940d938411afe5.diff

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Awesome, thanks! I'll go ahead and land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111914/new/ https://reviews.llvm.org/D111914

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

schrc3b6 added a comment. This is my first PR here, so if I missed something, I will be more than happy to change anything if you point me in the right direction. I didn't add an extra test so far, because check_clang_tidy.py doesn't support the .h extension so far. And before adding C support

[clang] 489561d - [clang] fix typo correction not looking for candidates in base classes.

Author: Matheus Izvekov Date: 2021-10-16T00:35:22+02:00 New Revision: 489561d46381d41a068beed1a2e18e00f0660248 URL: https://github.com/llvm/llvm-project/commit/489561d46381d41a068beed1a2e18e00f0660248 DIFF:

[PATCH] D111830: [clang] fix typo correction not looking for candidates in base classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG489561d46381: [clang] fix typo correction not looking for candidates in base classes. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

schrc3b6 created this revision. Herald added a subscriber: xazax.hun. schrc3b6 added a reviewer: alexfh. schrc3b6 updated this revision to Diff 380104. schrc3b6 added a comment. schrc3b6 published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber:

[clang] 1830ec9 - Revert "[HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols"

Author: Anshil Gandhi Date: 2021-10-15T16:16:18-06:00 New Revision: 1830ec94ac022ae0b6d6876fc2251e6b91e5931e URL: https://github.com/llvm/llvm-project/commit/1830ec94ac022ae0b6d6876fc2251e6b91e5931e DIFF: https://github.com/llvm/llvm-project/commit/1830ec94ac022ae0b6d6876fc2251e6b91e5931e.diff

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rjmccall added a comment. I don't think we currently hold very strongly to that ActOn vs. Build philosophy across all productions, but it does seem like a good idea. I don't really know why there's this much duplication between the code paths. The only semantic distinction I know of is that

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

Matt added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1832 + else { +assert(!Val.getAsInteger(10, Bits)); +CmdArgs.push_back( There may be a way to avoid side-effects in assertions (`getAsInteger` changing the value

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

rsmith added a comment. I've stepped through this in a debugger. The problem is that the `CompilerInstance` is setting up an `ASTReaderListener` that is informed whenever a module is loaded, and that listener is called when the AST file has been added to the module manager but hasn't had its

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf92db6d3fff1: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299). Repository: rG LLVM Github Monorepo

[clang] f92db6d - [HIP] Relax conditions for address space cast in builtin args

Author: Anshil Gandhi Date: 2021-10-15T15:35:52-06:00 New Revision: f92db6d3fff13bdacdf9b24660eb3f3158c58a17 URL: https://github.com/llvm/llvm-project/commit/f92db6d3fff13bdacdf9b24660eb3f3158c58a17 DIFF: https://github.com/llvm/llvm-project/commit/f92db6d3fff13bdacdf9b24660eb3f3158c58a17.diff

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) enh wrote: > mbenfield wrote: > > enh wrote: > > > (stray

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380098. gandhi21299 added a comment. cleaned up code for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

rsmith added a comment. In D111543#3067619 , @rsmith wrote: > In D111543#3066686 , @jansvoboda11 > wrote: > >> My understanding is that `Preprocessor::getIdentifierInfo` may trigger AST >> deserialization. The

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added a comment. In D111734#3067624 , @gandhi21299 wrote: > @tra I see, we sure can rewrite that segment for readability. It could've been done with a follow-up clean-up commit. revert/reland works, too. Thank you for following up on the comment,

[clang] 53fc510 - Revert "[HIP] Relax conditions for address space cast in builtin args"

Author: Anshil Gandhi Date: 2021-10-15T14:42:28-06:00 New Revision: 53fc5100e07ac078782ffb4e8e2b627c3cc8d046 URL: https://github.com/llvm/llvm-project/commit/53fc5100e07ac078782ffb4e8e2b627c3cc8d046 DIFF: https://github.com/llvm/llvm-project/commit/53fc5100e07ac078782ffb4e8e2b627c3cc8d046.diff

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. @tra I see, we sure can rewrite that segment for readability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

rsmith added a comment. In D111543#3066686 , @jansvoboda11 wrote: > My understanding is that `Preprocessor::getIdentifierInfo` may trigger AST > deserialization. The problem here seems to be that we're calling > `getIdentifierInfo` before the

[PATCH] D111883: [Parse] Improve diagnostic and recoveryy when there is an extra override in the outline method definition.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems very nice to me, I'd hit the bad diagnostic before but hadn't noticed the bad recovery. AFAICT this can't break any valid code. Comment at:

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b48e1170dc6: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3b48e11 - [HIP] Relax conditions for address space cast in builtin args

Author: Anshil Gandhi Date: 2021-10-15T14:06:47-06:00 New Revision: 3b48e1170dc623a95ff13a1e34c839cc094bf321 URL: https://github.com/llvm/llvm-project/commit/3b48e1170dc623a95ff13a1e34c839cc094bf321 DIFF: https://github.com/llvm/llvm-project/commit/3b48e1170dc623a95ff13a1e34c839cc094bf321.diff

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra accepted this revision. tra added a comment. LGTM in general, modulo a readability suggestion. Comment at: clang/lib/Sema/SemaExpr.cpp:6548-6550 +// Prevent addrspace cast if the parameter has a default address +// space, or the argument has a non-default

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0e7bdc20849: [modules] Make a module map referenced by a system map a system one too. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111476/new/ https://reviews.llvm.org/D111476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] d0e7bdc - [modules] Make a module map referenced by a system map a system one too.

Author: Volodymyr Sapsai Date: 2021-10-15T12:46:51-07:00 New Revision: d0e7bdc208491fd5d4245878c1ec2962694e2baa URL: https://github.com/llvm/llvm-project/commit/d0e7bdc208491fd5d4245878c1ec2962694e2baa DIFF:

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl added a comment. @gandhi21299 you may need to add "-target x86_64-unknown-linux-gnu" to your codegen test to avoid issue with Darwin toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk added a subscriber: rjmccall. rnk added a comment. So, after reading through Build(Unary|Bin)Op, I think the duplication of logic between TreeTransform is intentional, and the better fix is to generalize the existing logic for placeholder handling. If you enter into the Build*Op codepaths,

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/mac/37119/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

aaron.ballman added a comment. In D110614#3067303 , @carlosgalvezp wrote: > Thanks!! I'll wait for tomorrow morning (~8 PM here) to merge, to give some > last minute opportunity for comments. Is this what I should monitor after > merge to make sure

[PATCH] D106674: Runtime for Interop directive

sriharikrishna marked an inline comment as not done. sriharikrishna added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, +

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380067. gandhi21299 marked 3 inline comments as done. gandhi21299 added a comment. corrected sema test, as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp added a comment. Thanks!! I'll wait for tomorrow morning (~8 PM here) to merge, to give some last minute opportunity for comments. Is this what I should monitor after merge to make sure nothing breaks? https://lab.llvm.org/buildbot/#/console CHANGES SINCE LAST ACTION

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6548-6550 +// Prevent addrspace cast if the parameter has a default address +// space, or the argument has a non-default addrspace and the +// target addrspaces of the argument and the

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG03375a3fb33b: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 03375a3 - [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

Author: Anshil Gandhi Date: 2021-10-15T11:39:15-06:00 New Revision: 03375a3fb33b11e1249d9c88070b7f33cb97802a URL: https://github.com/llvm/llvm-project/commit/03375a3fb33b11e1249d9c88070b7f33cb97802a DIFF: https://github.com/llvm/llvm-project/commit/03375a3fb33b11e1249d9c88070b7f33cb97802a.diff

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108453/new/ https://reviews.llvm.org/D108453

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47eb99aa44ab: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob() (authored by aeubanks). Repository: rG LLVM Github Monorepo

[clang] 47eb99a - [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

Author: Arthur Eubanks Date: 2021-10-15T10:13:17-07:00 New Revision: 47eb99aa44ab1d20327d67a49d6c47163de76387 URL: https://github.com/llvm/llvm-project/commit/47eb99aa44ab1d20327d67a49d6c47163de76387 DIFF:

[clang] 6a154e6 - [clang] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-15T10:07:08-07:00 New Revision: 6a154e606e570870789b047a10c21642dce2fdd3 URL: https://github.com/llvm/llvm-project/commit/6a154e606e570870789b047a10c21642dce2fdd3 DIFF: https://github.com/llvm/llvm-project/commit/6a154e606e570870789b047a10c21642dce2fdd3.diff

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song updated this revision to Diff 380049. yonghong-song added a subscriber: urnathan. yonghong-song added a comment. - fix a few clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380048. gandhi21299 added a comment. removed unused diagnostic sema note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

aaronpuchert added a comment. Ping @gribozavr2. (Ideally also the followups.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111262/new/ https://reviews.llvm.org/D111262 ___ cfe-commits mailing list

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380047. gandhi21299 added a comment. installed clang-format, refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files:

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert added a comment. Ping @gribozavr2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90/new/ https://reviews.llvm.org/D90 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380046. gandhi21299 added a comment. adding sema test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

enh added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) mbenfield wrote: > enh wrote: > > (stray tabs?) > Not sure what

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @pchaigno @efriedma I added an IR pass in BPF backend to remove these stacksave/stackrestore intrinsics. https://reviews.llvm.org/D111897 @pchaigno Could you test with https://reviews.llvm.org/D111897 instead? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

hyeongyukim updated this revision to Diff 380037. hyeongyukim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108453/new/ https://reviews.llvm.org/D108453 Files: clang/test/CXX/except/except.spec/p14-ir.cpp

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:662 +if (Index < FD->getNumParams()) { + if (const auto *POS = + FD->getParamDecl(Index)->getAttr()) enh wrote: > (stray tabs?) Not sure what you're referring to.

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 380039. noajshu marked an inline comment as done. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files:

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42eea2b69bb9: [AIX] Enable int128 in 64 bit mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 42eea2b - [AIX] Enable int128 in 64 bit mode

Author: Jinsong Ji Date: 2021-10-15T16:23:04Z New Revision: 42eea2b69bb99415f5116ca8e28efdd5f836a03b URL: https://github.com/llvm/llvm-project/commit/42eea2b69bb99415f5116ca8e28efdd5f836a03b DIFF: https://github.com/llvm/llvm-project/commit/42eea2b69bb99415f5116ca8e28efdd5f836a03b.diff LOG:

[clang] 395e1fe - [clang] Capture Framework when HeaderSearch is resolved via headermap

Author: Cyndy Ishida Date: 2021-10-15T09:12:31-07:00 New Revision: 395e1fe3057482576eb0bc38d1079fcc1ff29193 URL: https://github.com/llvm/llvm-project/commit/395e1fe3057482576eb0bc38d1079fcc1ff29193 DIFF: https://github.com/llvm/llvm-project/commit/395e1fe3057482576eb0bc38d1079fcc1ff29193.diff

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG395e1fe30574: [clang] Capture Framework when HeaderSearch is resolved via headermap (authored by cishida). Repository: rG LLVM Github Monorepo

[PATCH] D111755: [ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or arm_cde_builtins.inc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc294715e2e0c: [ARM] Dont use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or… (authored by craig.topper). Repository: rG LLVM Github Monorepo

[clang] c294715 - [ARM] Don't use TARGET_HEADER_BUILTIN in arm_mve_builtins.inc or arm_cde_builtins.inc

Author: Craig Topper Date: 2021-10-15T09:11:06-07:00 New Revision: c294715e2e0c90761e69fd3a7db221601289d803 URL: https://github.com/llvm/llvm-project/commit/c294715e2e0c90761e69fd3a7db221601289d803 DIFF: https://github.com/llvm/llvm-project/commit/c294715e2e0c90761e69fd3a7db221601289d803.diff

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

cishida added a comment. In D111468#3066820 , @jansvoboda11 wrote: > LGTM. > > As a follow-up, do you think it would make sense to improve the > documentation/comments around "index header maps"? Variable names refer to > indexing while the

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. In D111078#3065552 , @hubert.reinterpretcast wrote: > In D111078#3063245 , @lkail wrote: > >> This LGTM as the start point to support int128 on AIX. We might need more >> patches involving

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone, can somebody please help me commit this patch to trunk? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith updated this revision to Diff 380015. bsmith added a comment. - Update sema checking for sve_vector_bits attribute to emit an error when the vscale min != max, i.e. when -mvse-vector-bits=+ is used - Add test to cover the above case Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7916 // The attribute vector size must match -msve-vector-bits. - if (VecSize != S.getLangOpts().ArmSveVectorBits) { + if (VecSize != S.getLangOpts().VScaleMin * 128) { S.Diag(Attr.getLoc(),

[clang] 096ace5 - [AArch64] Fix failing test target-invalid-cpu-note.c

Author: Tomas Matheson Date: 2021-10-15T16:10:46+01:00 New Revision: 096ace55804d21a187b37448376ecd51c8e810e1 URL: https://github.com/llvm/llvm-project/commit/096ace55804d21a187b37448376ecd51c8e810e1 DIFF:

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

bsmith added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7916 // The attribute vector size must match -msve-vector-bits. - if (VecSize != S.getLangOpts().ArmSveVectorBits) { + if (VecSize != S.getLangOpts().VScaleMin * 128) { S.Diag(Attr.getLoc(),

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 379976. Ericson2314 added a comment. Rebase again because previous diff changed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D33029: [clang-format] add option for dangling parenthesis

seesemichaelj added a comment. @MyDeveloperDay Great, sounds like this revision, D33029 , is stale and being superseded by the work in D109557 . It doesn't sound like there is anyone here that is wanting to keep pushing forward

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3066853 , @jansvoboda11 wrote: > This seems to be breaking the macOS bot, can you take a look? > https://green.lab.llvm.org/green/job/clang-stage1-RA/24735/ Will do. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3063679 , @MyDeveloperDay wrote: > Do you think this is going to need some other capability to put the break > after the opening paren? e.g. `BreakAfterOpeningParen` > > if ( > ^ I don't think so. This is

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

jansvoboda11 added a comment. This seems to be breaking the macOS bot, can you take a look? https://green.lab.llvm.org/green/job/clang-stage1-RA/24735/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D111790: [AArch64][Driver][SVE] Allow -msve-vector-bits=+ syntax to mean no maximum vscale

paulwalker-arm added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7893 // Attribute is unsupported if '-msve-vector-bits=' isn't specified. - if (!S.getLangOpts().ArmSveVectorBits) { + if (!S.getLangOpts().VScaleMin) { S.Diag(Attr.getLoc(),

[PATCH] D111805: [Driver][NetBSD] Use T reference instead of getToolChain().getTriple().

This revision was automatically updated to reflect the committed changes. Closed by commit rGecef0359538c: [Driver][NetBSD] Use Triple reference instead of ToolChain.getTriple(). (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ecef035 - [Driver][NetBSD] Use Triple reference instead of ToolChain.getTriple().

Author: Frederic Cambus Date: 2021-10-15T16:36:19+02:00 New Revision: ecef0359538ca54a5374dbf3547a395adc326bbe URL: https://github.com/llvm/llvm-project/commit/ecef0359538ca54a5374dbf3547a395adc326bbe DIFF:

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:1372 +(VMANDN_MM VR:$vd, VR:$vs2, VR:$vs1), 0>; + +def : InstAlias<"vmornot.mm $vd, $vs2, $vs1", craig.topper wrote: > Probably not worth having a blank line

[PATCH] D111476: [modules] Make a module map referenced by a system map a system one too.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111476/new/ https://reviews.llvm.org/D111476

[PATCH] D111468: [clang] Capture Framework when HeaderSearch is resolved via headermap

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. As a follow-up, do you think it would make sense to improve the documentation/comments around "index header maps"? Variable names refer to indexing while the documentation

[clang] f2ea852 - Fix a crash on an invalid templated UDL declaration

Author: Aaron Ballman Date: 2021-10-15T10:00:16-04:00 New Revision: f2ea85255075606563370c9249f61dfad6a3f98b URL: https://github.com/llvm/llvm-project/commit/f2ea85255075606563370c9249f61dfad6a3f98b DIFF: https://github.com/llvm/llvm-project/commit/f2ea85255075606563370c9249f61dfad6a3f98b.diff

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 379988. martong added a comment. - Remove the wrong inferrence of `a % b == 0 implies that a == 0` and related test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110357/new/

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong added a comment. After taking a look at the new findings we discovered, there is a logic error with this patch, actually `a % b == 0 implies that a == 0` does not hold, one counter example is `10 % 2 == 0`. Argh, probably we should be using Z3 next time to prove or disprove such

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

jansvoboda11 added a comment. In D111543#3062095 , @rsmith wrote: > I'm concerned that this is adding complexity to paper over a bug elsewhere. > Creating an `IdentifierInfo` should never cause unrelated uses of that > identifier to change their

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97809c828f8e: [AArch64]Enabling Cortex-A510 Support (authored by mubashar_, committed by lenary). Repository: rG LLVM Github Monorepo CHANGES

[clang] 97809c8 - [AArch64]Enabling Cortex-A510 Support

Author: Mubashar Ahmad Date: 2021-10-15T14:31:18+01:00 New Revision: 97809c828f8eb5f5e322ee1cbc20f96fd5ef8649 URL: https://github.com/llvm/llvm-project/commit/97809c828f8eb5f5e322ee1cbc20f96fd5ef8649 DIFF:

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added a comment. In D111654#3060822 , @martong wrote: > Could you please rebase on top of D111542 ? > That would make the changes direct and clear and the review would be easier. OK. I'll rebase.

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1669-1711 // The array index has to be known. if (auto CI = R->getIndex().getAs()) { -// If it is not an array, return Undef. -QualType T

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal added a comment. Additionally to my previous observation, a surprising amount of the new findings are of `deadcode` detections, and most of them there are loops. Other than that, I've seen a true-positive report as well: F19624854: image.png At line

[PATCH] D111883: [Parse] Improve diagnostic and recoveryy when there is an extra override in the outline method definition.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. The clang behavior was poor before this patch: void B::foo() override {} // Before: clang emited "expcted function body after function // declarator",

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, unless @whisperity sees something else of concern. Comment at:

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

steakhal accepted this revision. steakhal added a comment. In D110357#3066207 , @ASDenysPetrov wrote: > Ok. Let's see what the benefits it brings. According to our measurements, it has some effects but is probably difficult to draw clear conclusions.

  1   2   >