[clang] 1072699 - Use llvm::erase_value (NFC)

2021-10-16 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-10-16T23:31:21-07:00 New Revision: 10726992fad771e7c630fc511d85bb81a8d1562e URL: https://github.com/llvm/llvm-project/commit/10726992fad771e7c630fc511d85bb81a8d1562e DIFF: https://github.com/llvm/llvm-project/commit/10726992fad771e7c630fc511d85bb81a8d1562e.diff L

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

2021-10-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. I guess a downside of this solution, is that if an `i686` sysroot exists next to the clang binary, it becomes practically impossible to test codegen differences when you run it with various `-target iX86-w64-mingw32` options, as they'd all be corrected back to `i686`.

[PATCH] D109128: [VFS] Use original path when falling back to external FS

2021-10-16 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + keith wrote: > JDevlieghere wrote: > > I'm pretty sure there was a reason we stopped doing thi

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

2021-10-16 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: phosek, MaskRay. Herald added subscribers: pengfei, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. For x86, most contempory mingw toolchains use i686 as 32 bit x86 arch target. As long as the targ

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

2021-10-16 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. I am noticing a clang crash with ToT after this change. - testcase -- long a; char b, d; extern inline __attribute__((always_inline)) __attribute__((gnu_inline)) unsigned long strlen() { return a; } c(void) { strlen(&b); return 0; } unsig

[clang] 49562d3 - Revert "[clang] Pass -clear-ast-before-backend in Clang::ConstructJob()"

2021-10-16 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2021-10-16T12:05:41-07:00 New Revision: 49562d3dfed0ed6983d29d040db7e46ef3bc833e URL: https://github.com/llvm/llvm-project/commit/49562d3dfed0ed6983d29d040db7e46ef3bc833e DIFF: https://github.com/llvm/llvm-project/commit/49562d3dfed0ed6983d29d040db7e46ef3bc833e.diff

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

2021-10-16 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea marked an inline comment as done. labrinea added inline comments. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1548 + +static const AArch64SysReg::SysReg *lookupSysReg(unsigned Val, bool Read, + c

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

2021-10-16 Thread Alexandros Lamprineas via Phabricator via cfe-commits
labrinea updated this revision to Diff 380171. labrinea added a comment. Added an alternative name to indicate sytem register aliasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Ba

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

2021-10-16 Thread Carlos Galvez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf0711106dc6c: [clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang-tools-extra] f071110 - [clang-tidy] Fix false positive in cppcoreguidelines-virtual-class-destructor

2021-10-16 Thread Carlos Galvez via cfe-commits
Author: Carlos Galvez Date: 2021-10-16T08:27:08Z New Revision: f0711106dc6c14dcaf06437a0467043e983bf9dc URL: https://github.com/llvm/llvm-project/commit/f0711106dc6c14dcaf06437a0467043e983bf9dc DIFF: https://github.com/llvm/llvm-project/commit/f0711106dc6c14dcaf06437a0467043e983bf9dc.diff LOG:

[clang] 37ca7a7 - Fix missing failures in clang-ppc64be* and retry fixing clang-x64-windows-msvc

2021-10-16 Thread Juneyoung Lee via cfe-commits
Author: Juneyoung Lee Date: 2021-10-16T16:20:14+09:00 New Revision: 37ca7a795b277c20c02a218bf44052278c03344b URL: https://github.com/llvm/llvm-project/commit/37ca7a795b277c20c02a218bf44052278c03344b DIFF: https://github.com/llvm/llvm-project/commit/37ca7a795b277c20c02a218bf44052278c03344b.diff

[PATCH] D111760: [clang] Support __float128 on DragonFlyBSD.

2021-10-16 Thread Michał Górny via Phabricator via cfe-commits
mgorny added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:182 DefineStd(Builder, "unix", Opts); +if (this->HasFloat128) + Builder.defineMacro("__FLOAT128__"); Maybe I'm missing something but do you actually need to state `this->`