[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. Thanks @ZarkoCA, LGTM, but please address the sensible changes advised by Aaron. And thanks @aaron.ballman for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. > people DO incorporate clang-tidy into their own commercial offerings Gna, that //can// be a problem. I wonder if in that case it would be possible to add a few lines into the `LLVM Exceptions` part of the license. If it's too much of a hassle I guess I'll need

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

aaron.ballman added reviewers: alexfh, tonic. aaron.ballman added a subscriber: tonic. aaron.ballman added a comment. In D112730#3095767 , @carlosgalvezp wrote: > Also, I've sent a mail to AUTOSAR directly asking for consent, so there's no > doubt.

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. `swift_attr` has no subjects, so this will attempt to spray the attribute onto literally *everything*. That makes this incredibly risky to use with the pragma approach

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

tambre added a comment. This breaks the following code: struct sub { char data; }; struct main { constexpr main() { member = {}; } sub member; }; constexpr main a{}; With: fmt.cpp:16:16: error: constexpr variable

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3095623 , @yonghong-song wrote: >> Ah, yeah, I see what you mean - that does seem sort of unfortunate. Is it >> possible these attributes could only appear on typedefs and they'd be more >> readily carried

[PATCH] D112059: Fix inline builtin handling in case of redefinition

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a formatting nit. I don't think the precommit CI failures are related to your patch from what I was seeing, but may be worth keeping an eye on once you land just in case. Comment at:

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus added a comment. Sure, I reverted to the previous revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus updated this revision to Diff 383293. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 Files: clang/tools/scan-build/libexec/ccc-analyzer Index: clang/tools/scan-build/libexec/ccc-analyzer

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG32f102912493: [clangd] Track performance of IncludeCleaner (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/

[clang-tools-extra] 32f1029 - [clangd] Track performance of IncludeCleaner

Author: Kirill Bobyrev Date: 2021-10-29T12:59:22+02:00 New Revision: 32f102912493db3df864cc80d5bb602962839f68 URL: https://github.com/llvm/llvm-project/commit/32f102912493db3df864cc80d5bb602962839f68 DIFF:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

zixuan-wu added a comment. Herald added subscribers: VincentWu, luke957. Hi, @kito-cheng as your this patch unify the extension handing in one same place by new infra, are you going to support the multiple extension version in next step? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne added a comment. Herald added a project: Flang. If there is no plan to move forward with generating `.docx` documentation, can we please abandon this review? I'm trying to clean up libc++'s review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oops forgot to LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews.llvm.org/D112783

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

martong added a subscriber: vabridgers. martong added a comment. Adding @vabridgers as a subscriber, he might be interested in this. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1675 + // belong to an array with one element of type T. + // Hence, the

[PATCH] D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, too. D112786 does a couple more things that do pretty much the same - I don't mind if you want to fold them into this, or keep it as-is, with the

[PATCH] D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96808c69a13c: [ASTImporter] Remove redundant IsStructuralMatch overloads (authored by teemperor). Herald added a subscriber: cfe-commits.

[clang] 96808c6 - [ASTImporter] Remove redundant IsStructuralMatch overloads

Author: Raphael Isemann Date: 2021-10-29T12:23:38+02:00 New Revision: 96808c69a13c68280c2808b04dc5b733193bef6d URL: https://github.com/llvm/llvm-project/commit/96808c69a13c68280c2808b04dc5b733193bef6d DIFF:

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

hsmhsm accepted this revision. hsmhsm added a comment. This revision is now accepted and ready to land. Thanks for this clean-up patch. Looks good to me. However, please wait for some time if in case other reviewers have any comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D51650: Implement target_clones multiversioning

danielkiss added a comment. Hi @erichkeane, At Arm we are going to add the multiversioning support for Arm targets[1]. It would be nice to land this change because we could build top of it. Please let me know how can I help. [1]. https://github.com/ARM-software/acle/pull/21 CHANGES SINCE

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev updated this revision to Diff 383278. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews.llvm.org/D112783 Files:

[PATCH] D112791: [IR] Merge createReplacementInstr into ConstantExpr::getAsInstruction

foad created this revision. Herald added subscribers: ormris, dexonsmith, hiraditya. foad requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. createReplacementInstr was a trivial wrapper around ConstantExpr::getAsInstruction,

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:275 std::vector computeUnusedIncludes(ParsedAST ) { + trace::Span Tracer("IncludeCleaner::computeUnusedIncludes"); const auto = AST.getSourceManager(); this doesn't

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

pengfei added a comment. > *_mul_pch is to align with *_mul_ps annd *_mul_pd And *_mul_ph? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 ___ cfe-commits

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu marked 5 inline comments as done. ChuanqiXu added a comment. In D108696#3090484 , @Quuxplusone wrote: > @lewissbaker wrote: > >> #include // which transitively includes >> #include > > Good example! I had not previously been thinking

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

frasercrmck accepted this revision. frasercrmck added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke957. Thanks @khchen, that's great. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111062/new/

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. Also, I've sent a mail to AUTOSAR directly asking for consent, so there's no doubt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 ___ cfe-commits mailing list

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp updated this revision to Diff 383259. carlosgalvezp added a comment. Removed unnecessary dependency in CMakeLists.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383253. kbobyrev added a comment. Add a header guard in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. > "C++14 Guidelines"? So it's always and definitely C++14 specific? To my knowledge, AUTOSAR handed over the work to MISRA and the current direction is that MISRA will merge AUTOSAR C++14 and older MISRA revisions into a brand-new MISRA release, coming up 202x

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. In D112707#3093876 , @sammccall wrote: > What's the purpose of this patch at a high level? Was it triggered by a real > example? > IIUC it's avoiding false negatives, where we're using a class and an > otherwise-unused header

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383250. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files:

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

whisperity added a comment. "C++14 Guidelines"? So it's always and definitely C++14 specific? What is the licencing approach of this guideline? Looking up with searchers seems to turn up a few PDFs which say `--- AUTOSAR CONFIDENTIAL ---`, yet they are up and out on the official-looking

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske updated this revision to Diff 383245. balazske added a comment. Using a much smaller test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 Files:

[clang] 95e6e1c - [clang] Partially revert d8cd7806310c51af912a647a6ca46de62ff13214.

Author: Brad Smith Date: 2021-10-29T02:41:54-04:00 New Revision: 95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc URL: https://github.com/llvm/llvm-project/commit/95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc DIFF: https://github.com/llvm/llvm-project/commit/95e6e1cc923d6b88ebb4ac5e8f0887c2c77476cc.diff

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 383241. serge-sans-paille added a comment. Re-uploading previous version that walks redef, with a slight change in the walking algorithm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files:

[PATCH] D112722: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1b24d7360f: [clang-tidy]performance-unnecessary-copy-initialization: fix false negative (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] fc1b24d - [clang-tidy]performance-unnecessary-copy-initialization: fix false negative

Author: Clement Courbet Date: 2021-10-29T08:41:03+02:00 New Revision: fc1b24d7360f59c8b89f1b6290fe849a6207dc44 URL: https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44 DIFF:

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rGd758069f5e0d: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d758069 - [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

Author: Martin Storsjö Date: 2021-10-29T09:32:36+03:00 New Revision: d758069f5e0d483f85ed1ee2c84b3955238eedce URL: https://github.com/llvm/llvm-project/commit/d758069f5e0d483f85ed1ee2c84b3955238eedce DIFF:

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. > Ah, yeah, I see what you mean - that does seem sort of unfortunate. Is it > possible these attributes could only appear on typedefs and they'd be more > readily carried through that without needing extra typeloc tracking? (sorry > for not having read back

<    1   2