[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3285 } - if (const TypedefType *TypedefT = - dyn_cast(FromFPT->getReturnType())) { -TypedefNameDecl *TD = TypedefT->getDecl(); + if (const auto *TypedefT =

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc created this revision. chandlerc added reviewers: GMNGeoffrey, dblaikie. Herald added a subscriber: mcrosier. chandlerc requested review of this revision. Sadly, these are necessary AFAICT. There is a file `lib/AST/CXXABI.h`. On case insensitive file systems like macOS this will collide

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc requested review of this revision. chandlerc added a comment. PTAL, and thanks for feedback so far! Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + rnk wrote: > thakis wrote: > > GMNGeoffrey wrote: > >

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc updated this revision to Diff 383634. chandlerc marked 5 inline comments as done. chandlerc edited the summary of this revision. chandlerc added a reviewer: rnk. chandlerc added a comment. Major update to better fix some of the issues here. No longer requires any changes outside of

[PATCH] D112864: [clang-tidy] Fix lint warnings in clang-tidy source code (NFC)

salman-javed-nz added a comment. In D112864#3098351 , @carlosgalvezp wrote: > Looks great, thanks for fixing! I'm surprised we don't have a CI bot running > these checks post-merge? You would think so, but it looks like automatic checking during CI

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112881: Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, nemanjai. paulaltin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] c8b1ed5 - [clang, llvm] Use Optional::getValueOr (NFC)

Author: Kazu Hirata Date: 2021-10-30T19:00:21-07:00 New Revision: c8b1ed5fb2da8f030cb3c9d8a361ea7420e42da1 URL: https://github.com/llvm/llvm-project/commit/c8b1ed5fb2da8f030cb3c9d8a361ea7420e42da1 DIFF: https://github.com/llvm/llvm-project/commit/c8b1ed5fb2da8f030cb3c9d8a361ea7420e42da1.diff

[clang-tools-extra] 4db2e4c - Use {DenseSet,SetVector,SmallPtrSet}::contains (NFC)

Author: Kazu Hirata Date: 2021-10-30T19:00:19-07:00 New Revision: 4db2e4cebe9c542b58aee26c556c84bd12aa6780 URL: https://github.com/llvm/llvm-project/commit/4db2e4cebe9c542b58aee26c556c84bd12aa6780 DIFF: https://github.com/llvm/llvm-project/commit/4db2e4cebe9c542b58aee26c556c84bd12aa6780.diff

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ecd4a4d01a3: [clang][scan-build] Use uname -s to detect the operating system. (authored by fcambus). Repository: rG LLVM Github Monorepo

[clang] 6ecd4a4 - [clang][scan-build] Use uname -s to detect the operating system.

Author: Frederic Cambus Date: 2021-10-30T23:26:39+02:00 New Revision: 6ecd4a4d01a3f71dc6590194dd00f96550c2ab04 URL: https://github.com/llvm/llvm-project/commit/6ecd4a4d01a3f71dc6590194dd00f96550c2ab04 DIFF:

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 383608. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383607. eopXD added a comment. Address comment: Enforce user to specify version checks. @asb Thank you for leaving comments for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383606. eopXD added a comment. Herald added subscribers: VincentWu, luke957. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files:

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 383605. eopXD added a comment. Herald added subscribers: VincentWu, luke957. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files:

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 383601. eopXD added a comment. Rebase to newest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

This revision was automatically updated to reflect the committed changes. Closed by commit rG931d20c5db05: [docs][clang-format] warn on \code block indentation error (authored by FederAndInk, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 931d20c - [docs][clang-format] warn on \code block indentation error

Author: Ludovic Jozeau Date: 2021-10-30T17:45:39+01:00 New Revision: 931d20c5db05fc2e2f4071cc086fa3ff1b4aebdd URL: https://github.com/llvm/llvm-project/commit/931d20c5db05fc2e2f4071cc086fa3ff1b4aebdd DIFF:

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 383599. eopXD added a comment. Herald added subscribers: VincentWu, luke957. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[clang] bee61aa - [clang-format] Add --staged/--cached option to git-clang-format

Author: Erik Larsson Date: 2021-10-30T17:37:58+01:00 New Revision: bee61aa7b638726c3e0eec017fbd89d79a181434 URL: https://github.com/llvm/llvm-project/commit/bee61aa7b638726c3e0eec017fbd89d79a181434 DIFF: https://github.com/llvm/llvm-project/commit/bee61aa7b638726c3e0eec017fbd89d79a181434.diff

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee61aa7b638: [clang-format] Add --staged/--cached option to git-clang-format (authored by ortogonal, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

aaron.ballman added a comment. In D112101#3097618 , @rsmith wrote: > In D112101#3097387 , @rsmith wrote: > >> I think this is still not quite right > > Fixed in rG68ffcd521347e3c8b97ca233239d503beff239f4 >

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein created this revision. ibookstein added reviewers: MaskRay, aaron.ballman. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Itay Bookstein Repository: rG LLVM Github Monorepo

[PATCH] D112804: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01b3bd3992b4: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for… (authored by teemperor). Herald added a subscriber: cfe-commits.

[clang] 01b3bd3 - [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl

Author: Raphael Isemann Date: 2021-10-30T13:12:12+02:00 New Revision: 01b3bd3992b4b79ef103558eccc49981e97be479 URL: https://github.com/llvm/llvm-project/commit/01b3bd3992b4b79ef103558eccc49981e97be479 DIFF:

[PATCH] D112864: [clang-tidy] Fix lint warnings in clang-tidy source code (NFC)

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks great, thanks for fixing! I'm surprised we don't have a CI bot running these checks post-merge? Since this is my first review it's probably good to wait for other

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

ortogonal added a comment. @MyDeveloperDay Is everything okay with this? Can you help out with the next step in the process? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/ https://reviews.llvm.org/D90996