[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. @joerg, @emaste -- I finally got a chance to experiment with a Linux docker container and confirmed that libgcc_s's `__register_frame` can handle individual frames. Unfortunately that does not help us on FreeBSD. If we ignore FreeBSD for a moment we could imagine switch

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3113220 , @salman-javed-nz wrote: > In D112926#3113206 , @serkazi wrote: > >> This is now accepted, please feel free to merge on my behalf. Thanks. > > What's the full name

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. In D112926#3113206 , @serkazi wrote: > This is now accepted, please feel free to merge on my behalf. Thanks. What's the full name and email you want associated with your commit? CHANGES SINCE LAST ACTION

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3108140 , @salman-javed-nz wrote: > It looks good to me. I don't have any more comments to add - it is a very > small code change after all. > I have commit access and am happy to commit it on your behalf. > >

[PATCH] D112916: Confusable identifiers detection

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. The LLVM Board of Directors will do a legal review of this change. We will give an update in 4-6 weeks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3113055 , @pcc wrote: > (Adding back @rsmith, @rjmccall.) > > In D108479#3113035 , @samitolvanen > wrote: > >> In D108479#3112492 ,

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385212. ibookstein added a comment. Nicer param order for checkAliasedGlobal.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files:

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385211. ibookstein added a comment. Changed to using D->hasAttr() and passing that bool into the checkAliasedGlobal function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc added subscribers: rjmccall, rsmith. pcc added a comment. (Adding back @rsmith, @rjmccall.) In D108479#3113035 , @samitolvanen wrote: > In D108479#3112492 , @rjmccall > wrote: > >> You could also make this

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. I feel like we're getting lost in the weeds here. At the time a bitcode module is finalized, it is supposed to be in a valid state. The LLVM bitcode verifier does not consider GlobalAliases which have either a null or an undefined aliasee to be valid. The same

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen removed subscribers: rsmith, rjmccall. samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3112492 , @rjmccall wrote: > You could also make this Just Work for things like C++ member functions > rather

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#314 , @tambre wrote: > In D108482#3108013 , @ricejasonf > wrote: > >> In D108482#3105889 , @tambre wrote: >> >>> I presume you

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:546 fs::make_absolute(TestScheme::TestDir, Path); +path::native(Path); return std::string(Path); mstorsjo wrote: > sammccall wrote: > > This change is an

[clang] 6278682 - In spir functions, llvm.dbg.declare intrinsics created

Author: Zahira Ammarguellat Date: 2021-11-05T15:08:09-07:00 New Revision: 627868263cd4d57c230b61904483a3dad9e1a1da URL: https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da DIFF:

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

nikic added a comment. I don't think I fully understand the interaction this has with eager invalidation. I would have expected that if we eagerly invalidate, then this fine-grained invalidation wouldn't make much of a difference, because we invalidate anyway after processing a function.

[PATCH] D113320: [clang-format] Address fixme

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rG456a7e52310d: [clang][asan] Add test for ensuring PR52382 is fixed (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113143/new/

[clang] 456a7e5 - [clang][asan] Add test for ensuring PR52382 is fixed

Author: Leonard Chan Date: 2021-11-05T14:10:34-07:00 New Revision: 456a7e52310d632be4e41a4b7c4853e910648621 URL: https://github.com/llvm/llvm-project/commit/456a7e52310d632be4e41a4b7c4853e910648621 DIFF: https://github.com/llvm/llvm-project/commit/456a7e52310d632be4e41a4b7c4853e910648621.diff

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks added a comment. Or am I mistaken and we want to be able to control the line break? Also I would break before struct, class, union, but I would have needed to change the test, and I know that we at least need to talk about in in front. :) template require X class ...

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Generally lg. I find the word "allowlist" (and to a lesser level also "ignorelist") a bit awkward; imho you can often make things more clear by rephrasing things away from "foolist". A few

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

eugenis added a comment. In D105169#3111935 , @hyeongyukim wrote: > - long long res; > + register long long res __asm__("x0"); > > Is it okay to commit this change by myself? Yes, go ahead! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113145: [Sema] Mark virtual method declaration in union as invalid

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! fyi, I'll be on vacation for the next three weeks. I've added some additional reviewers to the patch based on prior reviews. Repository: rG

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a comment. Reviewing the code, I don't see any obvious sources of non-determinism (hash iteration). The only source I can imagine is uninitialized memory usage in the APInt. Let me know if this can be repro'd somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c:3 // REQUIRES: riscv-registered-target -// RUN: %clang_cc1 -triple riscv64 -target-feature +experimental-v -disable-O0-optnone -emit-llvm %s -o - | opt -S -mem2reg |

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev added a comment. Oh, sorry, I marked it as "changes intended" so that you could know it's not review-ready yet :) I was just playing around with it and previewing to see how it would feel to have a somewhat working solution. I didn't really implement the feature (add the proper header

[PATCH] D112613: [RISCV] Change TARGET_BUILTIN require to zve32x for vector instruction

craig.topper added a comment. The title of this patch isn't descriptive of the changes in this patch. Based on the title I would only expect changes to RISCVEmitter.cpp. Can you clarify the title? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calls to MMA builtins that take pointer to void do not accept other pointers/arrays whereas normal

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. Yeah, I think that's a better name. The documentation can say that ideally this also wouldn't include things like the THUMB bit, but there are technical limitations that make it hard to achieve that. You could also make this Just Work for things like C++ member

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

pcc added a comment. > Maybe it should even be semantically restricted to require a constant decl > reference as its operand? I think we should do this. Maybe it should be named something like `__builtin_symbol_address` if we're intending for this to have an effect with PAuth as well?

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks created this revision. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, eraman. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously, any change in

[PATCH] D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111860/new/ https://reviews.llvm.org/D111860

[clang] 3466e00 - Reland "[Attr] support btf_type_tag attribute"

Author: Yonghong Song Date: 2021-11-05T11:25:17-07:00 New Revision: 3466e00716e12e32fdb100e3fcfca5c2b3e8d784 URL: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784 DIFF: https://github.com/llvm/llvm-project/commit/3466e00716e12e32fdb100e3fcfca5c2b3e8d784.diff

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

shafik added a comment. How does it handle this case: struct A {int x;}; struct A f(void) { struct A{} a; return a; and this case: struct b{}; struct a {int x;} // visible outside of f f(struct b {int x; } b1) { // not visibile out of f return

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

tra added a comment. In D113249#3112279 , @Hahnfeld wrote: > Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang > enables this for CUDA. I think we've added support for i128 a while back: https://godbolt.org/z/18bEbhMYb > The

[PATCH] D106585: Fix clang debug info irgen of i128 enums

aprantl added a comment. In D106585#3110131 , @glandium wrote: > This broke determinism when building Firefox. I'm curious: can you share an example dwarfdump diff that shows what is non-deterministic? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385133. CJ-Johnson added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Feel free to commit your change given that you fix my final nits. Yeah, I'm soo bad in review. I should have proposed these previously. Sorry. Comment at:

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

v.g.vassilev added a comment. In D112349#3111927 , @erichkeane wrote: > In D112349#3111873 , @ibookstein > wrote: > >> And how is Cling expecting CFE to deal with partial knowledge situations at >> the

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 385130. CJ-Johnson added a comment. Remove double brackets for list initialization and use default initialization to avoid most vexing parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

Hahnfeld added a comment. Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang enables this for CUDA. The release notes also specify > `builtin_assume` can now be used to specify address space to allow for > efficient loads and stores. The docs are very scarce on this, I

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

steakhal added a comment. Excellent work. Don't be afraid of the number of nits I dump on you! Good job. Comment at: clang/docs/analyzer/checkers.rst:2338 +Default sources defined by `GenericTaintChecker`: +``fdopen``, ``fopen``, ``freopen``, ``getch``, ``getchar``,

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence added a comment. In D111866#3111243 , @asb wrote: > LGTM, modulo one tiny nit on a comment. Thanks! Thank you for your detailed suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111866: [RISCV] Support Zfhmin extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c3d7184b435: [RISCV] Support Zfhmin extension (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5c3d718 - [RISCV] Support Zfhmin extension

Author: Shao-Ce SUN Date: 2021-11-06T01:41:02+08:00 New Revision: 5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3 URL: https://github.com/llvm/llvm-project/commit/5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3 DIFF: https://github.com/llvm/llvm-project/commit/5c3d7184b43575e4cbf1da2fa6ba88485eaca4e3.diff

[PATCH] D113231: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

aeubanks updated this revision to Diff 385122. aeubanks added a comment. Herald added subscribers: cfe-commits, wenlei, steven_wu. Herald added a project: clang. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113231/new/

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 385121. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I think we're missing few more changes here: - The driver needs to enable ptx75 when it constructs cc1 command line in clang/lib/Driver/ToolChains/Cuda.cpp - We also need to handle PTX75

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7528554f83: [AIX][Clang] Fix XL product name in AIX XL compatibility warning (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[clang] 1b75285 - [AIX][Clang] Fix XL product name in AIX XL compatibility warning

Author: Zarko Todorovski Date: 2021-11-05T13:17:30-04:00 New Revision: 1b7528554f835d58036543de1e8839ba1ac29f1f URL: https://github.com/llvm/llvm-project/commit/1b7528554f835d58036543de1e8839ba1ac29f1f DIFF:

[PATCH] D113294: [IR] Remove unbounded as possible value for vscale_range minimum

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, bsmith, paulwalker-arm. Herald added subscribers: ctetreau, dexonsmith, dang, jdoerfert, hiraditya. c-rhodes requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The

[PATCH] D113261: [analyzer][solver] Remove reference to RangedConstraintManager

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Yey, it looks good. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1608 LLVM_NODISCARD static ProgramStateRef - assign(ProgramStateRef State,

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D106823#3109469 , @martong wrote: >> As of diff 5, line 1767 and all the code in the block at line 2184 are >> uncovered by the tests you

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. fixed with 7f62759697762473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113210/new/ https://reviews.llvm.org/D113210

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10617 +// copying the data, which is wasteful. +for (const unsigned N : {1u, FinalSize}) { + unsigned OldElts = Value->getArrayInitializedElts(); kadircet wrote: > maybe unroll

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz updated this revision to Diff 385102. adamcz marked an inline comment as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.org/D113120 Files:

Re: [PATCH] D51650: Implement target_clones multiversioning

I think you are these days too :) My offer was "past-past-me". I think you're probably ok here, I did a rough scan, but getting someone like Aaron for the attribute support would be good. On Fri, Nov 5, 2021 at 12:00 PM Erich Keane via Phabricator < revi...@reviews.llvm.org> wrote: > erichkeane

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a6c22e63a: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path=arg… (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D112591?vs=383507=385099#toc

[clang] a83a6c2 - [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

Author: Zarko Todorovski Date: 2021-11-05T12:27:05-04:00 New Revision: a83a6c22e63ad84e9c210c71b36413bed72ac23c URL: https://github.com/llvm/llvm-project/commit/a83a6c22e63ad84e9c210c71b36413bed72ac23c DIFF:

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

martong added a comment. Thanks Denys for the update! Very good! However, I think maybe we could make the code a bit more simpler. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:229-233 +// We want to keep the following invariant at all times: +

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111995 , @mstorsjo wrote: >> I think the biggest testing problem we have though is that we don't have a >> good way of defining integration tests with paths set up the right way >> (since we can't really use

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

tschuett added a comment. If you look at the `immintrin.h` header, the access too many builtins is guarded by ifdefs. ` #if defined(__SSSE3__)` The builtin `__builtin_ia32_reduce_smin_d512` is useless on aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan updated this revision to Diff 385098. ddpagan added a comment. Successfully rebased, built, and tested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112577/new/ https://reviews.llvm.org/D112577 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

aeubanks added a comment. In D113210#3110780 , @Meinersbur wrote: > This change caused the Polly build to fail: > https://lab.llvm.org/buildbot/#/builders/10/builds/7501 > > opt: >

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 385096. ASDenysPetrov added a comment. Updated according to @steakhal's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/ https://reviews.llvm.org/D111654 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. In D113268#3111798 , @sammccall wrote: > In D113268#3111709 , @mstorsjo > wrote: > >> FWIW, this change is not about mingw, it's about making the >> windows-with-forward-slashes

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. Sadly, I think _I_ am the multiversioning expert (or at least, past-me was), so I'm hoping some of the reviewers @danielkiss can get to join will be able to read/understand this stuff for a quality review. CHANGES SINCE LAST ACTION

[PATCH] D51650: Implement target_clones multiversioning

echristo added a comment. FWIW I'm a bit rusty in this area myself, but thanks for doing this. Let's see if we can't get Aaron to continue reviewing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

sammccall added a comment. This is cool! I think it will interact with other features (stdlib, exported headers), and so whatever lands second is going to have to eat the complexity of that interaction. I think both stdlib and exported headers are more critical and more essentially complex, so

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

lenary added a comment. I'm happy with these changes, and with the comments from @dmgreen - as I'm away next week, don't wait for my approval to land this if David has given his approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 385089. erichkeane added a comment. Another rebase, as requested. I am not particularly familiar with this code anymore, so my responses to reviews might not be particularly well informed, but I'm hoping that rust shakes off through the review :)

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

lenary added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160 AArch64::AEK_RCPC | AArch64::AEK_SSBS)) +AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_MTE |

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp index ea3e5bdbc754..826c6d36e1b1 100644 --- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp +++

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

sammccall added a comment. Thanks, this looks nice! Since the code is in Sema, we'd should (also) test this in `clang/test/CodeCompletion/` if possible. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:928 +// FIXME: Add support for per-signature activeParameter

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. Oh, I realized that issues relating to “mingw” probably are from msys (which often is used together, but is an entirely different thing) - yeah I can see that there’d be lots of unfixable issues with that, and I’m not signing up for looking into that… Msys is the

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3111873 , @ibookstein wrote: > And how is Cling expecting CFE to deal with partial knowledge situations at > the implementation level? To deal with exactly the non-local cases that the > current violations

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk accepted this revision. amyk added a comment. Aside from Nemanja's comments, this patch LGTM. Thanks for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 385083. hliao marked an inline comment as done. hliao added a comment. Rebase to the main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files:

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. And how is Cling expecting CFE to deal with partial knowledge situations at the implementation level? To deal with exactly the non-local cases that the current violations address? If there's no prescriptive way forward to dealing with these cases (so they're tech

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. In D113268#3111709 , @mstorsjo wrote: > FWIW, this change is not about mingw, it's about making the > windows-with-forward-slashes configuration usable. OK - can I ask why the windows-with-forward-slashes configuration is

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. @asb Thanks for the reply. To clarify the question, the 2 inconsistencies are: - Test cases with `clang -cc1` originally don't do dependency check to target feature specified (handled by `parseFeatures`) - Clang driver's -march enforces version to be specified, while

Re: [PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

On 11/5/21 1:40 AM, Martin Storsjö via Phabricator wrote: mstorsjo added a comment. I went ahead and reverted this, as it caused crashes when compiling a number of projects. The most reduced testcase is this: $ cat reduced.c void a(*); void a() {} $ clang -c reduced.c -O2 -g A

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. I forgot to add - I agree with the general sentiment though, that it’s not worth bending over backwards to make tests pass in a setup that’s known not to work in real use though. Then again, if someone were to want to actually step up to make it work in mingw setups,

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa00944ebeab1: [clang] unused-but-set-variable warning should not apply to __block objective… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a00944e - [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

Author: Alex Lorenz Date: 2021-11-05T07:48:07-07:00 New Revision: a00944ebeab1b0adbce606cde4d2410fcbb3f440 URL: https://github.com/llvm/llvm-project/commit/a00944ebeab1b0adbce606cde4d2410fcbb3f440 DIFF: https://github.com/llvm/llvm-project/commit/a00944ebeab1b0adbce606cde4d2410fcbb3f440.diff

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:105 + + Inspect string literal and comments for unterminated bidirectional Unicode + characters. Nit: Inspects CHANGES SINCE LAST ACTION

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a reviewer: kadircet. sammccall added a comment. Ooh sorry, I was missing some context. I see now that LLVM_WINDOWS_PREFER_FORWARD_SLASH, `windows_backslash` etc are new work. And maybe buildbots are coming? It's possible that the combination of our windows support plus improved

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before). Comment at: clang/lib/Sema/SemaOverload.cpp:6460 //

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 385071. adamcz added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a subscriber: rnk. mstorsjo added a comment. FWIW, this change is not about mingw, it's about making the windows-with-forward-slashes configuration usable. The windows-with-forward-slashes configuration works just as fine in MSVC configurations, and that's where I've tested it.

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

steakhal added subscribers: whisperity, steakhal. steakhal added a comment. Herald added a subscriber: carlosgalvezp. It seems like the checker is documented as `readability-data-pointer` but in the tests it reports issues under the `readability-container-data-pointer` name. Shouldn't they be

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111262/new/ https://reviews.llvm.org/D111262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

sammccall added a comment. TL;DR: clangd is unsupported/broken on mingw, this patch only makes the tests pass. The current maintainers don't plan to invest in this, or accept much extra complexity to support it. If you or someone wants to find a clean way to support the configuration, it'd be

[PATCH] D111190: Comment parsing: Complete list of Doxygen commands

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90/new/ https://reviews.llvm.org/D90 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added a comment. I do not have commit access, could you please help with the push? Here are the commit details: C. Rayroud - rayro...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @whisperity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:159-160 AArch64::AEK_RCPC | AArch64::AEK_SSBS)) +AARCH64_CPU_NAME("cortex-a710", ARMV9A, FK_NEON_FP_ARMV8, false, + (AArch64::AEK_MTE |

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

erichkeane added a comment. Explanations make sense to me, I'm generally in favor with the 1 concern. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:397 +bool IsIFunc = isa(Alias); llvm::Constant *Aliasee = ibookstein wrote: > erichkeane wrote: > >

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. In D112349#3109994 , @ibookstein wrote: > I see. What is the guiding principle there, though? Generating correct IR "up > front" / "the first time" rather than "fixing it up as you go via > manipulations"? (could you give a

  1   2   >