[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

MaskRay created this revision. MaskRay added reviewers: danalbert, pirama. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ld.lld used by Android ignores .note.GNU-stack and defaults to

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3129571 , @jrtc27 wrote: > For CHERI there's the added complication that descriptors and trampolines can > exist for security reasons when crossing security domains, and you absolutely > should not let one

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge requested review of this revision. nridge added a comment. Sorry for the delay here. @adamcz could you kindly have another look to make sure the test changes look ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge updated this revision to Diff 387057. nridge added a comment. Reworked test to use the framework in clang/test/AST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971 Files:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

jrtc27 added a comment. If it's bypassing the descriptors then __builtin_symbol_address is the wrong name (and a bit ambiguous). As far as dlsym is concerned, the symbol is the descriptor, but when you get down to the ELF representation itself that's not always true. For PPC64 ELFv1, the ELF

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. I don't know for certain, but I would guess that the kernel wants to get the address of the first instruction in the function for the purposes of some sort of later PC-based table lookup, which means that yes, it probably *does* need to bypass descriptors on CHERI /

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

jrtc27 added a comment. In D108479#3110003 , @rjmccall wrote: > `std::addressof()` certainly ought to return a signed pointer > under ptrauth, so if your goal here is to get a completely unadorned symbol > address, I think you do need a different

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. I also note that 32-bit Arm uses the same namespacing, and has CFI-icall support (at least, it's enabled, I don't know if it's actually expected to work) but did not have this change made to it (though probably best not to do so until the DWARF issue is resolved)

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. Or you can still do it in the frontend, just make sure that the DWARF emitted by the frontend doesn't have the DINamespace wrapper when not compiling C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104830/new/

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

aaronpuchert updated this revision to Diff 387056. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Also fix code generation for `void{}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99466/new/

[PATCH] D104830: AST: Create __va_list in the std namespace even in C.

jrtc27 added a comment. This results in the DWARF type info containing DW_TAG_namespace for C, which breaks DTrace's CTF (as the name implies, it is for C, not C++). This does not seem correct to me. If your mangling for va_list is broken then you should special case that in the CFI mangler as

[PATCH] D113838: Sema: Don't erroneously reject `void{}`

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is explicitly allowed via [expr.type.conv], if the initialization list is empty. Repository:

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaronpuchert updated this revision to Diff 387054. aaronpuchert added a comment. Herald added subscribers: kbarton, nemanjai. Herald added a project: clang-tools-extra. Adapt `clang-tidy/checkers/cppcoreguidelines-owning-memory.cpp` and run clang-format. Repository: rG LLVM Github Monorepo

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

salman-javed-nz added a comment. Happy to take a look at this, and do some of the initial review legwork, but let's leave final approval to @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113830/new/ https://reviews.llvm.org/D113830

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was always just a placeholder, but not a particularly good one: the expression certainly has a value

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

HazardyKnusperkeks added a comment. In D113826#3129383 , @lichray wrote: > Thanks for the patch! It works for me, both for the `auto{x}` and `new > auto{x}` cases. Some corner cases left: > > void f() { T()->n = 1; } > void f() { T{}->n = 1; }

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

Quuxplusone added a comment. In D113826#3129383 , @lichray wrote: > void f() { > T { } -> n = 1; > } > > and > > void h() { > auto{ } -> n = 0; > } > > But this may not worth a fix (for now). Kibitzing: I don't think those cases matter

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked an inline comment as done. csmulhern added a comment. I don't have commit access, so please submit this change on my behalf. Thanks for all your help on landing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG86e2af8043c7: reland: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG

[clang] 86e2af8 - reland: [VFS] Use original path when falling back to external FS

Author: Keith Smiley Date: 2021-11-13T12:14:34-08:00 New Revision: 86e2af8043c7728710a711b623f27425801a36c3 URL: https://github.com/llvm/llvm-project/commit/86e2af8043c7728710a711b623f27425801a36c3 DIFF: https://github.com/llvm/llvm-project/commit/86e2af8043c7728710a711b623f27425801a36c3.diff

[clang-tools-extra] 8ac9d2a - [clangd] Fix function-arg-placeholder suppression with macros.

Author: Sam McCall Date: 2021-11-13T20:50:51+01:00 New Revision: 8ac9d2ae5839172013ac6e9108398902da8a8969 URL: https://github.com/llvm/llvm-project/commit/8ac9d2ae5839172013ac6e9108398902da8a8969 DIFF: https://github.com/llvm/llvm-project/commit/8ac9d2ae5839172013ac6e9108398902da8a8969.diff

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac9d2ae5839: [clangd] Fix function-arg-placeholder suppression with macros. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

lichray added a comment. Thanks for the patch! It works for me, both for the `auto{x}` and `new auto{x}` cases. Some corner cases left: void f() { T()->n = 1; } void f() { T{}->n = 1; } // xxx void g() { auto()->n = 0; } void h() { auto{}->n = 0; } // xxx The `/// xxx` cases are

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

HazardyKnusperkeks added a comment. Should I copy my comments on the old file? Comment at: clang/lib/Format/BraceInserter.cpp:21-56 +bool SupportsAnyAutomaticBraces(FormatStyle , bool insertion) { + if (insertion) { +if (Style.AutomaticBraces.AfterIf ==

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good. :) In D113826#3129229 , @Quuxplusone wrote: > Personally I'd remove the tests that are invalid expressions; but I don't > know what's the usual practice. Ship

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: dexonsmith. Herald added subscribers: pengfei, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit

[PATCH] D113765: [clangd] Fix function-arg-placeholder suppression with macros.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:517 +Completion.Kind == CompletionItemKind::Method || +Completion.Kind ==

[clang] f0cf544 - Revert "[VFS] Use original path when falling back to external FS"

Author: Keith Smiley Date: 2021-11-13T10:11:51-08:00 New Revision: f0cf544d6f6fe6cbca4c07772998272d6bb433d8 URL: https://github.com/llvm/llvm-project/commit/f0cf544d6f6fe6cbca4c07772998272d6bb433d8 DIFF: https://github.com/llvm/llvm-project/commit/f0cf544d6f6fe6cbca4c07772998272d6bb433d8.diff

[PATCH] D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute

fwolff created this revision. fwolff added reviewers: alexfh, salman-javed-nz. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes part of PR#45815. Overriding

[clang] c972175 - [VFS] Use original path when falling back to external FS

Author: Keith Smiley Date: 2021-11-13T09:34:44-08:00 New Revision: c972175649f4bb50d40d911659a04d5620ce6fe0 URL: https://github.com/llvm/llvm-project/commit/c972175649f4bb50d40d911659a04d5620ce6fe0 DIFF: https://github.com/llvm/llvm-project/commit/c972175649f4bb50d40d911659a04d5620ce6fe0.diff

[PATCH] D109128: [VFS] Use original path when falling back to external FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc972175649f4: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 387030. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

fwolff created this revision. fwolff added reviewers: alexfh, aaron.ballman, mizvekov. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, abrachet, phosek, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#47614.

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay updated this revision to Diff 387028. MyDeveloperDay added a comment. Revert the last change but comment that the first 4 tests are from the unit tests of D113393 which are expected invalid (I wouldn't want the unit tests from formatting

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay added a comment. Sorry my mistake, the 1st 4 I want to keep because they related to the unit tests for D113393: [c++2b] Implement P0849R8 auto(x) foo(auto()); // expected-error {{initializer for functional-style cast to 'auto' is empty}}

[PATCH] D110745: Redefine deref(N) attribute family as point-in-time semantics (aka deref-at-point)

nikic added a subscriber: aeubanks. nikic added a comment. In D110745#3128719 , @reames wrote: > @nikic ping on previous question. It's been a month, and this has been > LGTMed. Without response, I plan to land this. Sorry, I did do some measurements

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

arthur.j.odwyer added subscribers: MyDeveloperDay, arthur.j.odwyer. arthur.j.odwyer added a comment. Sorry, I meant remove the first four cases that are invalid C++, e.g. auto{}. Personally I'd keep the "valid but arguably misformatted" cases (which I had suggested earlier but you just removed).

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked 4 inline comments as done. csmulhern added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:951 + if (PreviousNonComment && PreviousNonComment->is(tok::l_paren)) { +State.Stack.back().BreakBeforeClosingParen =

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 387025. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay updated this revision to Diff 387024. MyDeveloperDay added a comment. Remove invalid testcases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113826/new/ https://reviews.llvm.org/D113826 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. Personally I'd remove the tests that are invalid expressions; but I don't know what's the usual practice. Ship it AFAIC! CHANGES SINCE LAST ACTION

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay updated this revision to Diff 387021. MyDeveloperDay added a comment. Additional use cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113826/new/ https://reviews.llvm.org/D113826 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

Quuxplusone requested changes to this revision. Quuxplusone added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:22574 + verifyFormat("foo(auto{{}})"); +} + Looks like a good improvement to me!

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: lichray, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Looks like the work of D113393: [c++2b] Implement P0849R8 auto(x)

[clang] 6e58d14 - [clang-format] [PR52228] clang-format csharp inconsistant nested namespace indentation

Author: mydeveloperday Date: 2021-11-13T14:13:51Z New Revision: 6e58d14e5b012215007ae375006f5e847a9b61bc URL: https://github.com/llvm/llvm-project/commit/6e58d14e5b012215007ae375006f5e847a9b61bc DIFF: https://github.com/llvm/llvm-project/commit/6e58d14e5b012215007ae375006f5e847a9b61bc.diff

[PATCH] D112887: [clang-format] [PR52228] clang-format csharp inconsistant nested namespace indentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e58d14e5b01: [clang-format] [PR52228] clang-format csharp inconsistant nested namespace… (authored by MyDeveloperDay). Repository: rG LLVM

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 387017. lichray added a comment. - Manually adjust auto{x} formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

MyDeveloperDay marked 8 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/BraceInserter.cpp:21-56 +bool SupportsAnyAutomaticBraces(FormatStyle , bool insertion) { + if (insertion) { +if (Style.AutomaticBraces.AfterIf ==

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

MyDeveloperDay updated this revision to Diff 387015. MyDeveloperDay marked an inline comment as done. MyDeveloperDay edited the summary of this revision. MyDeveloperDay added a comment. Add more LLVM rules, and don't remove when there are single or multi lines comments CHANGES SINCE LAST

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 387016. lichray marked 3 inline comments as done. lichray added a comment. Address review comments - more test cases - render `auto({})` and `new auto({})` invalid - disambiguate `auto(x)->n` that looks like a declaration Repository: rG LLVM Github

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray marked 10 inline comments as done. lichray added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1032 + // the typename-specifier in a function-style cast expression may + // be 'auto' since C++2b Diag(Tok.getLocation(),

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

aaronpuchert added inline comments. Comment at: clang/include/clang/AST/CommentSema.h:205 - /// \returns \c true if the declaration that this comment is attached to - /// is a pointer to function/method/block type or has such a type. - bool involvesFunctionType(); - - bool

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

JonChesterfield added a comment. I can't see it in the diff - does the cmake somewhere enable the existing tests on this new target? A bit surprised to see ffi involved, are we thinking of spawning a separate process for the target? Comment at: