[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

nridge added a comment. Thanks, LGTM! I have a couple of nits about the test changes, but with those I think this is good to merged. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54 +void verifyIncomingMultiFile(std::string SourceExt, std::string

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

nridge added a comment. In addition to these compilation database docs, I would also suggest adding mention of Bazel to https://clangd.llvm.org/installation#project-setup. (The repo for that it https://github.com/llvm/clangd-www/blob/main/installation.md and a change can be proposed using a

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

rjmccall added a comment. Platforms are permitted to make stronger guarantees than the C standard requires, and it is totally reasonable for compilers to assume that `malloc` meets the target platform's documented guarantees. Arguably, libraries should not be replacing `malloc` if they fail

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

ChuanqiXu added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3226 +// No space between module :. +if (Left.isOneOf(Keywords.kw_module, tok::kw_export, Keywords.kw_import) && +Right.is(TT_ModulePartitionColon)) owenpan wrote: >

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 accepted this revision. gandhi21299 added a comment. This revision is now accepted and ready to land. LGTM, thanks for the bug fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/D92956

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. And thanks to Carlos for accepting the patch. (In case it's not a super demanding task, I would be willing to invest a bit of time towards making CUDA + Clang on Windows work better, but it would help to have "a supervisor" I could turn to when I get stuck or when I have

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. Well, even after this patch neither `clang` nor `clangd` work correctly for me (I need some patches in llvm/clang sources, there are some issues with Microsoft's libraries; I wasn't able to make the linker work even after that), and CMake doesn't fully support CUDA +

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

adamdb5 updated this revision to Diff 388751. adamdb5 added a comment. Renamed bit_DEPRFPUCSDS to bit_DEPR_FPU_CSDS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114318/new/ https://reviews.llvm.org/D114318 Files: clang/lib/Headers/cpuid.h

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

pengfei added a subscriber: hjl.tools. pengfei added a comment. > bit_HYPERVISOR: This seems to be standardized. See the following links: I'm not sure what are these bits defined according to. From PV of HW, I think this shouldn't be added. This bit is set by hypervisor rather than CPU like

[PATCH] D114326: Update the list of CUDA versions up to 11.5

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Thanks for the fix! I'm surprised nobody complained about this until now, CUDA 8 is really old. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

adamdb5 updated this revision to Diff 388746. adamdb5 added a comment. Thanks for the feedback, please see the following comments: bit_HYPERVISOR: This seems to be standardized. See the following links: -

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

pengfei added a comment. In D114318#3144721 , @adamdb5 wrote: > ran clang-format I think we'd better to keep the existing format. It's in good readability. Comment at: clang/lib/Headers/cpuid.h:110 +#define bit_RDRND 0x4000

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

adamdb5 updated this revision to Diff 388744. adamdb5 added a comment. undo clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114318/new/ https://reviews.llvm.org/D114318 Files: clang/lib/Headers/cpuid.h Index: