[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added a comment. No more comments from me (apart from one minor nit). This should definitely get someone with more familiarity with how these things are configured to take a look though. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire created this revision. junaire added reviewers: fhahn, aaron.ballman, scanon, craig.topper. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements one of the missing builtin functions specified in

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4aac00a71db3: [analyzer][doc] Add user documenation for taint analysis (authored by gamesh411). Repository: rG LLVM

[clang] 4aac00a - [analyzer][doc] Add user documenation for taint analysis

Author: Endre Fülöp Date: 2021-11-28T23:36:47+01:00 New Revision: 4aac00a71db31121d70b140d7367e7f9d9992f66 URL: https://github.com/llvm/llvm-project/commit/4aac00a71db31121d70b140d7367e7f9d9992f66 DIFF: https://github.com/llvm/llvm-project/commit/4aac00a71db31121d70b140d7367e7f9d9992f66.diff

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

cpsauer added a comment. Wahoo! Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114213/new/ https://reviews.llvm.org/D114213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

nridge added a comment. In D114213#3156940 , @cpsauer wrote: > could I ask for your help landing the change now that it's approved? Landed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114213/new/

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

This revision was automatically updated to reflect the committed changes. Closed by commit rG5233ad17e77e: Compilation Database: Point Bazel users to a solution (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114213/new/

[clang] 5233ad1 - Compilation Database: Point Bazel users to a solution

Author: Nathan Ridge Date: 2021-11-28T19:30:06-05:00 New Revision: 5233ad17e77eb7b7697f2664dc5a588a30fe5eaf URL: https://github.com/llvm/llvm-project/commit/5233ad17e77eb7b7697f2664dc5a588a30fe5eaf DIFF: https://github.com/llvm/llvm-project/commit/5233ad17e77eb7b7697f2664dc5a588a30fe5eaf.diff

[PATCH] D105869: [Driver] Support PowerPC SPE musl dynamic linker name ld-musl-powerpc-sf.so.1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3163c1cdde0: [Driver] Support PowerPC SPE musl dynamic linker name ld-musl-powerpc-sf.so.1 (authored by pattop, committed by MaskRay). Repository:

[clang] b3163c1 - [Driver] Support PowerPC SPE musl dynamic linker name ld-musl-powerpc-sf.so.1

Author: Patrick Oppenlander Date: 2021-11-28T15:39:55-08:00 New Revision: b3163c1cdde09467382984e5879aa9701b7036d3 URL: https://github.com/llvm/llvm-project/commit/b3163c1cdde09467382984e5879aa9701b7036d3 DIFF:

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I have confirmed that this matches musl `#define FP_SUFFIX "-sf"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105869/new/

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

pattop updated this revision to Diff 390227. pattop added a comment. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105869/new/ https://reviews.llvm.org/D105869 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:71 } - // Emit short-query trigrams: FooBar -> f, fo, fb. - if (!LowercaseIdentifier.empty()) -Out(Trigram(LowercaseIdentifier[0])); - if (LowercaseIdentifier.size() >= 2) -

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf08b2fe8b35: [AArch64] Avoid crashing on invalid -Wa,-march= values (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] df08b2f - [AArch64] Avoid crashing on invalid -Wa, -march= values

Author: Dimitry Andric Date: 2021-11-28T22:23:42+01:00 New Revision: df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e URL: https://github.com/llvm/llvm-project/commit/df08b2fe8b35cb63dfb3b49738a3494b9b4e6f8e DIFF:

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

tschuett accepted this revision. tschuett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114677/new/ https://reviews.llvm.org/D114677

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

dim updated this revision to Diff 390218. dim added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114677/new/ https://reviews.llvm.org/D114677 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

tschuett added a comment. There is precedence for checking `WaMArch.size()` in the file. I would expected `!WaMArch.empty()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114677/new/ https://reviews.llvm.org/D114677

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

tschuett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:263 if (!success) -D.Diag(diag::err_drv_clang_unsupported) << A->getAsString(Args); +D.Diag(diag::err_drv_clang_unsupported) +<< (WaMArch.size() ? "-march=" +

[PATCH] D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values

dim created this revision. dim added reviewers: jcai19, ostannard, DavidSpickett, nickdesaulniers. Herald added subscribers: kristof.beyls, krytarowski, arichardson. dim requested review of this revision. Herald added a project: clang. As reported in https://bugs.freebsd.org/260078, the gnutls

[clang] 8874ada - [clang] Fix -Wreturn-type false positive in @try statements

Author: Nico Weber Date: 2021-11-28T12:56:46-05:00 New Revision: 8874ada906f6a2ae0c4aa978581a0c9c26b89ffd URL: https://github.com/llvm/llvm-project/commit/8874ada906f6a2ae0c4aa978581a0c9c26b89ffd DIFF: https://github.com/llvm/llvm-project/commit/8874ada906f6a2ae0c4aa978581a0c9c26b89ffd.diff

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis added a comment. https://reviews.llvm.org/rG06b602e540cd94d09ccbb39d63b151860a4022d2 (added the c++ exception checks to the warning) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114660/new/ https://reviews.llvm.org/D114660 ___

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis added a comment. For future self, related changes I looked at: https://reviews.llvm.org/rG04c6851cd6053 (made it so that calls don't add edges to try cfg blocks) https://reviews.llvm.org/rG33979f75a0fd8 (added -Wreturn-type in the first place)

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114660/new/ https://reviews.llvm.org/D114660 ___ cfe-commits mailing list

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added a comment. Personally I think it's best to merge this as is, allowing people to e.g. replace cpplint with clang-tidy (one static analyzer to rule them all!), and add more functionality in a separate, focused patch. Looking forward to hearing your thoughts :) CHANGES SINCE

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} carlosgalvezp wrote: > Quuxplusone wrote: > > What about > > ``` > > template T foo(int i) { return T(i); }

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 390198. HsiangKai added a comment. Address a part of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic/CMakeLists.txt

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

Mordante added a comment. Since this patch requires both an update to both Clang and libc++ I think it would land the Clang part in a separate patch. Then wait for the CI to have ToT with this version and land that separately. For now can you run the CI with the Bootstrap build?

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} Quuxplusone wrote: > What about > ``` > template T foo(int i) { return T(i); } > int main() { > foo>();

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 390191. carlosgalvezp added a comment. Add extra test for template functions that use the functional cast. It should only warn when T is not a class type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 390187. eopXD added a comment. - Update code (zfh have been added recently. - Added test case `attribute-arch-invalid.s` to show that experimental extensions need to specify the version explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST