[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

carlosgalvezp added a comment. Could you summarize what problem this is solving? There's multiple ways to "ignore diagnostics from specific checks", I think it would be confusing to add yet another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D116163: [clang-tidy] Add a SuppressedChecks option to ignore diagnostics from specific checks

reyg created this revision. reyg added a reviewer: cfe-commits. Herald added subscribers: carlosgalvezp, xazax.hun. reyg requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116163 Files: clang-tools-extra

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. In D116161#3206447 , @fhahn wrote: > In D116161#3206442 , @junaire wrote: > >> Update the existing place that can use `emitUnaryBuiltin`. > > I meant just update the existing uses *without

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3206442 , @junaire wrote: > Update the existing place that can use `emitUnaryBuiltin`. I meant just update the existing uses *without* adding `floor`, `roundeven`, `trunc`, so this change should be NFC (non-functional c

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395853. junaire added a comment. Sorry, It seems that the base branch is wrong, reupdate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGe

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395852. junaire added a comment. Update the existing place that can use `emitUnaryBuiltin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/include/cla

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

SjoerdMeijer added reviewers: dmgreen, SjoerdMeijer. SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:937 case llvm::ARM::ArchKind::ARMV9_2A: getTargetDefinesARMV83A(Opts, Builder); break; Perhaps unrelated to this patc

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

ktkachov added a comment. I think the most important use of the __ARM_FEATURE_MOPS is to check whether it's safe to use the new intrinsics, so it should only be defined by the compiler once it supports the intrinsics proposed in https://github.com/ARM-software/acle/pull/38/files Repository:

[PATCH] D116022: [clang][dataflow] Add support for terminating noreturn destructors

sgatev updated this revision to Diff 395845. sgatev marked 3 inline comments as done. sgatev added a comment. Change commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files: clang/include/

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. Can you also update the existing places that could use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits mailing list c

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

junaire added a comment. > Sounds good! Might be good to split the emitUnaryBuiltin changes off into a > separate change? Thanks for your suggestion! I just sent another patch: D116161 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire created this revision. junaire added reviewers: fhahn, arsenm. junaire requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch adds an overload for emitUnaryBuiltin, which is addressed in D115429

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev marked 3 inline comments as done. sgatev added a comment. I also agree that the current approach isn't robust. I think that a proper solution would involve patching the CFG because in some cases it seems to be incorrect. For example, the call to `qux` is incorrectly deemed to be unreacha

[PATCH] D116022: [clang][dataflow] Add support for terminating virtual destructors

sgatev updated this revision to Diff 395841. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116022/new/ https://reviews.llvm.org/D116022 Files: clang/in

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

labath added a comment. Seems fairly straight-forward (and definitely useful). Just a couple of quick comments. Comment at: clang/utils/ClangDataFormat.py:28-35 +debugger.HandleCommand("type summary add -F ClangDataFormat.Optional_summary -x 'llvm::Optional<.*>'") +de

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu updated this revision to Diff 395837. ChuanqiXu added a comment. Format codes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces the new `__ARM_FEATURE_MOPS` ACLE feature test macro, which signals the a

[clang] 0af6281 - [CodeGen] Make lifetime marker test more robust (NFC)

Author: Nikita Popov Date: 2021-12-22T12:28:10+01:00 New Revision: 0af628152a0547ad02856a880830ec33aa79e21c URL: https://github.com/llvm/llvm-project/commit/0af628152a0547ad02856a880830ec33aa79e21c DIFF: https://github.com/llvm/llvm-project/commit/0af628152a0547ad02856a880830ec33aa79e21c.diff

[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces support for targetting the Armv9.3-A architecture, which should map to the existing A

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At impo

[PATCH] D116128: [clang][driver] Warn when '-mno-outline-atomics' is used with a non-AArch64 triple

melver accepted this revision. melver added inline comments. Comment at: clang/test/Driver/x86-outline-atomics.c:1-7 +// RUN: %clang -target x86_64 -moutline-atomics -S %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OUTLINE-ATOMICS +// CHECK-OUTLINE-ATOMICS: warning: 'x86_64' d

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by Ranjeet Singh and Son Tuan Vu. Change-Id: Ic18ffda35760587673b30c166ac145b0df038973 Repository:

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116153 Files: clang/lib/Basic/Targets/A

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall planned changes to this revision. sammccall added a comment. Actually we should probably handle `-Wno-` too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116147/new/ https://reviews.llvm.org/D116147 _

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. In D102669#3206089 , @steakhal wrote: > Prior to this patch, it worked on M1 ; after > landing it broke something, so we clearly shouldn't land this. I do not think it is this patch that breaks t

[PATCH] D116147: [clangd] Respect .clang-tidy ExtraArgs (-Wfoo only) when producing diagnostics

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This mechanism is used almost

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb55ea2fbc0a0: [Clang] Add __builtin_reduce_xor (authored by junaire, committed by fhahn). Changed prior to commit: https://reviews.llvm.org/D11523

[clang] b55ea2f - [Clang] Add __builtin_reduce_xor

Author: Jun Zhan Date: 2021-12-22T10:00:27Z New Revision: b55ea2fbc0a0564eece1e58fc5624057d5d05639 URL: https://github.com/llvm/llvm-project/commit/b55ea2fbc0a0564eece1e58fc5624057d5d05639 DIFF: https://github.com/llvm/llvm-project/commit/b55ea2fbc0a0564eece1e58fc5624057d5d05639.diff LOG: [Cla

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395809. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

[PATCH] D116110: Introduce the AttributeMask class

nikic added a comment. Looking at some of the changes here, I landed a couple of cleanup commits: - https://github.com/llvm/llvm-project/commit/3b0f5a4856fce76a6535feddd1692747b81b60cd (this should fix the build failure) - https://github.com/llvm/llvm-project/commit/e8e8bfeeb7233bde17d0a811b87

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. In D102669#3205889 , @OikawaKirie wrote: > In D102669#3199270 , @steakhal > wrote: > >> We shouldn't sk

[PATCH] D115923: [RISCV][Don't Commit] Refactor the RISCV ISA extension info and target features to support multiple extension version

zixuan-wu abandoned this revision. zixuan-wu added a comment. Only need review D115921 . Just abandon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115923/new/ https://reviews.llvm.org/D115923

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 updated this revision to Diff 395807. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115982/new/ https://reviews.llvm.org/D115982 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/address-space-avr.c clang/test/CodeGen/avr-flash.c

<    1   2