[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 2 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:288 + /// template parameters, no matter how many elements there are. + unsigned EntireContentsOfLargeArray : 1; + rsmith wrote: > It lo

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 396187. lichray marked an inline comment as done. lichray added a comment. Herald added a subscriber: mgorny. - Fix categorizing int64_t chars of negative values - More ArrayRef - Fix and test the EntireContentsOfLargeArray bit Repository: rG LLVM Github M

[clang] 3cfe375 - Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2021-12-24T22:05:34-08:00 New Revision: 3cfe375ae43139839af01e29c3ec03654e98186b URL: https://github.com/llvm/llvm-project/commit/3cfe375ae43139839af01e29c3ec03654e98186b DIFF: https://github.com/llvm/llvm-project/commit/3cfe375ae43139839af01e29c3ec03654e98186b.diff L

[clang-tools-extra] 62e48ed - Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2021-12-24T21:22:27-08:00 New Revision: 62e48ed10f9d2328331378f7c070487e58346a7e URL: https://github.com/llvm/llvm-project/commit/62e48ed10f9d2328331378f7c070487e58346a7e DIFF: https://github.com/llvm/llvm-project/commit/62e48ed10f9d2328331378f7c070487e58346a7e.diff L

[clang] 62e48ed - Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2021-12-24T21:22:27-08:00 New Revision: 62e48ed10f9d2328331378f7c070487e58346a7e URL: https://github.com/llvm/llvm-project/commit/62e48ed10f9d2328331378f7c070487e58346a7e DIFF: https://github.com/llvm/llvm-project/commit/62e48ed10f9d2328331378f7c070487e58346a7e.diff L

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer added inline comments. Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:404 bool usesThreadWrapperFunction(const VarDecl *VD) const override { -return false; +return true; } Should this depend on the MSVC compatibility version? CHANGES S

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

egorzhdan created this revision. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a compiler crash that was introduced in https://reviews.llvm.org/D103611: `Sema::BuildVAArgExpr` attempted to retrieve a correspo

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

yodaldevoid abandoned this revision. yodaldevoid added a comment. In D116229#3209414 , @owenpan wrote: > In D116229#3208507 , @curdeius > wrote: > >> Why this option is useful? Why would someone want to have a di

[PATCH] D115103: Leak Sanitizer port to Windows

vitalybuka added a comment. In D115103#3209326 , @clemenswasser wrote: > @vitalybuka > No `check-asan` **doesn't work** for me. It just hangs forever and does > absolutely nothing. No output, nothing showing up in Task Manager with high > CPU usage or

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb updated this revision to Diff 396178. cjdb added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Specifiers.h

[PATCH] D116264: [clang] adds `__remove_cvref` as a compiler buiilt-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116264/new/ https://reviews.llvm.org/D116264 ___

[PATCH] D116262: [clang] adds `__remove_reference` as a compiler built-in

cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116262/new/ https://reviews.llvm.org/D116262 ___ cfe-commits mailing list cfe-c

[PATCH] D116260: [clang] adds `__remove_cv` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116260/new/ https://reviews.llvm.org/D116260 ___

[PATCH] D116242: [clang] adds `__remove_volatile` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116242/new/ https://reviews.llvm.org/D116242 ___

[PATCH] D116226: [clang] adds `__remove_const` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116226/new/ https://reviews.llvm.org/D116226 ___

[PATCH] D116206: [clang] adds `__add_cv` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116206/new/ https://reviews.llvm.org/D116206 ___

[PATCH] D116205: [clang] adds `__add_volatile` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116205/new/ https://reviews.llvm.org/D116205 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb updated this revision to Diff 396177. cjdb retitled this revision from "[clang] adds `__add_const` as a compiler built-in" to "[clang] adds unary type transformations as compiler built-ins". cjdb edited the summary of this revision. cjdb added a comment. merges D116205

[PATCH] D116229: [clang-format] Add option to align pointers in C style casts differently

owenpan added a comment. In D116229#3208507 , @curdeius wrote: > Why this option is useful? Why would someone want to have a different > alignment in casts than in other places? > As such I'm opposed to introducing one more option. Is there any well > e

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea64d5585ec: [clang-format] Fix short enums getting wrapped even when denied (authored by yodaldevoid, committed by owenpan). Repository: rG LLVM

[clang] 8ea64d5 - [clang-format] Fix short enums getting wrapped even when denied

Author: Gabriel Smith Date: 2021-12-24T11:38:55-08:00 New Revision: 8ea64d5585ec3a0a52db20c9e57ac9bed9e80fc2 URL: https://github.com/llvm/llvm-project/commit/8ea64d5585ec3a0a52db20c9e57ac9bed9e80fc2 DIFF: https://github.com/llvm/llvm-project/commit/8ea64d5585ec3a0a52db20c9e57ac9bed9e80fc2.diff

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

Random06457 updated this revision to Diff 396171. Random06457 added a comment. Addressed the comments. I also updated `isFirstMul` to exclude integer multiplications which do not produce the bug. That change made me fix the tests too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116238

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan requested changes to this revision. atanasyan added a comment. This revision now requires changes to proceed. Thanks for the patch. Some notes are below. Comment at: llvm/lib/Target/Mips/MipsMulMulBugPass.cpp:16 +static cl::opt +EnableMulMulFix("mfix4300", cl::ini

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Anastasia created this revision. Anastasia added reviewers: Topotuna, svenvh. Herald added subscribers: Naghasan, ebevhan, yaxunl. Anastasia requested review of this revision. This patch contains an update of C++ for OpenCL 2021 support status along with other misc updates: - OpenCL 3.0 - Bugzi

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. @yaxunl It would be very much helpful to know how to write test coverage for this particular patch? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. @vitalybuka No `check-asan` **doesn't work** for me. It just hangs forever and does absolutely nothing. No output, nothing showing up in Task Manager with high CPU usage or anything. However `check-clang` **does work**. Is there some documentation on running `chec

[clang] dc8f9fb - [Docs] Minor fix in clang user manual

Author: Anastasia Stulova Date: 2021-12-24T16:21:56Z New Revision: dc8f9fb196dab8ca31361928bd6a361dc80d8ade URL: https://github.com/llvm/llvm-project/commit/dc8f9fb196dab8ca31361928bd6a361dc80d8ade DIFF: https://github.com/llvm/llvm-project/commit/dc8f9fb196dab8ca31361928bd6a361dc80d8ade.diff

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. In D116161#3209292 , @fhahn wrote: > In D116161#3209286 , @junaire wrote: > >> 35: %0 = load float, float* %f1.addr, align 4 >> 36: %1 = load float, float* %f1.addr, align 4 >> 3

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3209286 , @junaire wrote: > 35: %0 = load float, float* %f1.addr, align 4 > 36: %1 = load float, float* %f1.addr, align 4 > 37: %elt.abs = call float @llvm.fabs.f32(float %1) It looks like the argument expres

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid added a comment. In D116188#3208456 , @HazardyKnusperkeks wrote: > Since you only upload a diff, there is no name or email. ;) It had looked like arcanist was retaining this information, but I now realize what it was doing. At any rate, I

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. I confirmed that we can use `emitUnaryBuiltin` in the cases you pointed out. Please see the logs below: $ path/to/llvm-project/build/bin/clang -cc1 -internal-isystem /path/to/llvm-project/build/lib/clang/14.0.0/include -nostdsysteminc -triple x86_64-apple-darwin /pa

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Please go ahead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rGc7a589a2c4e2: [Clang][OpenMP] Add the support for atomic compare in parser (authored by tianshilei19

[clang] c7a589a - [Clang][OpenMP] Add the support for atomic compare in parser

Author: Shilei Tian Date: 2021-12-24T08:16:51-05:00 New Revision: c7a589a2c4e2db496d732821a8dba59508326250 URL: https://github.com/llvm/llvm-project/commit/c7a589a2c4e2db496d732821a8dba59508326250 DIFF: https://github.com/llvm/llvm-project/commit/c7a589a2c4e2db496d732821a8dba59508326250.diff L

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 ___

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

Anastasia created this revision. Anastasia added reviewers: svenvh, linjamaki, azabaznov. Herald added subscribers: ThomasRaoux, ebevhan. Anastasia requested review of this revision. Add support of linking files compiled into SPIR-V object files using spirv-link (https://github.com/KhronosGroup/S

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

mubashar_ updated this revision to Diff 396151. mubashar_ edited the summary of this revision. mubashar_ added a comment. Cleaned up code to make it more clang format friendly. Added another test suite in C. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3208353 , @MaskRay wrote: > I slightly adjusted the test in eafc64ed6325eba962096d4a947d7e45e909bfde > :) > > `-no-canonical-prefixes` can usually

[clang] 969a51f - Revert "[ASan] Moved optimized callbacks into a separate library."

Author: Krasimir Georgiev Date: 2021-12-24T12:01:36+01:00 New Revision: 969a51ff363263a3b5f2df55eba6b4d392bf30c0 URL: https://github.com/llvm/llvm-project/commit/969a51ff363263a3b5f2df55eba6b4d392bf30c0 DIFF: https://github.com/llvm/llvm-project/commit/969a51ff363263a3b5f2df55eba6b4d392bf30c0.d

[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

Sockke requested changes to this revision. Sockke added a comment. This revision now requires changes to proceed. Could you please add a test case where the smart pointer object is dereferenced before calling `size()`? E.g. `return (*ptr).size() == 0;`. I think this change doesn't work on this t

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. I don't know why but these will cause tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits mailing list cfe-c

[PATCH] D116090: [X86][MS-InlineAsm] Use exact conditions to recognize MS global variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG24c68ea1eb4f: Reland "[X86][MS-InlineAsm] Use exact conditions to recognize MS global… (authored by pengfei). Changed prior to commit: https://reviews.llvm.org/D116090?vs=395962&id=396145#toc Repositor

[clang] 24c68ea - Reland "[X86][MS-InlineAsm] Use exact conditions to recognize MS global variables"

Author: Phoebe Wang Date: 2021-12-24T17:42:51+08:00 New Revision: 24c68ea1eb4fc0d0e782424ddb02da9e8c53ddf5 URL: https://github.com/llvm/llvm-project/commit/24c68ea1eb4fc0d0e782424ddb02da9e8c53ddf5 DIFF: https://github.com/llvm/llvm-project/commit/24c68ea1eb4fc0d0e782424ddb02da9e8c53ddf5.diff L

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3137 else Result = Builder.CreateUnaryIntrinsic(llvm::Intrinsic::fabs, Op0, nullptr, "elt.abs"); Should also be used here? ===

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew added a comment. On further thought, the logic for `loadConfigFile()` looks incomplete. It does not properly handle the `InheritParentConfig` argument for `BasedOnStyle`. In fact, `loadConfigFile()` should probably use the same logic as that for `-style=file`. I can look into making this

[PATCH] D116264: [clang] adds `__remove_cvref` as a compiler buiilt-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116264 Files:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

zwliew added a comment. Hi, I'd like to help to get this patch accepted and merged. I have a few suggestions/questions below, and I can help make any changes to the patch if needed! Comment at: clang/docs/ClangFormatStyleOptions.rst:35 +When using ``-style=file:, :program:`

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396140. junaire added a comment. Fix wrong usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGen/CGBuiltin.cpp Index: clang/lib/CodeGen/

[PATCH] D116214: [OpenMP] Avoid creating null pointer lvalue (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd903173c0fb: [OpenMP] Avoid creating null pointer lvalue (NFC) (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-co

[clang] dd90317 - [OpenMP] Avoid creating null pointer lvalue (NFC)

Author: Nikita Popov Date: 2021-12-24T09:01:56+01:00 New Revision: dd903173c0fb9ead398b8b516f0672d30d25b120 URL: https://github.com/llvm/llvm-project/commit/dd903173c0fb9ead398b8b516f0672d30d25b120 DIFF: https://github.com/llvm/llvm-project/commit/dd903173c0fb9ead398b8b516f0672d30d25b120.diff