[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

curdeius added a comment. In D117520#3258454 , @MyDeveloperDay wrote: > I think its been fixed, in the last but one diff. > > Generally speaking we simply cannot have --output-replacements-xml , -n or > --dry-run show replacements that amount to

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. LGTM! Had some nits that can be fixed without review. Can't see anything else major that needs change. As said I'm fairly new here so probably a more experienced reviewer can find some more improvements/optimizations,

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

Izaron updated this revision to Diff 401872. Izaron added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117846/new/ https://reviews.llvm.org/D117846 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6de53b4de4a: [RISCV] Bump rvv-related extensions from 0.10 to 1.0 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/

[clang] e6de53b - [RISCV] Bump rvv-related extensions from 0.10 to 1.0

Author: eopXD Date: 2022-01-20T23:22:20-08:00 New Revision: e6de53b4de4aecca4ac892500a0907805896ed27 URL: https://github.com/llvm/llvm-project/commit/e6de53b4de4aecca4ac892500a0907805896ed27 DIFF: https://github.com/llvm/llvm-project/commit/e6de53b4de4aecca4ac892500a0907805896ed27.diff LOG:

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401870. eopXD added a comment. Follow clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. In D107450#3257877 , @aaron.ballman wrote: > Do you need someone to commit on your behalf? Thanks for your review, I committed it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7f8aea71485: [clang-tidy] Fix wrong FixIt in performance-move-const-arg (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/

[clang-tools-extra] a7f8aea - [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Author: Sockke Date: 2022-01-21T14:23:52+08:00 New Revision: a7f8aea71485c00db2ffb6288ae58475869048b1 URL: https://github.com/llvm/llvm-project/commit/a7f8aea71485c00db2ffb6288ae58475869048b1 DIFF: https://github.com/llvm/llvm-project/commit/a7f8aea71485c00db2ffb6288ae58475869048b1.diff LOG:

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:149 RV64 = 1 << 5, + VectorMaxELen32 = 1 << 6, + VectorMaxELen64 = 1 << 7, craig.topper wrote: > Do we need VectorMaxELen32 isn't that the minimum? Yes you are correct. We don't

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

eopXD updated this revision to Diff 401862. eopXD marked 2 inline comments as done. eopXD added a comment. Rebase and addres comments. Resolve conflcits due to zvlsseg removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/

[PATCH] D112987: [RISCV] Bump rvv-related extensions from 0.10 to 1.0

eopXD updated this revision to Diff 401861. eopXD added a comment. Rebase. Resolve conflict due to zvlsseg removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112987/new/ https://reviews.llvm.org/D112987 Files: clang/test/Driver/riscv-arch.c

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 updated this revision to Diff 401851. tyb0807 marked 2 inline comments as done. tyb0807 added a comment. `__ARM_FEATURE_MEMORY_TAGGING` not needed to enable `__builtin_arm_mops_memset_tag`. Follow variable naming convention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117626: [ADT] [NFC] Add StringRef::detectEOL

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me Comment at: llvm/unittests/ADT/StringRefTest.cpp:1114-1116 + for (const auto : Cases) { +EXPECT_EQ(StringRef("\n"), Entry.detectEOL()); + }

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG82af95029ec9: [X86] Enable ibt-seal optimization when LTO is used in Kernel (authored by joaomoreira, committed by pengfei). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 82af950 - [X86] Enable ibt-seal optimization when LTO is used in Kernel

Author: Joao Moreira Date: 2022-01-21T10:55:34+08:00 New Revision: 82af95029ec947fed8b9c516f04d4f217bd87930 URL: https://github.com/llvm/llvm-project/commit/82af95029ec947fed8b9c516f04d4f217bd87930 DIFF: https://github.com/llvm/llvm-project/commit/82af95029ec947fed8b9c516f04d4f217bd87930.diff

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 401843. Ericson2314 added a comment. Remove the LLVM part, which is now D101070 , and furthermore known to cause issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This seems to be the part of D99484 that wasn't working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101070/new/ https://reviews.llvm.org/D101070

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. @carlosgalvezp I believe I've addressed your comments now. Thanks for the review, it definitely improved this check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood updated this revision to Diff 401837. LegalizeAdulthood added a comment. - Properly apply fixes to header files - Add tests for fixes in header files - Move function to static outside anonymous namespace - Improve documentation CHANGES SINCE LAST ACTION

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3259928 , @majnemer wrote: > Your example is different from mine as it nests the constexpr variable inside > the function rather than having it at translation-unit scope. And I suppose we are interested in the

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG58580e922a69: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs. (authored by Ericson2314). Repository:

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.96

Jim added a comment. Herald added a subscriber: eopXD. In D108189#3188343 , @zixuan-wu wrote: > Hi, @Jim. > What time is P extension going to upstream to community since it's been no > update for some months? Hi @zixuan-wu, From RVP 0.9.7, it has lots

[PATCH] D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.

Ericson2314 added a comment. Continuing my bisect of D99484 (since this change was in there at the time it was approved, but failing) I will land this one next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rG0dfe953294ba: [OpenMP] Change default visibility to protected for device declarations (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0dfe953 - [OpenMP] Change default visibility to protected for device declarations

Author: Joseph Huber Date: 2022-01-20T21:06:26-05:00 New Revision: 0dfe953294ba1c0fc43fb710518b9b5a608b223a URL: https://github.com/llvm/llvm-project/commit/0dfe953294ba1c0fc43fb710518b9b5a608b223a DIFF: https://github.com/llvm/llvm-project/commit/0dfe953294ba1c0fc43fb710518b9b5a608b223a.diff

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added a comment. Can we just update `bool IEEELongDouble = false; ` to `bool IEEELongDouble = true;` in `clang/lib/Driver/ToolChains/Clang.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

pengfei accepted this revision. pengfei added inline comments. Comment at: clang/lib/Headers/avx512bwintrin.h:894 return (__m512i)__builtin_ia32_selectb_512((__mmask64)__M, (__v64qi)_mm512_min_epu8(__A, __B),

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:76 + if (SupportIEEEFloat128(getDriver(), getTriple(), DriverArgs) && + !DriverArgs.hasArg(options::OPT_mabi_EQ)) +CC1Args.push_back("-mabi=ieeelongdouble"); What if we

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:31 + * appear in the interface though. */ +typedef signed char __v64qs __attribute__((__vector_size__(64))); + craig.topper wrote: > pengfei wrote: > > Do we need to declare explicit

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:31 + * appear in the interface though. */ +typedef signed char __v64qs __attribute__((__vector_size__(64))); + pengfei wrote: > Do we need to declare explicit `signed`? The

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

pengfei accepted this revision. pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:31 + * appear in the interface though. */ +typedef signed char __v64qs __attribute__((__vector_size__(64))); + Do we need to declare explicit `signed`?

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

Izaron updated this revision to Diff 401817. Izaron added a comment. Removed the brackets in `{ return }` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117846/new/ https://reviews.llvm.org/D117846 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

Izaron added a comment. I'm going to use this matcher very soon in my new `clang-tidy` check. If you're interested and want to read more, I have a design document about my ne check - here (gist.github.com)

[PATCH] D117846: [ASTMatchers] Add `isConstinit` matcher

Izaron created this revision. Izaron added reviewers: aaron.ballman, cor3ntin. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support C++20 constinit variables for AST Matchers. Repository: rG LLVM Github Monorepo

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

craig.topper added a comment. In D117829#3259588 , @RKSimon wrote: > I should mention - according to > https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` > already exists, which I don't think is true. Does that documentation

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 401813. dcastagna added a comment. Fix invalid-offload-options.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 Files:

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

JonChesterfield accepted this revision. JonChesterfield added a comment. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117806/new/ https://reviews.llvm.org/D117806 ___ cfe-commits mailing

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5830 + // host, makes the system more robust, and improves performance. + if (IsOpenMPDevice) { +CmdArgs.push_back("-fvisibility");

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 updated this revision to Diff 401811. jhuber6 added a comment. Forgot to make this mutually exclusive with user defined visibility value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117806/new/ https://reviews.llvm.org/D117806 Files:

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rGd3b188a2d72f: [clang-tidy] Include constructor initializers in `bugprone-exception-escape`… (authored by fwolff). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] d3b188a - [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

Author: Fabian Wolff Date: 2022-01-21T00:53:57+01:00 New Revision: d3b188a2d72f9c398e4b1a36d23888c4ac783e9f URL: https://github.com/llvm/llvm-project/commit/d3b188a2d72f9c398e4b1a36d23888c4ac783e9f DIFF: https://github.com/llvm/llvm-project/commit/d3b188a2d72f9c398e4b1a36d23888c4ac783e9f.diff

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5830 + // host, makes the system more robust, and improves performance. + if (IsOpenMPDevice) { +CmdArgs.push_back("-fvisibility"); I think we need some more code here

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added a comment. Your example is different from mine as it nests the constexpr variable inside the function rather than having it at translation-unit scope. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b7bd911d9e: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images (authored by airlied). Repository: rG LLVM Github

[clang] e1b7bd9 - [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Author: Dave Airlie Date: 2022-01-21T09:51:01+10:00 New Revision: e1b7bd911d9e491e50db1aa00d340fb3b6b907ef URL: https://github.com/llvm/llvm-project/commit/e1b7bd911d9e491e50db1aa00d340fb3b6b907ef DIFF: https://github.com/llvm/llvm-project/commit/e1b7bd911d9e491e50db1aa00d340fb3b6b907ef.diff

[PATCH] D117753: [AArch64] Support for memset tagged intrinsic

tyb0807 marked 3 inline comments as done. tyb0807 added inline comments. Comment at: clang/lib/Headers/arm_acle.h:734 +/* Memory Operations Intrinsics */ +#if __ARM_FEATURE_MOPS && __ARM_FEATURE_MEMORY_TAGGING +#define __arm_mops_memset_tag(tagged_address, value, size)

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam added a comment. In D117569#3259255 , @majnemer wrote: > In D117569#3258307 , @zahiraam > wrote: > >> In D117569#3257121 , @majnemer >> wrote: >> >>> I have a

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

bnbarham added a comment. Also have bug up at https://github.com/llvm/llvm-project/issues/53306. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117730/new/ https://reviews.llvm.org/D117730 ___

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

bnbarham added a comment. @keith This patch causes some issues when nesting/chaining `RedirectingFileSystems`. I have a few tests in https://reviews.llvm.org/D117730 for more details. Feedback on that PR would be appreciated, I'm not sure if it's the direction we want to go or not.

[PATCH] D117840: [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5684114445a: [clang-tidy] Update bugprone-stringview-nullptr to

[clang-tools-extra] a568411 - [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions

Author: CJ Johnson Date: 2022-01-20T18:08:40-05:00 New Revision: a5684114445a72b5c0bb5b7b68a5c6eb3486b66d URL: https://github.com/llvm/llvm-project/commit/a5684114445a72b5c0bb5b7b68a5c6eb3486b66d DIFF: https://github.com/llvm/llvm-project/commit/a5684114445a72b5c0bb5b7b68a5c6eb3486b66d.diff

[PATCH] D117840: [clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions

CJ-Johnson created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. CJ-Johnson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously, function(nullptr) would have been fixed with function({}). This

[PATCH] D117759: [clang-format][NFC] Clean up tryMergeLessLess()

This revision was automatically updated to reflect the committed changes. owenpan marked an inline comment as done. Closed by commit rGc95afac89e00: [clang-format][NFC] Clean up tryMergeLessLess() (authored by owenpan). Changed prior to commit:

[clang] c95afac - [clang-format][NFC] Clean up tryMergeLessLess()

Author: owenca Date: 2022-01-20T14:35:07-08:00 New Revision: c95afac89e000b65edc51dc7d05610250a62c86f URL: https://github.com/llvm/llvm-project/commit/c95afac89e000b65edc51dc7d05610250a62c86f DIFF: https://github.com/llvm/llvm-project/commit/c95afac89e000b65edc51dc7d05610250a62c86f.diff LOG:

[PATCH] D101070: Make `llvm_install_symlink` robust with respect to absolute dirs.

Ericson2314 updated this revision to Diff 401784. Ericson2314 added a comment. Much simpler now Code taken from D99484 and then to D117419 and now to here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 39f779a - [clang-tidy][NFC] Remove redundant string creation for comparison

Author: Nathan James Date: 2022-01-20T22:20:10Z New Revision: 39f779afb35420c51e2c7094b2643a53baed9f59 URL: https://github.com/llvm/llvm-project/commit/39f779afb35420c51e2c7094b2643a53baed9f59 DIFF: https://github.com/llvm/llvm-project/commit/39f779afb35420c51e2c7094b2643a53baed9f59.diff LOG:

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, kiranchandramohan, peixin, clementval, Leporacanthicus, kiranktp, AMDChirag, fghanim, jdenny, MatsPetersson, ftynse. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota,

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

Quuxplusone added a comment. What ever happened to this patch? @fanfuqiang, are you still around to rebase this? Do you need someone to commit it for you? (Not that I'm saying I think it's perfect as is — I haven't looked and don't know the code that well — but just wondering what kept this

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I should mention - according to https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` already exists, which I don't think is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117181/new/ https://reviews.llvm.org/D117181

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 updated this revision to Diff 401766. jhuber6 added a comment. Changing to use '-fvisibility=protected' when we construct the job. This is much more transparent and leaves the option open for the user to override it if they need default visibility. Repository: rG LLVM Github

[libunwind] 4af1127 - [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm

Author: John Ericson Date: 2022-01-20T21:18:42Z New Revision: 4af11272f57a4a6fed2932e9e0857b2c1a707c51 URL: https://github.com/llvm/llvm-project/commit/4af11272f57a4a6fed2932e9e0857b2c1a707c51 DIFF: https://github.com/llvm/llvm-project/commit/4af11272f57a4a6fed2932e9e0857b2c1a707c51.diff LOG:

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112906/new/ https://reviews.llvm.org/D112906

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna added a comment. In D117137#3259276 , @yaxunl wrote: > The title says `--offline` option, which should be `--offload`. Fixed that and addressed the other comments. The last patch also adds a check to error out if --offload is used in CUDA

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 401760. dcastagna marked 2 inline comments as done. dcastagna added a comment. Address yaxunl@ comment in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 401759. dcastagna marked an inline comment as done. dcastagna retitled this revision from "[Driver] Add CUDA support for --offline param" to "[Driver] Add CUDA support for --offload param". dcastagna added a comment. Address tra@ and yaxunl@ comments.

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

brunodf added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:14583 if (Second && Second->getObjectKind() == OK_ObjCProperty) { ExprResult Result = SemaRef.CheckPlaceholderExpr(Second); rjmccall wrote: > rnk wrote: > > This is also pseudo

[PATCH] D112986: [Clang][RISCV] Restrict rvv builtin-s with zve macro-s

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:149 RV64 = 1 << 5, + VectorMaxELen32 = 1 << 6, + VectorMaxELen64 = 1 << 7, Do we need VectorMaxELen32 isn't that the minimum? Comment at:

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jdoerfert added inline comments. Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif jhuber6 wrote: > jdoerfert wrote: > > What happened here? > That was a special case I added that was only necessary when we were trying >

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman created this revision. dgoldman added a reviewer: sammccall. dgoldman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the Framework name was only set if the file came from a header mapped framework; now we'll always

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401746. dgoldman added a comment. Split up HeaderSearch change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, these are lowered to the llvm.vector.reduce.add/mul intrinsic calls.

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jhuber6 added inline comments. Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif jdoerfert wrote: > What happened here? That was a special case I added that was only necessary when we were trying to remove things from

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

jdoerfert added a comment. Does this still work with AMDGPU as we need it to? Comment at: clang/test/OpenMP/declare_target_codegen.cpp:293 -}; -int SS::SSS = 1; #endif What happened here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:57-60 if (const auto *FuncDecl = CExpr->getDirectCallee()) { if (FuncDecl->getDeclName().isIdentifier() && - FuncDecl->getName() ==

[PATCH] D117769: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG82452be5cbd7: [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 82452be - [clang-format] Refactor: add FormatToken::hasWhitespaceBefore(). NFC.

Author: Marek Kurdej Date: 2022-01-20T21:16:17+01:00 New Revision: 82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6 URL: https://github.com/llvm/llvm-project/commit/82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6 DIFF: https://github.com/llvm/llvm-project/commit/82452be5cbd7fb48e36dd4f7b2b7eaf598d34bd6.diff

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3259305 , @dblaikie wrote: >> According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has >> a configure to use -gz=zlib) > > Could you link to the queries you used to validate this? I'd be curious to

[PATCH] D117806: [OpenMP] Change default visibility to protected for device declarations

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117806/new/ https://reviews.llvm.org/D117806

[clang] 8b4fa2c - clang: Auto-cleanup left-over file from before 3da69fb5a26c7b on bots

Author: Nico Weber Date: 2022-01-20T14:59:30-05:00 New Revision: 8b4fa2c98e07997469f53bee30c0d24a61dc7c8c URL: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c DIFF: https://github.com/llvm/llvm-project/commit/8b4fa2c98e07997469f53bee30c0d24a61dc7c8c.diff

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie added a comment. > According to Debian Code Search, no project uses -gz=zlib-gnu (valgrind has a > configure to use -gz=zlib) Could you link to the queries you used to validate this? I'd be curious to take a look around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. > ! In D7982#325 , @carlosgalvezp > wrote: > I need to familiarize myself better with the `Loc` manipulation > code to be able to review the free-standing function but otherwise > looks reasonable. The "clang

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/DuplicateIncludeCheck.cpp:64 +SrcMgr::CharacteristicKind FileType) { + if (!SM.isInMainFile(HashLoc)) { +return; carlosgalvezp wrote: > I'm not familiar with

[PATCH] D117137: [Driver] Add CUDA support for --offline param

yaxunl added a comment. The title says `--offline` option, which should be `--offload`. Comment at: clang/include/clang/Driver/Options.td:1142 def offload_EQ : CommaJoined<["--"], "offload=">, Flags<[NoXarchOption]>, - HelpText<"Specify comma-separated list of offloading

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added a comment. In D117569#3258307 , @zahiraam wrote: > In D117569#3257121 , @majnemer > wrote: > >> I have a question regarding how this work with respect to the dllimport >> semantics known by the

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis added a comment. Any other comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117791/new/ https://reviews.llvm.org/D117791

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

craig.topper added a comment. In D117791#3258785 , @RKSimon wrote: > In D117791#3258602 , @craig.topper > wrote: > >> Just to confirm since I can't see the test CHECK lines. >> builtin_elementwise_abs is not

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3255414 , @aaron.ballman wrote: > LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you > need someone to commit on your behalf? If so, what name and email address > would you like

[PATCH] D117806: [OpenMP] Remove overriding visibility for device declarations

jhuber6 updated this revision to Diff 401716. jhuber6 added a comment. Changing to use default `protected` instead of passing `-Bsymbolic` this should be more portable and make the intentions clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117799: [clang][NFC] Small mangler cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rG493c85648401: [clang][NFC] Small mangler cleanups (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 493c856 - [clang][NFC] Small mangler cleanups

Author: Nathan Sidwell Date: 2022-01-20T11:20:15-08:00 New Revision: 493c856484015873737d7c995cac9e34101fb9e9 URL: https://github.com/llvm/llvm-project/commit/493c856484015873737d7c995cac9e34101fb9e9 DIFF:

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. In D111400#3246323 , @cor3ntin wrote: > In D111400#3243826 , @aaron.ballman > wrote: > >> In D111400#3172097 , @cor3ntin >> wrote: >> >>>

[clang] 5fa4cf8 - [Clang] Separate the 'debug-info-hotpatch' test in two parts: one for ARM and another for AArch64

Author: Alexandre Ganea Date: 2022-01-20T14:11:10-05:00 New Revision: 5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc URL: https://github.com/llvm/llvm-project/commit/5fa4cf82dfa075e7983ce92d0042480b7b8f4fbc DIFF:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:135 +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names that may be +// used as

[libunwind] df31ff1 - [cmake] Make include(GNUInstallDirs) always below project(..)

Author: John Ericson Date: 2022-01-20T18:59:17Z New Revision: df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 URL: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 DIFF: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4.diff LOG:

[PATCH] D117232: [clang] Improve -Wdeclaration-after-statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc65186c89f35: [clang] Improve -Wdeclaration-after-statement (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c65186c - [clang] Improve -Wdeclaration-after-statement

Author: Marco Elver Date: 2022-01-20T19:56:34+01:00 New Revision: c65186c89f35b7b599c41183def666a2bde62ddd URL: https://github.com/llvm/llvm-project/commit/c65186c89f35b7b599c41183def666a2bde62ddd DIFF: https://github.com/llvm/llvm-project/commit/c65186c89f35b7b599c41183def666a2bde62ddd.diff

[PATCH] D117137: [Driver] Add CUDA support for --offline param

tra added a comment. LGTM in general, modulo few nits. Nit: looks like the changes need some clang-formatting. Comment at: clang/lib/Driver/Driver.cpp:112 default: - D.Diag(diag::err_drv_only_one_offload_target_supported_in) << "HIP"; +

  1   2   3   >