[PATCH] D118322: [clangd] Fix a selection tree crash for unmatched-bracket code.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Thans @khchen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117989/new/ https://reviews.llvm.org/D117989

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:747 // Could not implement Zve* extension and the V extension at the same time. - if (HasZve32x && HasV) + if (HasZve && HasV) return createStringError( craig.topper

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan updated this revision to Diff 403503. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118225/new/ https://reviews.llvm.org/D118225 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. `rg 'clang_cc1.*fexperimental-new-pass-manager' -l => 41` I think the CC1 option can be removed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new/ https://reviews.llvm.org/D118313

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. In D118313#3274709 , @aeubanks wrote: > can we also remove the -cc1 option? Some tests will fail if `-DLLVM_ENABLE_NEW_PASS_MANAGER=off` is specified. But I see 5 tests have failed with `-DLLVM_ENABLE_NEW_PASS_MANAGER=off`, so

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

aeubanks added a comment. can we also remove the -cc1 option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new/ https://reviews.llvm.org/D118313 ___ cfe-commits mailing list

[clang] ad39b5b - [NFC] Remove duplicate include

Author: Jim Lin Date: 2022-01-27T13:56:13+08:00 New Revision: ad39b5bc59b0e71c86f8cf290ead2d9dd09e5c3e URL: https://github.com/llvm/llvm-project/commit/ad39b5bc59b0e71c86f8cf290ead2d9dd09e5c3e DIFF: https://github.com/llvm/llvm-project/commit/ad39b5bc59b0e71c86f8cf290ead2d9dd09e5c3e.diff LOG:

[PATCH] D118010: [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check

This revision was automatically updated to reflect the committed changes. Closed by commit rG836950c4e602: [clang-tidy] Fix nested namespaces in `readability-static-definition-in… (authored by Izaron, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 836950c - [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check

Author: Evgeny Shulgin Date: 2022-01-26T21:54:17-07:00 New Revision: 836950c4e602548e47851b66a261472f124994fa URL: https://github.com/llvm/llvm-project/commit/836950c4e602548e47851b66a261472f124994fa DIFF:

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay created this revision. MaskRay added reviewers: aeubanks, ctetreau, nikic. Herald added a subscriber: dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. to give users a final warning that they need to migrate away. They

[clang] ecb5023 - [ObjC] Emit selector load right before msgSend call.

Author: Ahmed Bougacha Date: 2022-01-26T20:52:54-08:00 New Revision: ecb502342cf2b3b4b6dfcd8fe881c596880d1a4a URL: https://github.com/llvm/llvm-project/commit/ecb502342cf2b3b4b6dfcd8fe881c596880d1a4a DIFF:

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito marked an inline comment as done. psigillito added inline comments. Comment at: clang/lib/Format/FormatToken.h:125 +/// Operators that can follow a C variable. +static const std::set C_OperatorsFollowingVar = { +tok::l_square, tok::r_square,

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese created this revision. Bigcheese added reviewers: bruno, dexonsmith, vsapsai. Bigcheese added a project: clang-modules. Bigcheese requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new form of requires called a requires block

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comment. Comment at: clang/test/Headers/Inputs/include/float.h:2 +#pragma once +#define FLOAT_LOCAL_DEF 1

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 403476. jhuber6 added a comment. Forgot to rename file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D116542 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 403468. jhuber6 added a comment. clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116542/new/ https://reviews.llvm.org/D116542 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no prototype">, InGroup< +

[PATCH] D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fcdd685bd02: [CMake][Fuchsia] Drop 32-bit ios runtimes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2fcdd68 - [CMake][Fuchsia] Drop 32-bit ios runtimes

Author: Petr Hosek Date: 2022-01-26T18:57:21-08:00 New Revision: 2fcdd685bd0213b75f45597b970ea9858a3a9d89 URL: https://github.com/llvm/llvm-project/commit/2fcdd685bd0213b75f45597b970ea9858a3a9d89 DIFF: https://github.com/llvm/llvm-project/commit/2fcdd685bd0213b75f45597b970ea9858a3a9d89.diff

[PATCH] D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118306/new/ https://reviews.llvm.org/D118306

[PATCH] D118306: [CMake][Fuchsia] Drop 32-bit ios runtimes

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are no longer supported in the recent Xcode SDK

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. It may not be appropriate to add other runtime libraries specifically for Mac Catalyst. However, currently `lld` does not allow linking with dynamic libraries with different types of build_version_command, whereas `ld64` does allow for Mac Catalyst. Considering

[PATCH] D118223: [NFC] [AST] Move isSame* check in ASTReader to ASTContext

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf85ee6d56a93: [NFC] [AST] Move isSameEntity into ASTContext (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f85ee6d - [NFC] [AST] Move isSameEntity into ASTContext

Author: Chuanqi Xu Date: 2022-01-27T10:30:50+08:00 New Revision: f85ee6d56a9371ccb8b3a63b6f9ed38ba8d071b7 URL: https://github.com/llvm/llvm-project/commit/f85ee6d56a9371ccb8b3a63b6f9ed38ba8d071b7 DIFF: https://github.com/llvm/llvm-project/commit/f85ee6d56a9371ccb8b3a63b6f9ed38ba8d071b7.diff

[PATCH] D118225: [RISCV] Decouple Zve* extensions.

jacquesguan added a comment. In D118225#3272071 , @eopXD wrote: > Not sure if this simplifies things. Users and the compiler can use the macro > `__riscv_v_elen` and `__riscv_v_elen_fp` to do things to the vector-related > target feature. > > Other

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

delcypher added a comment. @bc-lee Thanks for the patch. While I get what you're trying to do I have doubts about being able to accept the patch in its current form. Apple's ASan catalyst doesn't work by building a separate dylib, instead it builds the macosx dylib in a different way to make

[PATCH] D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`

njames93 added a comment. In D117593#3273562 , @aaron.ballman wrote: > Hmmm, this is a rule for checking a specific style guide. > https://google.github.io/styleguide/cppguide.html#Implicit_Conversions > doesn't say that `explicit(false)` is a

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239 +- gcc doesn't pack non-packed non-pod members in packed structs. Clang + historically did perform such packing. Clang now matches the gcc behavior "non-packed" here seems a little

[clang] 9c62728 - Default to DWARFv4 on Windows

Author: David Blaikie Date: 2022-01-26T18:01:07-08:00 New Revision: 9c6272861032f511a23784ce0c5cc8f6ac2f625b URL: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b DIFF: https://github.com/llvm/llvm-project/commit/9c6272861032f511a23784ce0c5cc8f6ac2f625b.diff

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:70 +unsigned AlignLog = (Pointer.getInt() << 3) | ElementType.getInt(); +return CharUnits::fromQuantity(1UL << AlignLog); + } LegalizeAdulthood wrote: > This is causing warnings to

[clang] eee97f1 - [clang] Use proper type to left shift after D117262

Author: Arthur Eubanks Date: 2022-01-26T17:54:37-08:00 New Revision: eee97f1617c94b88e9f0a964c47dc6003173f818 URL: https://github.com/llvm/llvm-project/commit/eee97f1617c94b88e9f0a964c47dc6003173f818 DIFF:

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

LegalizeAdulthood added inline comments. Comment at: clang/lib/CodeGen/Address.h:70 +unsigned AlignLog = (Pointer.getInt() << 3) | ElementType.getInt(); +return CharUnits::fromQuantity(1UL << AlignLog); + } This is causing warnings to be emitted: ```

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. I didn't find any mention of Darwin in RecordLayoutBuilder, which surprised me - I thought maybe Darwin was using the ClangABICompat to express its ABI compatibility requirements (which would sort of be handy rather than having to test multiple target features, for

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie updated this revision to Diff 403449. dblaikie added a comment. Herald added a subscriber: dexonsmith. Relnotes Opt out PS4 and Darwin Add support for -fclang-abi-compat=13 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. Can you rebase this? I cannot apply this patch on current main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114413/new/ https://reviews.llvm.org/D114413 ___ cfe-commits

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

nickdesaulniers added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:788 +else if (NumOutputs == 0) + Diag(Loc, diag::warn_asm_volatile); + } `Loc` is not correct if `volatile` is not the first asm-qualifier. Repository: rG LLVM

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

nickdesaulniers created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, sunfish, simoncook, johnrusso, rbar, asb,

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. @morehouse should be fixed in 98fa46f870e4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809

[clang] 98fa46f - [FIX][clang] Fix unused private field in ExtractAPIVisitor

Author: Zixu Wang Date: 2022-01-26T16:24:04-08:00 New Revision: 98fa46f870e402f225b60ab5d02487c36d79632b URL: https://github.com/llvm/llvm-project/commit/98fa46f870e402f225b60ab5d02487c36d79632b DIFF: https://github.com/llvm/llvm-project/commit/98fa46f870e402f225b60ab5d02487c36d79632b.diff

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. On it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117809/new/ https://reviews.llvm.org/D117809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna added a comment. @yaxunl Are you OK landing this change as it is, without the check for OS and environment in getHIPOffloadTargetTriple? We can follow up with patch that adds checks for in OS and environment in Triple.cpp. Is that what you meant? Repository: rG LLVM Github

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:163 def run_tidy(args, tmpdir, build_path, queue, lock, failed_files): """Takes filenames out of queue and runs clang-tidy on them.""" LegalizeAdulthood

[PATCH] D116543: [OpenMP] Embed device files into the host IR

jhuber6 updated this revision to Diff 403413. jhuber6 added a comment. Updating after changing flag in D116542 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116543/new/ https://reviews.llvm.org/D116543 Files:

[PATCH] D117137: [Driver] Add CUDA support for --offload param

yaxunl added a comment. In D117137#3273330 , @tra wrote: > In D117137#3269365 , @yaxunl wrote: > >> Does that mean only "spirv{64}-unknown-unknown" is acceptable, or >> "spirv{64}-amd-unknown-unknown" is also

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 added inline comments. Comment at: llvm/lib/Bitcode/Writer/CMakeLists.txt:14 MC + TransformUtils Object I'm not sure if it's worth linking TransformUtils just for `appendToCompilerUsed` I can copy the implementation locally if not. Repository:

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 403404. jhuber6 added a comment. Herald added a subscriber: mgorny. Updating approach, use a vector of string pairs now. Multiple files are simply passed multiple times. Will add filename to the offloading section name laterf, as similar sections could be

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of this change to also point to >>

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3273761 , @stella.stamenova wrote: > Can we update the lldb instructions as part of this change to also point to > VS2019? Alternatively, I can send a separate change for that. I'll add it to this patch - are people

[PATCH] D117809: [clang] Add an extract-api driver option

morehouse added inline comments. Comment at: clang/lib/Frontend/ExtractAPIConsumer.cpp:20 +private: + ASTContext *Context; +}; `ASTContext *Context` is unused, and causing buildbot failures: https://lab.llvm.org/buildbot/#/builders/77/builds/13645 ```

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:163 def run_tidy(args, tmpdir, build_path, queue, lock, failed_files): """Takes filenames out of queue and runs clang-tidy on them.""" Am I missing

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added a comment. Can we update the lldb instructions as part of this change to also point to VS2019? Alternatively, I can send a separate change for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/

[clang] 6bc20eb - [cc1as] Remove -Wa, --compress-debug-sections=zlib-gnu

Author: Fangrui Song Date: 2022-01-26T13:28:51-08:00 New Revision: 6bc20eb13470514c67e9ee5bbd515c2197ce8ea8 URL: https://github.com/llvm/llvm-project/commit/6bc20eb13470514c67e9ee5bbd515c2197ce8ea8 DIFF: https://github.com/llvm/llvm-project/commit/6bc20eb13470514c67e9ee5bbd515c2197ce8ea8.diff

[PATCH] D118010: [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check

Izaron added a comment. In D118010#3273716 , @LegalizeAdulthood wrote: > If there is an open github issue on this, please put "Fixes #" in the > commit description before pushing. Thanks! I didn't file a github issue. Just searched on github - no

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

This revision was automatically updated to reflect the committed changes. Closed by commit rG35d15222c05d: [Driver] Remove obsoleted -gz=zlib-gnu (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D117744?vs=401498=403395#toc Repository: rG LLVM Github Monorepo

[clang] 35d1522 - [Driver] Remove obsoleted -gz=zlib-gnu

Author: Fangrui Song Date: 2022-01-26T13:26:51-08:00 New Revision: 35d15222c05d3409076e170e4851fd3d58a64e35 URL: https://github.com/llvm/llvm-project/commit/35d15222c05d3409076e170e4851fd3d58a64e35 DIFF: https://github.com/llvm/llvm-project/commit/35d15222c05d3409076e170e4851fd3d58a64e35.diff

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D56303#3273694 , @LegalizeAdulthood wrote: > In D56303#3272711 , @aaron.ballman > wrote: >

[PATCH] D118010: [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check

LegalizeAdulthood added a comment. If there is an open github issue on this, please put "Fixes #" in the commit description before pushing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118010/new/ https://reviews.llvm.org/D118010

[PATCH] D118010: [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118010/new/ https://reviews.llvm.org/D118010

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

LegalizeAdulthood updated this revision to Diff 403390. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56303/new/ https://reviews.llvm.org/D56303 Files:

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

LegalizeAdulthood added a comment. In D56303#3272711 , @aaron.ballman wrote: > The rule of thumb is: if you have significant NFC changes, > do them first and push the changes (often doesn't even > require a review because it's NFC, but that depends on >

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 403386. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index:

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:389-390 +- Test your check under both Windows and Linux environments. +- Watch out for high false positive rates; ideally

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

curdeius added a comment. Haha, and I want to have a few things fixed before release 14! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118220/new/ https://reviews.llvm.org/D118220 ___ cfe-commits

[PATCH] D117593: [clang-tidy] Change google-explicit-constructor to ignore conversions and operators marked `explicit(false)`

aaron.ballman added a comment. Hmmm, this is a rule for checking a specific style guide. https://google.github.io/styleguide/cppguide.html#Implicit_Conversions doesn't say that `explicit(false)` is a reasonable marking. In fact, it says "Implicit conversions can sometimes be necessary and

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

MyDeveloperDay added a comment. In D118220#3273416 , @HazardyKnusperkeks wrote: > You guys have an enormous speed currently. I'm just trying to keep up with @curdeius, but my real work keeps getting in the way, but I'm loving the momentum and trying

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3273521 , @dblaikie wrote: > In D117744#3273481 , @MaskRay wrote: > >> In D117744#3273463 , @dblaikie >> wrote: >> >>> I don't

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 403370. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie added a comment. In D117744#3273481 , @MaskRay wrote: > In D117744#3273463 , @dblaikie > wrote: > >> I don't especially feel that removing low-cost features like this is a great >> idea (the benefit to

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. In D117744#3273463 , @dblaikie wrote: > I don't especially feel that removing low-cost features like this is a great > idea (the benefit to cleaning up a small amount of code compared to the > (albeit small) risk of breaking

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I don't especially feel that removing low-cost features like this is a great idea (the benefit to cleaning up a small amount of code compared to the (albeit small) risk of breaking users

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 403361. dgoldman marked an inline comment as done. dgoldman added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[clang] 6a953d9 - [clang] Fix -Wsubobject-linkage after D117262

Author: Arthur Eubanks Date: 2022-01-26T11:43:44-08:00 New Revision: 6a953d931c4de6f4b5bdc5466d15da62ede00b95 URL: https://github.com/llvm/llvm-project/commit/6a953d931c4de6f4b5bdc5466d15da62ede00b95 DIFF:

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 403354. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D118220: [clang-format] Correctly format lambdas with variadic template parameters.

HazardyKnusperkeks added a comment. You guys have an enormous speed currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118220/new/ https://reviews.llvm.org/D118220 ___ cfe-commits mailing list

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

tra added a comment. In D118084#3272154 , @lebedev.ri wrote: > My last idea was about allowing splitting > > struct { > int a; > int b[2]; > } a; > > into > > // not in a struct anymore! > int a; > int b[2] This looks like it's a

[PATCH] D116753: Default to -fno-math-errno for musl too

MaskRay accepted this revision. MaskRay added a comment. Looks great! Thanks for telling me that GCC `overloads -fno-math-errno to mean that malloc does not set errno`. This looks really scary. Clang doesn't have the problem:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117809: [clang] Add an extract-api driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1d946cbf780: [clang] Add an extract-api driver option (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b1d946c - [clang] Add an extract-api driver option

Author: Zixu Wang Date: 2022-01-26T11:31:12-08:00 New Revision: b1d946cbf780f1769b3a3a39ce68e462a181869e URL: https://github.com/llvm/llvm-project/commit/b1d946cbf780f1769b3a3a39ce68e462a181869e DIFF: https://github.com/llvm/llvm-project/commit/b1d946cbf780f1769b3a3a39ce68e462a181869e.diff

[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Driver.h:45 +class Command; +class Compilation; +class JobList; JonChesterfield wrote: > This looks like it should be a breaking change - InputInfo is no longer > forward declared. Would it

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building. dgoldman wrote: > cishida

[PATCH] D117137: [Driver] Add CUDA support for --offload param

tra added a comment. In D117137#3269365 , @yaxunl wrote: > Does that mean only "spirv{64}-unknown-unknown" is acceptable, or > "spirv{64}-amd-unknown-unknown" is also acceptable? My point is that `unknown` part of the triple is a catch-all for

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1043 // If this file is found in a header map and uses the framework style of // includes, then this header is part of a framework we're building.

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman updated this revision to Diff 403340. dgoldman added a comment. Update comment + run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117830/new/ https://reviews.llvm.org/D117830 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D117600: [CGCall] Annotate operator new with inaccessiblememonly if AssumeSaneOperatorNew is on

xbolva00 added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117600/new/ https://reviews.llvm.org/D117600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117600: [CGCall] Annotate operator new with inaccessiblememonly if AssumeSaneOperatorNew is on

Bryce-MW added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2071 RetAttrs.addAttribute(llvm::Attribute::NoAlias); + FuncAttrs.addAttribute("inaccessiblememonly"); +} nikic wrote: > This should be

[PATCH] D117600: [CGCall] Annotate operator new with inaccessiblememonly if AssumeSaneOperatorNew is on

Bryce-MW updated this revision to Diff 403339. Bryce-MW marked an inline comment as done. Bryce-MW added a comment. - Use proper attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117600/new/ https://reviews.llvm.org/D117600 Files:

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117939: [clang-tidy] Add more documentation about check development

ymandel added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:362 +Private custom matchers are a good example of auxiliary support code for your check +that is best tested with a unit test. It will be easier to test your matchers or +other

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1613f05ae0c: [NFC] Store Addresss alignment into PointerIntPairs (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b1613f0 - [NFC] Store Address's alignment into PointerIntPairs

Author: Arthur Eubanks Date: 2022-01-26T10:35:28-08:00 New Revision: b1613f05ae0ce4efc6b6475ea4459957ebcb0150 URL: https://github.com/llvm/llvm-project/commit/b1613f05ae0ce4efc6b6475ea4459957ebcb0150 DIFF:

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 403331. ashwin98 added a comment. Made changes to handle lint issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117929/new/ https://reviews.llvm.org/D117929 Files: clang/lib/Driver/XRayArgs.cpp

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

rnk accepted this revision. rnk added a comment. lgtm BTW, as a follow-on cleanup, which I may attempt, I think we could convert this alignment from CharUnits to llvm::Align. The vast majority of the `getAlignment` callers feed it to CGBuilder::CreateAlignedLoad/Store:

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:279 + /// List of file passed with -fembed-offload-binary option to embed + /// device-side offloading binaries in the host object file. JonChesterfield wrote: > This is

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4934 assert(Old->hasOneUse() && "llvm.embedded.module can only be used once in llvm.compiler.used"); GV->takeName(Old); here's an assert that this

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a subscriber: Xiangling_L. dblaikie added a comment. @Xiangling_L - I see you made an ABI change for AIX in rG05ad8e942996f36cc694478542ccd84aa5bbb80f - any idea if this new ABI break/fix is relevant to AIX?

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4891 GlobalVariable *Used = collectUsedGlobalVariables(M, UsedGlobals, true); for (auto *GV : UsedGlobals) { if (GV->getName() != "llvm.embedded.module" &&

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. I don't think this works for multiple files. The test only tries one and misses all the parsing handling. Comment at:

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG from my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117262/new/ https://reviews.llvm.org/D117262

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:29 +// so we fallback to storing the alignment separately. +template = 8> class AddressImpl {}; + nikic wrote: > Why do we need the extra T parameter? without it we end up instantiating

  1   2   >