[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

poelmanc added a comment. Sorry I somehow missed the acceptance back on 10 Jan. I lack commit access, it would be great if you could push for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97625/new/ https://reviews.llvm.org/D97625

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

expnkx reopened this revision. expnkx added a comment. This revision is now accepted and ready to land. This patch is simply wrong. cqwrteur@Home-Server:~/fast_io_cleanup/fast_io/examples/0001.helloworld$ clang++ -o helloworld helloworld.cc -Ofast -std=c++2b -s -flto -fuse-ld=lld

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

jyknight added a comment. Should be fixed by rGcaa1ebde70673ddb7124a0599ba846362a1f8b1e . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/

[clang] caa1ebd - Don't assume that a new cleanup was added to InnermostEHScope.

Author: James Y Knight Date: 2022-02-04T23:39:42-05:00 New Revision: caa1ebde70673ddb7124a0599ba846362a1f8b1e URL: https://github.com/llvm/llvm-project/commit/caa1ebde70673ddb7124a0599ba846362a1f8b1e DIFF:

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie added a comment. In D119051#3298491 , @dblaikie wrote: > Test case showing GCC's behavior here: https://godbolt.org/z/4W7j8Yd54 Oh, and demonstrating this applies (as best as I can figure) even when compiling in C++03 mode:

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie added a comment. Test case showing GCC's behavior here: https://godbolt.org/z/4W7j8Yd54 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. Hmm, I guess it might be the C++11 definition, as suggested - since a base class (even a public one) seems to classify the type as "non pod" as far as GCC is concerned ( In D117616#3298001 , @dblaikie wrote: > In

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie created this revision. dblaikie added reviewers: rsmith, Bhramar.vatsa, rjmccall, rnk. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119051 Files:

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

jyknight added a comment. Found the problem, tweaking a test-case; will commit shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D113620 ___ cfe-commits mailing

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

This revision was automatically updated to reflect the committed changes. Closed by commit rG38449c98f3d3: [Driver] Default to -fno-math-errno for musl (authored by alxu, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 38449c9 - [Driver] Default to -fno-math-errno for musl

Author: Alex Xu (Hello71) Date: 2022-02-04T19:20:30-08:00 New Revision: 38449c98f3d33dffdaf7e1feeb9dfdcf63b5126b URL: https://github.com/llvm/llvm-project/commit/38449c98f3d33dffdaf7e1feeb9dfdcf63b5126b DIFF:

[PATCH] D118965: [OpenMP] Add search path for llvm-strip

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea4aed50a9f: [OpenMP] Add search path for llvm-strip (authored by kkwli0). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8ea4aed - [OpenMP] Add search path for llvm-strip

Author: Kelvin Li Date: 2022-02-04T22:15:14-05:00 New Revision: 8ea4aed50a9f84d9617219ccc936c005c5f31c24 URL: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24 DIFF: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24.diff

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

MaskRay added a comment. I am testing check-clang-driver and will cherry pick this into release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753 ___

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

alxu added a comment. In D116753#3298299 , @pirama wrote: > @alxu Just realized you don't have commit access. Do you want one of us to > merge this? Yes, I forgot about this patch. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 280716e - [OpenMP] Change amdgcn to amdgpu in device library handling

Author: Joseph Huber Date: 2022-02-04T20:51:05-05:00 New Revision: 280716e75f76820f1c8b7c13812c96237dc4bcc5 URL: https://github.com/llvm/llvm-project/commit/280716e75f76820f1c8b7c13812c96237dc4bcc5 DIFF: https://github.com/llvm/llvm-project/commit/280716e75f76820f1c8b7c13812c96237dc4bcc5.diff

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; yaxunl wrote: > tra wrote: > > When will it ever be set to `none`?

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#3298184 , @void wrote: > In D59254#1792134 , @connorkuehl > wrote: > >> In D59254#1792068 , @xbolva00 wrote: >> >>> Re-ping >> >>

[PATCH] D119045: Fix address space for function types with AS qualifier

eandrews created this revision. eandrews added reviewers: rjmccall, dylanmckay, bader. eandrews requested review of this revision. This patch fixes a bug introduced in commit 4eaf5846d0e7 - https://reviews.llvm.org/D111566

[PATCH] D116753: [Driver] Default to -fno-math-errno for musl too

pirama added a comment. @alxu Just realized you don't have commit access. Do you want one of us to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116753/new/ https://reviews.llvm.org/D116753

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

tstellar added a comment. @yaxunl This looks good to me, you can go ahead and cherry-pick it directly to release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

yaxunl added a subscriber: tstellar. yaxunl added a comment. In D118876#3295958 , @linjamaki wrote: > Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the > LLVM 14 release branch too, if possible? Sure. @tstellar What is the

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; tra wrote: > When will it ever be set to `none`? Does the new

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

probinson added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:654 + while (!L.LexFromRawLexer(T)) { +ASSERT_TRUE(!ToksView.empty()); +EXPECT_EQ(T.getKind(), ToksView.front().getKind()); @kadircet @sammccall It turns out this while

[clang-tools-extra] fb7ddd0 - Revert "[clangd] Properly compute framework-style include spelling"

Author: David Goldman Date: 2022-02-04T18:02:32-05:00 New Revision: fb7ddd0628f4894f9d14a2d1f84830607c5f946e URL: https://github.com/llvm/llvm-project/commit/fb7ddd0628f4894f9d14a2d1f84830607c5f946e DIFF: https://github.com/llvm/llvm-project/commit/fb7ddd0628f4894f9d14a2d1f84830607c5f946e.diff

[PATCH] D59254: [RFC] Implementation of Clang randstruct

void added subscribers: kees, void. void added a comment. Herald added a subscriber: dang. In D59254#1792134 , @connorkuehl wrote: > In D59254#1792068 , @xbolva00 wrote: > >> Re-ping > > Still under development

[clang-tools-extra] 6abb70c - Attempt forward fix after 4dfd113

Author: David Goldman Date: 2022-02-04T17:47:38-05:00 New Revision: 6abb70c2d00812350153f4299a2491fdc3810ac3 URL: https://github.com/llvm/llvm-project/commit/6abb70c2d00812350153f4299a2491fdc3810ac3 DIFF: https://github.com/llvm/llvm-project/commit/6abb70c2d00812350153f4299a2491fdc3810ac3.diff

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson added a comment. By "the EXPECT_EQ was never executed" I mean, replacing it with `assert(false);` does not crash the test. The string `"a::b::Foo"` was never seen by the Visitor. Maybe this indicates some much more subtle, deeper problem; I don't know. This change does cause the

[PATCH] D119040: Fix LookupTest where it was missing an assertion

probinson created this revision. probinson added a reviewer: ioeric. probinson requested review of this revision. The preceding EXPECT_EQ was never executed; modifying the test input made that happen. Found by the Rotten Green Tests project. https://reviews.llvm.org/D119040 Files:

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

schweitz accepted this revision. schweitz added a comment. This revision is now accepted and ready to land. LGTM Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class

[PATCH] D113319: [clang-format] Improve require and concept handling

curdeius added a comment. Woow, that's a mountain of work! All my comments are non-blocking. Comment at: clang/docs/ClangFormatStyleOptions.rst:1992 +**BreakBeforeConceptDeclarations** (``BreakBeforeConceptDeclarationsStyle``) :versionbadge:`clang-format 13` + The style

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting updated this revision to Diff 406101. Herald added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting added a comment. In D118070#3297956 , @thakis wrote: > I think the setup matches what we have in clang, right? Yes, I think so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

pkasting marked an inline comment as done. pkasting added a comment. In D118070#3289222 , @ychen wrote: > Thanks for doing this! Update the release note? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

ldionne added a comment. @rsmith Thanks a bunch! And thanks @sepavloff for trying out this approach too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 ___

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 406099. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[clang] 5966c2e - [OpenMP] Fix mismatched device runtime name

Author: Joseph Huber Date: 2022-02-04T16:54:31-05:00 New Revision: 5966c2ec026c7953a86dd849b13a98589ed10e9c URL: https://github.com/llvm/llvm-project/commit/5966c2ec026c7953a86dd849b13a98589ed10e9c DIFF: https://github.com/llvm/llvm-project/commit/5966c2ec026c7953a86dd849b13a98589ed10e9c.diff

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dfd11324eb0: [clangd] Properly compute framework-style include spelling (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/

[clang-tools-extra] 4dfd113 - [clangd] Properly compute framework-style include spelling

Author: David Goldman Date: 2022-02-04T16:40:56-05:00 New Revision: 4dfd11324eb05d167392958c0f0f273cae6386c6 URL: https://github.com/llvm/llvm-project/commit/4dfd11324eb05d167392958c0f0f273cae6386c6 DIFF: https://github.com/llvm/llvm-project/commit/4dfd11324eb05d167392958c0f0f273cae6386c6.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

steffenlarsen updated this revision to Diff 406094. steffenlarsen added a comment. Added missing `isVariadicExprArgument` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/docs/ReleaseNotes.rst

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added a comment. In D117616#3295859 , @Bhramar.vatsa wrote: > @dblaikie > The condition `FieldClass->isPOD()` returns false for the following case > (when considering field 'struct foo t' of 'struct foo1') : > > class foo { > foo() =

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis added a comment. > @pkasting Note, this patch makes the outcome non-deterministic when the > auto-detection kicks in. We are stamping the command-line the .PDB file, see > https://github.com/llvm/llvm-project/blob/main/lld/COFF/PDB.cpp#L1402 - and > some live-code-patching tools rely

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef

[clang] be3d811 - Rename this file to fix the typo in its name; NFC

Author: Aaron Ballman Date: 2022-02-04T15:59:59-05:00 New Revision: be3d811e2c21c864694ce73cb5c2878c3ea0bd68 URL: https://github.com/llvm/llvm-project/commit/be3d811e2c21c864694ce73cb5c2878c3ea0bd68 DIFF: https://github.com/llvm/llvm-project/commit/be3d811e2c21c864694ce73cb5c2878c3ea0bd68.diff

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406086. ZarkoCA added a comment. - Moved AIX check to its own function to hopefully avoid Arg and ArgTy getting out of sync - Rebased and removed LIT test cases workaround Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 406081. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D118744: [clang] Don't cache function type after clearing clang->llvm type cache

aeubanks updated this revision to Diff 406077. aeubanks added a comment. fix more issues, ready to review I've split the OpenCL change out into D119011 , will rebase once that's submitted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297833 , @jdoerfert wrote: > In D116637#3297790 , > @tianshilei1992 wrote: > >> In D116637#3297785 , @kda wrote: >> >>> This

[clang] 0d54457 - [IntrospectionTest] Replace "return" with "GTEST_SKIP"

Author: Paul Robinson Date: 2022-02-04T12:35:44-08:00 New Revision: 0d54457f8aed169dff8a668059979a2646afc3fc URL: https://github.com/llvm/llvm-project/commit/0d54457f8aed169dff8a668059979a2646afc3fc DIFF: https://github.com/llvm/llvm-project/commit/0d54457f8aed169dff8a668059979a2646afc3fc.diff

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

jdoerfert added a comment. In D116637#3297790 , @tianshilei1992 wrote: > In D116637#3297785 , @kda wrote: > >> This still seems to be breaking sanitizers fast: >>

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297785 , @kda wrote: > This still seems to be breaking sanitizers fast: > https://lab.llvm.org/buildbot/#/builders/5/builds/18563 > > To reproduce these results: >

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

kda added a comment. This still seems to be breaking sanitizers fast: https://lab.llvm.org/buildbot/#/builders/5/builds/18563 To reproduce these results: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] eeb29c8 - [OpenMP] Add -Bsymbolic to arguments for GNU linker

Author: Joseph Huber Date: 2022-02-04T15:13:32-05:00 New Revision: eeb29c8477d96ad821b3283dad8ed060a3426118 URL: https://github.com/llvm/llvm-project/commit/eeb29c8477d96ad821b3283dad8ed060a3426118 DIFF: https://github.com/llvm/llvm-project/commit/eeb29c8477d96ad821b3283dad8ed060a3426118.diff

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

This revision was automatically updated to reflect the committed changes. Closed by commit rGeeb29c8477d9: [OpenMP] Add -Bsymbolic to arguments for GNU linker (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:575 +// times 100. +if (getTarget().getTargetOpts().CodeObjectVersion != "none") { + unsigned CodeObjVer; When will it ever be set to `none`? Does the new option parser

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

owenpan added a comment. In D118969#3297699 , @HazardyKnusperkeks wrote: > Ah because of a race condition, I couldn't accept anymore. :) Sorry! I should have waited a little longer. :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b8ec430 - [Clang][Sema][OpenMP] Fix uninitialized variable Op

Author: Shilei Tian Date: 2022-02-04T15:00:43-05:00 New Revision: b8ec430de71766d9a35a6b737c8a789c0c7cf812 URL: https://github.com/llvm/llvm-project/commit/b8ec430de71766d9a35a6b737c8a789c0c7cf812 DIFF: https://github.com/llvm/llvm-project/commit/b8ec430de71766d9a35a6b737c8a789c0c7cf812.diff

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. Ah because of a race condition, I couldn't accept anymore. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

HazardyKnusperkeks added a comment. LGTM, since when can't I post an empty comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118969/new/ https://reviews.llvm.org/D118969 ___ cfe-commits mailing

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Format notes updated on local commit. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses** (``RequiresClausePositionStyle``)

[PATCH] D118969: [clang-format][NFC] Fix a bug in setting type FunctionLBrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35f7dd601d33: [clang-format][NFC] Fix a bug in setting type FunctionLBrace (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 35f7dd6 - [clang-format][NFC] Fix a bug in setting type FunctionLBrace

Author: Owen Pan Date: 2022-02-04T11:36:30-08:00 New Revision: 35f7dd601d33219fafa2c0d308e187df3e36847a URL: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a DIFF: https://github.com/llvm/llvm-project/commit/35f7dd601d33219fafa2c0d308e187df3e36847a.diff

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: dang, kerbowa, t-tye, tpr, dstuttard, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. code object version determines ABI, therefore should not be mixed.

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 406048. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. This took a lot of work and debugging. I tried to minimize the refactoring on related code

[clang] 56d46b3 - [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Author: Devin Jeanpierre Date: 2022-02-04T20:17:34+01:00 New Revision: 56d46b36fc231a0beb518602503035bba92043e0 URL: https://github.com/llvm/llvm-project/commit/56d46b36fc231a0beb518602503035bba92043e0 DIFF:

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56d46b36fc23: [clang] roll-forward [clang] Mark `trivial_abi` types as trivially… (authored by devin.jeanpierre, committed by gribozavr).

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added a comment. Thanks for working on this! I love to see better `requires` support in clang-format. I didn't do a real review, just some drive-by comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3399 +**RequiresClausePositionForClasses**

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 15 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3130-3136 + /// \brief The position of the ``requires`` clause for class templates. + /// \version 14 + RequiresClausePositionStyle

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:41 +bool isInNoNamespace(const FunctionDecl *FD) { + const DeclContext *DC = FD->getDeclContext(); `isInGlobalNamespace` might be a better name?

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG9385ece95a4a: [HeaderSearch] Track framework name in LookupFile (authored by dgoldman). Changed prior to commit:

[clang] 9385ece - [HeaderSearch] Track framework name in LookupFile

Author: David Goldman Date: 2022-02-04T13:32:39-05:00 New Revision: 9385ece95a4a342ca4f4c46ea747f79d4ede9783 URL: https://github.com/llvm/llvm-project/commit/9385ece95a4a342ca4f4c46ea747f79d4ede9783 DIFF: https://github.com/llvm/llvm-project/commit/9385ece95a4a342ca4f4c46ea747f79d4ede9783.diff

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3297387 , @cmtice wrote: > This commit is causing some of our builds to fail with these errors: > > clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' > [-Werror,-Wunused-variable] > > Expr *D

[clang] 012c811 - [Clang][Sema][OpenMP] Remove unused variables. NFC.

Author: Benjamin Kramer Date: 2022-02-04T19:27:59+01:00 New Revision: 012c811fed44da85f9870df9accf4477e626a012 URL: https://github.com/llvm/llvm-project/commit/012c811fed44da85f9870df9accf4477e626a012 DIFF:

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:5736 +Matcherhttps://clang.llvm.org/doxygen/classclang_1_1VarDecl.html;>VarDeclisInline +Matches function and namespace declarations that are marked with +the inline keyword.

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:5736 +Matcherhttps://clang.llvm.org/doxygen/classclang_1_1VarDecl.html;>VarDeclisInline +Matches function and namespace declarations that are marked with +the inline keyword. >

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added a comment. > They all require PTX 7.0, SM_80. According to https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#half-precision-floating-point-instructions-fma only `fma.relu` and `bf16*` variants require ptx70/sm80: PTX ISA Notes Introduced in PTX ISA version 4.2.

[PATCH] D118900: [ASTMatchers] Expand isInline matcher to VarDecl

Izaron added a comment. Thanks for the matcher! I'm planning to reuse it in my checker (D118743 ). Looking forward to seeing this commit merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118900/new/

[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Izaron abandoned this revision. Izaron added a comment. In D118922#3296542 , @njames93 wrote: > I had the same idea in D118900 Wow! That's a curious coincidence. I'm closing my PR =) Let it be your version as the

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406027. jhuber6 added a comment. More informative error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118927/new/ https://reviews.llvm.org/D118927

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 added a comment. In D119018#3297391 , @JonChesterfield wrote: > Can we drop an xfail in an existing test as part of this patch? We can drop an XFAIL for AMDGPU, but that's not related to the problem this fixes, we don't have any XFAIL lines

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp:251 + if (InsertPos.isValid()) +InvalidFix |= InsertPos.isMacroID(); + else I'm not a fan of using

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

JonChesterfield added a comment. Can we drop an xfail in an existing test as part of this patch? Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581 + + // If we are linking for the device all symbols should be bound locally. + if (JA.isDeviceOffloading(Action::OFK_OpenMP))

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

cmtice added a comment. This commit is causing some of our builds to fail with these errors: clang/lib/Sema/SemaOpenMP.cpp:11372:9: error: unused variable 'D' [-Werror,-Wunused-variable] Expr *D = nullptr; ^ clang/lib/Sema/SemaOpenMP.cpp:11373:9: error: unused variable 'CE'

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks added a comment. In D119011#3297305 , @Anastasia wrote: > Just to understand the intent - is this a performance optimization or > functionality fix? This is a functionality fix. > Also is there any way to test this? I came across this while

[PATCH] D119011: [clang] Cache OpenCL types

aeubanks updated this revision to Diff 406024. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119011/new/ https://reviews.llvm.org/D119011 Files: clang/lib/CodeGen/CGOpenCLRuntime.cpp

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Approving the delta for the PS4 fix (relying or @rsmith 's approval for the actual patch -- https://reviews.llvm.org/D114732). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 updated this revision to Diff 406022. jhuber6 added a comment. Clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119018/new/ https://reviews.llvm.org/D119018 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3295876 , @JesApp wrote: > In D118104#3294883 , > @LegalizeAdulthood wrote: > >> What is the feasibility of Python unit tests Instead of a heavy-weight `lit` >>

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre created this revision. devin.jeanpierre added a reviewer: gribozavr2. Herald added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Anastasia added a comment. In D118999#3296899 , @azabaznov wrote: > It seems hard to find a direct mention in the spec, but in the API spec: > > //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device > supports independent forward

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

LegalizeAdulthood added a comment. In D118104#3296467 , @salman-javed-nz wrote: > Anyway, I don't want what was a drive-by comment by me baloon into a lot of > extra work for the author, so I will not push for it, unless others really > want it. I

[PATCH] D119011: [clang] Cache OpenCL types

Anastasia added a comment. Just to understand the intent - is this a performance optimization or functionality fix? Also is there any way to test this? Comment at: clang/lib/CodeGen/CGOpenCLRuntime.h:42 llvm::PointerType *SamplerTy; + llvm::StringMap Tys;

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

haowei added a comment. Hi, we are seeing clang Windows build breakages after this change was relanded error message: Assertion failed: isa(Val) && "cast() argument of incompatible type!", file C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include\llvm/Support/Casting.h, line 262 PLEASE submit

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406012. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. remove leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. The core difference of behavior is this, in the logic for setting `canPassInRegisters`: // Clang <= 4 used the pre-C++11 rule, which ignores move operations. // The PS4 platform ABI follows the behavior of Clang 3.2. if (CCK ==

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 406008. tianshilei1992 added a comment. rebase and make preparation for codegen in clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files:

  1   2   3   >