[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. Posted D120026 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116088/new/ https://reviews.llvm.org/D116088 ___ cfe-commits mailing list

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

iains updated this revision to Diff 409552. iains added a comment. address review comments, rebase onto parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118586/new/ https://reviews.llvm.org/D118586 Files:

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

iains updated this revision to Diff 409548. iains marked an inline comment as done. iains added a comment. rebased onto changes in parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 Files:

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains updated this revision to Diff 409546. iains added a comment. amended an assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Sorry, I took an oversight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589

[PATCH] D118599: [C++20][Modules][8/8] Amend module visibility rules for partitions.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118599/new/ https://reviews.llvm.org/D118599

[clang] a480841 - Add missing break statement in switch.

Author: Stanislav Gatev Date: 2022-02-17T09:37:02Z New Revision: a48084156653e8f3791d13c19ce64df13c44a11e URL: https://github.com/llvm/llvm-project/commit/a48084156653e8f3791d13c19ce64df13c44a11e DIFF: https://github.com/llvm/llvm-project/commit/a48084156653e8f3791d13c19ce64df13c44a11e.diff

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added a comment. My implementation is StringRef getPrimaryModuleName() const { if (Check Kind) return Name; return StringRef(Name).split('-').first; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118598/new/

[PATCH] D118589: [C++20][Modules][6/8] Record direct module imports.

ChuanqiXu added a comment. hmmm, I don't find this is used in following patch. Oversight? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118589/new/ https://reviews.llvm.org/D118589 ___ cfe-commits

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:367-368 + // owning named module. + size_t P = NamedMod->Name.find_first_of(":"); + ModuleName = NamedMod->Name.substr(0, P + 1); +} else { ChuanqiXu wrote: > I would

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM with the name about partition CMI addressed (It is raised in previous patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118588/new/ https://reviews.llvm.org/D118588

[PATCH] D118587: [C++20][Modules][4/8] Handle generation of partition implementation CMIs.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/cxx20-10-1-ex1.cpp:7-8 + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface -D TU=1 -x c++ %s \ +// RUN: -o %t/A_Internals.pcm + In my implementation, I replace ':' to '-' in pcm filename. I do

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/test/Modules/cxx20-partition-diagnostics-a.cpp:3-5 +// RUN: %clang_cc1 -std=c++20 -S -D TU=1 -x c++ %s -o /dev/null -verify + +// RUN: %clang_cc1 -std=c++20 -S -D TU=2 -x c++ %s -o /dev/null -verify We could use

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); I chose '-' in my implementation since here ModuleName refers to the name in filesystem,

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains marked 4 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there ChuanqiXu

[PATCH] D119953: [clang][dataflow] Add transfer functions for logical and, or, not.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4dde8d39a9: [clang][dataflow] Add transfer functions for logical and, or, not. (authored by sgatev). Repository: rG LLVM Github Monorepo

[clang] dd4dde8 - [clang][dataflow] Add transfer functions for logical and, or, not.

Author: Stanislav Gatev Date: 2022-02-17T09:09:59Z New Revision: dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd URL: https://github.com/llvm/llvm-project/commit/dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd DIFF: https://github.com/llvm/llvm-project/commit/dd4dde8d39a9c36ea692635bdfc0c90cc8d755fd.diff

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Comment at: clang/lib/Sema/SemaModule.cpp:144 GlobalModuleFragment = ModuleScopes.back().Module; // In C++20, the module-declaration must be the first declaration if there iains

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added a comment. I think we should add 2 more tests at least: Import a partition a module purview but we failed to find one. And test reflects the successful case. Comment at: clang/include/clang/Sema/Sema.h:2989 /// \param ImportLoc The location of the 'import'

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains marked 5 inline comments as done. iains added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:82 if (getLangOpts().Modules || getLangOpts().DebuggerSupport) { - SingleDecl = ParseModuleImport(AtLoc); + Sema::ModuleImportState IS =

[PATCH] D118893: [C++20][Modules][1/8] Track valid import state.

iains updated this revision to Diff 409521. iains added a comment. address review comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118893/new/ https://reviews.llvm.org/D118893 Files:

[clang] 0ae2464 - [clang-format] Fix wrong assertion with non-negative shift when aligning tokens.

Author: Marek Kurdej Date: 2022-02-17T09:49:00+01:00 New Revision: 0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2 URL: https://github.com/llvm/llvm-project/commit/0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2 DIFF: https://github.com/llvm/llvm-project/commit/0ae2464fcd4d2c2f285b83d16ff6e2426dd722d2.diff

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409511. junaire added a comment. Simplify code a little bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949 Files:

[PATCH] D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers

junaire updated this revision to Diff 409510. junaire added a comment. - Only suppress canonical types when it's a TypedefNameType. - Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119949/new/ https://reviews.llvm.org/D119949

[PATCH] D114714: [C++20][Modules][2/8] Add enumerations for partition modules and stream them.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114714/new/ https://reviews.llvm.org/D114714 ___ cfe-commits mailing list

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2658-2682 +Expr::EvalResult EVRX, EVRY; +if (!DefaultArgumentX->EvaluateAsConstantExpr(EVRX, C) || +!DefaultArgumentY->EvaluateAsConstantExpr(EVRY, C)) + return false; + +

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 409507. ChuanqiXu added a comment. Use ODRHash to simplify code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

<    1   2   3