[PATCH] D121184: Try code change

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121184 Files: clang/lib/Sema/TreeTransform.h Index:

[PATCH] D121172: [AMDGPU] Set noclobber metadata on loads instead of cast to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9eabea396814: [AMDGPU] Set noclobber metadata on loads instead of cast to constant (authored by rampitec). Herald added a project: clang. Herald

[clang] 9eabea3 - [AMDGPU] Set noclobber metadata on loads instead of cast to constant

Author: Stanislav Mekhanoshin Date: 2022-03-07T23:13:02-08:00 New Revision: 9eabea396814c5580978cd4766b524bef57844cf URL: https://github.com/llvm/llvm-project/commit/9eabea396814c5580978cd4766b524bef57844cf DIFF:

[clang] eddd94c - Reland "[clang][debug] port clang-cl /JMC flag to ELF"

Author: Yuanfang Chen Date: 2022-03-07T21:55:41-08:00 New Revision: eddd94c27df609113af1d1b795d8483aa6dd662c URL: https://github.com/llvm/llvm-project/commit/eddd94c27df609113af1d1b795d8483aa6dd662c DIFF: https://github.com/llvm/llvm-project/commit/eddd94c27df609113af1d1b795d8483aa6dd662c.diff

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

jdoerfert added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2713-2714 +/// \endcode +extern const internal::VariadicDynCastAllOfMatcher +attributedStmt; + aaron.ballman wrote: > Design-wise, I'm on the fence here. AST matchers

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 413696. ajohnson-uoregon added a comment. Somehow got other edits into ASTMatcher.h, dunno how, it's fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 413693. ajohnson-uoregon added a comment. Actually has the right doc updates now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files:

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 413691. ajohnson-uoregon marked 5 inline comments as done. ajohnson-uoregon added a comment. update with fixes from Aaron, tests, and docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4de9a752d6af: [X86] Add helper enum for ternary intrinsics (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4de9a75 - [X86] Add helper enum for ternary intrinsics

Author: Phoebe Wang Date: 2022-03-08T11:19:05+08:00 New Revision: 4de9a752d6affb7427d53c50bb64c94c3014b3f0 URL: https://github.com/llvm/llvm-project/commit/4de9a752d6affb7427d53c50bb64c94c3014b3f0 DIFF: https://github.com/llvm/llvm-project/commit/4de9a752d6affb7427d53c50bb64c94c3014b3f0.diff

[PATCH] D121181: [DNM] Testing for premerge builds

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121181 Files: clang/lib/Sema/TreeTransform.h Index:

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD updated this revision to Diff 413688. eopXD added a comment. Herald added a project: All. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 Files:

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c84e2d325f: [clang][dataflow] Fix nullptr dereferencing error. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 18c84e2 - [clang][dataflow] Fix nullptr dereferencing error.

Author: Yitzhak Mandelbaum Date: 2022-03-08T03:01:31Z New Revision: 18c84e2d325fe64f303a13b17addce1c0e6aca23 URL: https://github.com/llvm/llvm-project/commit/18c84e2d325fe64f303a13b17addce1c0e6aca23 DIFF: https://github.com/llvm/llvm-project/commit/18c84e2d325fe64f303a13b17addce1c0e6aca23.diff

[PATCH] D121095: [C++20][Modules][HU 1/5] Introduce header units as a module type.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2978-2980 + /// The parser has begun a translation unit to be compiled as a C++20 + /// Header Unit. + void ActOnStartOfHeaderUnit(); From the implementation, I think it should be

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

xazax.hun accepted this revision. xazax.hun added a comment. Wonderful, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 ___ cfe-commits mailing list

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

pengfei updated this revision to Diff 413676. pengfei marked 2 inline comments as done. pengfei added a comment. Thanks @skan ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files:

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel added a comment. In D121158#3365494 , @ymandel wrote: > In D121158#3365415 , @xazax.hun > wrote: > >>> When pre-initializing fields in the environment, the code assumed that all >>> fields of a struct

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3365542 , @SimplyDanny wrote: > In D121078#3363856 , @aaron.ballman > wrote: > >> I think we need to retain *some* references to the existing mailing list >> archives. The

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel updated this revision to Diff 413674. ymandel added a comment. switch to c++11 for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 Files:

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel updated this revision to Diff 413673. ymandel added a comment. Add test for recursive type case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 Files:

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

shafik added a comment. This make sense to me at a first pass, please make sure you run `check-lldb` as well. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1971 +return false; + unsigned SlotsToCheck = NumArgs > 0 ? NumArgs : 1; + for (unsigned I = 0; I <

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

vsapsai added a comment. The main alternative to the current implementation was to change `getRedeclContext` for ObjCCategoryDecl, so we handle ivar redeclarations and merges in ObjCInterfaceDecl with `ASTDeclReader::findExisting`. Decided against it because of noticeably different merging

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

skan added inline comments. Comment at: clang/test/Sema/asm.c:318-346 +typedef struct test19_a { + int a; + char b; +} test19_a; + +typedef struct test19_b { + int a; Better to add comments about the size of the struct. Comment at:

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

vsapsai created this revision. vsapsai added reviewers: aprantl, ChuanqiXu, rsmith, ahatanak. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Emitting metadata for

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai created this revision. vsapsai added reviewers: martong, shafik, a_sidorin. Herald added subscribers: ributzka, rnkovacs. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Will post shortly another patch that relies on comparing

[PATCH] D121101: [clang] Fix OpenMP critical hint parameter check

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e159e4c7b97: [clang] Fix OpenMP critical hint parameter check (authored by peixin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121101/new/

[clang] 4e159e4 - [clang] Fix OpenMP critical hint parameter check

Author: Peixin-Qiao Date: 2022-03-08T09:04:31+08:00 New Revision: 4e159e4c7b975c4c091e175fde0a340ca643ccd3 URL: https://github.com/llvm/llvm-project/commit/4e159e4c7b975c4c091e175fde0a340ca643ccd3 DIFF: https://github.com/llvm/llvm-project/commit/4e159e4c7b975c4c091e175fde0a340ca643ccd3.diff

[PATCH] D121063: [AST] Make the last element in the linked list null

void abandoned this revision. void added a comment. In D121063#3364872 , @erichkeane wrote: > In D121063#3364833 , @void wrote: > >> In D121063#3364815 , @erichkeane >>

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void updated this revision to Diff 413662. void added a comment. Don't call little-used function in DeclContext to re-link the record decls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files:

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mysterymath created this revision. mysterymath added reviewers: phosek, MaskRay. Herald added a subscriber: dexonsmith. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These options allow guarding a

[PATCH] D121151: [WebAssembly] Add new target feature in support of 'extended-const' proposal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc832edfd3fbc: [WebAssembly] Add new target feature in support of extended-const proposal (authored by sbc100). Repository: rG LLVM Github

[clang] c832edf - [WebAssembly] Add new target feature in support of 'extended-const' proposal

Author: Sam Clegg Date: 2022-03-07T16:45:42-08:00 New Revision: c832edfd3fbccfac6d5212d6495f0dde851dbdde URL: https://github.com/llvm/llvm-project/commit/c832edfd3fbccfac6d5212d6495f0dde851dbdde DIFF: https://github.com/llvm/llvm-project/commit/c832edfd3fbccfac6d5212d6495f0dde851dbdde.diff

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; Quuxplusone wrote: > I haven't tried to

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

sammccall added a comment. Nice! Some early comments, I haven't gotten deep into the GLR algorithm itself Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h:9 +// +// Parse forest is the output of the GLR parser. +// nit: i think we should reverse

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @erichkeane Thanks for the review. I will try to address your comments as soon as possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added inline comments. Comment at: clang/include/clang/AST/Type.h:4793 + + QualType ModifiedType; + QualType EquivalentType; erichkeane wrote: > I suspect both of these aren't necessary. If the intent here is to just wrap > a single type, I

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3350072 , @rnk wrote: > I would structure this as a LangOpt, and feed the target checks and ABI > compat checks into the default setting for it. It could be something like > `DefaultedSMFArePOD` /

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413642. SimplyDanny added a comment. Removed duplicate target names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 Files: clang-tools-extra/README.txt

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 413641. dblaikie added a comment. Herald added subscribers: dexonsmith, dang. Herald added a project: All. Add a -f driver flag for defaulted-smf-are-pod Include the other cases from itanium ABI issue 66 (implicitly and explicitly deleted special members,

[PATCH] D121132: [clang-format] Handle C# 9 `init` accessor specifier.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121132/new/ https://reviews.llvm.org/D121132 ___ cfe-commits mailing list

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

craig.topper added a comment. > So at this point we have these options: > > 1. Make the `__m[128|256|512]bh` types aliases of `__m[128|256|512]i` > 2. Deprecate the `__m[128|256|512]bh` types and replace them with > `__m[128|256|512]i` > 3. Add load/store/insert/extract intrinsics for the

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3359255 , @pengfei wrote: > I don't agree. Unlike `__fp16`, `__bf16` is simple an ARM specific type. Why is __bf16 an ARM-specific type? It's a type that describes a floating point value with a specific

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang. In files where different preprocessing paths are possible, our goal is

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3358533 , @craig.topper wrote: > __m256bh should not have been a new type. It should have been an alias of > __m256i. We don't have load/store intrinsics for __m256bh so if you can even > get the __m256bh

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Herald added a project: All. Ping. Is there anyone familiar with the template instantiation code I should add as a reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3363856 , @aaron.ballman wrote: > I think we need to retain *some* references to the existing mailing list > archives. The migration to Discourse worked fairly well, but there were still > data migration issues.

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added inline comments. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on the Clang development mailing list: - http://lists.llvm.org/mailman/listinfo/cfe-dev +in the Clang forum: +

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413630. SimplyDanny marked 9 inline comments as done. SimplyDanny added a comment. Updated revision according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel added a comment. In D121158#3365415 , @xazax.hun wrote: >> When pre-initializing fields in the environment, the code assumed that all >> fields of a struct would be initialized > > Was this assumption ever correct given that it was already

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 413625. hctim marked an inline comment as done. hctim added a comment. Herald added a project: All. Rebase onto D119384 , removing all the llvm and lld-specific parts. This patch now only contains the clang-specific bits.

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel added a comment. Thanks for the review! That was impressively fast... :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121158/new/ https://reviews.llvm.org/D121158 ___ cfe-commits mailing list

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

xazax.hun added a comment. > When pre-initializing fields in the environment, the code assumed that all > fields of a struct would be initialized Was this assumption ever correct given that it was already skipping the initialization of recursive cases? Repository: rG LLVM Github Monorepo

[PATCH] D113456: Allow protocol metadata to be deduplicated within dylibs

davide abandoned this revision. davide added a comment. Herald added a project: All. We fixed this in the linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113456/new/ https://reviews.llvm.org/D113456

[PATCH] D121158: [clang][dataflow] Fix nullptr dereferencing error.

ymandel created this revision. ymandel added a reviewer: sgatev. Herald added subscribers: tschuett, steakhal. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. When pre-initializing fields in the environment, the code assumed that all fields

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai planned changes to this revision. vsapsai added inline comments. Herald added a project: All. Comment at: clang/test/Modules/merge-anon-record-definition-in-objc.m:5 +// RUN: %clang_cc1 -fsyntax-only -F%t/Frameworks %t/test.m -Wno-objc-property-implementation

[PATCH] D121156: [OPENMP]PR53344: Emit code for final update of the inscan reduction vars in worksharing loops.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to emit final update of the

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: cjdb wrote: > owenpan wrote: > > Do we still need this line? > I'd prefer to get rid of `default` if we can. We can't. It's the

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 413612. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

cjdb accepted this revision. cjdb added a comment. Thanks for working on this! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > Do we still need this line? I'd prefer to get rid of `default`

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains updated this revision to Diff 413611. iains added a comment. amend a testcase. I reordered and squashed two of the patches before posting, and failed to spot that a test case had a (non-critical) dependency on functionality introduced by a later patch. Fixed by removing the dependency.

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 413609. hokein added a comment. some tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121150/new/ https://reviews.llvm.org/D121150 Files: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein added a comment. This is an initial version, not unittests yet, but it should be good enough for high-level reviews. Basically, it contains all key pieces of the GLR parser: - ForestForest: it is a DAG with compact nodes (8 bytes per node). It is not mutable by design. The code is

[PATCH] D121153: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBuiltin.cpp

ahatanak created this revision. ahatanak added a reviewer: opaque-pointers. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121153 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121151: [WebAssembly] Add new target feature in support of 'extended-const' proposal

sbc100 added a comment. Surprising amount of boilerplate here.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121151/new/ https://reviews.llvm.org/D121151 ___ cfe-commits mailing list

[PATCH] D121151: [WebAssembly] Add new target feature in support of 'extended-const' proposal

sbc100 created this revision. Herald added subscribers: wingo, dang, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM.

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. This patch implements a standard(Tomita's) GLR

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: Do we still need this line? Comment at:

[clang] f46fa4d - Revert "[clang][debug] port clang-cl /JMC flag to ELF"

Author: Yuanfang Chen Date: 2022-03-07T12:40:43-08:00 New Revision: f46fa4de4a95329b74ba0bb4ce9623b64ad84876 URL: https://github.com/llvm/llvm-project/commit/f46fa4de4a95329b74ba0bb4ce9623b64ad84876 DIFF: https://github.com/llvm/llvm-project/commit/f46fa4de4a95329b74ba0bb4ce9623b64ad84876.diff

[PATCH] D121028: [AMDGPU] new gfx940 fp atomics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG932f628121d8: [AMDGPU] new gfx940 fp atomics (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 932f628 - [AMDGPU] new gfx940 fp atomics

Author: Stanislav Mekhanoshin Date: 2022-03-07T12:32:02-08:00 New Revision: 932f628121d85281ef1a2410dd158a735acdea5e URL: https://github.com/llvm/llvm-project/commit/932f628121d85281ef1a2410dd158a735acdea5e DIFF:

[PATCH] D121132: [clang-format] Handle C# 9 `init` accessor specifier.

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4244 Keywords.kw_readonly, Keywords.kw_override, Keywords.kw_abstract, -Keywords.kw_get, Keywords.kw_set, Keywords.kw_async, -Keywords.kw_await)) +

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle ping @alexfh @JonasToth Thank you. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:228 'default') - parser.add_argument('-config', default=None, + group =

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. In D119910#3364892 , @thakis wrote: > Looks like this breaks tests on mac and win: > http://45.33.8.238/win/54551/step_7.txt > http://45.33.8.238/macm1/29590/step_7.txt > > Please take a look, and revert for now if it takes a while

[PATCH] D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features

egorzhdan added a comment. Herald added a project: All. Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141 In D120160#3352399 , @Mordante wrote: > `-funstable` is an option that controls

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic requested changes to this revision. tonic added a comment. Thank you so much for doing this! I have added some comments inline that I would like changed. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

egorzhdan created this revision. Herald added a subscriber: dang. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up for https://reviews.llvm.org/D120160 that addresses some of the

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

thakis added a comment. Looks like this breaks tests on mac and win: http://45.33.8.238/win/54551/step_7.txt http://45.33.8.238/macm1/29590/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121063: [AST] Make the last element in the linked list null

erichkeane added a comment. In D121063#3364833 , @void wrote: > In D121063#3364815 , @erichkeane > wrote: > >> In D121063#3364810 , @void wrote: >> >>> In

[PATCH] D121092: [pseudo] Strip comments for TokenStream.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01ac18df93: [pseudo] Strip comments for TokenStream. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2d01ac1 - [pseudo] Strip comments for TokenStream.

Author: Haojian Wu Date: 2022-03-07T20:24:37+01:00 New Revision: 2d01ac18df93f2f8dd925888aabb7681224fb670 URL: https://github.com/llvm/llvm-project/commit/2d01ac18df93f2f8dd925888aabb7681224fb670 DIFF: https://github.com/llvm/llvm-project/commit/2d01ac18df93f2f8dd925888aabb7681224fb670.diff

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a comment. In D121063#3364815 , @erichkeane wrote: > In D121063#3364810 , @void wrote: > >> In D121063#3364780 , @void wrote: >> >>> In D121063#3363852

[PATCH] D121089: [pseudo] empty parameter-declaration should be allowed in lambda declarator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5b8ecbd33c9: [pseudo] empty parameter-declaration should be allowed in lambda declarator. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d5b8ecb - [pseudo] empty parameter-declaration should be allowed in lambda declarator.

Author: Haojian Wu Date: 2022-03-07T20:05:35+01:00 New Revision: d5b8ecbd33c95d9a6ac8371d5dc187196b71604d URL: https://github.com/llvm/llvm-project/commit/d5b8ecbd33c95d9a6ac8371d5dc187196b71604d DIFF: https://github.com/llvm/llvm-project/commit/d5b8ecbd33c95d9a6ac8371d5dc187196b71604d.diff

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static bool unconditionallyLeadsHere(const ExplodedNode *N) { + size_t NonSinkNodeCount = llvm::count_if( NoQ wrote: >

[PATCH] D121063: [AST] Make the last element in the linked list null

erichkeane added a comment. In D121063#3364810 , @void wrote: > In D121063#3364780 , @void wrote: > >> In D121063#3363852 , @erichkeane >> wrote: >> >>> I suspect this

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

NoQ added a comment. In D120992#3359864 , @steakhal wrote: > BTW what is the semantics of `[p retain]` in ObjC? Can `p` be null in that > context? Or does it count as a dereferences, hence it constraints the pointer? In Objective-C "methods" can be

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a comment. In D121063#3364780 , @void wrote: > In D121063#3363852 , @erichkeane > wrote: > >> I suspect this works because we never really treated this as a LL, just as a >> pair of iterators. Two

[PATCH] D120864: [AArch64] Avoid scanning feature list for target parsing

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:407-408 // TargetParser rewrite. const auto ItRNoFullFP16 = std::find(Features.rbegin(), Features.rend(), "-fullfp16"); const auto ItRFP16FML = std::find(Features.rbegin(),

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

NoQ added a comment. This check checks must-properties/all-paths properties. This has to be a data flow / CFG-based warning. I don't think there's a way around. Comment at: clang/lib/StaticAnalyzer/Checkers/NullPtrInterferenceChecker.cpp:166 +/// child is a sink node. +static

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added subscribers: seaneveson, MatzeB. paulkirth added a comment. @MatzeB @seaneveson Can either of you confirm that the logic we're inserting here is not in conflict with the stack size section? Based on D39788 and the original RFC, I would say

[PATCH] D121063: [AST] Make the last element in the linked list null

void added a subscriber: urnathan. void added a comment. In D121063#3363852 , @erichkeane wrote: > I suspect this works because we never really treated this as a LL, just as a > pair of iterators. Two things: > > 1- Can you produce some situation

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 413556. paulkirth added a comment. Update emitStackSection to emit the size of the combined stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files:

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; I haven't tried to understand the main

[PATCH] D121112: [clang-format] Fix namespace end comments in ObjC++ files too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6a8b92b8959: [clang-format] Fix namespace end comments in ObjC++ files too (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES

[clang] e6a8b92 - [clang-format] Fix namespace end comments in ObjC++ files too

Author: Nico Weber Date: 2022-03-07T13:30:25-05:00 New Revision: e6a8b92b8959b17a140a30b340dd59cfa8781dea URL: https://github.com/llvm/llvm-project/commit/e6a8b92b8959b17a140a30b340dd59cfa8781dea DIFF: https://github.com/llvm/llvm-project/commit/e6a8b92b8959b17a140a30b340dd59cfa8781dea.diff

[PATCH] D121077: Simplify OpenMP Lambda use

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0a6433f2b51: Simplify OpenMP Lambda use (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121077/new/ https://reviews.llvm.org/D121077

[clang] c0a6433 - Simplify OpenMP Lambda use

Author: David Blaikie Date: 2022-03-07T18:23:20Z New Revision: c0a6433f2b5120d79f03431e9bf61b4da1184412 URL: https://github.com/llvm/llvm-project/commit/c0a6433f2b5120d79f03431e9bf61b4da1184412 DIFF: https://github.com/llvm/llvm-project/commit/c0a6433f2b5120d79f03431e9bf61b4da1184412.diff

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731347431976: [clang][debug] port clang-cl /JMC flag to ELF (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7313474 - [clang][debug] port clang-cl /JMC flag to ELF

Author: Yuanfang Chen Date: 2022-03-07T10:16:24-08:00 New Revision: 731347431976509823e38329a96fcbc69fe98cd2 URL: https://github.com/llvm/llvm-project/commit/731347431976509823e38329a96fcbc69fe98cd2 DIFF: https://github.com/llvm/llvm-project/commit/731347431976509823e38329a96fcbc69fe98cd2.diff

  1   2   3   >