[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416668. tahonermann added a comment. Rebase to acquire fixes from parent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; vabridgers wrote: > NoQ

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann updated this revision to Diff 41. tahonermann added a comment. Rebase with a correction for an incorrect merge conflict resolution that propagated from D121958 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 41f74bc - [CMake] Update cache file for Win to ARM Linux cross toolchain builders. NFC.

Author: Vladimir Vereschaka Date: 2022-03-18T21:39:02-07:00 New Revision: 41f74bc7ae33d9cd9a1eaacfc29ba53a933c042f URL: https://github.com/llvm/llvm-project/commit/41f74bc7ae33d9cd9a1eaacfc29ba53a933c042f DIFF:

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. In D121951#3392470 , @scott.linder wrote: > In D121951#3391472 , @sameerds > wrote: > >> The check for "__ockl_hostcall_internal" is not longer relevant with the new >> hostcall

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. Yeah, it happened in D119216 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.org/D121951 ___ cfe-commits

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann updated this revision to Diff 416665. tahonermann added a comment. Corrected a clang-format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added a comment. In D121733#3393640 , @dexonsmith wrote: > In D121733#3393552 , @bnbarham > wrote: > >> In D121733#3393546 , @rnk wrote: >> >>> I've been

[PATCH] D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.

tahonermann updated this revision to Diff 416647. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121963/new/ https://reviews.llvm.org/D121963 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests.

tahonermann updated this revision to Diff 416646. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121962/new/ https://reviews.llvm.org/D121962 Files: clang/test/OpenMP/declare_variant_messages.c Index:

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416645. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type.

tahonermann updated this revision to Diff 416644. tahonermann added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121960/new/ https://reviews.llvm.org/D121960 Files: clang/lib/Sema/SemaDecl.cpp Index:

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann updated this revision to Diff 416643. tahonermann added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121959/new/ https://reviews.llvm.org/D121959 Files: clang/lib/Sema/SemaDecl.cpp

[clang] fc35376 - Ensure that APIRecords get destroyed correctly.

Author: Daniel Grumberg Date: 2022-03-19T00:49:37Z New Revision: fc3537697db7724834d8071cfee10cacceb9fc2a URL: https://github.com/llvm/llvm-project/commit/fc3537697db7724834d8071cfee10cacceb9fc2a DIFF: https://github.com/llvm/llvm-project/commit/fc3537697db7724834d8071cfee10cacceb9fc2a.diff

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

zhouyizhou updated this revision to Diff 416636. zhouyizhou edited the summary of this revision. zhouyizhou added reviewers: mizvekov, eli.friedman, EricWF, faisalv. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119493/new/ https://reviews.llvm.org/D119493

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1904-1906 +if (!SemaRef.LangOpts.CPlusPlus2b && +CheckLiteralType(SemaRef, Kind, VD->getLocation(), VD->getType(),

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; NoQ wrote: > How

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added a comment. In D121733#3393552 , @bnbarham wrote: > In D121733#3393546 , @rnk wrote: > >> I've been somewhat afraid to touch this code because of symlinks. Is that >> something we need to worry

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 416633. ppluzhnikov added a comment. More Debian and Win x64 fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 Files:

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann updated this revision to Diff 416632. tahonermann added a comment. Fix bad merge conflict resolution that I failed to even test compiling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958

[PATCH] D122047: [CMake][Fuchsia] Switch to lld on Apple platforms

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D120989: Support debug info for alias variable

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3922 + return cast(GVE); +return dyn_cast_or_null(N); + } if we don't expect anything but non-null DINodes to be in the cache, then this whole condition should be ``` return

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 416627. LegalizeAdulthood added a comment. - Undo change introduced by clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks added a comment. I'm very out of my depth with tablegen, let me know if there's a more elegant way of doing this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:318 + + // It can be +Lit, -Lit or just Lit. + Token Tok = Info->tokens().front();

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks created this revision. Herald added a subscriber: dmgreen. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to keep track of pointer pointee types with opaque pointers. Repository:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 416625. LegalizeAdulthood added a comment. - Recognize bitwise negated integers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D121733: Clean pathnames in FileManager.

bnbarham added a comment. In D121733#3393546 , @rnk wrote: > I've been somewhat afraid to touch this code because of symlinks. Is that > something we need to worry about? Consider this path: root/symlink/../foo.h. > remove_dots will turn this into

[PATCH] D121733: Clean pathnames in FileManager.

rnk added a comment. I've been somewhat afraid to touch this code because of symlinks. Is that something we need to worry about? Consider this path: root/symlink/../foo.h. remove_dots will turn this into root/foo.h, but if symlink points to some unrelated directory, the .. directory entry

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 416624. LegalizeAdulthood added a comment. - Tests pass again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. In D117522#3392122 , @aaron.ballman wrote: > In D117522#3390136 , > @LegalizeAdulthood wrote: > >> I think I've got all the changes incorporated, but I'm getting a test >>

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

MyDeveloperDay added a comment. I think you can spin it any number of ways, but bottom line its a massive truth table and I sort of feel however you change it, it will just become a different equally incomprehensible pattern. For me I'd prefer to stick with the devil I know, unless its broken,

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann updated this revision to Diff 416618. tahonermann added a comment. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121961/new/ https://reviews.llvm.org/D121961 Files: clang/lib/AST/TextNodeDumper.cpp

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov planned changes to this revision. ppluzhnikov added a comment. Pending further Win x64 failure cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added reviewers: mstorsjo, rnk. dexonsmith added subscribers: mstorsjo, rnk. dexonsmith added a comment. FWIW, I quite like the clean up effect that this patch has (assuming we are able to convince ourselves that it's safe/correct for `FileManager` to do this). - Removing the dots

[clang] bb78dd2 - [RGT] StencilTest: Fix an assertion

Author: Paul Robinson Date: 2022-03-18T14:13:41-07:00 New Revision: bb78dd2e1f81323a631e2964d06a40aa10d5e2f5 URL: https://github.com/llvm/llvm-project/commit/bb78dd2e1f81323a631e2964d06a40aa10d5e2f5 DIFF: https://github.com/llvm/llvm-project/commit/bb78dd2e1f81323a631e2964d06a40aa10d5e2f5.diff

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann updated this revision to Diff 416604. tahonermann added a comment. Updates to address clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121958/new/ https://reviews.llvm.org/D121958 Files:

[PATCH] D122028: [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd8dc91b89d: [OpenMP] Initial parsing/sema for the omp target teams loop construct (authored by mikerice). Herald added a project: clang. Herald

[clang] 6bd8dc9 - [OpenMP] Initial parsing/sema for the 'omp target teams loop' construct

Author: Mike Rice Date: 2022-03-18T13:48:32-07:00 New Revision: 6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331 URL: https://github.com/llvm/llvm-project/commit/6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331 DIFF: https://github.com/llvm/llvm-project/commit/6bd8dc91b89d0b130d8c03174b7b3b0d1cf3b331.diff

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

efriedma added a comment. Herald added a project: All. D120026 is merged now, which addresses the issue of the compiler generating __sync calls where it isn't supposed to. Does anyone want to continue discussing what changes to compiler-rt would be

[clang] 37e7cf7 - Driver: Make macOS the default target OS for -arch arm64

Author: Duncan P. N. Exon Smith Date: 2022-03-18T13:36:47-07:00 New Revision: 37e7cf7f1c6920d33a4a5dd3f0a415a61dd24731 URL: https://github.com/llvm/llvm-project/commit/37e7cf7f1c6920d33a4a5dd3f0a415a61dd24731 DIFF:

[PATCH] D121961: [clang] Produce a "multiversion" annotation in textual AST output.

tahonermann added a comment. > Is there a need for this functionality? Not a strong need, but I found it helpful in two scenarios: 1. A forward declaration of a multiversion function is not required to include a multiversion function attribute; later declarations might trigger

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

dexonsmith added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:2 +// RUN: rm -rf %t && mkdir -p %t +// RUN: %clang -c %s -o %t/out -arch x86_64 -arch arm64 -MJ %t/compilation_database.json +// RUN: FileCheck

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

dexonsmith added a comment. In D121997#3393079 , @jansvoboda11 wrote: > Avoid buggy driver behavior I just remembered the "correct" way to specify a platform without an SDK if you're using `-arch`: `-mmacosx-version-min=12.0.0`. That's probably better

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

dexonsmith added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:5-6 + +// CHECK: { "directory": "{{.*}}", "file": "{{.*}}", "output": "{{.*}}", "arguments": [{{.*}} "--target=x86_64-apple-macosx12.0.0"]}, +// CHECK-NEXT: { "directory":

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

erichkeane added a comment. LGTM, thanks for the clarification! Comment at: clang/test/Sema/attr-cpuspecific.c:133 -// FIXME: Declaration of a non-overloadable function when more than one -// FIXME: multiversion function declarations are present results in an -// FIXME:

[PATCH] D122030: Driver: Make macOS the default target OS for -arch arm64

dexonsmith created this revision. dexonsmith added reviewers: arphaman, ab, steven_wu. Herald added a subscriber: kristof.beyls. Herald added a project: All. dexonsmith requested review of this revision. Herald added a project: clang. This is a follow up to

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

tahonermann added a comment. > These words have no power here. No power, but not uninformative to some. I promise to keep such references out of git's permanent record :) Comment at: clang/test/Sema/attr-cpuspecific.c:133 -// FIXME: Declaration of a non-overloadable

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Ok then, I seem to then just not understand its purpose, but you seem to understand it well enough. I'm ok with this patch now (after the format fixes!). Repository: rG LLVM

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

HazardyKnusperkeks added a comment. FWIW I proposed to go this way: https://discourse.llvm.org/t/clang-format-spacerequiredbefore-vs-spacerequiredbetween/60901/5?u=hazardyknusperkeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

erichkeane added a comment. Just a couple of questions/concerns! Otherwise it LGTM. Since I have a suggestion for a code change, I'll hold off on approval until you do it or give a reasonable reason why not. Comment at: clang/lib/AST/ASTContext.cpp:10290 +//

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147 +// know how they can be followed by a star or amp. +// co_await, delete - It doesn't make sense to have them followed by a unary +// `+` or `-`. +if

[PATCH] D121958: [clang] NFC: Remove forced type merging in multiversion function checks.

tahonermann added a comment. > Hmm... my understanding is "MergeTypeWithPrevious" is important for cases > where we decide that this is a redeclaration, right? We need to set it to > 'false' when we "know" that this is a different declaration, right? So at > least the '=false' was correct? As

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:35 inline SourceLocation getLocation() const { return loc; } - void setUsed(bool Used=true) { used = Used; } - inline bool

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, comex, erichkeane, jyknight, rjmccall. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, Clang handles some qualifiers correctly for `__auto_type`, but

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. Makes sense to me. Comment at: clang/include/clang/Sema/Weak.h:35 inline SourceLocation getLocation() const { return loc; } - void setUsed(bool Used=true)

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416576. jansvoboda11 added a comment. Avoid buggy driver behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:2 +// RUN: rm -rf %t && mkdir -p %t +// RUN: %clang -c %s -o %t/out -arch x86_64 -arch arm64 -MJ %t/compilation_database.json +// RUN: FileCheck

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 416569. jansvoboda11 added a comment. Specify the `apple-darwin` target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/new/ https://reviews.llvm.org/D121997 Files:

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. In D119017#3392996 , @devin.jeanpierre wrote: > In D119017#3392993 , @Manna wrote: > lf so, what target triple, so that I can reproduce? (New to clang development...) >> >> You

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

dexonsmith added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:5-6 + +// CHECK: { "directory": "{{.*}}", "file": "{{.*}}", "output": "{{.*}}", "arguments": [{{.*}} "--target=x86_64-apple-macosx12.0.0"]}, +// CHECK-NEXT: { "directory":

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

dexonsmith added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:2 +// RUN: rm -rf %t && mkdir -p %t +// RUN: %clang -c %s -o %t/out -arch x86_64 -arch arm64 -MJ %t/compilation_database.json +// RUN: FileCheck

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre added a comment. In D119017#3392993 , @Manna wrote: >>> lf so, what target triple, so that I can reproduce? (New to clang >>> development...) > > You can reproduce the test failure if you checkout 32 bit clang compiler. Please bear

[PATCH] D121733: Clean pathnames in FileManager.

bnbarham added a comment. In D121733#3392968 , @ppluzhnikov wrote: >> There's also some others where I wouldn't expect them to be failing in this >> patch, eg. the ones from `/` -> `{{[/\\]}}`. > > These are failing because `remove_dots`

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. In D119017#3392984 , @devin.jeanpierre wrote: > In D119017#3392961 , @Manna wrote: > >> LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. >> The same failures are

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre added a comment. In D119017#3392961 , @Manna wrote: > LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. > The same failures are happening with our downstream X86 clang build. > [...] > The test might need to be

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added a comment. > There's also some others where I wouldn't expect them to be failing in this > patch, eg. the ones from `/` -> `{{[/\\]}}`. These are failing because `remove_dots` (un-intuitively) also changes "foo/bar\\baz" to "foo\\bar\\baz" > Are there tests that we can't

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. Herald added a project: All. LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. The same failures are happening with our downstream X86 clang build. - TEST 'Clang :: SemaCXX/attr-trivial-abi.cpp' FAILED Script: --- :

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov added a comment. > @ppluzhnikov, can you give more context on how this interacts with > https://reviews.llvm.org/D121658? I had a quick look but it wasn't > immediately obvious. D121658 broke Winx64 test due to "./" vs. ".\\" mismatch. This

[PATCH] D121733: Clean pathnames in FileManager.

bnbarham added a comment. In D121733#3392931 , @dexonsmith wrote: > However, FileManager changes sometimes have odd side effects... and it's > possible that somewhere in clang relies on having `FileManager::getFileRef()` > return precisely the same

[PATCH] D121733: Clean pathnames in FileManager.

dexonsmith added reviewers: dexonsmith, benlangmuir, bnbarham, arphaman, vsapsai. dexonsmith added a comment. I haven't had time yet to think through the implications of this. At first glance this seems fine/correct/great. The only case I know of where `./` means something is if you're running

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. Thanks! I updated the change. Let me know if this is what you had in mind. I kept the original test too, can't hurt right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 416561. adamcz added a comment. changed to marking VarDecl as invalid if it's ref type and initializer is invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; aaron.ballman wrote: > LegalizeAdulthood wrote: > >

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 416555. junfd added a comment. Disable test on Windows, because -fsplit-machine-functions only works for ELF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files:

[clang-tools-extra] 217f267 - Revert "[pseudo] Split greatergreater token."

Author: Zequan Wu Date: 2022-03-18T10:15:48-07:00 New Revision: 217f267efe3082438e698e2f08566b9df8c530fa URL: https://github.com/llvm/llvm-project/commit/217f267efe3082438e698e2f08566b9df8c530fa DIFF: https://github.com/llvm/llvm-project/commit/217f267efe3082438e698e2f08566b9df8c530fa.diff

[clang] 8cd8bd4 - Implement __cpuid and __cpuidex as Clang builtins

Author: Alan Zhao Date: 2022-03-18T18:13:52+01:00 New Revision: 8cd8bd4a5ca702024b9df53a9c7984bb700488a0 URL: https://github.com/llvm/llvm-project/commit/8cd8bd4a5ca702024b9df53a9c7984bb700488a0 DIFF: https://github.com/llvm/llvm-project/commit/8cd8bd4a5ca702024b9df53a9c7984bb700488a0.diff

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 416550. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. - Update from review comments - `check-clang-tools` is reporting a test failure that still needs to be diagnosed (I think it is a mismatch between a

[PATCH] D122022: [CMake][Fuchsia] Drop Darwin architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa014cb865042: [CMake][Fuchsia] Drop Darwin architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a014cb8 - [CMake][Fuchsia] Drop Darwin architectures

Author: Petr Hosek Date: 2022-03-18T10:09:57-07:00 New Revision: a014cb865042872521ea2dcdf2bb2730de5dadde URL: https://github.com/llvm/llvm-project/commit/a014cb865042872521ea2dcdf2bb2730de5dadde DIFF: https://github.com/llvm/llvm-project/commit/a014cb865042872521ea2dcdf2bb2730de5dadde.diff

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9a855e7c1a: [CMake][Fuchsia] Include llvm-undname (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0f9a855 - [CMake][Fuchsia] Include llvm-undname

Author: Petr Hosek Date: 2022-03-18T10:09:13-07:00 New Revision: 0f9a855e7c1a55fee881ec5061c8b139ad45ba4f URL: https://github.com/llvm/llvm-project/commit/0f9a855e7c1a55fee881ec5061c8b139ad45ba4f DIFF: https://github.com/llvm/llvm-project/commit/0f9a855e7c1a55fee881ec5061c8b139ad45ba4f.diff

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:315 + if (Info->isFunctionLike() || Info->isBuiltinMacro() || + Info->tokens().empty() ||

[PATCH] D122022: [CMake][Fuchsia] Drop Darwin architectures

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to build runtimes for all available

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

phosek updated this revision to Diff 416546. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122021/new/ https://reviews.llvm.org/D122021 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D122021: [CMake][Fuchsia] Include llvm-undname

phosek created this revision. phosek added reviewers: abrachet, haowei. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when developing on Windows.

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. I've worked through this issue before, I just need to spend some time on it. The basic problem is that the test fails and dumps a bunch of output to "help" you understand the failure, but the way it is formatted and mangled doesn't end up being useful.

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ChromiumCheckModelTest.cpp:122 + void transfer(const Stmt *S, NoopLattice &, Environment ) { +M.transfer(S, Env); + } ymandel wrote: > xazax.hun wrote: > > ymandel wrote:

[PATCH] D121578: [RISCV][NFC] Add tests to address invalid arch dependencies.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5fea45d09e5: [RISCV][NFC] Add tests to address invalid arch dependencies. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121578/new/

[clang] f5fea45 - [RISCV][NFC] Add tests to address invalid arch dependencies.

Author: Zakk Chen Date: 2022-03-18T09:41:04-07:00 New Revision: f5fea45d09e5bae2f141195d05cfcb055914b63f URL: https://github.com/llvm/llvm-project/commit/f5fea45d09e5bae2f141195d05cfcb055914b63f DIFF: https://github.com/llvm/llvm-project/commit/f5fea45d09e5bae2f141195d05cfcb055914b63f.diff

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a()); } // expected-error {{'alloc::A::ret_a' is not a constant expression}} expected-error {{'alloc::to_lvalue_ref' is not a constant expression}} + //

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

ymandel added a comment. In D121797#3392444 , @xbolva00 wrote: > Why this should be maintained and developed by LLVM/Clang developers and not > by Chromium? That's a good question. I think the short answer, that skirts around the issue, is that this

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121907/new/ https://reviews.llvm.org/D121907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:633 (State.Line->Type == LT_PreprocessorDirective || State.Line->Type == LT_ImportStatement)) { Spaces += State.FirstIndent; AfterHash - Could be

[clang] 1df3a91 - [OpenMP][FIX] Make test check lines less strict

Author: Johannes Doerfert Date: 2022-03-18T10:53:32-05:00 New Revision: 1df3a913efc497b2ce63d856b25ba8903378d377 URL: https://github.com/llvm/llvm-project/commit/1df3a913efc497b2ce63d856b25ba8903378d377 DIFF:

[PATCH] D121837: [OpenMP][FIX] Allow device constructors for AMD GPU

jdoerfert added a comment. In D121837#3392346 , @kamaub wrote: > The test cases added with this commit failed on clang-ppc64be-linux-lnt # > 13809 could you > please revert this change, and

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3391472 , @sameerds wrote: > The check for "__ockl_hostcall_internal" is not longer relevant with the new > hostcall attribute. Can we simply remove this check? What is the situation > where the warning is still

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. The changes here generally look good, and I'm happy to see that more of our test cases are diagnosing similar to other compilers with the changes. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:362-364 + { A k = to_lvalue_ref(A().ret_a());

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski updated this revision to Diff 416513. awarzynski added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

xbolva00 added a comment. Why this should be maintained and developed by LLVM/Clang developers and not by Chromium? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121797/new/ https://reviews.llvm.org/D121797

  1   2   >