[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:744 + void setMaxVectorWidth(unsigned Width) { +MaxVectorWidth = llvm::Log2_32(Width) + 1; + } craig.topper wrote: > Are you assuming Width is a power of 2? Should we

[PATCH] D122104: [X86][regcall] Support passing / returning structures

pengfei updated this revision to Diff 417179. pengfei marked 2 inline comments as done. pengfei added a comment. Herald added a subscriber: StephenFan. Address review comments. Thanks Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122104/new/

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:577 + if (Args.hasArg(options::OPT_fsplit_machine_functions)) { +CmdArgs.push_back("-plugin-opt=-split-machine-functions"); Should also check

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu added a comment. Both `ast-dump` and `ast-dump=json` couldn't solve this. And I feel `static_assert` is hard to implement. But from your wording, I feel a unittest could match the intention. @dblaikie @aaron.ballman I thought the key point here is to test the linkage actually. And I

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu updated this revision to Diff 417175. ChuanqiXu added a comment. Use Unittest instead of `expected-no-diagnostic` tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 Files: clang/lib/AST/Decl.cpp

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f90254286dc: [analyzer][ctu] Fix wrong multiple definitions errors caused by space… (authored by OikawaKirie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9f90254 - [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

Author: Ella Ma Date: 2022-03-22T10:28:42+08:00 New Revision: 9f90254286dc6ec9be39648200712dfe2e4b1fda URL: https://github.com/llvm/llvm-project/commit/9f90254286dc6ec9be39648200712dfe2e4b1fda DIFF: https://github.com/llvm/llvm-project/commit/9f90254286dc6ec9be39648200712dfe2e4b1fda.diff LOG:

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. In D119409#3396690 , @dblaikie wrote: > Not even necessarily then - if you have code like protobufs (large amounts of > autogenerated code, much of which you might never call) - or even just > libraries where you only use a

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7832-7833 def err_redeclaration_non_exported : Error < - "cannot export redeclaration %0 here since the previous declaration is not " - "exported">; + "cannot export redeclaration

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `StructFieldRecord` and `StructRecord` to store API information for structs - Implement

[PATCH] D122133: [LTO] Add configuartion option to use default optimization pipeline

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I tested it locally, and it fixes the performance regression. Since it is internal flag, it will not break any existing code. I'm okay with the change. Not sure if we want to

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw added inline comments. Comment at: clang/lib/SymbolGraph/ExtractAPIConsumer.cpp:197 + void recordEnumConstants(EnumRecord *EnumRecord, + const EnumDecl::enumerator_range Constants) { dang wrote: > Should this be static or in an

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw updated this revision to Diff 417154. zixuw marked 4 inline comments as done. zixuw added a comment. - Address review issues; - Fix memory managment for EnumConstantRecord and EnumRecord Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

ahatanak created this revision. ahatanak added a reviewer: opaque-pointers. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122199 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f4be78abc: [Clang] Set -mlinker-version explicitly in the lto test (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122110/new/

[clang] 7f7f4be - [Clang] Set -mlinker-version explicitly in the lto test

Author: Petr Hosek Date: 2022-03-21T18:33:50-07:00 New Revision: 7f7f4be78abcad4558367b22693ea55cfc5bb547 URL: https://github.com/llvm/llvm-project/commit/7f7f4be78abcad4558367b22693ea55cfc5bb547 DIFF: https://github.com/llvm/llvm-project/commit/7f7f4be78abcad4558367b22693ea55cfc5bb547.diff

[clang] c624cc2 - [CMake][Clang] Skip host link version detection for lld on Darwin

Author: Petr Hosek Date: 2022-03-21T18:32:03-07:00 New Revision: c624cc252738c30ada3f00a498e971a7a3a84196 URL: https://github.com/llvm/llvm-project/commit/c624cc252738c30ada3f00a498e971a7a3a84196 DIFF: https://github.com/llvm/llvm-project/commit/c624cc252738c30ada3f00a498e971a7a3a84196.diff

[PATCH] D122109: [CMake][Clang] Skip host link version detection for lld on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGc624cc252738: [CMake][Clang] Skip host link version detection for lld on Darwin (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121984: [RISCV][NFC] Moving RVV intrinsic type related util to llvm/Support

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121984/new/ https://reviews.llvm.org/D121984

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw updated this revision to Diff 417147. zixuw marked 2 inline comments as done. zixuw added a comment. Rebase onto D122160 refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417146. junfd added a comment. Refine the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417145. zixuw added a comment. - Minor Doxygen auto-link string adjustments - Forgot to rename the test directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nathanchance added a comment. This passes through all my `ARCH=arm` and `ARCH=arm64` build and boot tests on `next-20220321` with the instances of `-Wdeclaration-after-statement` resolved and no new instances of any other warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:123 +private: + virtual void anchor(); }; dang wrote: > This is new so I don't think it belongs in this patch. > This is to follow the LLVM Coding Standards guideline of providing

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417132. zixuw marked 11 inline comments as done. zixuw added a comment. Address review issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 Files:

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. Herald added a project: All. Fedora recently banned RUNPATH, so packages built with clang and -fopenmp are rejected by the build system with this change. Can you elaborate more about the

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw marked 2 inline comments as done. sstwcw added a comment. It turned out this patch does change behavior. - while ( - FormatTok->isOneOf(tok::identifier, tok::kw_requires, tok::coloncolon)) { + while (FormatTok->isOneOf(tok::identifier, tok::kw_requires, +

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw added a comment. Allow me another attempt in justifying this patch. Using the macros, it is easier to see when a keyword is not classified as some language's keyword. The author and reviewers didn't notice `final` and `dollar` being in only one place previously. With the old way, when

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 417129. jhuber6 added a comment. Add more comments and an entry size field to the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122069/new/ https://reviews.llvm.org/D122069 Files:

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 417128. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:633 (State.Line->Type == LT_PreprocessorDirective || State.Line->Type == LT_ImportStatement)) { Spaces += State.FirstIndent;

[PATCH] D121906: [clang-format] Indent import statements in JavaScript.

sstwcw updated this revision to Diff 417125. sstwcw marked an inline comment as done. sstwcw added a comment. remove unnecessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121906/new/ https://reviews.llvm.org/D121906 Files:

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_help.py:29 +def get_help_output(): +args = ["clang-format", "--help"] +cmd = subprocess.Popen(args, stdout=subprocess.PIPE, You intentionally did not write `build/bin/clang-format` to

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

hubert.reinterpretcast added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3-2b.cpp:17-22 +constexpr int g() { // expected-error {{constexpr function never produces a constant expression}} + goto test;// expected-note {{subexpression not

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3397867 , @tra wrote: > In D122069#3397560 , @jhuber6 wrote: > >> I was definitely thinking about a lot of alternatives to making yet another >> on-disk binary format. I had a

[clang] cff34cc - Revert "[ASTMatchers] Output currently processing match and nodes on crash"

Author: Nathan James Date: 2022-03-21T22:29:22Z New Revision: cff34ccb605aa78030cd51cfe44362ed1c1fb80b URL: https://github.com/llvm/llvm-project/commit/cff34ccb605aa78030cd51cfe44362ed1c1fb80b DIFF: https://github.com/llvm/llvm-project/commit/cff34ccb605aa78030cd51cfe44362ed1c1fb80b.diff LOG:

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417116. nickdesaulniers added a comment. - rebase on main, don't mass refomat tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D122189 Files:

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:85 + auto Tokens = annotate("x - 0"); + EXPECT_EQ(Tokens.size(), 4u) << Tokens; + EXPECT_TOKEN(Tokens[1], tok::minus, TT_BinaryOperator);

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3397508 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/54785/step_7.txt > > Please take a look, and revert for now if takes a while to fix. Seems to be that on windows we aren't

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw updated this revision to Diff 417115. sstwcw marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/ https://reviews.llvm.org/D121754 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D121450: [clang-format] Handle attributes before case label.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1826 + if (Style.isJavaScript() && Line->MustBeDeclaration) +// 'case: string' field declaration. +break; Here's the loop. In the switch before

[PATCH] D122188: [Clang] update_cc_test_checks on 2 ARM NEON tests. NFC

nickdesaulniers added a comment. Now that I can more easily see the actual diff (https://reviews.llvm.org/D122189), let me see if I can simply rebase https://reviews.llvm.org/D122189 on main so that we can drop this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf69f63df2c: [Clang] Fix an unused-but-set-variable warning with volatile variable (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bdf69f6 - [Clang] Fix an unused-but-set-variable warning with volatile variable

Author: Yonghong Song Date: 2022-03-21T14:59:03-07:00 New Revision: bdf69f63df2cf4c9e3cd1af5cfcd503bc8e2869b URL: https://github.com/llvm/llvm-project/commit/bdf69f63df2cf4c9e3cd1af5cfcd503bc8e2869b DIFF: https://github.com/llvm/llvm-project/commit/bdf69f63df2cf4c9e3cd1af5cfcd503bc8e2869b.diff

[PATCH] D121907: [clang-format] Use an enum for context types. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sstwcw marked an inline comment as done. Closed by commit rG8c31b68f4876: [clang-format] Use an enum for context types. NFC (authored by sstwcw). Repository: rG

[clang] 8c31b68 - [clang-format] Use an enum for context types. NFC

Author: sstwcw Date: 2022-03-21T21:58:17Z New Revision: 8c31b68f4876ca81fa2038b5b2990b3d7b53a77c URL: https://github.com/llvm/llvm-project/commit/8c31b68f4876ca81fa2038b5b2990b3d7b53a77c DIFF: https://github.com/llvm/llvm-project/commit/8c31b68f4876ca81fa2038b5b2990b3d7b53a77c.diff LOG:

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers created this revision. nickdesaulniers added a reviewer: DavidSpickett. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The generated

[PATCH] D122188: [Clang] update_cc_test_checks on 2 ARM NEON tests. NFC

nickdesaulniers created this revision. nickdesaulniers added a reviewer: DavidSpickett. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm planning to

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

tra added a comment. In D122069#3397560 , @jhuber6 wrote: > I was definitely thinking about a lot of alternatives to making yet another > on-disk binary format. I had a few discussions with @JonChesterfield on the > subject. There were two things that

[clang] 5b81158 - Revert "[clang-format] Handle attributes before case label."

Author: Jorge Gorbe Moya Date: 2022-03-21T14:39:14-07:00 New Revision: 5b811586758808ce3335272d5b41852cf87666c7 URL: https://github.com/llvm/llvm-project/commit/5b811586758808ce3335272d5b41852cf87666c7 DIFF:

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added a comment. LMK if there are other folks more suited to review this, I'm not sure... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 ___

[PATCH] D121450: [clang-format] Handle attributes before case label.

jgorbe added a comment. Hi, We've observed that this patch introduces infinite loops in some cases. Here's a reduced test case: export class Foo extends Bar { get case(): Case { return ( (this.Bar$has('case')) ? (this.Bar$get('case')) :

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 417101. kwk added a comment. - Remove duplicate assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

arphaman added a comment. `clang -x objective-c++ -Weverything -std=c++14 -c test.mm` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121748/new/ https://reviews.llvm.org/D121748 ___ cfe-commits mailing

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 417099. kwk added a comment. - Remove left-over comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

bulbazord added a comment. In D121748#3397715 , @arphaman wrote: > I don't think this patch is sound. I found this problem with this change when > the following file is compiled in Objective-C++ mode: > > template > T umax(T a, T b) { > return

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

This revision was automatically updated to reflect the committed changes. Closed by commit rG063bd3b886b2: [format] Use int8_t as the underlying type of all enums in FormatStyle (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 063bd3b - [format] Use int8_t as the underlying type of all enums in FormatStyle

Author: Konrad Kleine Date: 2022-03-21T21:19:00Z New Revision: 063bd3b886b2e9baf35de5655807d150dd727038 URL: https://github.com/llvm/llvm-project/commit/063bd3b886b2e9baf35de5655807d150dd727038 DIFF: https://github.com/llvm/llvm-project/commit/063bd3b886b2e9baf35de5655807d150dd727038.diff

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked 3 inline comments as done. kwk added a comment. @HazardyKnusperkeks thank you for the approval. Can you have one last view please? I've introduced a function to get the match instead of repeating the for loop two times. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 417097. kwk marked an inline comment as done. kwk added a comment. - introduce getIncludeNameFromMatches - Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

dblaikie added a comment. In D121328#3396984 , @aaron.ballman wrote: >> once we figure out what to do about the change in behavior for >> -Wnon-c-typedef-for-linkage > > The devil is in the details; I'm not sure what to do here. I don't think >

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rGedbb99a7edc6: Ensure -extract-api handles multiple headers correctly (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/

[clang] edbb99a - Ensure -extract-api handles multiple headers correctly

Author: Daniel Grumberg Date: 2022-03-21T21:04:47Z New Revision: edbb99a7edc6f2dca0ebb27d95c624aa6479eb21 URL: https://github.com/llvm/llvm-project/commit/edbb99a7edc6f2dca0ebb27d95c624aa6479eb21 DIFF: https://github.com/llvm/llvm-project/commit/edbb99a7edc6f2dca0ebb27d95c624aa6479eb21.diff

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin added a subscriber: erichkeane. cor3ntin added a comment. In D111400#3397533 , @hubert.reinterpretcast wrote: > LGTM with minor nit. Thank you. Thanks a lot for the review. I will probably merge tomorrow unless @aaron.ballman or @erichkeane

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

arphaman added a comment. I don't think this patch is sound. I found this problem with this change when the following file is compiled in Objective-C++ mode: template T umax(T a, T b) { return a; } produces this error: test.mm:3:3: error: declaration of 'umax' shadows template

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman created this revision. dgoldman added reviewers: sammccall, doug.gregor. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang,

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin updated this revision to Diff 417084. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9edeceaece60: [libTooling] Generalize string explanation as templated metadata (authored by li.zhe.hua, committed by ymandel). Repository: rG

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

efriedma accepted this revision. efriedma added a comment. In D121715#3397446 , @yonghong-song wrote: > The 'j++' is not warned as it is not a BinaryOperator or CXXOperatorCallExpr > so it is not handled and considered no warning by default. > This

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. But please fix the format. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370

[PATCH] D120884: [format] Use int8_t as the underlying type of all enums in FormatStyle

owenpan accepted this revision. owenpan added a comment. Should we also simplify the regex https://github.com/llvm/llvm-project/blob/a3248e4b28ce09c3a749ecae5378dd0b3a8d42b1/clang/docs/tools/dump_format_style.py#L263? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 ___

[clang-tools-extra] 9edecea - [libTooling] Generalize string explanation as templated metadata

Author: Eric Li Date: 2022-03-21T20:39:35Z New Revision: 9edeceaece606125fa392e1648e549d256df423a URL: https://github.com/llvm/llvm-project/commit/9edeceaece606125fa392e1648e549d256df423a DIFF: https://github.com/llvm/llvm-project/commit/9edeceaece606125fa392e1648e549d256df423a.diff LOG:

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3248e4b28ce: [CUDA] Add getTargetFeatures for the NVPTX toolchain (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122089/new/

[clang] a3248e4 - [CUDA] Add getTargetFeatures for the NVPTX toolchain

Author: Joseph Huber Date: 2022-03-21T16:32:36-04:00 New Revision: a3248e4b28ce09c3a749ecae5378dd0b3a8d42b1 URL: https://github.com/llvm/llvm-project/commit/a3248e4b28ce09c3a749ecae5378dd0b3a8d42b1 DIFF: https://github.com/llvm/llvm-project/commit/a3248e4b28ce09c3a749ecae5378dd0b3a8d42b1.diff

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang added a comment. This is up as a "draft" right now. I am waiting on https://reviews.llvm.org/D122160 to land before doing a final rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang created this revision. dang added reviewers: ributzka, zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before actually executing the ExtractAPIAction, clear the

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 added a comment. In D122069#3397373 , @tra wrote: >> I decided to use a custom format rather than using an existing format (ELF, >> JSON, etc) because of the specialty use-case of this. > > Will we ever need to process the files with tools built

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor nit. Thank you. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:4 + +struct NonLiteral { //cxx2a-note

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

mstorsjo added a comment. @rnk Can you have a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 ___ cfe-commits mailing list

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/54785/step_7.txt Please take a look, and revert for now if takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/

[PATCH] D120360: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua updated this revision to Diff 417063. li.zhe.hua added a comment. Fix issue with "explicit specialization in non-namespace scope" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw added a comment. In D122160#3397366 , @tschuett wrote: > Would you mind putting a high level description of the intent at the top of > the main header. > > Maybe even a link at https://github.com/apple/swift-docc-symbolkit Sure thing!

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song updated this revision to Diff 417060. yonghong-song added a comment. - fix typo - add a new test case with typedef of volatile type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121715/new/ https://reviews.llvm.org/D121715 Files:

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song added a comment. In D121715#3397407 , @efriedma wrote: > In D121715#3397215 , @xbolva00 > wrote: > >> If there is j = j + 1 .. do we warn ? > > > > In D121715#3397237

[PATCH] D122169: [libTooling] Generalize string explanation as templated metadata

li.zhe.hua created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Change RewriteRule from holding an `Explanation` to being

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2033 return; + unsigned DiagID = isa(VD) ? diag::warn_unused_but_set_parameter efriedma wrote: > (Accidental change?) Right. Thanks for catching this. This is a leftover from my

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

fwolff marked an inline comment as done. fwolff added a comment. Thanks for the quick review @aaron.ballman! I think I've addressed your comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605 + unless(isMacro()),

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

fwolff updated this revision to Diff 417054. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122111/new/ https://reviews.llvm.org/D122111 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

efriedma added a comment. In D121715#3397215 , @xbolva00 wrote: > If there is j = j + 1 .. do we warn ? In D121715#3397237 , @xbolva00 wrote: > j++; > > Should not we warn in this case? (Currently no

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1065 + if (Tok.isNot(tok::annot_pragma_fp) && + getLangOpts().getFPEvalMethod() != LangOptions::FEM_UnsetOnCommandLine && zahiraam wrote: > aaron.ballman wrote: > > This looks

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

tra added a comment. > I decided to use a custom format rather than using an existing format (ELF, > JSON, etc) because of the specialty use-case of this. Will we ever need to process the files with tools built with a different LLVM version? E.g clang and lld may be built separately from

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

tschuett added a comment. Would you mind putting a high level description of the intent at the top of the main header. Maybe even a link at https://github.com/apple/swift-docc-symbolkit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/

[PATCH] D122102: [clangd] Introduce "add subclass" tweak

njames93 added a comment. In its current incarnation, I struggle to see the use case for this. Most of the time Base classes live in header files are pretty much every time this tweak is applied you will then want to move the class. The idea about just implementing the interface I had started

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1065 + if (Tok.isNot(tok::annot_pragma_fp) && + getLangOpts().getFPEvalMethod() != LangOptions::FEM_UnsetOnCommandLine && aaron.ballman wrote: > This looks like it's going to

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:34 +/// Documentation comment is a vector of RawComment::CommentLine. +/// You should use the actual name of the type or "This" Comment at:

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd89f9e963e49: [ASTMatchers] Output currently processing match and nodes on crash (authored by njames93). Repository: rG LLVM Github Monorepo

[clang] d89f9e9 - [ASTMatchers] Output currently processing match and nodes on crash

Author: Nathan James Date: 2022-03-21T19:13:36Z New Revision: d89f9e963e4979466193dc6a15fe091bf7ca5c47 URL: https://github.com/llvm/llvm-project/commit/d89f9e963e4979466193dc6a15fe091bf7ca5c47 DIFF: https://github.com/llvm/llvm-project/commit/d89f9e963e4979466193dc6a15fe091bf7ca5c47.diff LOG:

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. In D119477#3397311 , @aaron.ballman wrote: > I've commit on your behalf in 403d7d8d7093d6637a006f8b3f75382294259d3f > , and > I'm going to add a

  1   2   3   >