[PATCH] D122567: [X86][AMX] enable amx cast intrinsics in FE.

xiangzhangllvm accepted this revision. xiangzhangllvm added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122567/new/ https://reviews.llvm.org/D122567

[PATCH] D122704: [Clang][CodeGen]Beautify dump format, add indent for nested struct and struct members

yihanaa created this revision. yihanaa added reviewers: erichkeane, aaron.ballman. yihanaa added a project: clang. Herald added a project: All. yihanaa requested review of this revision. Herald added a subscriber: cfe-commits. Beautify dump format, add indent for nested struct and struct members,

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

owenpan added a comment. In D121757#3415402 , @sstwcw wrote: > I ran check-clang after formatting the entire code base with the new version. > It turned out it did break some tests. It seems to be because it messed up > these comments. > > diff

[PATCH] D122682: [clang][DR] Add test for DR1227 and mark it as complete

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122682/new/ https://reviews.llvm.org/D122682

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Herald added a project: All. `speculable` implies no undefined behavior (so it can even be speculatively executed with arguments when the source code would not, but its

[PATCH] D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG10b2760da0fd: Revert [RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR (authored by khchen). Herald

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

beanz created this revision. beanz added reviewers: MaskRay, jdoerfert, kuhar, rnk, aaron.ballman, rsmith. Herald added subscribers: StephenFan, arphaman, mgorny. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL has a language feature

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS created this revision. FabioRS added a reviewer: sammccall. FabioRS added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. FabioRS requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Are you going to work on it? Just confirming. I am working on D122255 . The code generation part for the dynamic condition is useful. However, my understanding is that it is not according to the OpenMP 5.2 specification.

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet updated this revision to Diff 419014. abrachet added a comment. Herald added a subscriber: mgorny. - Add new build option `CLANG_CRASH_SAVE_TEMPS` which defaults to Off, or On if `CMAKE_BUILD_TYPE` is Debug. It retains the old behavior alongside the tar file. - Mark tests which use

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

vabridgers updated this revision to Diff 419013. vabridgers added a comment. Herald added a project: All. rebase, check ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118050/new/ https://reviews.llvm.org/D118050 Files:

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. I ran check-clang after formatting the entire code base with the new version. It turned out it did break some tests. It seems to be because it messed up these comments. diff --git a/clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.fallthrough/p1.cpp

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 419009. sstwcw retitled this revision from "[clang-format] Take out common code for parsing blocks" to "[clang-format] Take out common code for parsing blocks NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

sstwcw updated this revision to Diff 419007. sstwcw retitled this revision from "[clang-format] Refactor determineStarAmpUsage" to "[clang-format] Refactor determineStarAmpUsage NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121754/new/

[PATCH] D121756: [clang-format] Clean up code looking for if statements NFC

sstwcw updated this revision to Diff 419006. sstwcw retitled this revision from "[clang-format] Clean up code looking for if statements" to "[clang-format] Clean up code looking for if statements NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

xbolva00 added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122425: Pass -disable-llvm-passes to avoid running llvm passes

ahatanak added a comment. I removed `-O1` from the command line: https://github.com/llvm/llvm-project/commit/6ec79a15cbe9539faf121b5ad39f195dc611fc09 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122425/new/ https://reviews.llvm.org/D122425

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

bulbazord created this revision. bulbazord added a reviewer: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Motivation: The intent here is for use in Swift. When building a clang module for

[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. Fix looks good. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94189b42cc51: [HLSL] Fix MSFT Attribute parsing, add numthreads (authored by beanz). Changed prior to commit:

[clang] 94189b4 - [HLSL] Fix MSFT Attribute parsing, add numthreads

Author: Chris Bieneman Date: 2022-03-29T17:17:19-05:00 New Revision: 94189b42cc51b5fa8355957a976f0d8b4f8c312b URL: https://github.com/llvm/llvm-project/commit/94189b42cc51b5fa8355957a976f0d8b4f8c312b DIFF:

[PATCH] D122611: [clang][extract-api] Add support for macros

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:334 + using RecordMap = llvm::MapVector>; + /// /// Get the target triple for the ExtractAPI invocation. Extra/should-be-empty line here? Comment at:

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe8b2236ef9c: [analyzer] Fix RhsLoc and LhsLoc bitwidth must be same (authored by vabridgers, committed by einvbri vince.a.bridg...@ericsson.com).

[clang] fe8b223 - [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

Author: Vince Bridgers Date: 2022-03-29T17:08:19-05:00 New Revision: fe8b2236ef9cf873875135dcc41364911898698d URL: https://github.com/llvm/llvm-project/commit/fe8b2236ef9cf873875135dcc41364911898698d DIFF:

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/test/Analysis/addrspace-null.c:19 + +#if defined(AMDGCN) +// this crashes NoQ wrote: > Shouldn't this be `AMDGCN_TRIPLE`? fixed, thank you. Repository: rG LLVM

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers updated this revision to Diff 418996. vabridgers added a comment. fix typo in test - ready to land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/ https://reviews.llvm.org/D122513 Files:

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:2515-2540 SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp, void) {} SANITIZER_INTERFACE_WEAK_DEF(void, __dfsw___sanitizer_cov_trace_cmp1, void) {}

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1d34bafef56: [clang][extract-api] Add Objective-C protocol support (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d1d34ba - [clang][extract-api] Add Objective-C protocol support

Author: Zixu Wang Date: 2022-03-29T14:44:49-07:00 New Revision: d1d34bafef56b732b461e12032eaf030e609f55a URL: https://github.com/llvm/llvm-project/commit/d1d34bafef56b732b461e12032eaf030e609f55a DIFF: https://github.com/llvm/llvm-project/commit/d1d34bafef56b732b461e12032eaf030e609f55a.diff

[PATCH] D122685: [msan] Add link to the lifetime definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG122638d97d91: [msan] Add link to the lifetime definition (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 122638d - [msan] Add link to the lifetime definition

Author: Vitaly Buka Date: 2022-03-29T14:42:36-07:00 New Revision: 122638d97d913edcdfa8ccf921eb5929498166c7 URL: https://github.com/llvm/llvm-project/commit/122638d97d913edcdfa8ccf921eb5929498166c7 DIFF: https://github.com/llvm/llvm-project/commit/122638d97d913edcdfa8ccf921eb5929498166c7.diff

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. In D120159#3415112 , @kda wrote: > This appears to have broken buildbot: sanitizer-x86_64-linux-fast > > Validating if reversion clears it up. > > Then will revert. Fixed by 8f66f1371981bda1af1ca43d505e1bc5836b3e36

[clang] 8f66f13 - Fix memory leak in [Clang] Implement __builtin_source_location.

Author: James Y Knight Date: 2022-03-29T17:32:59-04:00 New Revision: 8f66f1371981bda1af1ca43d505e1bc5836b3e36 URL: https://github.com/llvm/llvm-project/commit/8f66f1371981bda1af1ca43d505e1bc5836b3e36 DIFF:

[PATCH] D122685: [msan] Add link to the lifetime definition

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122685/new/ https://reviews.llvm.org/D122685

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zixuw marked an inline comment as done. Closed by commit rG9b36e126fdb1: [clang][extract-api] Add Objective-C interface support (authored by zixuw). Repository: rG

[clang] 9b36e12 - [clang][extract-api] Add Objective-C interface support

Author: Zixu Wang Date: 2022-03-29T14:29:39-07:00 New Revision: 9b36e126fdb1da4d7e255e089ef225dfb130ef63 URL: https://github.com/llvm/llvm-project/commit/9b36e126fdb1da4d7e255e089ef225dfb130ef63 DIFF: https://github.com/llvm/llvm-project/commit/9b36e126fdb1da4d7e255e089ef225dfb130ef63.diff

[PATCH] D120159: [Clang] Implement __builtin_source_location.

kda added a comment. This appears to have broken buildbot: sanitizer-x86_64-linux-fast Validating if reversion clears it up. Then will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added a comment. (Just checking you've seen this is accepted and you can land when you're ready!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 ___

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka updated this revision to Diff 418979. vitalybuka added a comment. fix link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122685/new/ https://reviews.llvm.org/D122685 Files: clang/docs/MemorySanitizer.rst Index:

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka updated this revision to Diff 418978. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122685/new/ https://reviews.llvm.org/D122685 Files: clang/docs/MemorySanitizer.rst Index:

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122685 Files:

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

jcranmer-intel added a comment. Apologies for the drive-by comment, but I happened to be searching for TBAA reviews after lamenting the current documentation and this popped up. > Agreed, strict aliasing violations are already a problem with the current > level of TBAA support and we regularly

[PATCH] D122677: [prototype] include-cleaner library

sammccall updated this revision to Diff 418971. sammccall added a comment. doc and clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122677/new/ https://reviews.llvm.org/D122677 Files: clang-tools-extra/CMakeLists.txt

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield. Herald added subscribers: ormris, dexonsmith, guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits,

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

vitalybuka added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h:91 void __sanitizer_cov_trace_cmp8(); SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE + void __sanitizer_cov_trace_cmp_fp2();

[PATCH] D122682: [clang][DR] Add test for DR1227 and mark it as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1227 This

[PATCH] D122627: [HLSL] Fix MSFT Attribute parsing, add numthreads

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Basic/AttrDocs.td:6377 +are required. The ``X``, ``Y``, and ``Z`` values provided to the attribute +dictate the thread id. Total number of

[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

jhuber6 added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:350 + +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target=nvptx64-nvida-cuda -march=sm_70 \ +// RUN:

[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

MaskRay added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:350 + +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target=nvptx64-nvida-cuda -march=sm_70 \ +// RUN:

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Other than that, looks great now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/ https://reviews.llvm.org/D122513

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

NoQ added inline comments. Comment at: clang/test/Analysis/addrspace-null.c:19 + +#if defined(AMDGCN) +// this crashes Shouldn't this be `AMDGCN_TRIPLE`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/

[clang] dfde354 - NFC. Fixing warnings from adding DXContainer

Author: Chris Bieneman Date: 2022-03-29T14:46:24-05:00 New Revision: dfde354958ca49138349e1428bf2fc0414a73a43 URL: https://github.com/llvm/llvm-project/commit/dfde354958ca49138349e1428bf2fc0414a73a43 DIFF:

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 418961. fhahn added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I rebased the patch and added new pm support based on the latest version of D32198 Repository: rG LLVM Github Monorepo

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

erichkeane added a comment. In D122681#3414901 , @aaron.ballman wrote: > In D122681#3414900 , @erichkeane > wrote: > >> Ah! Release notes! > > I didn't add one because this is augmenting

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham updated this revision to Diff 418959. bnbarham added a comment. Keep using the redirection hack for the time being Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122549/new/ https://reviews.llvm.org/D122549 Files:

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

aaron.ballman added a comment. In D122681#3414900 , @erichkeane wrote: > Ah! Release notes! I didn't add one because this is augmenting https://reviews.llvm.org/D122656 which already added the release note. :-) Repository: rG LLVM Github

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

erichkeane added a comment. Ah! Release notes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122681/new/ https://reviews.llvm.org/D122681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122681: Don't diagnostic atomic object access as UB in an unevaluated context

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, erichkeane, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We started diagnosing this situation with a more clear diagnostic message, but

[PATCH] D122549: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham marked an inline comment as not done. bnbarham added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:273 - if (Status.getName() == Filename) { + if (!Status.IsVFSMapped) { // The name matches. Set the FileEntry. dexonsmith wrote: >

[PATCH] D122679: [OpenMP] Use offload bundler when outputting textual formats with new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, saiislam. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418950. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. would it make sense to submit separate patches for when (OMPC_when) and otherwise (OMPC_otherwise) clauses? The D120573 also has OMPC_when support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6323-6325 + // If there is more than 1 use, I don't really know what we can do. + // EmitStaticExternCAliases won't be able to do anything, and the ifunc + // diagnostic will have to catch this.

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

dang accepted this revision. dang added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6319 +/// If all uses of the GV are from an IFunc resolver, which can happen when the +/// IFunc resolver is a static-function, but the name ends up being different, +/// return the IFunc so it

[PATCH] D122611: [clang][extract-api] Add support for macros

dang updated this revision to Diff 418948. dang added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122611/new/ https://reviews.llvm.org/D122611 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

rjmccall added a comment. In D122573#3414357 , @fhahn wrote: > In D122573#3412109 , @rjmccall > wrote: > >> Hmm. We know that the big picture here, distinguishing pointers by pointee >> type, is going to be

[PATCH] D122677: [prototype] include-cleaner library

sammccall updated this revision to Diff 418946. sammccall added a comment. oops, remove "include is used" diagnostic from clang-tidy! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122677/new/ https://reviews.llvm.org/D122677 Files:

[PATCH] D122677: [prototype] include-cleaner library

sammccall created this revision. Herald added subscribers: carlosgalvezp, usaxena95, arphaman, mgrang, mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. See RFC

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e614c8eb50: [clang][DR] Test and mark DR1305 as complete (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c1e614c - [clang][DR] Test and mark DR1305 as complete

Author: Markus Böck Date: 2022-03-29T20:45:49+02:00 New Revision: c1e614c8eb5004582c4d8f153f30fbfd0fcbea94 URL: https://github.com/llvm/llvm-project/commit/c1e614c8eb5004582c4d8f153f30fbfd0fcbea94 DIFF: https://github.com/llvm/llvm-project/commit/c1e614c8eb5004582c4d8f153f30fbfd0fcbea94.diff

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

cor3ntin added a comment. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122674/new/ https://reviews.llvm.org/D122674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

zero9178 updated this revision to Diff 418941. zero9178 added a comment. Address reviewers comments: Group test nicely with the other dr namespaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122674/new/ https://reviews.llvm.org/D122674 Files: clang/test/CXX/drs/dr13xx.cpp

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122674/new/ https://reviews.llvm.org/D122674

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

cor3ntin added a comment. Looks good except I think it makes more sense to put the new test just before the first test Comment at: clang/test/CXX/drs/dr13xx.cpp:25 } namespace dr1310 { // dr1310: 5 I think it would make more sense to put the new test here

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

erichkeane closed this revision. erichkeane added a comment. committed in: de7cd3ccf563847a24e04fb920cd0e3c310ba5bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122670/new/

[clang] de7cd3c - [Clang][CodeGen]Remove anonymous tag locations

Author: wangyihan Date: 2022-03-29T11:38:29-07:00 New Revision: de7cd3ccf563847a24e04fb920cd0e3c310ba5bd URL: https://github.com/llvm/llvm-project/commit/de7cd3ccf563847a24e04fb920cd0e3c310ba5bd DIFF: https://github.com/llvm/llvm-project/commit/de7cd3ccf563847a24e04fb920cd0e3c310ba5bd.diff

[PATCH] D122648: [clang][extractapi] Tie API and serialization to the FrontendAction

zixuw added a comment. Mostly LGTM after addressing the inline comments. Comment at: clang/include/clang/ExtractAPI/FrontendActions.h:42-58 /// Prepare to execute the action on the given CompilerInstance. /// /// This is called before executing the action on any

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 418936. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D122673: Add kcfi_unchecked attribute

samitolvanen added a comment. Note that this was split from D119296 . In the previous discussion, @joaomoreira pointed out that this is very similar to `nocf_check` and proposed reusing that attribute. In an offline discussion, @pcc was concerned that an

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1305 This

[clang] 7a94a03 - NFC. Fixing rebase error

Author: Chris Bieneman Date: 2022-03-29T13:19:06-05:00 New Revision: 7a94a032f02515a66d2820c1bc331424be25f6d8 URL: https://github.com/llvm/llvm-project/commit/7a94a032f02515a66d2820c1bc331424be25f6d8 DIFF:

[PATCH] D122673: Add kcfi_unchecked attribute

samitolvanen created this revision. samitolvanen added reviewers: aaron.ballman, pcc, nickdesaulniers, ardb, kees, joaomoreira. Herald added subscribers: jdoerfert, martong. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic

sameerds accepted this revision. sameerds added a comment. LGTM! But not sure if @yaxunl and/or @arsenm should have another look at the final version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.org/D121951

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 418933. samitolvanen added a comment. Herald added subscribers: llvm-commits, pengfei, MaskRay, hiraditya. Herald added projects: LLVM, All. - Split the `kcfi_unchecked` attribute into a separate patch. - Based on feedback from kernel developers,

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

yihanaa added a comment. In D122670#3414574 , @erichkeane wrote: > Still LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122670/new/ https://reviews.llvm.org/D122670

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

erichkeane accepted this revision. erichkeane added a comment. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122670/new/ https://reviews.llvm.org/D122670 ___ cfe-commits mailing list

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

yihanaa updated this revision to Diff 418929. yihanaa added a comment. Add this change into ReleaseNotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122670/new/ https://reviews.llvm.org/D122670 Files: clang/docs/ReleaseNotes.rst

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

yihanaa added a comment. In D122670#3414549 , @erichkeane wrote: > I think Aaron wants release notes for just about everything :) Mind tossing > one on this patch? I'll commit for you after that. Thanks @erichkeane ,i try to add this change into

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think Aaron wants release notes for just about everything :) Mind tossing one on this patch? I'll commit for you after that. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122087: Add HLSL Language Option and Preprocessor

beanz added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401 +// The current shader stage itself +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - erichkeane wrote: > Why does this do a

[PATCH] D122670: [Clang][CodeGen]Remove anonymous tag locations

yihanaa created this revision. yihanaa added reviewers: erichkeane, aaron.ballman. Herald added a project: All. yihanaa requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove anonymous tag locations, powered by 'PrintingPolicy',

[PATCH] D122636: [llvm][clang][NFC] Add missing references to MisExpect in TOC

paulkirth abandoned this revision. paulkirth added a comment. Since I had to revert, these changes will be incorporated into the main patch when it lands again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122636/new/

[PATCH] D122087: Add HLSL Language Option and Preprocessor

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401 +// The current shader stage itself +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - Why does this do a double-assign

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 418924. paulkirth added a comment. Herald added a subscriber: arphaman. Fix missing reference in TOC & fix formatting of tables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

efriedma added a comment. > Maybe we should try improve our tooling to detect violations in parallel to > the effort in this patch? I am planning on trying to resurrect the > type-sanitizer patches. I've also been playing around with a simple tool > that's inserting assertions to check 2

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw marked an inline comment as done. zixuw added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:642-648 +// Instantiate template for FunctionDecl. +template FunctionSignature +DeclarationFragmentsBuilder::getFunctionSignature(const FunctionDecl *);

[clang] 6c32075 - [Clang][doc][NFC]Remove duplicate items in ReleaseNotes

Author: wangyihan Date: 2022-03-29T10:30:34-07:00 New Revision: 6c32075d29d4fe3985aa8a98b23c33902190a15d URL: https://github.com/llvm/llvm-project/commit/6c32075d29d4fe3985aa8a98b23c33902190a15d DIFF: https://github.com/llvm/llvm-project/commit/6c32075d29d4fe3985aa8a98b23c33902190a15d.diff

[PATCH] D122668: [Clang][doc][NFC]Remove duplicate items in ReleaseNotes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c32075d29d4: [Clang][doc][NFC]Remove duplicate items in ReleaseNotes (authored by yihanaa, committed by erichkeane). Repository: rG LLVM Github

[PATCH] D121951: [AMDGPU][OpenCL] Remove "printf and hostcall" diagnostic

scott.linder added a comment. In D121951#3414271 , @sameerds wrote: > In D121951#3411856 , @scott.linder > wrote: > >> @yaxunl Does excluding device-libs via COV_None make sense? >> >> @sameerds Would you still

  1   2   3   >