[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

jyknight added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. What's the status of this? Did the GCC proposal go anywhere? I'd be happy to see this move forward if you're also pushing it on the GCC side. Comment at:

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 421223. awarzynski added a comment. Make sure the MLIR CL options are "applied" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123297/new/ https://reviews.llvm.org/D123297 Files:

[PATCH] D123229: [clang][deps] Ensure deterministic file names on case-insensitive filesystems

jansvoboda11 updated this revision to Diff 421221. jansvoboda11 added a comment. Windows path separators... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123229/new/ https://reviews.llvm.org/D123229 Files:

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

psamolysov-intel marked an inline comment as done. psamolysov-intel added a comment. Colleagues, could you help me with landing? @tejohnson has approved the patch (if I applied the suggestion as it was expected, thank you @tejohnson!) CHANGES SINCE LAST ACTION

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

cameron.mcinally added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; nikic wrote: > cameron.mcinally wrote: > >

[PATCH] D123197: Remove a few effectively-unused FileEntry APIs. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2a7f1c3904e: Remove a few effectively-unused FileEntry APIs. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b2a7f1c - Remove a few effectively-unused FileEntry APIs. NFC

Author: Sam McCall Date: 2022-04-07T16:45:47+02:00 New Revision: b2a7f1c3904ede781565c6ed772f155167aa8325 URL: https://github.com/llvm/llvm-project/commit/b2a7f1c3904ede781565c6ed772f155167aa8325 DIFF: https://github.com/llvm/llvm-project/commit/b2a7f1c3904ede781565c6ed772f155167aa8325.diff

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

thakis added a comment. We're seeing the same problem here https://bugs.chromium.org/p/chromium/issues/detail?id=1314297=linux_upload_clang=2 Reverted in e22a60b1c898a760a73417fa225c2fbe0609a69f for now. Repository: rG

[clang] e22a60b - Revert "Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON"""

Author: Nico Weber Date: 2022-04-07T10:07:07-04:00 New Revision: e22a60b1c898a760a73417fa225c2fbe0609a69f URL: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f DIFF: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f.diff

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

benshi001 added a comment. In D123200#3436043 , @aykevl wrote: > What about chip families other than avr2 (the default)? Some have a different > PC pointer size (1-3 bytes, therefore affecting the ABI), some have different > instructions, etc. There

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

tschuett added a comment. Thanks. I let Aaron go over the details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123278/new/ https://reviews.llvm.org/D123278 ___ cfe-commits mailing list

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary updated this revision to Diff 421193. lenary marked 2 inline comments as done. lenary added a comment. - Updated set of safe instructions - Address reviewer feedback, including reordering passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

nemanjai accepted this revision. nemanjai added a comment. Please add a test case that would cause a failure prior to this patch due to the argument being emitted more than once (i.e. the test case that prompted this patch). If that is already added and I just missed it, please add a note to

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

aaron.ballman added a comment. Thanks for getting a start on this documentation, I appreciate it! Comment at: clang/docs/HLSLSupport.rst:11 + +HLSL Support is a new initiative underway in the Clang codebase. This document +describes the high level goals of the project, the

[PATCH] D123308: Handle a subtle hole in inline builtin handling

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, aaron.ballman, tstellar. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When an inline builtin

[PATCH] D123200: [compiler-rt][CMake] Add initial support of target AVR

aykevl added a comment. What about chip families other than avr2? Some have a different PC pointer size (1-3 bytes, therefore affecting the ABI), some have different instructions, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123200/new/

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 421186. erichkeane marked 2 inline comments as done. erichkeane added a comment. Make suggestions from @ChuanqiXu CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNotes.rst

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

erichkeane added a comment. I note that 'recursive' depth is limited to 1024: https://godbolt.org/z/h9bEfsToT Though I think there are other ways to get 'deeper' than that. So perhaps in any case we're just arranging deck chairs on a -post-error titanic :) Repository: rG LLVM Github

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane marked 8 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:4705 CheckConstraintSatisfaction( - NamedConcept, {NamedConcept->getConstraintExpr()}, Converted, + NamedConcept,

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

philnik added a comment. > Hmmm, I'd be more comfortable if this wasn't an ABI break for people using > the `__attribute__(())` spelling. If we wanted to surprise users with ABI > breaks, we'd just implement `[[no_unique_address]]` on Windows and break > users when Microsoft eventually

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123261/new/ https://reviews.llvm.org/D123261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

erichkeane added a comment. > I think people instantiate to deeper template depths than they typically have > for template parameters, so having a deeper depth made sense to me. Hmm... the cases I can think of make me think this isn't necessarily true... It is very common to template-recurse

[clang-tools-extra] dc15bed - Fix MSVC "not all control paths return a value" warning

Author: Simon Pilgrim Date: 2022-04-07T14:01:15+01:00 New Revision: dc15bedfb9de8ec574c1b480a15cd584b82eaa0d URL: https://github.com/llvm/llvm-project/commit/dc15bedfb9de8ec574c1b480a15cd584b82eaa0d DIFF: https://github.com/llvm/llvm-project/commit/dc15bedfb9de8ec574c1b480a15cd584b82eaa0d.diff

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123304 Files:

[PATCH] D123303: [Clang][AArch64][SVE] Add shift operators for SVE vector types

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3433919 , @erichkeane wrote: > Up for review: https://reviews.llvm.org/D123241 Thank you @erichkeane! That landed in a87f4e4f9808a397dc4c575013142c9eac0b7eba

[PATCH] D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! There's an open question about the circumstances under which we emit the `err_hlsl_attr_unsupported_in_stage` diagnostic, but if there's code to be changed there, it can

[PATCH] D121556: [randstruct] Add randomize structure layout support

aaron.ballman added a comment. Recap: aside from the function merging behavior and the possible question about assertions in tests, I think this is ready to go. Comment at: clang/lib/Sema/SemaDecl.cpp:27 #include "clang/AST/NonTrivialTypeVisitor.h" +#include

[PATCH] D123220: [clang] Verify internal entity module mangling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eda5fc0c6ea: [clang] Verify internal entity module mangling (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 9eda5fc - [clang] Verify internal entity module mangling

Author: Nathan Sidwell Date: 2022-04-07T05:40:57-07:00 New Revision: 9eda5fc0c6eafd772d0e6ff015352136c5e505a4 URL: https://github.com/llvm/llvm-project/commit/9eda5fc0c6eafd772d0e6ff015352136c5e505a4 DIFF:

Re: [PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

On Thu, Apr 7, 2022 at 8:35 AM Corentin via cfe-commits wrote: > > > > On Thu, Apr 7, 2022 at 2:11 PM Aaron Ballman via Phabricator > wrote: >> >> aaron.ballman added a comment. >> >> In D123298#3435796 , @cor3ntin >> wrote: >> >> > In D123298#3435770

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. In D123297#3435816 , @rovka wrote: > I don't know the command line library that well, so I have this curiosity: > what happens if LLVM and MLIR have 2 different options with the same name? Do > we get a compile time error?

Re: [PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

On Thu, Apr 7, 2022 at 2:11 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D123298#3435796 , @cor3ntin > wrote: > > > In D123298#3435770 , >

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski updated this revision to Diff 421168. awarzynski edited the summary of this revision. awarzynski added a comment. Fix pre-commit CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123297/new/ https://reviews.llvm.org/D123297 Files:

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've landed on your behalf in 7c3d8c8977cfc013254783b85b9fc6026566b35f . CHANGES SINCE LAST ACTION

[clang] 7c3d8c8 - Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

Author: Antonio Frighetto Date: 2022-04-07T08:20:54-04:00 New Revision: 7c3d8c8977cfc013254783b85b9fc6026566b35f URL: https://github.com/llvm/llvm-project/commit/7c3d8c8977cfc013254783b85b9fc6026566b35f DIFF:

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

aaron.ballman added a comment. In D123298#3435796 , @cor3ntin wrote: > In D123298#3435770 , @aaron.ballman > wrote: > >> Changes LGTM, I also don't think we should hit these limits. Perhaps we >> should add

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. In D122808#3435821 , @antoniofrighetto wrote: > Awesome, thank you for reviewing this! PS: I do not have commit access, feel > free to close it, if you say. Ah, thank you for letting me know you don't have commit access.

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm not an expert in CMake, but the changes look reasonable from what I do know. The current bot failures all look to be unrelated to the changes in this patch as best I can

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rovka wrote: > Is this the most llvm-ish option we have? I'm concerned

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Awesome, thank you for reviewing this! PS: I do not have commit access, feel free to close it, if you say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 ___

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka added a comment. I don't know the command line library that well, so I have this curiosity: what happens if LLVM and MLIR have 2 different options with the same name? Do we get a compile time error? Or is there a risk that someone might -mllvm -XYZ and it would end up in MLIR's XYZ

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

cor3ntin added a comment. In D123298#3435770 , @aaron.ballman wrote: > Changes LGTM, I also don't think we should hit these limits. Perhaps we > should add some assertions to the ctor and the setter functions just to be > sure though? If we are going

[clang] 82d0f7b - [Clang] Remove redundant -no-opaque-pointers flag in test (NFC)

Author: Nikita Popov Date: 2022-04-07T13:53:37+02:00 New Revision: 82d0f7bdb5b542118f54aa03fac52e7a8f776123 URL: https://github.com/llvm/llvm-project/commit/82d0f7bdb5b542118f54aa03fac52e7a8f776123 DIFF: https://github.com/llvm/llvm-project/commit/82d0f7bdb5b542118f54aa03fac52e7a8f776123.diff

[clang] b1ea019 - [clang][DebugInfo] Support debug info for alias variable

Author: Kavitha Natarajan Date: 2022-04-07T17:15:40+05:30 New Revision: b1ea0191a42074341847d767609f66a26b6d5a41 URL: https://github.com/llvm/llvm-project/commit/b1ea0191a42074341847d767609f66a26b6d5a41 DIFF:

[PATCH] D120989: Support debug info for alias variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ea0191a420: [clang][DebugInfo] Support debug info for alias variable (authored by kavitha-natarajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 421159. mboehme added a comment. Add documentation and a unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/include/clang/Basic/Attr.td

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes LGTM, I also don't think we should hit these limits. Perhaps we should add some assertions to the ctor and the setter functions just to be sure though? Repository: rG

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry added a comment. Hi, I've got yet another one. Luckily, nothing wrong with clang-format 10, all were fine. This one was the only option incorrectly marked as clang-format 9. Note, AllowShortIfStatementsOnASingleLine was introduced by 1b750edda14879a16ce782b3ade3af599bfbb717

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. In D116203#3434761 , @rjmccall wrote: > In D116203#3434515 , @cjdb wrote: > >> In D116203#3431612 , @rjmccall >> wrote: >> >>> In

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, aaron.ballman, cor3ntin. ChuanqiXu added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found

[clang-tools-extra] be572e1 - [clangd] NFC: Fix doc typos

Author: Kirill Bobyrev Date: 2022-04-07T12:56:56+02:00 New Revision: be572e1e1d297039129b0c4ff2deffd817e42f30 URL: https://github.com/llvm/llvm-project/commit/be572e1e1d297039129b0c4ff2deffd817e42f30 DIFF:

[clang] b16a3b4 - [Clang] Add -no-opaque-pointers to more tests (NFC)

Author: Nikita Popov Date: 2022-04-07T12:53:29+02:00 New Revision: b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf URL: https://github.com/llvm/llvm-project/commit/b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf DIFF: https://github.com/llvm/llvm-project/commit/b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf.diff

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new interface and fixes! (Current Precommit CI failures look unrelated to me.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. I've read the whole patch. It looks good to me roughly except some style issues and the 2 places you marked as ` Attn Reviewers`. Let's try to fix them one by one. Comment at: clang/lib/Sema/SemaTemplate.cpp:4705 CheckConstraintSatisfaction(

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett added reviewers: amilendra, tmatheson. DavidSpickett added a comment. The background here is that I want to automate what I did in https://reviews.llvm.org/D121999 and thought I could do that by passing 0xf...f to getExtensionFeatures. I thought there might be some reason to not

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski created this revision. awarzynski added a reviewer: rovka. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This takes the AARCH64_ARCH_EXT_NAME in

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

dang created this revision. dang added reviewers: zixuw, ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123295 Files:

[PATCH] D123115: [OpaquePtrs][Clang] Add -no-opaque-pointers to tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG532dc62b9075: [OpaquePtrs][Clang] Add -no-opaque-pointers to tests (NFC) (authored by nikic). Herald added a project: clang. Herald added a

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF, CanonicalType, FieldLV, Align, Func, Lvl

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang updated this revision to Diff 421143. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Looks like this causes a relocation failure on this buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/7311 ld.lld: error: relocation R_MIPS_64 cannot be used against local symbol; recompile with -fPIC >>> defined in

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 421134. manas added a comment. Format constant-folding.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

dang accepted this revision. dang added a comment. LGTM thanks for spotting this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259 ___ cfe-commits mailing list

[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5479174071ec: [clang][ASTImporter] Not using consumeError at failed import of in-class… (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D122528?vs=418395=421132#toc

[clang] 5479174 - [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

Author: Balázs Kéri Date: 2022-04-07T11:07:15+02:00 New Revision: 5479174071ec7d4692959bbdc15b5bb79e268e00 URL: https://github.com/llvm/llvm-project/commit/5479174071ec7d4692959bbdc15b5bb79e268e00 DIFF: https://github.com/llvm/llvm-project/commit/5479174071ec7d4692959bbdc15b5bb79e268e00.diff

[clang-tools-extra] 817df79 - [clang-tidy] Silence unused variable warning in release builds. NFCI.

Author: Benjamin Kramer Date: 2022-04-07T11:00:28+02:00 New Revision: 817df7999a71a5dbda0025b75612b54160fb5f9c URL: https://github.com/llvm/llvm-project/commit/817df7999a71a5dbda0025b75612b54160fb5f9c DIFF:

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka added a comment. Just for the record, I'd like to speak in favor of option 2 - merge the patch now, but put the functionality behind a flag. This sounds like a good compromise to me. I think if we choose an inconspicuous name like -fexperimentail-test-driver-integration-with-cmake (or

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet created this revision. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. In D123211#3433059 , @awarzynski wrote: > Thanks for taking a look Diana! > >> Why not use the BackendAction for this? > > This action only requires

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 421122. manas added a comment. Fix comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[clang] 5390606 - [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option

Author: Nikita Popov Date: 2022-04-07T10:14:56+02:00 New Revision: 5390606aa963a7b415da65aa8120efbbafd30401 URL: https://github.com/llvm/llvm-project/commit/5390606aa963a7b415da65aa8120efbbafd30401 DIFF: https://github.com/llvm/llvm-project/commit/5390606aa963a7b415da65aa8120efbbafd30401.diff

[PATCH] D123122: [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5390606aa963: [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

hans added a comment. In D123070#3430207 , @ekieri wrote: > @hans , thanks, that is a valid concern. I was asked to add closing comments > on an earlier patch though, and I find them particularly useful (when > accurate...) in this file, which does not

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added inline comments. Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:994 + enum A { Zero = 0, One = 1 }; + enum B { IntMax = INT_MAX, ULongLongMax = ULLONG_MAX }; + enum class C : unsigned { Two = 2 }; aaron.ballman wrote: > It looks like

[PATCH] D123286: Patch for : omp nothing

koops created this revision. koops added reviewers: dreachem, soumitra, cchen, jdoerfert. Herald added a project: All. koops requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Patch to support "#pragma omp nothing"

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc7ed0caaca5: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D118370?vs=416435=421112#toc

[clang-tools-extra] cc7ed0c - [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

Author: Balázs Kéri Date: 2022-04-07T09:38:58+02:00 New Revision: cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02 URL: https://github.com/llvm/llvm-project/commit/cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02 DIFF: https://github.com/llvm/llvm-project/commit/cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02.diff

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 42. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index:

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a subscriber: owenpan. kuzkry added a comment. @owenpan, thank you for delivery. > You just could ask for push rights, especially if you want to change > something more in the future. I will request it then. Hopefully I get accepted as apparently they check for a good "record of

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 421103. balazske added a comment. Removed a left comment and improved another comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files:

<    1   2