[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith updated this revision to Diff 424379. rsmith added a comment. - Fix some code that was making incorrect assumptions that PseudoObjectExpr is only used for ObjC properties. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/

[clang] 3b3dd76 - Use range based for loop in Sema::CheckParameterPacksForExpansion. NFC

Author: Jun Zhang Date: 2022-04-22T13:31:31+08:00 New Revision: 3b3dd76d8da80ff91295d8c0c23de8462ac22b49 URL: https://github.com/llvm/llvm-project/commit/3b3dd76d8da80ff91295d8c0c23de8462ac22b49 DIFF: https://github.com/llvm/llvm-project/commit/3b3dd76d8da80ff91295d8c0c23de8462ac22b49.diff

[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

khchen added a comment. In D124186#3465136 , @craig.topper wrote: > The intrinsic interface doesn't care about 0 give user control of vstart. Nearly every instruction is undisturbed for > 0 > But having said that it probably makes sense to keep the

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

MaskRay updated this revision to Diff 424374. MaskRay added a comment. I still do not see the argument about C API, but I just drop that changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124063/new/ https://reviews.llvm.org/D124063 Files:

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11 +} __attribute__((aligned(1))); +struct MyType mt; + You can drop

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl updated this revision to Diff 424364. yaxunl added a comment. use basicGVALinkageForFunction CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124189/new/ https://reviews.llvm.org/D124189 Files: clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added inline comments. Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:17 +// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11}} #include Mordante wrote:

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added a comment. close with clang format at commit 6454ff35e0e7b0c0762c640031aa6c2b5d1f16ec [Clang Format] emmintrin.h smmintrin.h (NFC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] afa536e - [x86] Support 3 builtin functions for 32-bits mode

Author: Xiang1 Zhang Date: 2022-04-22T11:28:28+08:00 New Revision: afa536e33e10536380ccf67732fa3a101facab92 URL: https://github.com/llvm/llvm-project/commit/afa536e33e10536380ccf67732fa3a101facab92 DIFF: https://github.com/llvm/llvm-project/commit/afa536e33e10536380ccf67732fa3a101facab92.diff

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa536e33e10: [x86] Support 3 builtin functions for 32-bits mode (authored by xiangzhangllvm). Herald added a project: clang. Changed prior to

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Thanks for the review, Gabor! Now I'll work on rebasing the patch and testing one final time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/56771/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12300 + (D->hasAttr() && + GetGVALinkageForFunction(cast(D), + /*IgnoreCUDAGlobalAttr=*/true) == tra wrote: > yaxunl wrote: > > tra wrote: >

[clang] a7815d3 - [randstruct] Check final randomized layout ordering

Author: Bill Wendling Date: 2022-04-21T19:41:00-07:00 New Revision: a7815d33bf8f955f2a1888abbccf974bd4858f79 URL: https://github.com/llvm/llvm-project/commit/a7815d33bf8f955f2a1888abbccf974bd4858f79 DIFF: https://github.com/llvm/llvm-project/commit/a7815d33bf8f955f2a1888abbccf974bd4858f79.diff

[PATCH] D124199: [randstruct] Check final randomized layout ordering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7815d33bf8f: [randstruct] Check final randomized layout ordering (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void updated this revision to Diff 424357. void added a comment. Fixed "std::vector" mishap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199 Files: clang/lib/AST/Randstruct.cpp

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:153 - std::shuffle(std::begin(Buckets), std::end(Buckets), RNG); + llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG); MaskRay wrote: > This was my original fix and your reland

[PATCH] D124157: [clang][preprocessor] Add more macros to target AVR

benshi001 updated this revision to Diff 424355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124157/new/ https://reviews.llvm.org/D124157 Files: clang/lib/Basic/Targets/AVR.cpp clang/test/Preprocessor/avr-common.c Index: clang/test/Preprocessor/avr-common.c

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

maryammo added a comment. It seems it breaks the following builds: https://lab.llvm.org/buildbot/#/builders/121/builds/18618 https://lab.llvm.org/buildbot/#/builders/57/builds/17125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123668/new/

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added a comment. (In general, be wary when you write a CL desc that goes "people currently do X in the following N ways, so let's add a N+1th way". This feels short-term good for you since the N+1th way is written exactly like you'd write it – you wrote it, after all! But for everyone

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

thakis added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:18 + clangBasic + clangFrontend + ) Making clang/lib/Testing depend on clangFrontend (and hence on basically everything) seems pretty heavy. Maybe this should be in a new library?

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith updated this revision to Diff 424350. rsmith added a comment. - Some improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files: clang/docs/LanguageExtensions.rst

[clang] caf5ad5 - Revert "[x86] Support 3 builtin functions for 32-bits mode"

Author: Xiang1 Zhang Date: 2022-04-22T09:11:40+08:00 New Revision: caf5ad5da7c2d0dc7a2c2efecc26f4803d283d24 URL: https://github.com/llvm/llvm-project/commit/caf5ad5da7c2d0dc7a2c2efecc26f4803d283d24 DIFF: https://github.com/llvm/llvm-project/commit/caf5ad5da7c2d0dc7a2c2efecc26f4803d283d24.diff

[clang] a69c219 - [x86] Support 3 builtin functions for 32-bits mode

Author: Xiang1 Zhang Date: 2022-04-22T09:06:25+08:00 New Revision: a69c219a8c9f7eaff142b6b4d135ac0456e0d4ae URL: https://github.com/llvm/llvm-project/commit/a69c219a8c9f7eaff142b6b4d135ac0456e0d4ae DIFF: https://github.com/llvm/llvm-project/commit/a69c219a8c9f7eaff142b6b4d135ac0456e0d4ae.diff

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added a comment. I'm not entirely sure whether I want to pursue this -- I'd prefer to have only a single mechanism that works well in both C and C++, rather than this (which is flexible but not really usable in C) and `__builtin_dump_struct` (which is extremely inflexible but works well

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

nirvedhmeshram added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. Hello, I was interested in using `llvm.nvvm.cp.async.cg.shared.global.8` and `llvm.nvvm.cp.async.cg.shared.global.4` and was wondering if there is some fundamental reason they

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith created this revision. rsmith added reviewers: aaron.ballman, erichkeane, yihanaa. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This builtin, like __builtin_dump_struct, allows for limited

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:596 + MF.getFunction().getSubprogram(), ()) + << "--"; + }); scott.linder wrote: > This seems like the wrong place to

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 424344. vangthao added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move remarks into its own function. Skip if !ORE. Add clang frontend test. Remove LDSSpillSize. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// RKSimon wrote: > xiangzhangllvm wrote: >

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. Oh, one other tiny detail I forgot to mention. I noticed that the tag is pushing the functions 6 bytes forward, regardless of any prepending padding nops that were added to ensure 16b alignment. It would be cool to care about the proper function alignment and also

[PATCH] D124215: [clang-format][NFC] Use isComment() in setCommentLineLevels()

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also replace

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. I played a little bit with kcfi and here are some thoughts: - under -Os I saw functions being inlined, regardless of the source code calling them indirectly. In these scenarios, the KCFI check was still in place, even though there was not a pointer involved in the

[clang] 3348991 - [OpenMP] Properly guard linker input using the new driver

Author: Joseph Huber Date: 2022-04-21T18:50:26-04:00 New Revision: 334899110639297d62618f2bb5f8da9c0c46698a URL: https://github.com/llvm/llvm-project/commit/334899110639297d62618f2bb5f8da9c0c46698a DIFF: https://github.com/llvm/llvm-project/commit/334899110639297d62618f2bb5f8da9c0c46698a.diff

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen created this revision. samitolvanen added reviewers: aaron.ballman, pcc, nickdesaulniers, ardb, kees, joaomoreira. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With

[PATCH] D124210: Revert "[clang][safestack] Remove triple from stack usage test"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8786413d800: Revert [clang][safestack] Remove triple from stack

[clang] b878641 - Revert "[clang][safestack] Remove triple from stack usage test"

Author: Paul Kirth Date: 2022-04-21T22:47:56Z New Revision: b8786413d8007f6864f0dc55d95a09c232e3 URL: https://github.com/llvm/llvm-project/commit/b8786413d8007f6864f0dc55d95a09c232e3 DIFF: https://github.com/llvm/llvm-project/commit/b8786413d8007f6864f0dc55d95a09c232e3.diff LOG:

[PATCH] D124210: Revert "[clang][safestack] Remove triple from stack usage test"

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 414f84ba29d96c8cbbe198cfc022146e4582cbef

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12300 + (D->hasAttr() && + GetGVALinkageForFunction(cast(D), + /*IgnoreCUDAGlobalAttr=*/true) == yaxunl wrote: > tra wrote: > > yaxunl wrote: >

[PATCH] D124203: [clang][safestack] Remove triple from stack usage test

paulkirth added a comment. unfortunately it breaks many other tests, so we probably need to revert this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124203/new/ https://reviews.llvm.org/D124203 ___

[PATCH] D124203: [clang][safestack] Remove triple from stack usage test

vvereschaka added a comment. Thank you @paulkirth. I have tested these changes locally on the builder. It works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124203/new/ https://reviews.llvm.org/D124203

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

efriedma added a comment. (Please mark this "closed" to reflect the fact that it was merged.) Comment at: clang/lib/Sema/JumpDiagnostics.cpp:935 +LabelStmt *Label = cast(To); +Label->setSideEntry(true); } tentzen wrote: > rjmccall wrote: > > This

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ff992bca208: [DEBUG-INFO] Change how we handle auto return types for lambda operator() to be… (authored by shafik). Herald added a project: clang.

[clang] 5ff992b - [DEBUG-INFO] Change how we handle auto return types for lambda operator() to be consistent with gcc

Author: Shafik Yaghmour Date: 2022-04-21T14:58:50-07:00 New Revision: 5ff992bca208a0e37ca6338fc735aec6aa848b72 URL: https://github.com/llvm/llvm-project/commit/5ff992bca208a0e37ca6338fc735aec6aa848b72 DIFF:

[PATCH] D124203: [clang][safestack] Remove triple from stack usage test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG414f84ba29d9: [clang][safestack] Remove triple from stack usage test (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall added a comment. In D123668#3465771 , @vitalybuka wrote: > Breaks multiple builders > https://lab.llvm.org/buildbot/#/builders/169/builds/7648 > https://lab.llvm.org/buildbot/#/builders/70/builds/20812 >

[clang] 414f84b - [clang][safestack] Remove triple from stack usage test

Author: Paul Kirth Date: 2022-04-21T21:58:24Z New Revision: 414f84ba29d96c8cbbe198cfc022146e4582cbef URL: https://github.com/llvm/llvm-project/commit/414f84ba29d96c8cbbe198cfc022146e4582cbef DIFF: https://github.com/llvm/llvm-project/commit/414f84ba29d96c8cbbe198cfc022146e4582cbef.diff LOG:

[PATCH] D124152: [clang-format] Fix a crash on AllowShortFunctionsOnASingleLine

This revision was automatically updated to reflect the committed changes. Closed by commit rG221c2b68ddc6: [clang-format] Fix a crash on AllowShortFunctionsOnASingleLine (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 221c2b6 - [clang-format] Fix a crash on AllowShortFunctionsOnASingleLine

Author: owenca Date: 2022-04-21T14:56:30-07:00 New Revision: 221c2b68ddc6efc97739ab8ab8e41f1a086fef6c URL: https://github.com/llvm/llvm-project/commit/221c2b68ddc6efc97739ab8ab8e41f1a086fef6c DIFF: https://github.com/llvm/llvm-project/commit/221c2b68ddc6efc97739ab8ab8e41f1a086fef6c.diff LOG:

[PATCH] D124199: [randstruct] Check final randomized layout ordering

MaskRay added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:153 - std::shuffle(std::begin(Buckets), std::end(Buckets), RNG); + llvm::shuffle(std::begin(Buckets), std::end(Buckets), RNG); This was my original fix and your reland dropped it :(

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

vitalybuka added a comment. Breaks multiple builders https://lab.llvm.org/buildbot/#/builders/169/builds/7648 https://lab.llvm.org/buildbot/#/builders/70/builds/20812 https://lab.llvm.org/buildbot/#/builders/77/builds/16736 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added a comment. @vvereschaka I have a fix out in D124203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 ___

[PATCH] D124203: [clang][safestack] Remove triple from stack usage test

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Supplying the target triple caused breakeages for compilers that don't support the supplied triple. Repository: rG

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik updated this revision to Diff 424300. shafik added a comment. -Replacing CHECK-NEXT with CHECK CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/no_auto_return_lambda.cpp

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added a comment. In D119996#3465735 , @vvereschaka wrote: > Hi @paulkirth, > > using of specific triple within `stack-usage-safestack.c` test causes a > failure for the compilers, which don't support these triples (arm/aarch64 in > my case).

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

vvereschaka added a comment. Hi @paulkirth, using of specific triple within `stack-usage-safestack.c` test causes a failure for the compilers, which don't support these triples (arm/aarch64 in my case). Such as: error: unable to create target: 'No available targets are compatible with

[clang] 713800d - [Testing] Fix standalone builds after a7691dee2d3c0ea3f9f4d1

Author: Sam McCall Date: 2022-04-21T23:22:46+02:00 New Revision: 713800d331da199dd387820d1630f0173cba8c8f URL: https://github.com/llvm/llvm-project/commit/713800d331da199dd387820d1630f0173cba8c8f DIFF: https://github.com/llvm/llvm-project/commit/713800d331da199dd387820d1630f0173cba8c8f.diff

[clang] f6a5ab6 - Use builtin recognition to detect std::move / std::forward.

Author: Richard Smith Date: 2022-04-21T14:21:07-07:00 New Revision: f6a5ab6c8c316fa4f60e40030586e230920a63ea URL: https://github.com/llvm/llvm-project/commit/f6a5ab6c8c316fa4f60e40030586e230920a63ea DIFF: https://github.com/llvm/llvm-project/commit/f6a5ab6c8c316fa4f60e40030586e230920a63ea.diff

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2046-2048 static llvm::Value *dumpRecord(CodeGenFunction , QualType RType, LValue RecordLV, CharUnits Align, + bool dumpTypeName,

[PATCH] D123741: [clang-format][NFC] Clean up code in token annotator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7343f768d144: [clang-format][NFC] Clean up code in token annotator (authored by owenpan). Herald added a project: clang. Herald added a subscriber:

[clang] 7343f76 - [clang-format][NFC] Clean up code in token annotator

Author: owenca Date: 2022-04-21T14:17:38-07:00 New Revision: 7343f768d1442cbc3c12fee3c6846b0cfbf644c3 URL: https://github.com/llvm/llvm-project/commit/7343f768d1442cbc3c12fee3c6846b0cfbf644c3 DIFF: https://github.com/llvm/llvm-project/commit/7343f768d1442cbc3c12fee3c6846b0cfbf644c3.diff LOG:

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default @hans

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka updated this revision to Diff 424291. vitalybuka added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124057/new/ https://reviews.llvm.org/D124057 Files: clang/docs/AddressSanitizer.rst

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. Thank you @nemanjai and @Jake-Egan for the help, I really appreciate it! I've disabled the diagnostics from another test (it looks like I caught the other ones earlier today), so hopefully the bot goes back to green shortly. If not, I'll keep on it. :-)

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12300 + (D->hasAttr() && + GetGVALinkageForFunction(cast(D), + /*IgnoreCUDAGlobalAttr=*/true) == tra wrote: > yaxunl wrote: > > tra wrote: >

[clang-tools-extra] 5287237 - [clangd] Fix CLANGD_TIDY_CHECKS=Off tests after b859c39c40a7

Author: Sam McCall Date: 2022-04-21T23:02:41+02:00 New Revision: 5287237a74a8d316f079ae4db666138752fa69b4 URL: https://github.com/llvm/llvm-project/commit/5287237a74a8d316f079ae4db666138752fa69b4 DIFF: https://github.com/llvm/llvm-project/commit/5287237a74a8d316f079ae4db666138752fa69b4.diff

[PATCH] D124058: [msan] Update Use-after-destruction documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb580c0e01982: [msan] Update Use-after-destruction documentation (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124058/new/

[clang] b580c0e - [msan] Update Use-after-destruction documentation

Author: Vitaly Buka Date: 2022-04-21T14:02:02-07:00 New Revision: b580c0e019826074a22e2676dd0889a57d8558fb URL: https://github.com/llvm/llvm-project/commit/b580c0e019826074a22e2676dd0889a57d8558fb DIFF: https://github.com/llvm/llvm-project/commit/b580c0e019826074a22e2676dd0889a57d8558fb.diff

[clang] 3119292 - Mark test stack-usage-safestack.c as requiring x86.

Author: Douglas Yung Date: 2022-04-21T13:58:39-07:00 New Revision: 311929267d296ff2bf0ca4488223ba7e79ed4acd URL: https://github.com/llvm/llvm-project/commit/311929267d296ff2bf0ca4488223ba7e79ed4acd DIFF: https://github.com/llvm/llvm-project/commit/311929267d296ff2bf0ca4488223ba7e79ed4acd.diff

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12300 + (D->hasAttr() && + GetGVALinkageForFunction(cast(D), + /*IgnoreCUDAGlobalAttr=*/true) == yaxunl wrote: > tra wrote: > > Perhaps we

[clang] 480c59c - [Testing] fix shared lib build after a7691dee2d3c0ea3f9f4d1

Author: Sam McCall Date: 2022-04-21T22:50:33+02:00 New Revision: 480c59c11a878afd66c9142a4e9f20b1c5205a33 URL: https://github.com/llvm/llvm-project/commit/480c59c11a878afd66c9142a4e9f20b1c5205a33 DIFF: https://github.com/llvm/llvm-project/commit/480c59c11a878afd66c9142a4e9f20b1c5205a33.diff

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl updated this revision to Diff 424280. yaxunl marked an inline comment as done. yaxunl added a comment. use static function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124189/new/ https://reviews.llvm.org/D124189 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. I just did an experiment with the following patch that punts everything to `const char*` types to try and get better folding onto a single type: The change didn't make a significant difference, with the clang binary size of 1263433512 (126384B reduction, or 1.224% ->

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

AaronLiu added a comment. In D119136#3465522 , @cor3ntin wrote: > In D119136#3465361 , @AaronLiu > wrote: > >> When compile the following valid testcase: >> >> void foo() >> { >> int x = [x](int

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

Jake-Egan added a comment. @aaron.ballman Here are all the errors. Thanks! MultiSource/Applications/d/write_ctables.c:600:6: error: call to undeclared library function 'strncasecmp' with type 'int (const char *, const char *, unsigned long)'; ISO C99 and later do not support implicit

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rGa7691dee2d3c: [Testing] TestAST, a helper for writing straight-line AST tests (authored by sammccall).

[clang] a7691de - [Testing] TestAST, a helper for writing straight-line AST tests

Author: Sam McCall Date: 2022-04-21T21:46:45+02:00 New Revision: a7691dee2d3c0ea3f9f4d14c7e52f1359f23671c URL: https://github.com/llvm/llvm-project/commit/a7691dee2d3c0ea3f9f4d14c7e52f1359f23671c DIFF: https://github.com/llvm/llvm-project/commit/a7691dee2d3c0ea3f9f4d14c7e52f1359f23671c.diff

[PATCH] D124199: [randstruct] Check final randomized layout ordering

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This uses "llvm::shuffle" to stop

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3465361 , @AaronLiu wrote: > When compile the following valid testcase: > > void foo() > { > int x = [x](int y[sizeof x]){return sizeof x;}(0); > } > > It will complain: > > error: captured variable

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. 1263559896 (new) - 1248280328 (old) = 15279568 B (1.22% increase). Seems more reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3465403 , @rsmith wrote: > In D119136#3463888 , @cor3ntin > wrote: > >> @rsmith @aaron.ballman Do you think it's worth resubmitting this patch with >> a look ahead of the

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11322 + } else if (Context.getLangOpts().CUDA && Context.getLangOpts().CUDAIsDevice && + !IgnoreCUDAGlobalAttr) { // Device-side functions with

[clang] e80ee18 - Reland [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

Author: Sam McCall Date: 2022-04-21T21:15:39+02:00 New Revision: e80ee1829c59b34a574cd424ecdcbdff400f1401 URL: https://github.com/llvm/llvm-project/commit/e80ee1829c59b34a574cd424ecdcbdff400f1401 DIFF: https://github.com/llvm/llvm-project/commit/e80ee1829c59b34a574cd424ecdcbdff400f1401.diff

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

rsmith added a comment. In D119136#3463888 , @cor3ntin wrote: > @rsmith @aaron.ballman Do you think it's worth resubmitting this patch with a > look ahead of the `mutable` keyword (this seems to me a better strategy than > other flimsy workaround

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. The new test looks good (I would replace the CHECK-NEXT with CHECK though). It sounds like there was no objections for doing this for lambdas. CHANGES SINCE LAST ACTION

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

rsmith added a comment. In D119136#3463888 , @cor3ntin wrote: > @rsmith @aaron.ballman Do you think it's worth resubmitting this patch with a > look ahead of the `mutable` keyword (this seems to me a better strategy than > other flimsy workaround

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

curdeius accepted this revision. curdeius added a comment. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123896/new/ https://reviews.llvm.org/D123896 ___ cfe-commits mailing list

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi updated this revision to Diff 424257. MaggieYi added a comment. Thanks David, I have modified the test following your advice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.org/D124006 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

sammccall added a comment. In D124180#3465304 , @thakis wrote: > I think this might've broken check-clangd: > http://45.33.8.238/linux/74320/step_9.txt > > The output isn't very useful though, I'm guessing @yln's recent gtest runner > change it's not

[PATCH] D124189: [CUDA][HIP] Externalize kernels with internal linkage

tra added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11322 + } else if (Context.getLangOpts().CUDA && Context.getLangOpts().CUDAIsDevice && + !IgnoreCUDAGlobalAttr) { // Device-side functions with __global__ attribute must always be

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

AaronLiu added a comment. When compile the following valid testcase: void foo() { int x = [x](int y[sizeof x]){return sizeof x;}(0); } It will complain: error: captured variable 'x' cannot appear here int x = [x](int y[sizeof x]){return sizeof x;}(0);

[PATCH] D123896: [clang-format] fix nested angle brackets parse inside concept definition

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. No I think it is a step in the right direction. It will help in common cases, and I still don't know when I will have the time to work on that. But you are very welcome

[clang] eadf352 - Revert "[Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory"

Author: Sam McCall Date: 2022-04-21T20:22:47+02:00 New Revision: eadf35270727ca743c11b07040bbfedd415ab6dc URL: https://github.com/llvm/llvm-project/commit/eadf35270727ca743c11b07040bbfedd415ab6dc DIFF: https://github.com/llvm/llvm-project/commit/eadf35270727ca743c11b07040bbfedd415ab6dc.diff

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added a subscriber: ychen. thakis added a comment. Sorry, @ychen, not @yln (D122251 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124180/new/ https://reviews.llvm.org/D124180

[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

thakis added subscribers: yln, thakis. thakis added a comment. I think this might've broken check-clangd: http://45.33.8.238/linux/74320/step_9.txt The output isn't very useful though, I'm guessing @yln's recent gtest runner change it's not getting printed. Repository: rG LLVM Github

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

rastogishubham added a comment. Hi Qiongsi Thanks for the response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

nemanjai added a comment. In D122983#3465122 , @aaron.ballman wrote: > In D122983#3465099 , @nemanjai > wrote: > >> @daltenty Can you please run this with the same config as the bot on one of >> our AIX

[clang] 1283ccb - Support z16 processor name

Author: Ulrich Weigand Date: 2022-04-21T19:58:22+02:00 New Revision: 1283ccb610feef4f2e0edf22f66a705155a0e0c7 URL: https://github.com/llvm/llvm-project/commit/1283ccb610feef4f2e0edf22f66a705155a0e0c7 DIFF:

  1   2   3   >