[clang] e0039b8 - Use llvm::less_second (NFC)

Author: Kazu Hirata Date: 2022-06-04T22:48:32-07:00 New Revision: e0039b8d6a5bd05e70203962f448569f2d2ef1c2 URL: https://github.com/llvm/llvm-project/commit/e0039b8d6a5bd05e70203962f448569f2d2ef1c2 DIFF: https://github.com/llvm/llvm-project/commit/e0039b8d6a5bd05e70203962f448569f2d2ef1c2.diff

[clang] 8cc9fa6 - Use static_cast from SmallString to std::string (NFC)

Author: Kazu Hirata Date: 2022-06-04T22:09:27-07:00 New Revision: 8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf URL: https://github.com/llvm/llvm-project/commit/8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf DIFF: https://github.com/llvm/llvm-project/commit/8cc9fa6f78237a5771a5f85eb9ef129ea85a54cf.diff

[clang] 4969a69 - Use llvm::less_first (NFC)

Author: Kazu Hirata Date: 2022-06-04T21:23:18-07:00 New Revision: 4969a6924dc1644d4fa6cf89a33b598e647f5513 URL: https://github.com/llvm/llvm-project/commit/4969a6924dc1644d4fa6cf89a33b598e647f5513 DIFF: https://github.com/llvm/llvm-project/commit/4969a6924dc1644d4fa6cf89a33b598e647f5513.diff

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + LuoYuanke wrote: > pengfei wrote: > > LuoYuanke wrote: > > > Is _Float16 a legal type for target armv7a and aarch64?

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `Builder.defineMacro("__cpp_multidimensional_subscript", "202110L");` line has some `U+00AD`s that shouldn't

[PATCH] D127065: [docs] Update supported language standards list for C++

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127065 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + pengfei wrote: > LuoYuanke wrote: > > Is _Float16 a legal type for target armv7a and aarch64? > Yes, see >

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + LuoYuanke wrote: > Is _Float16 a legal type for target armv7a and aarch64? Yes, see

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/test/CodeGen/builtin_Float16.c:7 +void test_float16_builtins(void) { + volatile _Float16 res; + Is _Float16 a legal type for target armv7a and aarch64? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:145 BUILTIN(__builtin_huge_vall, "Ld", "nc") +BUILTIN(__builtin_huge_valf16, "x", "nc") BUILTIN(__builtin_huge_valf128, "LLd", "nc") LuoYuanke wrote: > Is the builtin sorted in

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

LuoYuanke added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:145 BUILTIN(__builtin_huge_vall, "Ld", "nc") +BUILTIN(__builtin_huge_valf16, "x", "nc") BUILTIN(__builtin_huge_valf128, "LLd", "nc") Is the builtin sorted in alphabet order?

[PATCH] D127005: [clang-format][NFC] Clean up the unwrapped line parser

owenpan updated this revision to Diff 434287. owenpan edited the summary of this revision. owenpan added a comment. Restored the prototype of `parseStructuralElement()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127005/new/ https://reviews.llvm.org/D127005 Files:

[PATCH] D127054: [clang-format] Handle attributes for for/while loops

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

fwolff updated this revision to Diff 434283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127036/new/ https://reviews.llvm.org/D127036 Files: clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp

[PATCH] D127036: [clang-tidy] Warn about arrays in `bugprone-undefined-memory-manipulation`

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:27 void UndefinedMemoryManipulationCheck::registerMatchers(MatchFinder *Finder) { - const auto NotTriviallyCopyableObject = -

[PATCH] D127042: [Clang][OpenMP] Enable floating-point operation for `atomic compare` series

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127042/new/ https://reviews.llvm.org/D127042

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked 5 inline comments as done. abrachet added a comment. In D109977#3378312 , @phosek wrote: > Another potential future improvement is error reporting for subcommands: > > $ ./bin/llvm clang > llvm: error: no input files > $

[PATCH] D109977: LLVM Driver Multicall tool

abrachet updated this revision to Diff 434277. abrachet added a comment. Herald added a subscriber: hiraditya. - `llvm llvm-$tool` -> `llvm $tool` - Error messages will now show `$tool: error: ...` instead of `error: ...` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/

[PATCH] D109977: LLVM Driver Multicall tool

abrachet commandeered this revision. abrachet added a reviewer: beanz. abrachet added a comment. I spoke to @beanz offline to make sure he is still ok with the patch being commandeered. Thanks for the patch @beanz, very excited about this :) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

gribozavr2 added a comment. > using the StructValue for its properties, while modeling a non-struct type. Could you explain the use case in more details? Maybe a better change is to move synthetic properties to the base class `Value`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127050: [Clang][FP16] Add 4 builtins for _Float16

pengfei created this revision. pengfei added reviewers: rjmccall, erichkeane, LuoYuanke. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are lacking builtins support for `_Float16`. In most cases, we

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:772 + size_t PackLocation = OptPackLocation.getValue(); + ArrayRef MatchingParams = + Callee->parameters().slice(PackLocation, Parameters.size()); Similar to processCall

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 434262. upsj added a comment. add test for varargs function called from forwarding function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Files:

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 434257. upsj added a comment. This is now ready to review, only needed to fix a formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Files:

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg added a comment. Thanks Mehdi for reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

mehdi_amini added a comment. The shared library build was broken, I had to revert: https://lab.llvm.org/buildbot/#/builders/61/builds/27377 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126158/new/ https://reviews.llvm.org/D126158

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434251. junaire added a comment. I think std::swap makes the logic more clear Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files:

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

AshleyRoll updated this revision to Diff 434250. AshleyRoll added a comment. Rebased to remove clangd test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126960/new/ https://reviews.llvm.org/D126960 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbcfc0a905101: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with… (authored by csigg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION