[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

v.g.vassilev added reviewers: rsmith, rjmccall. v.g.vassilev added a subscriber: rjmccall. v.g.vassilev added a comment. I am adding some more reviewers as I think this patch is ready to go. @rjmccall, could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 441920. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 updated this revision to Diff 441908. tianshilei1992 added a comment. rebase and fix test error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/ https://reviews.llvm.org/D129008 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

mizvekov added a subscriber: rjmccall. mizvekov added a comment. In D126172#3626809 , @roberteg16 wrote: > Hi again @mizvekov, I've been spending a bit of time on resuming this issue. > > When applying (after reverting the changes) the first change

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441906. SchrodingerZhu added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/include/llvm/IR/GlobalIFunc.h

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441905. SchrodingerZhu added a comment. more clean ups for ifunc logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

bjope added a comment. In D128472#3625584 , @hokein wrote: > Thanks for the report. There is an out-of-bound issue in > LRTable::getReduceRules, fixed in c99827349927a44334f2b04139168efd0bc87cd3 >

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

shafik added a comment. During the parsing of the assignment in `main` for the `constexpr` case we end up in `Sema::MarkFunctionReferenced` in particular this code: else if (Func->isConstexpr()) // Do not defer instantiations of constexpr functions, to avoid the // expression

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. Hi again @mizvekov, I've been spending a bit of time on resuming this issue. When applying (after reverting the changes) the first change related to the `Template` case of profiling the as-written one name this resulted in the following test failing: Changes:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu marked an inline comment as done. SchrodingerZhu added a comment. ThinLTO with IFUNC is still Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441899. SchrodingerZhu added a comment. fix test arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441898. SchrodingerZhu added a comment. fix test arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441897. SchrodingerZhu added a comment. enlarge test and fix accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441895. SchrodingerZhu added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441894. SchrodingerZhu added a comment. fix more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

Re: [PATCH] D129014: rewording static_assert to more generic static assertion

Ok ... I am working on the tests I will update it On Sat, Jul 2, 2022, 7:35 AM Shivam Gupta via Phabricator < revi...@reviews.llvm.org> wrote: > xgupta added a comment. > > Running check-clang after applying the patch, results into 36 failed test > cases. Please update them all. > Also add a

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441891. SchrodingerZhu added a comment. fix liveness of resolvers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. The LTO problem is fixed but thinlto is not fully resolved: /home/schrodinger/Documents/llvm-project/llvm/cmake-build-debug/bin/clang test.c -o test -flto=thin -sha red -fuse-ld=lld IFunc resolver must be a definition ptr @f LLVM ERROR: Broken module

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441887. SchrodingerZhu added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu updated this revision to Diff 441886. SchrodingerZhu added a comment. - stage - stage - fix lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 Files:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. @MaskRay unfortunately and fortunately, extending the test case to ; RUN: opt -module-summary -o %t.bc %s ; RUN: llvm-lto2 run %t.bc -r %t.bc,foo,pl -r %t.bc,bar,px -r %t.bc,baz,px -o %t2 ; RUN: llvm-nm %t2.1 | FileCheck %s ; CHECK: i foo ; CHECK: t

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Then we need to add the option -fexcess-precision. I am not sure for now > where and what values the _FLT_EVAL_METHOD should have when excess precision > is enabled/disabled. I'm fine with a follow up patch to enable this option. Please notice LLVM15 will branch on

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

pengfei commandeered this revision. pengfei edited reviewers, added: zahiraam; removed: pengfei. pengfei added a comment. This patch was replaced by D128571 . Let me commandeer and abandon it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. FYI, `COMPILER_RT_HAS_FLOAT16` is set according to https://github.com/llvm/llvm-project/blob/main/compiler-rt/cmake/builtin-config-ix.cmake#L25-L31 and https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/CMakeLists.txt#L699 Repository: rG LLVM

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#3626632 , @sylvestre.ledru wrote: > Same as in https://reviews.llvm.org/D114099 > It breaks the build on ubuntu bionic, Hirsute, etc on amd64: > > >

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. Same as in https://reviews.llvm.org/D114099 It breaks the build on ubuntu bionic, Hirsute, etc on amd64: "/build/llvm-toolchain-snapshot-15~++20220702091600+23ee84f43201/build-llvm/./bin/clang" --target=x86_64-pc-linux-gnu -DVISIBILITY_HIDDEN

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Herald added a subscriber: jsji. Herald added a project: All. @zahiraam Sorry, i missed your questions > But I see in the command above that it is compiling with > -DCOMPILER_RT_HAS_FLOAT16. @sylvestre.ledru is this flag really supposed to > be on? dunno, I

[PATCH] D128604: [RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 441872. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 441871. iains added a comment. fix a state transition after include translation. This update fixes an (apparently pre-existing) bug in handling: module; #include "translated-header.h" import "header-unit.h"; The translation process pushes a

[PATCH] D128984: [clang-format] Tweak help text a bit

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128984/new/ https://reviews.llvm.org/D128984 ___ cfe-commits mailing

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added inline comments. Comment at: llvm/test/LTO/Resolution/X86/alias-indirect-function-lto.ll:1 +; RUN: opt -module-summary -o %t.bc %s + Testing a command does not crash does not make good use of the test. Please check basic properties. And add a

[PATCH] D30538: Add documentation for -fno-strict-aliasing

simonbyrne removed subscribers: jeroen.dobbelaere, carlosgalvezp. simonbyrne added a comment. i have no idea. It looks like it may have been resolved in https://reviews.llvm.org/rL303851? In that case, the NOTE should be removed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D30538/new/