[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fbc0519c52: [clangd] Support usedAsMutableReference in member initializations (authored by ckandeler, committed by nridge). Repository: rG

[clang-tools-extra] b1fbc05 - [clangd] Support "usedAsMutableReference" in member initializations

Author: Christian Kandeler Date: 2022-07-08T23:16:20-04:00 New Revision: b1fbc0519c5224de44b2711f8a813b24d767dd3e URL: https://github.com/llvm/llvm-project/commit/b1fbc0519c5224de44b2711f8a813b24d767dd3e DIFF:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. make check-openmp passes on amdgpu. Need to check on nvptx. Testing Time: 39.95s Unsupported : 143 Passed : 563 Expectedly Failed: 14 [100%] Built target check-openmp [100%] Built target check-openmp Repository: rG LLVM Github Monorepo

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Results from "make check-clang": Failed Tests (14): Clang :: AST/ast-dump-openmp-distribute-parallel-for-simd.c Clang :: AST/ast-dump-openmp-distribute-parallel-for.c Clang :: AST/ast-dump-openmp-target-teams-distribute-parallel-for-simd.c Clang ::

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 443403. vsapsai added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files: clang/lib/Serialization/ASTReader.cpp Index:

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

vsapsai added a comment. Thanks for the changes, they look good! While I was looking how we handle "requires" constraints in other cases, I've noticed that they are suspiciously similar. That's why I offer the following change to unify comparison of the constraint expressions diff --git

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:4263 case OMPRTL___kmpc_nvptx_end_reduce_nowait: +case OMPRTL___kmpc_alloc_aggregate_arg: break; dhruvachak wrote: > @jdoerfert Is this enough to enable

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:4263 case OMPRTL___kmpc_nvptx_end_reduce_nowait: +case OMPRTL___kmpc_alloc_aggregate_arg: break; @jdoerfert Is this enough to enable SPMDization or is further

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3640232 , @jdoerfert wrote: > In D102107#3640198 , @dhruvachak > wrote: > >> Thanks. I followed the above steps and regenerated a couple of the AST tests >> but they still

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 443399. dhruvachak added a comment. Herald added a subscriber: hiraditya. Fixed opaque pointer miscompile. Added alloc_aggregate_arg entry point to OpenMPOpt SPMD list. Fixed nocapture attribute of __kmpc_alloc_aggregate_arg, Added align attribute for call

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jhuber6 added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

jdoerfert added a comment. In D129008#3640194 , @tianshilei1992 wrote: > `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Don't we generate copies of things elsewhere already? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3640198 , @dhruvachak wrote: > Thanks. I followed the above steps and regenerated a couple of the AST tests > but they still fail. Perhaps I am missing some options? > > I currently have a handful of clang test

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3639735 , @jdoerfert wrote: > F23722893: ast_dump_2_check.py >>! In > D102107#3639615 , @dhruvachak wrote: > >> In D102107#3639556

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. `callCStructCopyConstructor` is actually for Objective-C…Cannot use it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129008/new/

[PATCH] D128950: Add 'sanitize_memtag' Global IR attribute

hctim updated this revision to Diff 443390. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. After talking with Evgenii offline, and testing, clearly we don't need an exclude mask. Update the patch to remove the exclude mask, and

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir updated this revision to Diff 443379. benlangmuir added a comment. Updates: - Made lookup of module outputs fallible. Not currently used by clang-scan-deps, but since the expectation is for a build system to provide these settings account for possibility of errors. - Attempt to fix

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions. Otherwise the change just introduces some CMake

[PATCH] D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8b55e609c8: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bd8b55e - [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

Author: Hubert Tong Date: 2022-07-08T18:33:16-04:00 New Revision: bd8b55e609c825f1063a28ef94502a6bfed7a0fd URL: https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd DIFF: https://github.com/llvm/llvm-project/commit/bd8b55e609c825f1063a28ef94502a6bfed7a0fd.diff

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

shafik added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:894 bool useObjCFPRetForRealType(FloatModeKind T) const { -return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T); +return

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: probinson, wristow. Herald added a project: All. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > This needs a change in lld/test/CMakeLists.txt > >

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ This needs a change in lld/test/CMakeLists.txt Looks like you

[PATCH] D128036: [CMake] Option to select C++ library for runtimes that use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90d22704d8: [CMake] Option to select C++ library for runtimes that use it (authored by phosek). Changed prior to commit:

[clang] df90d22 - [CMake] Option to select C++ library for runtimes that use it

Author: Petr Hosek Date: 2022-07-08T22:10:24Z New Revision: df90d22704d8743746fa00bc6d67e2789ca9ee9e URL: https://github.com/llvm/llvm-project/commit/df90d22704d8743746fa00bc6d67e2789ca9ee9e DIFF: https://github.com/llvm/llvm-project/commit/df90d22704d8743746fa00bc6d67e2789ca9ee9e.diff LOG:

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443362. cassanova edited the summary of this revision. cassanova added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building the expression evaluator fuzzer is now conditional on the CLANG_ENABLE_PROTO_FUZZER CMake

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

This revision was automatically updated to reflect the committed changes. Closed by commit rG24849c9eb504: [Clang] Fix the wrong features being derivec in the offload packager (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 24849c9 - [Clang] Fix the wrong features being derivec in the offload packager

Author: Joseph Huber Date: 2022-07-08T17:26:20-04:00 New Revision: 24849c9eb504cad5b17f16ed23a88dab92882d5d URL: https://github.com/llvm/llvm-project/commit/24849c9eb504cad5b17f16ed23a88dab92882d5d DIFF: https://github.com/llvm/llvm-project/commit/24849c9eb504cad5b17f16ed23a88dab92882d5d.diff

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rGd36b96afb224: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d36b96a - [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

Author: Joseph Huber Date: 2022-07-08T17:22:35-04:00 New Revision: d36b96afb2245d791eaf9d9b1b1adfa52df1e498 URL: https://github.com/llvm/llvm-project/commit/d36b96afb2245d791eaf9d9b1b1adfa52df1e498 DIFF: https://github.com/llvm/llvm-project/commit/d36b96afb2245d791eaf9d9b1b1adfa52df1e498.diff

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 added a comment. In D128314#3635861 , @njames93 wrote: > Sorry to do this again, but could this be split up again, one patch for the > new matcher and the tests associated with it, then another for the actual bug > fix. > Also cc @klimek

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129393/new/ https://reviews.llvm.org/D129393

[PATCH] D129398: Adding a new ASTMatcher for callee declarations of Obj-C message expressions

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, njames93, aaron.ballman, klimek, t-rasmud, usama54321, LegalizeAdulthood. ziqingluo-90 added a project: clang. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a subscriber:

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb069801ffb6d: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b069801 - [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

Author: Martin Storsjö Date: 2022-07-09T00:11:45+03:00 New Revision: b069801ffb6d11143c2b611a220827120113c7a1 URL: https://github.com/llvm/llvm-project/commit/b069801ffb6d11143c2b611a220827120113c7a1 DIFF:

[PATCH] D128927: [libc++] Always build c++experimental.a

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb939931a1ad: [libc++] Always build c++experimental.a (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bb93993 - [libc++] Always build c++experimental.a

Author: Louis Dionne Date: 2022-07-08T16:58:22-04:00 New Revision: bb939931a1adb9a47a2de13c359d6a72aeb277c8 URL: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8 DIFF: https://github.com/llvm/llvm-project/commit/bb939931a1adb9a47a2de13c359d6a72aeb277c8.diff

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

shafik accepted this revision. shafik added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ldionne added inline comments. Comment at: llvm/CMakeLists.txt:441 +set(LLVM_ENABLE_ZSTD "ON" CACHE STRING "Use zstd for compression/decompression if available. Can be ON, OFF, or FORCE_ON") + This broke builds that do not specify `LLVM_ENABLE_ZSTD=OFF`

[clang-tools-extra] 474c873 - Revert "[llvm] cmake config groundwork to have ZSTD in LLVM"

Author: Leonard Chan Date: 2022-07-08T13:48:05-07:00 New Revision: 474c873148b1441f1dd7a2b269441a1b20e30aa2 URL: https://github.com/llvm/llvm-project/commit/474c873148b1441f1dd7a2b269441a1b20e30aa2 DIFF: https://github.com/llvm/llvm-project/commit/474c873148b1441f1dd7a2b269441a1b20e30aa2.diff

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443342. ldionne added a comment. Rebase onto main and remove references to -funstable since the design is still changing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/

[clang] cc5b772 - [clang] Introduce -Warray-parameter

Author: serge-sans-paille Date: 2022-07-08T22:36:05+02:00 New Revision: cc5b77273af3705b6f5cf574567b49d5158bb3a9 URL: https://github.com/llvm/llvm-project/commit/cc5b77273af3705b6f5cf574567b49d5158bb3a9 DIFF:

[PATCH] D128449: [clang] Introduce -Warray-parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc5b77273af3: [clang] Introduce -Warray-parameter (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3213 +static bool EquivalentArrayTypes(QualType Old, QualType New, + ASTContext const ) { + aaron.ballman wrote: > East const? MONSTEROUS! ;-) (We

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this is now diagnosed as an error. +- Clang now correctly emit symbols for implicitly instanciated constexpr + template function. Fixes `Issue 55560

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Confirm that #56445 is fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129383/new/ https://reviews.llvm.org/D129383

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443337. serge-sans-paille added a comment. ++review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3639615 , @dhruvachak wrote: > In D102107#3639556 , @jdoerfert > wrote: > >> In D102107#3639551 , @dhruvachak >> wrote: >> >>> Is

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. In D128927#3638973 , @ldionne wrote: > Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it > would make sense to use a different visibility macro for symbols that we know > are provided only as part of

[PATCH] D129393: [Clang] Fix the wrong features being derivec in the offload packager

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The offload packager embeds the features

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3639556 , @jdoerfert wrote: > In D102107#3639551 , @dhruvachak > wrote: > >> Is there an llvm/utils script to update clang tests that have RUN lines at >> the top? An

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building modules, override secondary outputs (dependency

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3639551 , @dhruvachak wrote: > Is there an llvm/utils script to update clang tests that have RUN lines at > the top? An example is clang/test/OpenMP/debug_threadprivate_copyin.c. You can create the run lines with

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. Is there an llvm/utils script to update clang tests that have RUN lines at the top? An example is clang/test/OpenMP/debug_threadprivate_copyin.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07caf20b9d3: [llvm] cmake config groundwork to have ZSTD in LLVM (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5300263c70da: [OpenMP] Add loop tripcount argument to kernel launch and remove push function (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D128550: [OpenMP] Change OpenMP code generation for target region entries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fff116645b3: [OpenMP] Change OpenMP code generation for target region entries (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443310. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. marked fixed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443308. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake - added have_zstd to compiler-rt/test/lit.common.cfg.py, clang-tools-extra/clangd/test/lit.cfg.py and several lit.site.cfg.py.in files

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3541 .getPointerType(CGF.getContext().getPointerType( CGF.getContext().VoidPtrTy)) .castAs());

[clang] 7ecec30 - [Clang][Docs] Update the clang-linker-wrapper documentation.

Author: Joseph Huber Date: 2022-07-08T14:30:07-04:00 New Revision: 7ecec30e43987f4851130fc08423ab23fec234a4 URL: https://github.com/llvm/llvm-project/commit/7ecec30e43987f4851130fc08423ab23fec234a4 DIFF: https://github.com/llvm/llvm-project/commit/7ecec30e43987f4851130fc08423ab23fec234a4.diff

[PATCH] D129384: [objcxx] Fix `std::addressof` for `id`.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG22c7a6ec: [objcxx] Fix `std::addressof` for `id`. (authored by zoecarver). Repository: rG LLVM Github Monorepo

[clang] 22c7a6d - [objcxx] Fix `std::addressof` for `id`.

Author: zoecarver Date: 2022-07-08T11:29:30-07:00 New Revision: 22c7a6ec6d62e627ca66b886b60ba1ce1e7c URL: https://github.com/llvm/llvm-project/commit/22c7a6ec6d62e627ca66b886b60ba1ce1e7c DIFF: https://github.com/llvm/llvm-project/commit/22c7a6ec6d62e627ca66b886b60ba1ce1e7c.diff

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG96063bfa9088: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib… (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128953: [NFC] Refactor llvm::zlib namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea61750c35a1: [NFC] Refactor llvm::zlib namespace (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ea61750 - [NFC] Refactor llvm::zlib namespace

Author: Cole Kissane Date: 2022-07-08T11:19:07-07:00 New Revision: ea61750c35a11140e9245bd9cbeb383c37f6e031 URL: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031 DIFF: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031.diff

[clang-tools-extra] ea61750 - [NFC] Refactor llvm::zlib namespace

Author: Cole Kissane Date: 2022-07-08T11:19:07-07:00 New Revision: ea61750c35a11140e9245bd9cbeb383c37f6e031 URL: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031 DIFF: https://github.com/llvm/llvm-project/commit/ea61750c35a11140e9245bd9cbeb383c37f6e031.diff

[PATCH] D128766: Update references to Discourse instead of the mailing lists.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb1ffd817c3c: Update references to Discourse instead of the mailing lists. (authored by tonic). Changed prior to commit:

[clang] eb1ffd8 - Update references to Discourse instead of the mailing lists.

Author: tlattner Date: 2022-07-08T11:16:47-07:00 New Revision: eb1ffd817c3ce5120c3f9d4152de65954314a8d5 URL: https://github.com/llvm/llvm-project/commit/eb1ffd817c3ce5120c3f9d4152de65954314a8d5 DIFF: https://github.com/llvm/llvm-project/commit/eb1ffd817c3ce5120c3f9d4152de65954314a8d5.diff

[PATCH] D127624: [C++20][Modules] Allow for redeclarations in partitions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc2a6defc853: [C++20][Modules] Allow for redeclarations in partitions. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bc2a6de - [C++20][Modules] Allow for redeclarations in partitions.

Author: Iain Sandoe Date: 2022-07-08T19:02:59+01:00 New Revision: bc2a6defc853553b3896cb853bb84fe663f6bfd0 URL: https://github.com/llvm/llvm-project/commit/bc2a6defc853553b3896cb853bb84fe663f6bfd0 DIFF: https://github.com/llvm/llvm-project/commit/bc2a6defc853553b3896cb853bb84fe663f6bfd0.diff

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks added a comment. moving DAE after the function simplification pipeline makes sense In D128830#3622736 , @psamolysov wrote: > In D128830#3622467 , @fhahn wrote: > >> Do we need to retain the run of

[PATCH] D129384: [objcxx] Fix `std::addressof` for `id`.

zoecarver created this revision. Herald added a project: All. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129384 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3639318 , @yaxunl wrote: > I think before the new binary format supports Windows and -fno-gpu-rdc and > HIP runtime support the new binary format, we cannot deprecate > clang-offload-bundler. I expect that would take

[PATCH] D129383: [LinkerWrapper] Fix use of string savers and correctly pass bitcode libraries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some uses of string savers that are no-longer needed. We

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. In D129301#3637641 , @lamb-j wrote: > @yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or > combine a subset of patches? I recommend combining all patches as one. Repository: rG LLVM Github Monorepo

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

yaxunl added a comment. In D129301#3637664 , @jhuber6 wrote: > In D129301#3637642 , @jdoerfert > wrote: > >> Isn't the offload bundler on it's "way out" (=replaced and then deleted >> soon)? > > HIP still uses

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some test changes, assuming that precommit CI comes back green. Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:17 #include "llvm/ADT/StringRef.h" +#include "llvm/Support/raw_ostream.h" #include Do we need the header or is a forward declaration enough? Repository: rG

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

craig.topper added inline comments. Comment at: clang/test/Sema/riscv-bad-intrnisic-pragma.c:1 +// RUN: %clang_cc1 -triple riscv64 -target-feature +v %s -emit-llvm -o - \ +// RUN:2>&1 | FileCheck %s this test file name is misspelled

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443276. serge-sans-paille added a comment. + release note + take review into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files:

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

aaron.ballman added a comment. In D129362#3639193 , @tambre wrote: > In D129362#3638896 , @aaron.ballman > wrote: > >> In D129362#3638485 , @tambre wrote: >> >>> Makes

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + The doc is auto-generated by tablegen

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

tambre added a comment. In D129362#3638896 , @aaron.ballman wrote: > In D129362#3638485 , @tambre wrote: > >> Makes sense to me, thanks! > > Thanks! Would you mind handling the libc++ side like last time, or do

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:145 set(openmp_wrapper_files openmp_wrappers/math.h chapuni wrote: > It doesn't contain , intentional? We don't wrap that yet. Do you need it? Repository: rG LLVM Github

[clang] 0d7161a - [Clang] Fix test failing due to renamed arg

Author: Joseph Huber Date: 2022-07-08T11:50:56-04:00 New Revision: 0d7161af89f91db798f7be2a521568a4cd754214 URL: https://github.com/llvm/llvm-project/commit/0d7161af89f91db798f7be2a521568a4cd754214 DIFF: https://github.com/llvm/llvm-project/commit/0d7161af89f91db798f7be2a521568a4cd754214.diff

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen added a comment. @tahonermann, I addressed your comments in https://reviews.llvm.org/D129373. I just need to remove a tab that crept in and it seems to be more difficult than I thought as my code does not seem to have any tab and reformatting the code does not change the file.

[clang] 74a8fce - [LinkerWrapper] Fix save-temps and argument name

Author: Joseph Huber Date: 2022-07-08T11:38:33-04:00 New Revision: 74a8fce6e87e81802b4fe69769daec19504753bf URL: https://github.com/llvm/llvm-project/commit/74a8fce6e87e81802b4fe69769daec19504753bf DIFF: https://github.com/llvm/llvm-project/commit/74a8fce6e87e81802b4fe69769daec19504753bf.diff

[PATCH] D128449: [clang] Introduce -Warray-parameter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new diagnostic! Comment at: clang/lib/Sema/SemaDecl.cpp:3213 +static bool EquivalentArrayTypes(QualType Old, QualType New, +

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + royjacobson wrote: > aaron.ballman wrote: > >

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen updated this revision to Diff 443258. jolanta.jensen added a comment. Removing a tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129373/new/ https://reviews.llvm.org/D129373 Files: clang/include/clang/Basic/TargetInfo.h

[clang] e0de264 - [LinkerWrapper][NFC] Move error handling to a common function

Author: Joseph Huber Date: 2022-07-08T11:18:38-04:00 New Revision: e0de264f6355c397e91927827a9cbb940c903607 URL: https://github.com/llvm/llvm-project/commit/e0de264f6355c397e91927827a9cbb940c903607 DIFF: https://github.com/llvm/llvm-project/commit/e0de264f6355c397e91927827a9cbb940c903607.diff

[clang] d2ead9e - [LinkerWrapper][NFC] Rework command line argument handling in the linker wrapper

Author: Joseph Huber Date: 2022-07-08T11:18:38-04:00 New Revision: d2ead9e324d4d268e8c0634849d6081e177c9dd7 URL: https://github.com/llvm/llvm-project/commit/d2ead9e324d4d268e8c0634849d6081e177c9dd7 DIFF: https://github.com/llvm/llvm-project/commit/d2ead9e324d4d268e8c0634849d6081e177c9dd7.diff

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne updated this revision to Diff 443252. ldionne marked an inline comment as done. ldionne added a comment. Windows fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128927/new/ https://reviews.llvm.org/D128927 Files:

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne marked an inline comment as done. ldionne added a comment. Thanks @mstorsjo! Regarding `_LIBCPP_EXPERIMENTAL_FUNC_VIS`, yes I think it would make sense to use a different visibility macro for symbols that we know are provided only as part of a static library. I would not call it

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D129277#3637317 , @mstorsjo wrote: > In D129277#3636795 , @aaron.ballman > wrote: > >> In

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn added a comment. Looking at the descriptions of maths functions in C99 (and I expect C11 will be the same) it looks like there are three kinds: - Those that can report error by errno and floating-point exeption, and may also raise the inexact exception - Those that don't set errno,

  1   2   >