[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen updated this revision to Diff 444363. ychen added a comment. - add CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129678: Tidy up handler-functions in SymbolicRangeInferrer

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ. ASDenysPetrov added a project: clang. Herald added a subscriber: rnkovacs. Herald added a project: All. ASDenysPetrov requested review of this revision. Herald added a subscriber: cfe-commits. Sorted some

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

tra added a comment. In D128090#3649125 , @jhuber6 wrote: > It just defaults to `sm_35` if CUDA isn't present on the system IIRC. > Alternatively we could ship a tool to derive it at compile time. As it happens, recent CUDA releases ship with

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 444352. python3kgae marked an inline comment as done. python3kgae added a comment. Change default to O3 implement to HLSL driver and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3649059 , @tra wrote: > In D128090#3648999 , @jhuber6 wrote: > >> Right now there's `CLANG_OPENMP_NVPTX_DEFAULT_ARCH`, which is defined by >> CMake to be the architecture of

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3648964 , @erichkeane wrote: > Please format your patch with clang-format. See the command at the end of > this: https://clang.llvm.org/docs/ClangFormat.html > > `git diff -U0 --color=never |

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

tra added a comment. In D128090#3648999 , @jhuber6 wrote: > Right now there's `CLANG_OPENMP_NVPTX_DEFAULT_ARCH`, which is defined by > CMake to be the architecture of the system used to build clang That does not make sense to me. Most of the time clang

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. In D128090#3648984 , @tra wrote: > At some point we should start consolidating the ways we can specify an > offload target and try to avoid adding new ones until then. Agreed, that was my intention with making `--offload-arch`

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

MaskRay added a comment. Linux tests organization isn't great. --sysroot tests both include and library search paths, so ideally we use one RUN line to test both. The name of linux-header-search.cpp focus on just include search path. For FreeBSD/OpenBSD, if you want to start in a clean state,

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

tra added a comment. > Overloading the meaning of `-march` might not work here. Typically `-march` > is just checked via `Args.getLastArg()`, so repeated uses just override the > last one. I'm not exactly sure what the expected use is however, maybe @tra > can help there. Although we could

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov updated this revision to Diff 444336. ASDenysPetrov added a comment. Constrained the test by adding llvm-lit `REQUIRES` command. Documented a new function at https://clang.llvm.org/docs/analyzer/developer-docs/DebugChecks.html CHANGES SINCE LAST ACTION

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/cxx20-decomposition.cpp:26 +// CHECK: %{{.*}} = load ptr, {{.*}} +// CHECK: %{{.*}} = load i32, {{.*}} +// CHECK: %{{.*}} = getelementptr {{.*}}, i32 0, i32 0 erichkeane wrote: > Which is the

[PATCH] D129048: Rewording the "static_assert" to static assertion

erichkeane added a comment. Please format your patch with clang-format. See the command at the end of this: https://clang.llvm.org/docs/ClangFormat.html `git diff -U0 --color=never | clang-format-diff.py -i -p1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646601 , @MaskRay wrote: > In D128465#3646561 , @ckissane > wrote: > >> In D128465#3646258 , @MaskRay >> wrote: >> >>> In

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. In D125693#3644029 , @dblaikie wrote: > In D125693#3641742 , @krisb wrote: > >> @dblaikie, could you please take a look at this and/or D113741 >> ? Do you

Re: [PATCH] D129048: Rewording the "static_assert" to static assertion

Done. On Wed, Jul 13, 2022 at 10:30 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added inline comments. > > > > Comment at: > clang/test/CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp:48 > } > \ No newline at end of file > >

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/cxx20-decomposition.cpp:26 +// CHECK: %{{.*}} = load ptr, {{.*}} +// CHECK: %{{.*}} = load i32, {{.*}} +// CHECK: %{{.*}} = getelementptr {{.*}}, i32 0, i32 0 Which is the important lines here?

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. In D122768#3648545 , @erichkeane wrote: > Just about all of the '%' variables in LLVM are unstable names, so you need > to use wildcards. Additionally, it seems like you're checking EVERY line of > the llvm function, which

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 444330. cor3ntin added a comment. Simplify codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files:

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a subscriber: tra. jhuber6 added a comment. In D128090#3648879 , @saiislam wrote: > `-Xopenmp-target -march ` used to be the only option to target a specific sub > arch before `--offload-arch`. But, it doesn't support multiple archs. >

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp:48 } \ No newline at end of file Codesbyusman wrote: > aaron.ballman wrote: > > xgupta wrote: > > > a 'newline' is missing here. > > Still

[PATCH] D129563: [docs] Document git-clang-format

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. In D129563#3645343 , @thakis wrote: > (does anyone know why git-clang-format isn't implemented in terms of > clang-format-diff.py? I suppose it's

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp:48 } \ No newline at end of file aaron.ballman wrote: > xgupta wrote: > > a 'newline' is missing

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam added a comment. In D128090#3648210 , @jhuber6 wrote: > Sorry never noticed this revision. The purpose of this patch seems to be > supporting something like this > > clang input.c -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 >

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis updated this revision to Diff 444327. ellis added a comment. Use `crc32` rather than `md5` to compute function hashes faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129594/new/ https://reviews.llvm.org/D129594 Files:

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2871 + if (NumGroups > 1) { +auto Group = llvm::MD5Hash(Fn->getName()) % NumGroups; +if (Group != getCodeGenOpts().ProfileSelectedFunctionGroup) ianlevesque wrote: > In D87953

[PATCH] D129048: Rewording the "static_assert" to static assertion

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:995 DeclEnd = Tok.getLocation(); - ExpectAndConsumeSemi(diag::err_expected_semi_after_static_assert); + ExpectAndConsumeSemi(diag::err_expected_semi_after_static_assert , SavedTok.getName());

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

cor3ntin added a comment. @aaron.ballman I think we might as well do that now, and revert if WG21 does some funny business in plenary. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ https://reviews.llvm.org/D129664

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

cor3ntin updated this revision to Diff 444322. cor3ntin added a comment. Forgot to format! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ https://reviews.llvm.org/D129664 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WG21 approved delimited escape sequences and named escape sequences. Adjust the extension warnings accordingly, and

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:929 + // saving the token used for static assertion. + Token SavedTok = Tok; Comment at: clang/lib/Parse/ParseDeclCXX.cpp:995 DeclEnd =

[PATCH] D129594: [InstrProf] Add options to profile function groups

ianlevesque added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2871 + if (NumGroups > 1) { +auto Group = llvm::MD5Hash(Fn->getName()) % NumGroups; +if (Group != getCodeGenOpts().ProfileSelectedFunctionGroup) In D87953 I used crc32 to

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new/ https://reviews.llvm.org/D129499

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. > I'd like to see the set of concrete examples you cannot otherwise deal with. I'm also very curious, I fail to understand the need of not considering [0] as a FAM, esp. given that to my understanding, this is the only use of that syntax. Repository: rG

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz added inline comments. Comment at: clang/test/SemaCXX/concept-fatal-error.cpp:8 + // We test that we do not crash in such cases (#55401) + int i = requires { { i } f } // expected-error {{expected ';' at end of declaration list}} + ilya-biryukov wrote:

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

adamcz updated this revision to Diff 444315. adamcz added a comment. improved the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new/ https://reviews.llvm.org/D129499 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444311. Codesbyusman added a comment. updated the comment styles suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[clang] 20d253e - [LinkerWrapper] Fix linker-wrapper not working with host-LTO

Author: Joseph Huber Date: 2022-07-13T12:32:02-04:00 New Revision: 20d253e3bf69494e670ad529b311948a21caf783 URL: https://github.com/llvm/llvm-project/commit/20d253e3bf69494e670ad529b311948a21caf783 DIFF: https://github.com/llvm/llvm-project/commit/20d253e3bf69494e670ad529b311948a21caf783.diff

[PATCH] D126586: [InstrProf][WIP] Implement boolean counters in coverage

gulfem added a comment. In D126586#3646197 , @davidxl wrote: > For coverage mode, why using 'incrementProfileCounter'? Should it be set to > '1' instead? Also is the 'or' expression needed? The expression can be > folded to either zero or 1.

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. In D128927#3648616 , @fhahn wrote: > It looks like this is causing macOS builds to fail on GreenDragon. Please > take a look and refer the commit if it takes longer to resolve, as the bot > has been red for a while now. Thanks

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. This breaks all the LLDB tests that import the std module: import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py

[PATCH] D128927: [libc++] Always build c++experimental.a

fhahn added a comment. It looks like this is causing macOS builds to fail on GreenDragon. Please take a look and refer the commit if it takes longer to resolve, as the bot has been red for a while now. [3495/5980]

[PATCH] D129594: [InstrProf] Add options to profile function groups

ellis created this revision. Herald added a subscriber: Enna1. Herald added a project: All. ellis edited the summary of this revision. ellis added reviewers: ianlevesque, kyulee, MaskRay, phosek, wenlei, davidxl. Herald added a subscriber: StephenFan. ellis updated this revision to Diff 444091.

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

erichkeane added a comment. Just about all of the '%' variables in LLVM are unstable names, so you need to use wildcards. Additionally, it seems like you're checking EVERY line of the llvm function, which is likely a mistake, it ends up being incredibly unstable as a result. I'd suggest just

[PATCH] D129655: [CUDA] Allow the new driver to compile CUDA in non-RDC mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, JonChesterfield, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7045519359de: Add missing sanitizer metadata plumbing from CFE. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129492/new/

[PATCH] D129048: Rewording the "static_assert" to static assertion

erichkeane added a comment. A couple of comment suggestions, our comments use a full-stop. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:929 + // saving the token used for static assertion + Token SavedTok = Tok; Comment at:

[PATCH] D128950: Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90e5a8ac475f: Remove no_sanitize_memtag. Add sanitize_memtag. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7045519 - Add missing sanitizer metadata plumbing from CFE.

Author: Mitch Phillips Date: 2022-07-13T08:54:41-07:00 New Revision: 7045519359de7fe717e29b24d2601679c923ca98 URL: https://github.com/llvm/llvm-project/commit/7045519359de7fe717e29b24d2601679c923ca98 DIFF:

[clang] 90e5a8a - Remove 'no_sanitize_memtag'. Add 'sanitize_memtag'.

Author: Mitch Phillips Date: 2022-07-13T08:54:41-07:00 New Revision: 90e5a8ac475fa3c2fa7c22a341e798d6f7356b54 URL: https://github.com/llvm/llvm-project/commit/90e5a8ac475fa3c2fa7c22a341e798d6f7356b54 DIFF:

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a subscriber: erichkeane. cor3ntin added inline comments. Comment at: clang/test/CodeGenCXX/cxx20-decomposition.cpp:1 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-linux-gnu -emit-llvm %s -o - | FileCheck %s + @erichkeane This is my first time

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

egorzhdan created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. egorzhdan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This is the same change as

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. @shafik Thanks for the review. I was able to reorganize the things you pointed out to be more consistent such that the checks for structured bindings and regular vars are made in the same place. I think it's much better that way. It took me a while to find the correct

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444284. Codesbyusman added a comment. the tests for the coverage of changes being made for the static assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 444283. cor3ntin added a comment. - Rename `diagnoseUncapturableValueReferenceOr` => `diagnoseUncapturableValueReferenceOrBinding` - Remove superfluous assert - Check for unsupported binding decl in `isVariableCapturable` instead of

[PATCH] D129562: [SystemZ] Enable `-mtune=` option in clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG880eb839e63f: [SystemZ] Enable `-mtune=` option in clang. (authored by Kai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129562/new/

[clang] 880eb83 - [SystemZ] Enable `-mtune=` option in clang.

Author: Kai Nacke Date: 2022-07-13T11:39:24-04:00 New Revision: 880eb839e63fb40de11e5f488cfef62d7ebbffbe URL: https://github.com/llvm/llvm-project/commit/880eb839e63fb40de11e5f488cfef62d7ebbffbe DIFF: https://github.com/llvm/llvm-project/commit/880eb839e63fb40de11e5f488cfef62d7ebbffbe.diff

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For sharing. WIP Repository: rG LLVM Github

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. It seems the buildbot didn't actually test this patch but an old one, still: The checks for this tests are not updated: target_teams_distribute_parallel_for_order_codegen.cpp target_in_reduction_codegen.cpp nvptx_lambda_capturing.cpp

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

jhuber6 added a comment. Sorry never noticed this revision. The purpose of this patch seems to be supporting something like this clang input.c -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_70 -Xopenmp-target=nvptx64 -march=sm_80 Right now the above works if you replace

[PATCH] D129595: [clangd] Enable designator inlay hints by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b50f2bbdbf4: [clangd] Enable designator inlay hints by default. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129595/new/

[clang-tools-extra] 6b50f2b - [clangd] Enable designator inlay hints by default.

Author: Sam McCall Date: 2022-07-13T16:31:45+02:00 New Revision: 6b50f2bbdbf4c5a8961ddf0dc82dae186cab0fd4 URL: https://github.com/llvm/llvm-project/commit/6b50f2bbdbf4c5a8961ddf0dc82dae186cab0fd4 DIFF: https://github.com/llvm/llvm-project/commit/6b50f2bbdbf4c5a8961ddf0dc82dae186cab0fd4.diff

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

sammccall added a comment. It's possible we should *only* be checking the IsHeaderFile flag here and drop all the sourcemanager stuff, but I'm not sure of the implications - thoughts appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

sammccall updated this revision to Diff 444253. sammccall edited the summary of this revision. sammccall added a comment. Herald added a subscriber: ilya-biryukov. add bug link to description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Certain idioms

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. In D109701#3646856 , @abrahamcd wrote: > Hi! I'm interning with @cjdb and @denik this summer and I was working on > adding a `-fdiagnostics-format=sarif` option to start off my project, but I > just found that a previous

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman marked 3 inline comments as done. Codesbyusman added a comment. In D129048#3647918 , @aaron.ballman wrote: > I think this is getting pretty close! I did have some style guideline > changes, and at least one test addition I'd like to see

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444250. Codesbyusman added a comment. updated the styles and other small things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D128411: [syntax] Introduce a TokenManager interface.

hokein updated this revision to Diff 444244. hokein added a comment. Herald added subscribers: kadircet, arphaman. Herald added a project: clang-tools-extra. update the API changes in clangd part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

erichkeane accepted this revision. erichkeane added a comment. Nothing sticks out to me, LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 ___

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the explanation on non-trailing packs, I think I'm convinced. Aside from some test coverage, I think this LGTM. Please hold off on landing until @erichkeane has

[PATCH] D129542: [CodeGen] Add codegen of IR function attribute fine_grained_bitfields

aaron.ballman added a comment. The changes look reasonable to me as far as they go, but I'm not confident I understand the LLVM bits this builds on top of well enough to accept with much authority. So giving my LG, but not accepting the review so other reviewers can weigh in. Repository:

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

erichkeane added a comment. Code changes LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129591/new/ https://reviews.llvm.org/D129591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129591: Modify CXXMethodDecl::isMoveAssignmentOperator() to look through type sugar

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, that's a great catch! You should also add a release note for the fix (to the bug fixes section) before landing. CHANGES SINCE LAST ACTION

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D129269

[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:212-214 +/// Abstract interface for diagnostic contexts (traditionally: notes). +/// A BasicDiagnostic may have as many different contexts as required to provide +/// users with a complete

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added a comment. Thanks for the extra test case! > Do you see an obvious fix? If not, please revert while investigating. Obvious fix landed in 66fa2847a775dda27ddcac3832769441727db42f Repository: rG

[clang] 66fa284 - [clang] Ignore DependentSizeArray in -Warray-parameter

Author: serge-sans-paille Date: 2022-07-13T14:58:23+02:00 New Revision: 66fa2847a775dda27ddcac3832769441727db42f URL: https://github.com/llvm/llvm-project/commit/66fa2847a775dda27ddcac3832769441727db42f DIFF:

[PATCH] D125946: Handles failing driver tests of clang

Purva-Chaudhari updated this revision to Diff 444238. Purva-Chaudhari added a comment. modify tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125946/new/ https://reviews.llvm.org/D125946 Files: clang/lib/Interpreter/IncrementalParser.cpp

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

sammccall added a comment. In D129579#3647834 , @kadircet wrote: > sorry for being late to the party, but reading the spec >

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. I think this is getting pretty close! I did have some style guideline changes, and at least one test addition I'd like to see though. Also, it looks like precommit CI caught a test that still needs to be updated: FAIL: Clang :: SemaCXX/cxx98-compat.cpp (16448

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8082a0028638: [CodeGen] Keep track of decls that were deferred and have been emitted. (authored by junaire). Changed prior to commit: https://reviews.llvm.org/D128782?vs=441667=444228#toc Repository:

[clang] 8082a00 - [CodeGen] Keep track of decls that were deferred and have been emitted.

Author: Jun Zhang Date: 2022-07-13T20:00:59+08:00 New Revision: 8082a00286380d0dafa05bfe5ddfe6075b9769f9 URL: https://github.com/llvm/llvm-project/commit/8082a00286380d0dafa05bfe5ddfe6075b9769f9 DIFF: https://github.com/llvm/llvm-project/commit/8082a00286380d0dafa05bfe5ddfe6075b9769f9.diff

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8d83e8004e4: [clang][dataflow] Generate readable form of input and output of satisfiability… (authored by wyt). Repository: rG LLVM Github

[clang] b8d83e8 - [clang][dataflow] Generate readable form of input and output of satisfiability checking.

Author: Wei Yi Tee Date: 2022-07-13T11:58:51Z New Revision: b8d83e8004e4b70fa81e8582eb9f8443a0f3758c URL: https://github.com/llvm/llvm-project/commit/b8d83e8004e4b70fa81e8582eb9f8443a0f3758c DIFF: https://github.com/llvm/llvm-project/commit/b8d83e8004e4b70fa81e8582eb9f8443a0f3758c.diff LOG:

[PATCH] D129568: [clang][dataflow] Rename `Status` field in a `Solver::Result` struct to `SATCheckStatus`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec2b2f4ec32: [clang][dataflow] Rename `Status` field in a `Solver::Result` struct to… (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3ec2b2f - [clang][dataflow] Rename `Status` field in a `Solver::Result` struct to `SATCheckStatus`.

Author: Wei Yi Tee Date: 2022-07-13T11:40:37Z New Revision: 3ec2b2f4ec3205a5b11c083b80566292d6ee2ecb URL: https://github.com/llvm/llvm-project/commit/3ec2b2f4ec3205a5b11c083b80566292d6ee2ecb DIFF: https://github.com/llvm/llvm-project/commit/3ec2b2f4ec3205a5b11c083b80566292d6ee2ecb.diff LOG:

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

kadircet added a comment. sorry for being late to the party, but reading the spec it sounds like vscode behaviour is actually the

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444211. Codesbyusman added a comment. the parser updates maked for the static asserion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

aaron.ballman added a comment. Thank you, this is looking really promising! Can you also add a test to `unittests/ASTMatchers/Dynamic/RegistryTest.cpp` to the `TEST_F(RegistryTest, OverloadedMatchers)` test which tests the behavior of `callee()` to make sure it works from dynamic matchers? If

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3647530 , @nikic wrote: > FYI this change had a noticeable compile-time impact >

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9666d2339e5: [clang][dataflow] Generate readable form of boolean values. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c9666d2 - [clang][dataflow] Generate readable form of boolean values.

Author: Wei Yi Tee Date: 2022-07-13T10:35:17Z New Revision: c9666d2339e5e11fa4f2de2e0294948b871c50ab URL: https://github.com/llvm/llvm-project/commit/c9666d2339e5e11fa4f2de2e0294948b871c50ab DIFF: https://github.com/llvm/llvm-project/commit/c9666d2339e5e11fa4f2de2e0294948b871c50ab.diff LOG:

[clang] 1e9cd04 - [clang][dataflow] Refactor boolean creation as a test utility.

Author: Wei Yi Tee Date: 2022-07-13T10:35:17Z New Revision: 1e9cd04d7ba67c48a783bde217f97ea6679053e4 URL: https://github.com/llvm/llvm-project/commit/1e9cd04d7ba67c48a783bde217f97ea6679053e4 DIFF: https://github.com/llvm/llvm-project/commit/1e9cd04d7ba67c48a783bde217f97ea6679053e4.diff LOG:

[PATCH] D129628: Fix aligning of java-style declarations

eoanermine added a comment. I found that the problem was that `TokenAnnotator` doesn't handle Java-style array declarations fine. It doesn't consider identifier after square brackets as a StartOfName. I fixed it, it seems valid, but I'm not a hundred percent sure about it. Repository: rG

[PATCH] D129628: Fix aligning of java-style declarations

eoanermine created this revision. eoanermine added reviewers: MyDeveloperDay, owenpan, HazardyKnusperkeks, curdeius. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Modify

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG632de855a042: [clang][dataflow] Refactor boolean creation as a test utility. (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES

[clang] 632de85 - [clang][dataflow] Refactor boolean creation as a test utility.

Author: Wei Yi Tee Date: 2022-07-13T10:15:06Z New Revision: 632de855a0420bf6ea56fc8b4727c64a9823a485 URL: https://github.com/llvm/llvm-project/commit/632de855a0420bf6ea56fc8b4727c64a9823a485 DIFF: https://github.com/llvm/llvm-project/commit/632de855a0420bf6ea56fc8b4727c64a9823a485.diff LOG:

<    1   2   3   >