[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen marked an inline comment as done. ychen added a comment. In D128750#3627085 , @royjacobson wrote: > I'm also a bit concerned that we're deviating from the standard here w.r.t. > to the 'reordering' checks for reversed candidates. I support this -

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209 + OMPLexicalScope Scope(*this, S, OMPD_unknown); + if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) { +llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder();

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

shraiysh updated this revision to Diff 445697. shraiysh added a comment. Moved checking to `isSupportedByOpenMPIRBuilder`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129992/new/ https://reviews.llvm.org/D129992 Files:

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

shafik added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14176 + ParmVarDecl *Param = Method->getParamDecl(i); + if (!Param->hasDefaultArg()) { +IsError = true; Do we have a test for this case? Repository: rG LLVM Github

[PATCH] D130026: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

This revision was automatically updated to reflect the committed changes. Closed by commit rG6357f1c1aa76: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 6357f1c - [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

Author: Nathan James Date: 2022-07-19T05:21:19+01:00 New Revision: 6357f1c1aa7694240a3b18e164faa977383dc9b6 URL: https://github.com/llvm/llvm-project/commit/6357f1c1aa7694240a3b18e164faa977383dc9b6 DIFF: https://github.com/llvm/llvm-project/commit/6357f1c1aa7694240a3b18e164faa977383dc9b6.diff

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. DR2338 clarified that it was undefined behavior to set the value outside

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu updated this revision to Diff 445690. zixuan-wu added a comment. Remove unnecessary include header. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/riscv-abi.c

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3660650 , @tahonermann wrote: > I neglected to explicitly mention in conjunction with my last comment, but > @ChuanqiXu, can you check to see if we are indeed serializing class template > specializations "too

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM basically if the following comments addressed. Comment at: clang/lib/Sema/SemaLookup.cpp:3864-3878 + for (auto *E : AssociatedClasses) { +

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5128 +// to the function itself; it points to a stub for the compiler. +// FIXME: We also need to emit an entry thunk. +SmallString<256> MangledName; A headache thing

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

shafik added a comment. Thank you for working on this. It looks like there are some pre-commit test failures, did you confirm whether they were related to your change or not? Also you mentioned that this changes the output of `-ast-dump` it might be worth adding a test to capture this

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:10-19 +// empty statement without semicolon +while(1) // expected-error {{while loop outside of a function}} +{ + +} + +// empty statement without semicolon, inline l_paren

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1533 + *ReplacedOrErr, ToReplacementTypeOrErr->getCanonicalType(), + T->getPackIndex()); } I think we should have a test in `ASTImporterTest.cpp` to make sure we are importing

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked an inline comment as done. manas added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1272-1273 + // (x != y). + if ((ConvertedLHS.getMaxValue() < ConvertedRHS.getMinValue()) || + (ConvertedLHS.getMinValue() >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 445671. manas added a comment. Rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 445668. inclyc retitled this revision from "[Clang] add a diagnostic note 'while loop outside functions' at global scope" to "[clang] add a diagnostic note 'while loop outside functions' at global scope". CHANGES SINCE LAST ACTION

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, rnk, MaskRay, void. Herald added a subscriber: StephenFan. Herald added a reviewer: NoQ. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Sometimes a default-initialized

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:8 + +void some_fn(); + inclyc wrote: > mizvekov wrote: > > inclyc wrote: > > > mizvekov wrote: > > > > Can you add a few more test cases showing how error recovery is > >

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:8 + +void some_fn(); + mizvekov wrote: > inclyc wrote: > > mizvekov wrote: > > > Can you add a few more test cases showing how error recovery is > > > performing here? > >

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:8 + +void some_fn(); + inclyc wrote: > mizvekov wrote: > > Can you add a few more test cases showing how error recovery is performing > > here? > > > > Have we parsed

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:3 + +while(1) {}; // expected-error {{while loop outside of function}} + mizvekov wrote: > You could break this down further into more lines to test exactly where the >

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:8 + +void some_fn(); + mizvekov wrote: > Can you add a few more test cases showing how error recovery is performing > here? > > Have we parsed this function declaration

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3198364e6e49: [RISCV][Clang] Add support for Zmmul extension (authored by ksyx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3198364 - [RISCV][Clang] Add support for Zmmul extension

Author: ksyx Date: 2022-07-18T20:26:08-04:00 New Revision: 3198364e6e4943512ed48f2a1c1ab4c418b72f42 URL: https://github.com/llvm/llvm-project/commit/3198364e6e4943512ed48f2a1c1ab4c418b72f42 DIFF: https://github.com/llvm/llvm-project/commit/3198364e6e4943512ed48f2a1c1ab4c418b72f42.diff LOG:

[PATCH] D129311: [clang-format] Update return code

owenpan added a comment. Please mark as done if you have addressed an inline comment. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree, - '--']) +

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

hubert.reinterpretcast added a comment. In D129912#3661282 , @akyrtzi wrote: > Sorry about that, it should be fixed via > https://github.com/llvm/llvm-project/commit/d1b58cada61aa8bc44d8e8ef9c23ed12ef7b549b Thanks for the fix; it does look promising.

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

akyrtzi added a comment. In D129912#3661181 , @hubert.reinterpretcast wrote: > The added test is not passing on the AIX builder: > https://lab.llvm.org/buildbot/#/builders/214/builds/2388/steps/6/logs/FAIL__Clang-Unit__83 > > Note that Clang on that

[clang] d1b58ca - [unittests/Tooling/DependencyScannerTest] Add a target triple for `ScanDepsWithFS` test

Author: Argyrios Kyrtzidis Date: 2022-07-18T16:55:07-07:00 New Revision: d1b58cada61aa8bc44d8e8ef9c23ed12ef7b549b URL: https://github.com/llvm/llvm-project/commit/d1b58cada61aa8bc44d8e8ef9c23ed12ef7b549b DIFF:

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 445652. sridhar_gopinath added a comment. Updated subprocess.call -> subprocess.run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/ https://reviews.llvm.org/D129311 Files:

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

hubert.reinterpretcast added a comment. The added test is not passing on the AIX builder: https://lab.llvm.org/buildbot/#/builders/214/builds/2388/steps/6/logs/FAIL__Clang-Unit__83 Note that Clang on that platform generates assembly by default (then invokes the system assembler). Repository:

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445648. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 445647. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 445646. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few nits about naming, but otherwise this LGTM. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:47

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445643. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3661049 , @MaskRay wrote: > Does this address the macOS build failure? I believe so! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 445635. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Does this address the macOS build failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445634. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Herald added a subscriber: StephenFan. If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` sets `c.Options.DataSections = true;` to enable data sections by

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445631. quinnp added a comment. Updating patch to forward `-data-sections=1` to `libLTO`/`gold` instead of just `-data-sections` when `-fdata-sections` is explicitly specified in `clang`. This is to be more explicit since `-data-sections=0` is now being

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:579 + if (Args.hasArg(options::OPT_fno_data_sections)) +CmdArgs.push_back("-plugin-opt=-data-sections=0"); This should be combined with the previous `if` Repository:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445628. quinnp added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Updating patch with a `clang` change to properly forward `-data-sections=0` to `libLTO`/`gold` when `-fno-data-sections` is explicitly specified.

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445623. ckissane added a comment. - remove extra cmake info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: llvm/CMakeLists.txt

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. For more context see the discussion on b/187405187 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 ___ cfe-commits mailing list

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 445618. dgoldman added a comment. Revert unintended change in symbol-info.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files:

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane updated this revision to Diff 445615. ckissane added a comment. - move try_find_dependency into it's own file - add newline to end of TryFindDependencyMacro.cmake - clarify comment in TryFindDependencyMacro.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] fa0c763 - [pseudo] Add guards for module contextual keywords

Author: Sam McCall Date: 2022-07-18T22:38:41+02:00 New Revision: fa0c7639e91fa1cd0cf2ff0445a1634a90fe850a URL: https://github.com/llvm/llvm-project/commit/fa0c7639e91fa1cd0cf2ff0445a1634a90fe850a DIFF: https://github.com/llvm/llvm-project/commit/fa0c7639e91fa1cd0cf2ff0445a1634a90fe850a.diff

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. impl looks good! Comment at: clang-tools-extra/pseudo/test/cxx/declarator-function.cpp:6 // RUN: clang-pseudo -grammar=cxx -source=%s --print-forest | FileCheck %s

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG315072b45011: [clang-tidy] Reduce the dependencies for the make-confusable-table tool (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 315072b - [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

Author: Martin Storsjö Date: 2022-07-18T22:50:29+03:00 New Revision: 315072b450114ca596d7cbd89b1f22f6b13b6281 URL: https://github.com/llvm/llvm-project/commit/315072b450114ca596d7cbd89b1f22f6b13b6281 DIFF:

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added a comment. In D88299#3660779 , @nridge wrote: > Thanks! (I was intrigued by Sam's "solves a whole class of clang-format's > biggest problems" comment :-)) The end-result hopefully will :) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88299: [clang-format] Add MacroUnexpander.

nridge added a comment. Thanks! (I was intrigued by Sam's "solves a whole class of clang-format's biggest problems" comment :-)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. In D109977#3660734 , @mgorny wrote: > In D109977#3660006 , @abrachet > wrote: > >> In D109977#3652467 , @mgorny wrote: >> >>> Though I can

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209 + OMPLexicalScope Scope(*this, S, OMPD_unknown); + if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) { +llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder();

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added a comment. In D88299#3660772 , @nridge wrote: > Does this patch change the formatting behaviour of clang-format? > > If so, are there any test cases that show before/after formatting? The > MacroCallReconstructorTest unit test seems like

[PATCH] D88299: [clang-format] Add MacroUnexpander.

nridge added a comment. Does this patch change the formatting behaviour of clang-format? If so, are there any test cases that show before/after formatting? The MacroCallReconstructorTest unit test seems like it's testing an internal interface. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129946: [clang-format] Mark constexpr lambdas as lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2eda4920238: [clang-format] Mark constexpr lambdas as lambda (authored by HazardyKnusperkeks). Changed prior to commit:

[PATCH] D129942: [clang-format] Indent TT_CtorInitializerColon after requires clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c18a8b3a349: [clang-format] Indent TT_CtorInitializerColon after requires clauses (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b04c41b2832: [clang-format] Fix misannotation of colon in presence of requires clause (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d2eda49 - [clang-format] Mark constexpr lambdas as lambda

Author: Björn Schäpers Date: 2022-07-18T21:42:34+02:00 New Revision: d2eda49202386b222cec763aad9aaecd463ce044 URL: https://github.com/llvm/llvm-project/commit/d2eda49202386b222cec763aad9aaecd463ce044 DIFF:

[clang] 3c18a8b - [clang-format] Indent TT_CtorInitializerColon after requires clauses

Author: Björn Schäpers Date: 2022-07-18T21:41:09+02:00 New Revision: 3c18a8b3a349781eac54144d0cf252bbbce0c4c1 URL: https://github.com/llvm/llvm-project/commit/3c18a8b3a349781eac54144d0cf252bbbce0c4c1 DIFF:

[clang] 2b04c41 - [clang-format] Fix misannotation of colon in presence of requires clause

Author: Björn Schäpers Date: 2022-07-18T21:41:09+02:00 New Revision: 2b04c41b28320c1e399209fbe7a5a8d540578999 URL: https://github.com/llvm/llvm-project/commit/2b04c41b28320c1e399209fbe7a5a8d540578999 DIFF:

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. In D128465#3660733 , @ckissane wrote: > In D128465#3660714 , @MaskRay wrote: > >> Instead of marking a differential `[OLD] ` (which may confuse readers >> whether this is to be

[PATCH] D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Not the way I would have gone. I'm not fond of the allocations for the strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129982/new/

[PATCH] D128667: [WIP] Add Zstd ELF support

MaskRay added a comment. There is kinda consensus that the proper way is to introduce `ELFCOMPRESS_ZSTD` as my proposal https://groups.google.com/g/generic-abi/c/satyPkuMisk did. This is currently blocked by an agreement from Cary Coutant that this value will be added to the generic ABI.

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. In D109977#3660006 , @abrachet wrote: > In D109977#3652467 , @mgorny wrote: > >> Though I can reproduce it with much shorter: >> >> mkdir build >> cd build >> cmake ../clang -G Ninja

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3660714 , @MaskRay wrote: > Instead of marking a differential `[OLD] ` (which may confuse readers whether > this is to be abandoned), you can mark a differential `Request > Reviews`/`Request Changes`. Then it will

[clang] 523a99c - [AMDGPU] Support for gfx940 fp8 smfmac

Author: Stanislav Mekhanoshin Date: 2022-07-18T12:12:41-07:00 New Revision: 523a99c0eb0331680905e9ef6fbdd114f4ee7a47 URL: https://github.com/llvm/llvm-project/commit/523a99c0eb0331680905e9ef6fbdd114f4ee7a47 DIFF:

[PATCH] D129908: [AMDGPU] Support for gfx940 fp8 smfmac

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG523a99c0eb03: [AMDGPU] Support for gfx940 fp8 smfmac (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D128465: [OLD] [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. Instead of marking a differential `[OLD] ` (which may confuse readers whether this is to be abandoned), you can mark a differential `Request Reviews`/`Request Changes`. Then it will not be in the green state. I clicked "Reopen" to make it clear the patch hasn't

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added a comment. In D129573#3659404 , @inclyc wrote: > Now it only generates 1 error encountering token "while" Yes thank you, that is what I meant! But now we just gotta make sure this stays true for more complex test cases.

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

aaron.ballman added a comment. In D129748#3658657 , @ChuanqiXu wrote: > In D129748#3654918 , @aaron.ballman > wrote: > >> For example, I would be IBOutletCollection, OwnerAttr, PointerAttr, and >>

[PATCH] D129906: [AMDGPU] Support for gfx940 fp8 mfma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2695f0a688e9: [AMDGPU] Support for gfx940 fp8 mfma (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 2695f0a - [AMDGPU] Support for gfx940 fp8 mfma

Author: Stanislav Mekhanoshin Date: 2022-07-18T11:49:56-07:00 New Revision: 2695f0a688e9d26fcb0f3a4b686a2783f2eb145c URL: https://github.com/llvm/llvm-project/commit/2695f0a688e9d26fcb0f3a4b686a2783f2eb145c DIFF:

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. I neglected to explicitly mention in conjunction with my last comment, but @ChuanqiXu, can you check to see if we are indeed serializing class template specializations "too early" and, if so, whether delaying such serialization until a defining point resolves the

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

tahonermann added a comment. Thank you for the detailed explanation, @ChuanqiXu, that was very helpful. It looks to me like the problem may be that the initial declaration of the `basic_string_view` class template is non-defining, but when serializing that declaration, we serialize a

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

denik added a comment. Thanks for adding the flag! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1383 + +def SarifFormatUnstable : DiagGroup<"sarif-format-unstable">; cjdb wrote: > Please make sure that there's a newline at the end of each file. I

[PATCH] D130033: [HLSL] Add resource binding attribute for HLSL.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk, Anastasia, aaron.ballman. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The resource binding

[clang] 9fa5a6b - [AMDGPU] Support for gfx940 fp8 conversions

Author: Stanislav Mekhanoshin Date: 2022-07-18T11:48:43-07:00 New Revision: 9fa5a6b7e8a292ec91b844a622836d2990ef5796 URL: https://github.com/llvm/llvm-project/commit/9fa5a6b7e8a292ec91b844a622836d2990ef5796 DIFF:

[PATCH] D129902: [AMDGPU] Support for gfx940 fp8 conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fa5a6b7e8a2: [AMDGPU] Support for gfx940 fp8 conversions (authored by rampitec). Herald added a project: clang. Herald added a subscriber:

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. In D119792#3658987 , @Izaron wrote: > Hi! > > Unfortunately I don't have time to finish this pull request, so please feel > free to take it and get it done =) > > (You may reuse the code from this PR or write a completely

[PATCH] D130026: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130026/new/ https://reviews.llvm.org/D130026

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 + "diagnostic formatting in SARIF mode is currently unstable">, + InGroup>; } abrahamcd wrote: > Please let me know if there's a better warning group you think this

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

beanz updated this revision to Diff 445572. beanz added a comment. Updating based on feedback from @python3kgae provided via chat. Because of the odd nature of DXIL, the DirectX backend needs to filter the module flags, for that reason it is easier to use a named metadata entry which can just

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

ASDenysPetrov added a comment. In D90157#2518118 , @steakhal wrote: > Why don't you use the `SValVisitor` instead? @steakhal Finally fulfilled you suggestion :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource marked an inline comment as done. frederic-tingaud-sonarsource added a comment. Hi @NoQ , Do the changes correspond to what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, NoQ, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project:

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

vaibhav.y added a comment. In D129886#3660299 , @abrahamcd wrote: > In D129886#3656221 , @vaibhav.y > wrote: > >> Might be worth hiding it from `--help`, despite the instability warning. > > I already couldn't

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} python3kgae wrote: > What does the parameter 0 mean here? > For the purposes of this test, the value doesn't

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 + "diagnostic formatting in SARIF mode is currently unstable">, + InGroup>; } Please let me know if there's a better warning group you think this should be

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added a comment. In D129886#3656221 , @vaibhav.y wrote: > Might be worth hiding it from `--help`, despite the instability warning. I already couldn't find any mention of `-fdiagnostics-format` or `sarif` when I ran `clang --help`. Is there

[PATCH] D130026: [clang-tidy] Remove unnecessary code from ReadabilityModuleTest

njames93 created this revision. njames93 added reviewers: LegalizeAdulthood, aaron.ballman, kwk, serge-sans-paille. Herald added subscribers: xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445554. abrahamcd retitled this revision from "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics" to "[clang] Add -fdiagnostics-format=sarif option for future SARIF output". abrahamcd edited the summary of this revision. abrahamcd added a

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 5 inline comments as done. manas added a comment. Considering @ASDenysPetrov 's example of `LHS = [1, 2] U [8, 9]` and `RHS = [5, 6]`, I constructed a test case as following: `(((u1 >= 1 && u1 <= 2) || (u1 >= 8 && u1 <= 9)) && u2 >= 5 && u2 <= 6)` but I can see that the analyzer

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:1 +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" #include "ClangTidyTest.h" kwk wrote: > @LegalizeAdulthood I'm doing standalone builds

[clang] 47b0aa5 - [LinkerWrapper] Rework passing args to the LLVM backend

Author: Joseph Huber Date: 2022-07-18T12:44:15-04:00 New Revision: 47b0aa5e4be7ba88bab60b9573407be1f6c387b1 URL: https://github.com/llvm/llvm-project/commit/47b0aa5e4be7ba88bab60b9573407be1f6c387b1 DIFF: https://github.com/llvm/llvm-project/commit/47b0aa5e4be7ba88bab60b9573407be1f6c387b1.diff

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 445549. manas added a comment. Remove filling gaps and convert, use castTo, and add tests for short-ushort, char-uchar pairs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/

  1   2   >