[clang] 1f54006 - [clang][docs] use `Fixes` instead of `This fixes` in ReleaseNotes [NFC]

Author: YingChi Long Date: 2022-08-07T12:42:15+08:00 New Revision: 1f54006bcacf3967b03f9851edf7f9cd773d53e8 URL: https://github.com/llvm/llvm-project/commit/1f54006bcacf3967b03f9851edf7f9cd773d53e8 DIFF: https://github.com/llvm/llvm-project/commit/1f54006bcacf3967b03f9851edf7f9cd773d53e8.diff

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 450587. cjdb added a comment. rebases to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llvm.org/D130867 Files: clang/docs/ReleaseNotes.rst

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 450585. cjdb added a comment. fixes commit update mistake and rebases to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files:

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 450584. cjdb added a comment. adds logic to diagnose misqualified pointer-to-member functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llvm.org/D130867 Files:

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

thakis added a comment. It's already an error, but it's a warning default-mapped to an error. You can -Wno-error=name to downgrade it into a warning, but that requires an explicit action. So people are unlikely to miss it. This is how we usually handle these breaking changes. Maybe there

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay created this revision. MaskRay added a reviewer: aaron.ballman. Herald added subscribers: steakhal, kosarev, pmatos, asb, StephenFan, martong, kerbowa, arphaman, kbarton, jgravelle-google, sbc100, jvesely, nemanjai, dschuff. Herald added a reviewer: dang. Herald added a reviewer: NoQ.

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 450581. cjdb retitled this revision from "WORK-IN-PROGRESS [clang] adds builtin `std::invoke` and `std::invoke_r`" to "[clang] adds builtin `std::invoke` and `std::invoke_r`". cjdb edited the summary of this revision. cjdb added a comment. updates commit

[PATCH] D130689: [LLVM] Update C++ standard to 17

MaskRay added a comment. In D130689#3704581 , @dyung wrote: > Your change is causing a build failure on the PS4 linux build bot using GCC > 9.3. Can you take a look? > https://lab.llvm.org/buildbot/#/builders/139/builds/26186 > > FAILED: >

[clang-tools-extra] c7ec86b - [clang-tidy] Fix g++ -DCMAKE_CXX_STANDARD=17 build

Author: Fangrui Song Date: 2022-08-06T23:12:18Z New Revision: c7ec86b13c461f6a8ce11f8443c1b6242013d26f URL: https://github.com/llvm/llvm-project/commit/c7ec86b13c461f6a8ce11f8443c1b6242013d26f DIFF: https://github.com/llvm/llvm-project/commit/c7ec86b13c461f6a8ce11f8443c1b6242013d26f.diff LOG:

[PATCH] D130689: [LLVM] Update C++ standard to 17

Trass3r added a comment. Also fails on gcc 11.2: https://github.com/Trass3r/llvm-project/runs/7703302032 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. Your change is causing a build failure on the PS4 linux build bot using GCC 9.3. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/26186 FAILED:

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21202dac18e: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e21202d - [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

Author: Shilei Tian Date: 2022-08-06T16:50:37-04:00 New Revision: e21202dac18ed7f718d26a0e131f96b399b4891c URL: https://github.com/llvm/llvm-project/commit/e21202dac18ed7f718d26a0e131f96b399b4891c DIFF: https://github.com/llvm/llvm-project/commit/e21202dac18ed7f718d26a0e131f96b399b4891c.diff

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450569. inclyc added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2b158e29eed: clang/cmake: Drop use of llvm-config for LLVM install discovery (authored by tstellar, committed by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d2b158e - clang/cmake: Drop use of llvm-config for LLVM install discovery

Author: Tom Stellard Date: 2022-08-06T16:22:59-04:00 New Revision: d2b158e29eedf4a29bf8d2142f2ed21a52fc80a7 URL: https://github.com/llvm/llvm-project/commit/d2b158e29eedf4a29bf8d2142f2ed21a52fc80a7 DIFF: https://github.com/llvm/llvm-project/commit/d2b158e29eedf4a29bf8d2142f2ed21a52fc80a7.diff

[PATCH] D131277: clang: fix typo availbility

inclyc added a comment. Copied from github comments: Thanks for working on this, changes on serialization may still cause issue related to backward compatibility. Even though this patch passed all regression tests, if in the future some one reports clang must give `availbility` (typo), we

[PATCH] D131277: clang: fix typo availbility

sloorush added a comment. In D131277#3704519 , @inclyc wrote: > In D131277#3704510 , @sloorush > wrote: > >> @inclyc, Here is my real name and email address in the requested format: >> >> Aarush Bhat >> >> I

[PATCH] D131277: clang: fix typo availbility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6cb8419b175: clang: fix typo availbility (authored by sloorush, committed by inclyc). Changed prior to commit:

[clang] a6cb841 - clang: fix typo availbility

Author: Aarush Bhat Date: 2022-08-07T03:44:55+08:00 New Revision: a6cb8419b1757380e3c577477fdc2501484a7245 URL: https://github.com/llvm/llvm-project/commit/a6cb8419b1757380e3c577477fdc2501484a7245 DIFF: https://github.com/llvm/llvm-project/commit/a6cb8419b1757380e3c577477fdc2501484a7245.diff

[PATCH] D131277: clang: fix typo availbility

inclyc added a comment. In D131277#3704510 , @sloorush wrote: > @inclyc, Here is my real name and email address in the requested format: > > Aarush Bhat > > I would love to get commit access. What exactly is the process? Do I have to > email as

[PATCH] D131277: clang: fix typo availbility

sloorush added a comment. @inclyc, Here is my real name and email address in the requested format: Aarush Bhat I would love to get commit access. What exactly is the process? Do I have to email as mentioned in https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access? Repository:

[PATCH] D131258: [Sema] Merge variable template specializations

inclyc added inline comments. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:45 +export import var_def; \ No newline at end of file Missing newline Comment at: clang/test/Modules/merge-var-template-spec.cpp:68 +#endif

[PATCH] D131277: clang: fix typo availbility

inclyc accepted this revision. inclyc added a comment. This revision is now accepted and ready to land. LGTM. Could you please provide your real name and email address, like Name ? So that I can commit this for you. Also feel free to ask for commit access. Repository: rG LLVM Github

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

smeenai added a comment. Thank you! I'm worried that users might miss this if it's only in the release notes, and then we'd be in a similar situation again when we try converting it to an error. Maybe you could also include the bit about the diagnostic turning into error-only in the

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

mgorny accepted this revision. mgorny added a comment. This one LGTM to me as well, and doesn't seem to break Gentoo either ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

hubert.reinterpretcast added inline comments. Comment at: libcxx/trunk/include/istream:1223 +__state |= ios_base::badbit; return -1; } @ldionne, another dubious aspect of this patch is that it initializes `__r` to

[clang] 486a3c4 - Update the status of some more C DRs

Author: Aaron Ballman Date: 2022-08-06T11:53:40-04:00 New Revision: 486a3c4662cb052329b96537da18893d73138b64 URL: https://github.com/llvm/llvm-project/commit/486a3c4662cb052329b96537da18893d73138b64 DIFF: https://github.com/llvm/llvm-project/commit/486a3c4662cb052329b96537da18893d73138b64.diff

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:110 + ` check to + use the `*and_present` and `*if_present` templates added in + `D123901 `_. Please use double back-ticks.

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450530. inclyc added a comment. rebase && qualify `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

Ericson2314 updated this revision to Diff 450529. Ericson2314 added a comment. Add my changes but split to just Clang as @tstellar requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files:

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450528. inclyc added a comment. Use isa<> to check Expr class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc added a comment. There are too many things changed in this patch, I think the function of displaying the evaluation results, `FIXME` warning, these can be done in subsequent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131314: [clang] format string checks for `InitListExpr`

tbaeder added a comment. Not a formal review of course, but for the diagnostics, I'm missing something that tells the user what the format string ended up looking like; in your example, the output never mentions that it checked "%s%d". Comment at:

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. Friendly Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131318: [clang-tidy] Add llvm-derefencing-dyn-cast check

njames93 added a comment. I had thought about merging this into the prefer-isa-or-dyn-cast in conditionals check, however there just isn't enough cross-over between the 2 and the names wouldn't really match up with what each part of the check does. There could be merit in merging them both into

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. > It would be greatly welcome for such comments! OK, here goes. Sorry for the large volume of comments. In addition to typos and stylistic improvements, I've had a few questions where the content wasn't clear to me (but note I'm not experienced with modules at all,

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, LegalizeAdulthood, JonasToth, bzcheeseman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D131318: [clang-tidy] Add llvm-derefencing-dyn-cast check

njames93 created this revision. njames93 added reviewers: aaron.ballman, JonasToth, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450496. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/format-strings.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450495. inclyc added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp clang/test/SemaCXX/format-strings.cpp

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc updated this revision to Diff 450494. inclyc added a comment. typo fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

smd added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > fmayer wrote: > > > vitalybuka wrote: > > > >

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc created this revision. Herald added a project: All. inclyc added reviewers: aaron.ballman, rsmith, mizvekov, tbaeder. inclyc added a project: clang. inclyc added a subscriber: clang. inclyc published this revision for review. Herald added a subscriber: cfe-commits. this patch enhances

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 450492. python3kgae marked an inline comment as done. python3kgae added a comment. Rebase and add unit-test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753

[PATCH] D130689: [LLVM] Update C++ standard to 17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1356504e63a: [LLVM] Update C++ standard to 17 (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128372: [Clang-Tidy] Empty Check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:124 + return isa(ND) && + llvm::dyn_cast(ND)->getMinRequiredArguments() == + 0; `dyn_cast` isn't needed here