[PATCH] D130689: [LLVM] Update C++ standard to 17

Jake-Egan added a comment. There is a failure on the AIX bot also: 152.827 [4302/10/270] Linking CXX executable bin/llvm-tblgen FAILED: bin/llvm-tblgen : && /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r -mcmodel=large -fPIC -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu added inline comments. Comment at: clang/test/Modules/merge-var-template-spec-cxx-modules.cpp:18-23 +template constexpr T zero = 0; // expected-error-re {{declaration{{.*}}in the global module follows declaration in module var_def}} +

[PATCH] D131258: [Sema] Merge variable template specializations

ChuanqiXu added a comment. When I run this locally, it emits several unexpected errors: While building module 'library': In file included from :2: /disk2/workspace.xuchuanqi/llvm-project-for-work/build/tools/clang/test/Modules/Output/merge-var-template-spec.cpp.tmp/var2.h:4:32: error:

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 450692. ChuanqiXu marked 8 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 Files: clang/docs/CPlusPlus20Modules.rst

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a reviewer: h-vetinari. ChuanqiXu marked 45 inline comments as done. ChuanqiXu added a comment. In D131062#3704017 , @h-vetinari wrote: >> It would be greatly welcome for such comments! > > OK, here goes. Sorry for the large volume of

[PATCH] D130689: [LLVM] Update C++ standard to 17

dyung added a comment. We are seeing an additional failure on an internal linux bot due to the change to using C++17 by default when using GNU ld: [3/7] Generating GwpAsan-x86_64-Test FAILED: projects/compiler-rt/lib/gwp_asan/tests/GwpAsan-x86_64-Test cd

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3699911 , @kito-cheng wrote: > Just realized the problem is trying to fixed the default value of `-mabi=`, > currently `clang -target riscv32-elf -march=rv64gc > -mabi=lp64d`/`riscv32-elf-clang -march=rv64gc

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5726-5731 + FirstArgType = S.BuiltinAddReference( + dyn_cast( + dyn_cast(FirstArgType)->getNamedType()) + ->getArg(0) + .getAsType(), + Sema::UTTKind::AddLvalueReference,

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

smeenai added a comment. In D131307#3704709 , @thakis wrote: > It's already an error, but it's a warning default-mapped to an error. You can > -Wno-error=name to downgrade it into a warning, but that requires an explicit > action. So people are

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1bb3016ddc8: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES

[clang] d1bb301 - [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

Author: Ashay Rane Date: 2022-08-07T15:48:38-07:00 New Revision: d1bb3016ddc8331a96048eda37ab13bf412c7749 URL: https://github.com/llvm/llvm-project/commit/d1bb3016ddc8331a96048eda37ab13bf412c7749 DIFF: https://github.com/llvm/llvm-project/commit/d1bb3016ddc8331a96048eda37ab13bf412c7749.diff

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Can we land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129926/new/ https://reviews.llvm.org/D129926 ___

[PATCH] D131360: [clang-format] Fixes crash in QualifierOrder

MyDeveloperDay added a comment. Maybe I didn’t rebase correctly, let me retry and I’ll abandon if necessary, Thanks @owenpan for the pointer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131360/new/ https://reviews.llvm.org/D131360 ___

[PATCH] D131360: [clang-format] Fixes crash in QualifierOrder

owenpan added a comment. It seems rG492cb7bf9164 also fixed this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131360/new/ https://reviews.llvm.org/D131360 ___

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MapEntryOptionalStorage is an underlying storage class for OptionalStorage. This patch deprecates: OptionalStorage::hasValue

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705236 , @royjacobson wrote: > This affects people on their work branches as well, and it's not obvious that > it's a configuration error and not a broken master. > > The CMake approach sounds cleaner to me, but I

[PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. In D130689#3705145 , @thieta wrote: > In D130689#3705131 , @royjacobson > wrote: > >> This seems to have been more disruptive than expected, since an existing >> CMakeCache.txt can

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github added inline comments. Comment at: llvm/cmake/modules/TableGen.cmake:147 + cmake_parse_arguments(ADD_TABLEGEN "${options}" "${oneValueArgs}" +"${multiValueArgs}" ${ARGN}) + nikic wrote: > I think it would be fine to write this as just >

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github updated this revision to Diff 450661. ashay-github marked an inline comment as done. ashay-github added a comment. Simply invocation of `cmake_parse_arguments()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131282/new/

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the bots

[PATCH] D130689: [LLVM] Update C++ standard to 17

royjacobson added a comment. This seems to have been more disruptive than expected, since an existing CMakeCache.txt can make LLVM compile in previous C++14 configuration. This seems to make some of the bots fail in a way that makes the patches making use of C++17 features seem at fault. See:

[PATCH] D131360: [clang-format] Fixes crash in QualifierOrder

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added a project: clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Prevent Null Token from causing a crash Fixes:

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

inclyc added a comment. I think in fact you are now fully qualified to apply for commit access. Don't worry, Lattner generally trusts all developers willing to contribute to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. In D130394#3705047 , @inclyc wrote: > (Not a serious review) It seems like that your patch has already been > accepted, so that I can commit this patch for you. It was very nice of you, thanks! Repository: rG LLVM

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87dc7d4b619d: [clang][CodeGen] Factor out Swift ABI hooks (NFCI) (authored by barannikov88, committed by inclyc). Repository: rG LLVM Github

[clang] 87dc7d4 - [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

Author: Sergei Barannikov Date: 2022-08-08T00:23:23+08:00 New Revision: 87dc7d4b619d9823b4d5d33bbc3ff3a193b9da2f URL: https://github.com/llvm/llvm-project/commit/87dc7d4b619d9823b4d5d33bbc3ff3a193b9da2f DIFF:

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

inclyc accepted this revision. inclyc added a comment. (Not a serious review) It seems like that your patch has already been accepted, so that I can commit this patch for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

rusyaev-roman accepted this revision. rusyaev-roman added a comment. This revision is now accepted and ready to land. LGTM. Maybe in the future it's better to use SwiftABIInfo as mix-in like this class ARMABIInfo : public ABIInfo, public SwiftABIInfo Repository: rG LLVM Github Monorepo

[clang-tools-extra] 82439b2 - [clang-tidy] Fix a forwarding-reference-overload crash after the

Author: Haojian Wu Date: 2022-08-07T16:53:56+02:00 New Revision: 82439b201a01707fd18f0d34a4b625132b9c7304 URL: https://github.com/llvm/llvm-project/commit/82439b201a01707fd18f0d34a4b625132b9c7304 DIFF: https://github.com/llvm/llvm-project/commit/82439b201a01707fd18f0d34a4b625132b9c7304.diff

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I agree that this address potential security issues. I'm curious how many people will be affected, but hopefully by doing that early in the clang 16 cycle we might find out! Thanks

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, jyknight, efriedma, clang-language-wg. Herald added a subscriber: jdoerfert. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Implicitly converting between

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/cmake/modules/TableGen.cmake:147 + cmake_parse_arguments(ADD_TABLEGEN "${options}" "${oneValueArgs}" +"${multiValueArgs}" ${ARGN}) +

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github marked an inline comment as done. ashay-github added inline comments. Comment at: llvm/cmake/modules/TableGen.cmake:199 COMPONENT ${target} RUNTIME DESTINATION "${${project}_TOOLS_INSTALL_DIR}") if(NOT LLVM_ENABLE_IDE)

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github updated this revision to Diff 450614. ashay-github added a comment. Herald added subscribers: cfe-commits, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, nicolasvasilache,

[PATCH] D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

smd created this revision. Herald added subscribers: Enna1, sunshaoce, VincentWu, luke957, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson, mgorny. Herald added a project: All. smd edited the summary of this revision. smd added

[clang] 7542e72 - Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-08-07T00:16:17-07:00 New Revision: 7542e72188cb05b22523cc58ea4223951399520d URL: https://github.com/llvm/llvm-project/commit/7542e72188cb05b22523cc58ea4223951399520d DIFF: https://github.com/llvm/llvm-project/commit/7542e72188cb05b22523cc58ea4223951399520d.diff