[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a7d476087df: [clang][Interp] Implement array initializers and subscript expressions (authored by tbaeder). Repository: rG LLVM Github Monorepo

[PATCH] D132832: [clang][Interp] Handle missing local initializers better

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7c5c9c4e5e: [clang][Interp] Handle missing local initializers better (authored by tbaeder). Changed prior to commit:

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c4dbff0b6c3: [clang][Interp] Handle SubstNonTypeTemplateParmExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG4d700ffe67be: [clang][Interp] Implement ImplicitValueInitExprs (authored by tbaeder). Repository: rG

[clang] 651f4ce - [clang][Interp][NFC] Use constexpr if when possible in Integral.h

Author: Timm Bäder Date: 2022-09-08T07:31:08+02:00 New Revision: 651f4ce7b186079e78de20d7de903112ea78d846 URL: https://github.com/llvm/llvm-project/commit/651f4ce7b186079e78de20d7de903112ea78d846 DIFF: https://github.com/llvm/llvm-project/commit/651f4ce7b186079e78de20d7de903112ea78d846.diff

[PATCH] D132739: [clang][Interp] Implement IntegralToBoolean casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG95e6a407d92b: [clang][Interp] Implement IntegralToBoolean casts (authored by tbaeder). Repository: rG

[clang] 0da7e40 - [clang][Interp][NFC] Context::classify() can be const

Author: Timm Bäder Date: 2022-09-08T07:31:08+02:00 New Revision: 0da7e409e0cb09ea955d9751d2601449244cc53f URL: https://github.com/llvm/llvm-project/commit/0da7e409e0cb09ea955d9751d2601449244cc53f DIFF: https://github.com/llvm/llvm-project/commit/0da7e409e0cb09ea955d9751d2601449244cc53f.diff

[clang] 3a7d476 - [clang][Interp] Implement array initializers and subscript expressions

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 3a7d476087df175b6fe056e7c20ac9707019e92b URL: https://github.com/llvm/llvm-project/commit/3a7d476087df175b6fe056e7c20ac9707019e92b DIFF: https://github.com/llvm/llvm-project/commit/3a7d476087df175b6fe056e7c20ac9707019e92b.diff

[PATCH] D132286: [clang][Interp] Implement function calls

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e41e6a4eafa: [clang][Interp] Implement function calls (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D132286?vs=455791=458645#toc Repository: rG LLVM Github Monorepo

[clang] aa7c5c9 - [clang][Interp] Handle missing local initializers better

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: aa7c5c9c4e5e56fc668b055ce40c1a65fae1e38e URL: https://github.com/llvm/llvm-project/commit/aa7c5c9c4e5e56fc668b055ce40c1a65fae1e38e DIFF: https://github.com/llvm/llvm-project/commit/aa7c5c9c4e5e56fc668b055ce40c1a65fae1e38e.diff

[clang] 5c4dbff - [clang][Interp] Handle SubstNonTypeTemplateParmExprs

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 5c4dbff0b6c3943dfbcba930986e23e015df97c5 URL: https://github.com/llvm/llvm-project/commit/5c4dbff0b6c3943dfbcba930986e23e015df97c5 DIFF: https://github.com/llvm/llvm-project/commit/5c4dbff0b6c3943dfbcba930986e23e015df97c5.diff

[clang] 4d700ff - [clang][Interp] Implement ImplicitValueInitExprs

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 4d700ffe67be03220487604785ee2049570ba6db URL: https://github.com/llvm/llvm-project/commit/4d700ffe67be03220487604785ee2049570ba6db DIFF: https://github.com/llvm/llvm-project/commit/4d700ffe67be03220487604785ee2049570ba6db.diff

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5777c05d1609: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 95e6a40 - [clang][Interp] Implement IntegralToBoolean casts

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 95e6a407d92bbb1d977351cc6ee39aa990ed50c5 URL: https://github.com/llvm/llvm-project/commit/95e6a407d92bbb1d977351cc6ee39aa990ed50c5 DIFF: https://github.com/llvm/llvm-project/commit/95e6a407d92bbb1d977351cc6ee39aa990ed50c5.diff

[clang] 8e41e6a - [clang][Interp] Implement function calls

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 8e41e6a4eafa2b667ec37ece33a85493fe0156c2 URL: https://github.com/llvm/llvm-project/commit/8e41e6a4eafa2b667ec37ece33a85493fe0156c2 DIFF: https://github.com/llvm/llvm-project/commit/8e41e6a4eafa2b667ec37ece33a85493fe0156c2.diff

[clang] 5777c05 - [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

Author: Timm Bäder Date: 2022-09-08T07:31:07+02:00 New Revision: 5777c05d16098cb690decef95ad6c20c695a5fa9 URL: https://github.com/llvm/llvm-project/commit/5777c05d16098cb690decef95ad6c20c695a5fa9 DIFF: https://github.com/llvm/llvm-project/commit/5777c05d16098cb690decef95ad6c20c695a5fa9.diff

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. > It looks like the only change needed for ppc would be to remove the > `!DirectTy->isStructTy()` check here? (I guess to avoid inadvertently > change other targets, this might need to be triggered by a flag passed as > argument. On the other hand, maybe there is

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added inline comments. Comment at: clang/include/clang/AST/Type.h:5000 + + const TemplateTypeParmDecl *getReplacedParameter() const; + Another question worth raising: is it acceptable churn to change the return of `getReplacedParameter()` from a

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

vitalybuka added a comment. 897.65s: Clangd Unit Tests :: ./ClangdTests/25/72 In D127082#3776206 , @daiyousei-qz wrote: > In D127082#3776173 , @vitalybuka > wrote: > >> Looks like it breaks >>

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1618 + QualType getSubstTemplateTypeParmType(QualType Replacement, +Decl *ReplacedDecl, +unsigned Index) const;

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. In D127082#3776173 , @vitalybuka wrote: > Looks like it breaks > https://lab.llvm.org/buildbot/#/builders/236/builds/206 > https://lab.llvm.org/buildbot/#/builders/237/builds/85 >

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, TypedefTypes and UsingTypes can

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

vitalybuka added a comment. Looks like it breaks https://lab.llvm.org/buildbot/#/builders/236/builds/206 https://lab.llvm.org/buildbot/#/builders/237/builds/85 https://lab.llvm.org/buildbot/#/builders/238/builds/103 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133266: [MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport

MaskRay updated this revision to Diff 458627. MaskRay retitled this revision from "[MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration" to "[MinGW] Reject explicit hidden visibility applied to dllexport and hidden/protected applied to dllimport". MaskRay

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

MaskRay added a comment. In D133266#3776051 , @bd1976llvm wrote: > In D133266#3775832 , @MaskRay wrote: > >> In D133266#3775384 , @MaskRay >> wrote: >> >>> In

[libunwind] 6332a00 - [libunwind] Fix a few libunwind includes

Author: Ryan Prichard Date: 2022-09-07T22:18:09-04:00 New Revision: 6332a00d696d37942f2743851c86f1d4493968f0 URL: https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0 DIFF: https://github.com/llvm/llvm-project/commit/6332a00d696d37942f2743851c86f1d4493968f0.diff

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

mizvekov updated this revision to Diff 458623. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D132816 Files: clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1618 + QualType getSubstTemplateTypeParmType(QualType Replacement, +Decl *ReplacedDecl, +unsigned Index) const;

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 458621. mizvekov marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

shafik added a comment. Maybe I missed it but I don't see a test that covers temp.res p5 e.g.: template void f(int i) { T::x * i; // This will be assumed to be the expression // T::x multiplied by i // Not a

[PATCH] D133405: [Linux] Hack around Linux/sparc

MaskRay added a comment. It's not a compiler's job to define this workaround... If a platform want to provide a built-in macro, you can use https://clang.llvm.org/docs/UsersManual.html#configuration-files and add `-D__NO_INLINE__` there. To avoid magic behaviors, `${triple}-clang` loads

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast(FirstArg)) +FirstArg = CE->getSubExprAsWritten(); rsmith wrote: > This looks very suspicious to me:

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7651-7652 + Expr *FirstArg = TheCall->getArg(0); + if (auto *CE = dyn_cast(FirstArg)) +FirstArg = CE->getSubExprAsWritten(); This looks very suspicious to me: this will remove a

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

bd1976llvm added a comment. In D133266#3775832 , @MaskRay wrote: > In D133266#3775384 , @MaskRay wrote: > >> In D133266#3775189 , @bd1976llvm >> wrote: >> >>> >> >>

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 458613. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov marked 4 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12141 static Decl *getCommonDecl(Decl *X, Decl *Y) { - if (X == Y) -return X; - assert(declaresSameEntity(X, Y)); + if (!declaresSameEntity(X, Y)) +

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

rsmith added a comment. In terms of the high-level direction here, I think it would make sense to approach this by adding a full-fledged language extension to Clang to allow statements at the top level (with a `-f` flag to enable it), and then enable that extension in the interpreter. The

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 458608. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked an inline comment as done. ayzhao added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5100-5101 bool IsConstructor = false; - if (isDeclarationSpecifier()) + if (isDeclarationSpecifier(ITC_Never)) IsConstructor = true; else if

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added a comment. In D111283#3771900 , @erichkeane wrote: > Thanks for your patience, this was a sizable review that it took a while to > be able to make time for. A handful of non-functional reviews, but the > functionality looks fine.

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12139 +return X; + assert(declaresSameEntity(X, Y)); + for (const Decl *DX : X->redecls()) { erichkeane wrote: > As a nit, I'd prefer this

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. In regards to the review, I have checked most cases, and I'm pretty confident this patch should cover all cases (given that `CompilerInvocation` is used directly from clang's `main()`), but if there are any edge cases that somehow pop up due to this patch, it

[clang] bc502d9 - Revert D133266 "[MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration"

Author: Fangrui Song Date: 2022-09-07T16:06:19-07:00 New Revision: bc502d9c24f8fce3b90e3fe8a8a9ca18894e68cb URL: https://github.com/llvm/llvm-project/commit/bc502d9c24f8fce3b90e3fe8a8a9ca18894e68cb DIFF: https://github.com/llvm/llvm-project/commit/bc502d9c24f8fce3b90e3fe8a8a9ca18894e68cb.diff

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:262 + } + default:; + }; mizvekov wrote: > erichkeane wrote: > > The semicolon after default is bizarre/unnecessary. That said, I'd suggest

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

thakis added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB@"

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

MaskRay added a comment. In D133266#3775384 , @MaskRay wrote: > In D133266#3775189 , @bd1976llvm > wrote: > >> This approach doesn't account for the implementation of >> -fvisibility-global-new-delete-hidden.

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458587. mizvekov marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files:

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 458586. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ASTContext.h

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae marked 7 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:59 + +switch (Tok.getKind()) { +case tok::kw_namespace: aaron.ballman wrote: > The approach of using a switch and handling

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 458585. python3kgae marked 14 inline comments as done. python3kgae added a comment. Parse first and report error on the generated AST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

ddcc added a comment. Yup, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132003/new/ https://reviews.llvm.org/D132003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

ddcc updated this revision to Diff 458581. ddcc marked an inline comment as done. ddcc added a comment. Fix typo in __revsh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132003/new/ https://reviews.llvm.org/D132003 Files:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 458580. ayzhao marked 12 inline comments as done. ayzhao added a comment. address code review comments from shafik@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4514 +// Infer data storing path of the options `-ftime-trace`, `-ftime-trace=` +void InferTimeTracePath(Compilation ) { + bool HasTimeTrace = Use `static`. See

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

MaskRay added a comment. I appreciate the detailed summary. It has sufficient information but I think it can be rephased to be conciser. I request changes for the verbosity and the possibly functionality issue. > We can use -ftime-trace or -ftime-trace= to switch on the TimeProfiler. "We can

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked 2 inline comments as done. azat added a comment. > PS4CPU.cpp actually does have a case where we pass "-mllvm > -enable-jmc-instrument" to lld, so you are not breaking new ground here. Great, thanks for pointing out! The patch had been rebased with addressed comments. Repository:

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:4230-4236 +void testDeferredTemporary() { + SelfLockDeferred(); // expected-warning {{releasing mutex '.mu_' that was not held}} +} + +void testDeferredTemporary2() { +

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd. This will allow selecting the MS C runtime library without having to use cc1 flags.

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133457 Files:

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 458573. azat added a comment. Update test and comments in the code (suggestions from @probinson) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files:

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert updated this revision to Diff 458572. aaronpuchert marked 3 inline comments as done. aaronpuchert added a comment. Use `SmallDenseMap` plus some minor changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert marked 3 inline comments as done. aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:935 +// Same as constructors, but without tag types. (Requires C++17 copy elision.) +static MutexLocker Lock(Mutex *mu) ACQUIRE(mu)

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

shafik added a comment. First set of comments. Comment at: clang/include/clang/Parse/Parser.h:2418 +DS, TemplateInfo, AS, DSC, LateAttrs, +(ImplicitTypenameContext)isImplicitTypenameContext(DSC)); + } Why don't we just have

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added a reviewer: probinson. probinson added a comment. > Yeah, but it seems that it is not possible to use lld for PS4 It's correct that PS4 does not use lld. PS5 does use lld (under a different name). But, we don't use addLTOOptions() for either PS4 or PS5, so this patch doesn't

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458559. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe321c8dd2cea: C++/ObjC++: switch to gnu++17 as the default standard (authored by MaskRay). Changed prior to commit:

[clang] e321c8d - C++/ObjC++: switch to gnu++17 as the default standard

Author: Fangrui Song Date: 2022-09-07T14:17:52-07:00 New Revision: e321c8dd2cea8365045ed44ae1c3c00c6a977d2e URL: https://github.com/llvm/llvm-project/commit/e321c8dd2cea8365045ed44ae1c3c00c6a977d2e DIFF: https://github.com/llvm/llvm-project/commit/e321c8dd2cea8365045ed44ae1c3c00c6a977d2e.diff

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay updated this revision to Diff 458556. MaskRay edited the summary of this revision. MaskRay added a comment. revert a clangd change after sammccall's change to make it immune to gnu++14/gnu++17 default change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap()

jansvoboda11 updated this revision to Diff 458555. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127647/new/ https://reviews.llvm.org/D127647 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. In D131465#3774552 , @sammccall wrote: > In D131465#3774276 , @aaron.ballman > wrote: > >> In D131465#3772803 , @MaskRay >> wrote: >> >>>

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

ldionne added a comment. I think I like the spirit of this change, which seems to be to move us closer to `CMAKE_foo` variables and further from `LLVM_foo` variables for equivalent functionality. I have a comment, but this essentially LGTM. The libc++ CI failures (in particular the

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov updated this revision to Diff 458553. Herald added subscribers: mstorsjo, arichardson. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 458552. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index:

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/GlobalConstructors.hlsl:3 + +RWBuffer Buffer; + aaron.ballman wrote: > Can you also add a test using `__attribute__((constructor))`? And probably > one using `__attribute__((destructor))` at some

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. MyDeveloperDay wrote: > yusuke-kadowaki wrote: > > MyDeveloperDay

[PATCH] D133191: Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

probinson closed this revision. probinson added a comment. Closing this for @MaggieYi the commit message didn't cite the Phabricator review. https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a comment. This is related to changes for https://reviews.llvm.org/D86049. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

compnerd added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:3 + get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME) +endif() + Should this perhaps be moved further down near the usage? Comment at:

[PATCH] D132977: [HLSL] Call global constructors inside entry

beanz updated this revision to Diff 458542. beanz added a comment. Adding test coverage for `__attribute__((constructor))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132977/new/ https://reviews.llvm.org/D132977 Files:

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

MaskRay added a comment. In D133266#3775189 , @bd1976llvm wrote: > This approach doesn't account for the implementation of > -fvisibility-global-new-delete-hidden. The following case now fails after > this change: > > >type new_del.cpp > >

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov added a comment. In D133262#3768883 , @royjacobson wrote: > There are some known bugs about how we handle this built-in in the AST- > #42102, #51928, #54993. Is it possible that your patch solves them? It would > be great if it does, I hit

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. yusuke-kadowaki wrote: > MyDeveloperDay wrote: > > Is Don'tAlign the same

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:262 + } + default:; + }; erichkeane wrote: > The semicolon after default is bizarre/unnecessary. That said, I'd suggest > just making the 'default' case be 'return false'. This is

[PATCH] D133262: [clang] Fixes how we represent / emulate builtin templates

mizvekov retitled this revision from "[clang] Represent __make_integer_seq as alias template in the AST" to "[clang] Fixes how we represent / emulate builtin templates". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458541. mizvekov marked 3 inline comments

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov retitled this revision from "NFC: [clang] add template substitution AST test for make_integer_seq" to "NFC: [clang] add template AST test for make_integer_seq and type_pack_element". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 458540.

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. Wouldn't re-applying https://github.com/llvm/llvm-project/commit/fcd549a7d8284a8e7c763fee3da2206acd8cdc4f (which had been reverted IIUC) be a more precise fix for this problem? We'd suppress the warning, but only for classes that we know are OK to use with CTAD. It is

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64GlobalsTagging.cpp:25 + +using namespace llvm; + fmayer wrote: > why don't we put this into the llvm namespace rather than using? common for code in this folder, `INITIALIZE_PASS_BEGIN`

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

hctim updated this revision to Diff 458536. hctim marked 2 inline comments as done. hctim added a comment. Some namespace moving and shaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133392/new/ https://reviews.llvm.org/D133392 Files:

[PATCH] D128372: [Clang-Tidy] Empty Check

MaskRay added a comment. Drive-by comments: this patch may need a review from common reviewers like @njames93. I assume that @LegalizeAdulthood's comment (about the file hierarchy since there was a big reorganization few months ago) has been addressed. If you are concerned with unable to

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4842bb2e98e: [Clang] Introduce -fexperimental-sanitize-metadata= (authored by melver). Changed prior to commit:

[clang] c4842bb - [Clang] Introduce -fexperimental-sanitize-metadata=

Author: Marco Elver Date: 2022-09-07T21:25:40+02:00 New Revision: c4842bb2e98e2f1ee23bb3bc753752816927b7b3 URL: https://github.com/llvm/llvm-project/commit/c4842bb2e98e2f1ee23bb3bc753752816927b7b3 DIFF: https://github.com/llvm/llvm-project/commit/c4842bb2e98e2f1ee23bb3bc753752816927b7b3.diff

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132727/new/ https://reviews.llvm.org/D132727 ___ cfe-commits mailing

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, jrtc27 wrote: > This doesn't really belong here, but a

[PATCH] D133444: [RISCV] Update error message to not call 'RV32' and 'RV64' an extension.

craig.topper created this revision. craig.topper added reviewers: reames, luismarques, asb, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:709 + +let Predicates = [HasStdExtZawrs] in { +def WRS_NTO : RVInstI<0b000, OPC_SYSTEM, (outs), (ins), "wrs.nto", "">, This doesn't really belong here, but a separate

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames created this revision. reames added reviewers: palmer-dabbelt, sunshaoce, craig.topper, kito-cheng, jrtc27, frasercrmck, asb, luismarques. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

bd1976llvm added a comment. This approach doesn't account for the implementation of -fvisibility-global-new-delete-hidden. The following case now fails after this change: > type new_del.cpp namespace std { typedef __typeof__(sizeof(int)) size_t; struct nothrow_t {}; struct align_val_t

[clang] cc14e19 - [RISCV] Remove space before colon in error message.

Author: Craig Topper Date: 2022-09-07T11:34:33-07:00 New Revision: cc14e195e79d0c1eca2190acffbddd53d0898317 URL: https://github.com/llvm/llvm-project/commit/cc14e195e79d0c1eca2190acffbddd53d0898317 DIFF: https://github.com/llvm/llvm-project/commit/cc14e195e79d0c1eca2190acffbddd53d0898317.diff

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:947-949 +Option `--search-config-dirs` changes the search algorith if the included +file is specified without a directory separator. In this case the file is looked +for in the same directories as

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. `CodeGenModule` doesn't get invoked when compiling IR. The error would trip when compiling other languages (eg c), but when passing IR to clang, the function doing error checking would never get called so no error was ever thrown. Repository: rG LLVM Github

[PATCH] D133339: [clangd] Isolate logic for setting LSPServer options

sammccall added a comment. I like the change to initialize() a lot. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:64 + +/// Options used for diagnostics. +ClangdDiagnosticOptions DiagOpts; I don't really like making these options part of this

  1   2   >