[clang] aef03c9 - [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

Author: Kees Cook Date: 2022-10-01T18:45:45-07:00 New Revision: aef03c9b3bed5cef5a1940774b80128aefcb4095 URL: https://github.com/llvm/llvm-project/commit/aef03c9b3bed5cef5a1940774b80128aefcb4095 DIFF: https://github.com/llvm/llvm-project/commit/aef03c9b3bed5cef5a1940774b80128aefcb4095.diff

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

This revision was automatically updated to reflect the committed changes. kees marked an inline comment as done. Closed by commit rGaef03c9b3bed: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will… (authored by kees). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9d0d404 - [clang] Use std::enable_if_t (NFC)

Author: Kazu Hirata Date: 2022-10-01T17:24:54-07:00 New Revision: 9d0d4046c05f230183d31130425b5294b768200b URL: https://github.com/llvm/llvm-project/commit/9d0d4046c05f230183d31130425b5294b768200b DIFF: https://github.com/llvm/llvm-project/commit/9d0d4046c05f230183d31130425b5294b768200b.diff

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added a comment. In D134853#3822842 , @rymiel wrote: > Unless any reviewers have any other opinions, I would leave fixing those out > of this patch and leave the tests "incomplete" for now? +1. > Also, UDLs that don't start with an underscore

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-aranges.c:1 +// REQUIRES: lld + Remove `// REQUIRES: lld` Comment at:

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt planned changes to this revision. RIscRIpt added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4995-4997 + case ParsedAttr::AT_MSConstexpr: +D->addAttr(::new (S.Context) MSConstexprAttr(S.Context, AL)); +return; aaron.ballman

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt updated this revision to Diff 464522. RIscRIpt retitled this revision from "[AST] Add C++11 attribute msvc::constexpr" to "Add C++11 attribute msvc::constexpr". RIscRIpt added a comment. Add more tests, don't alter constexprKind of `[[msvc::constexpr]]` functions - instead change

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny added reviewers: MaskRay, thesamesam. mgorny added subscribers: thesamesam, MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. @MaskRay, @thesamesam, any chance you could reproduce/test this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/

[PATCH] D131310: [llvm-driver] Support single distributions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0df701b0d9: [llvm-driver] Support single distributions (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[clang] 3b0df70 - [llvm-driver] Support single distributions

Author: Alex Brachet Date: 2022-10-01T20:20:28Z New Revision: 3b0df701b0d95612e5da3544e2361808b78a6015 URL: https://github.com/llvm/llvm-project/commit/3b0df701b0d95612e5da3544e2361808b78a6015 DIFF: https://github.com/llvm/llvm-project/commit/3b0df701b0d95612e5da3544e2361808b78a6015.diff LOG:

[clang] aa1c58b - [llvm-driver][NFC] Simplify handling of tool symlinks

Author: Alex Brachet Date: 2022-10-01T20:18:49Z New Revision: aa1c58b9c67a30228a59df18e004d0c6e2c02d3e URL: https://github.com/llvm/llvm-project/commit/aa1c58b9c67a30228a59df18e004d0c6e2c02d3e DIFF: https://github.com/llvm/llvm-project/commit/aa1c58b9c67a30228a59df18e004d0c6e2c02d3e.diff LOG:

[PATCH] D134979: [llvm-driver][NFC] Simplify handling of tool symlinks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1c58b9c67a: [llvm-driver][NFC] Simplify handling of tool symlinks (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny created this revision. mgorny added reviewers: eugenis, vitalybuka, rovka. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Update sem_init_glibc.cpp to apply the "newer" GET_SEM_VALUE(v) logic to i386 if glibc is 2.36 or

[clang] d7804e1 - [Clang] Move ParsedTargetAttr to TargetInfo.h

Author: David Green Date: 2022-10-01T18:26:42+01:00 New Revision: d7804e187a8fc90bde2c12e373aff85a1148b5e7 URL: https://github.com/llvm/llvm-project/commit/d7804e187a8fc90bde2c12e373aff85a1148b5e7 DIFF: https://github.com/llvm/llvm-project/commit/d7804e187a8fc90bde2c12e373aff85a1148b5e7.diff

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

JohelEGP added a comment. I can confirm that, with this patch, Clang successfully compiles my actual code base. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134874/new/ https://reviews.llvm.org/D134874 ___ cfe-commits mailing list

[clang] 6dc5f3e - Foward declare ParsedTargetAttr as a struct.

Author: David Green Date: 2022-10-01T16:14:00+01:00 New Revision: 6dc5f3ec89748f2aa7cface6698bdcd27c8b329e URL: https://github.com/llvm/llvm-project/commit/6dc5f3ec89748f2aa7cface6698bdcd27c8b329e DIFF: https://github.com/llvm/llvm-project/commit/6dc5f3ec89748f2aa7cface6698bdcd27c8b329e.diff

[PATCH] D134589: [C++20][Modules] Elide unused guard variables in Itanium ABI module initializers.

iains updated this revision to Diff 464502. iains edited the summary of this revision. iains added a comment. rebased and updated to elide the guard only for the case of no inits _and_ no imports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133848: [Clang][AArch64] Support AArch64 target(..) attribute formats.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG781b491bba9d: [Clang][AArch64] Support AArch64 target(..) attribute formats. (authored by dmgreen). Herald added a project: clang. Herald added a

[clang] 781b491 - [Clang][AArch64] Support AArch64 target(..) attribute formats.

Author: David Green Date: 2022-10-01T15:40:59+01:00 New Revision: 781b491bba9d798e53f7784dced3c2be77c81dd4 URL: https://github.com/llvm/llvm-project/commit/781b491bba9d798e53f7784dced3c2be77c81dd4 DIFF: https://github.com/llvm/llvm-project/commit/781b491bba9d798e53f7784dced3c2be77c81dd4.diff

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; jcranmer-intel wrote: > aaron.ballman

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/AST/Expr.cpp:225 + + } else if (!Context.getAsIncompleteArrayType(getType())) +return false; tschuett wrote: > Could this be an early exit? I

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille updated this revision to Diff 464494. serge-sans-paille added a comment. Add an early exit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/ https://reviews.llvm.org/D134791 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

davrec added a subscriber: rjmccall. davrec added a comment. First thank you for having separated out the public AST changes into other patches, it makes these mostly-Sema changes much easier to review. I don't see any major issues with the code, though this would benefit from a close look

[PATCH] D134384: [clangd] Add support for HeaderInsertion in .clangd config file

qchateau updated this revision to Diff 464492. qchateau added a comment. - clangd: rename HeaderInsertion and IncludeInsertion, read value from Config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134384/new/ https://reviews.llvm.org/D134384

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

tahonermann marked 5 inline comments as done. tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1159 +Expr *UninstExpr = PVD->getUninstantiatedDefaultArg(); +// FIXME: Obtain the source location for the '=' token. +

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

tahonermann updated this revision to Diff 464489. tahonermann added a comment. Rebased and removed redundant asserts pointed out in code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133500/new/ https://reviews.llvm.org/D133500 Files:

[PATCH] D133499: [clang]: Add DeclContext::dumpAsDecl().

tahonermann marked an inline comment as done. tahonermann added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:203 +LLVM_DUMP_METHOD void DeclContext::dumpDecl() const { + if (const Decl *D = dyn_cast(this)) shafik wrote: > Interesting `

[PATCH] D133499: [clang]: Add DeclContext::dumpAsDecl().

tahonermann updated this revision to Diff 464488. tahonermann marked 9 inline comments as done. tahonermann added a comment. Addressed a suggested edit I originally failed to notice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133499/new/

[PATCH] D133499: [clang]: Add DeclContext::dumpAsDecl().

tahonermann updated this revision to Diff 464487. tahonermann retitled this revision from "[clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext." to "[clang]: Add DeclContext::dumpAsDecl().". tahonermann edited the summary of this revision. tahonermann

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

tschuett added inline comments. Comment at: clang/lib/AST/Expr.cpp:225 + + } else if (!Context.getAsIncompleteArrayType(getType())) +return false; Could this be an early exit? Comment at: clang/lib/AST/Expr.cpp:267 + +if

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 464486. azat added a comment. Rerun CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

serge-sans-paille updated this revision to Diff 464485. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Add test case for ObjC interface with FAM, as hinted by @msebor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134791/new/

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unfortunately, I have //no idea// how to test

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

tbaeder updated this revision to Diff 464478. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135012/new/ https://reviews.llvm.org/D135012 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees marked an inline comment as done. kees added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3464-3465 + D.Diag(diag::warn_ignored_clang_option) + << "-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-" +

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees updated this revision to Diff 464476. kees added a comment. Update optional removal target release to Clang 18 2 releases was the suggested time to wait between deprecation and removal for this option. As this change was originally written during the Clang 15 development window, and we're

[PATCH] D125142: [clang][auto-init] Deprecate -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

kees updated this revision to Diff 464474. kees added a comment. use Group Instead of a custom warning, use the clang_ignored_legacy_options_Group, as MaskRay suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/