[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay updated this revision to Diff 464581. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer: ctetreau. https://wiki.debian.org/ReproducibleBuilds/TimestampsFromCPPMacros says > We missed out __TIMESTAMP__ by mistake, but we will probably send in

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

thakis added a comment. Or, alternatively, maybe Recognizer could stay in clangd (or move to a separate lib); looks like that's the only thing in StandardLibrary.h that needs `clang/AST/Decl.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

thakis added a comment. Herald added a project: All. This makes clang-format depend on clang's AST library, which it shouldn't. Could this move into a dedicated library, or in some library that Format doesn't depend on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay created this revision. MaskRay added reviewers: clang-language-wg, aaron.ballman, appcs, efriedma, emaste. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D135026: [clang-format] Handle C# interpolated verbatim string prefix @$

owenpan added inline comments. Comment at: clang/lib/Format/.clang-format:2 BasedOnStyle: LLVM -InsertBraces: true +#InsertBraces: true RemoveBracesLLVM: true Commented out by mistake. Will undo it when landing. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

owenpan added a comment. In D134853#3829433 , @rymiel wrote: > So, after some investigation, it turns out the clang lexer only combines an > underscore-less UDL to a single `string_literal` token if it's a valid > standard library UDL (in the given

[PATCH] D135027: [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135027/new/ https://reviews.llvm.org/D135027 ___

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

MyDeveloperDay added a comment. I'm not actually really considering the new "keywords" much at the moment (less match), some of this is really about formatting the Carbon fundamentals (SpaceBetween etc..) to a Google style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134652/new/

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. > TODO: I think, I'll need to read more about constexpr for functions in > standard (and LLVM code), to add relevant restrictions here. In the standard I was able to find the following paragraphs about `constexpr`: 1. Neither constructor nor destructor can be

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 464549. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/records.cpp Index:

[PATCH] D135027: [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled

alvinhochun created this revision. alvinhochun added reviewers: rnk, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/49958 Repository:

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked an inline comment as done. azat added a comment. > Optional: End full sentences with a period. Some directories use the > convention that non-RUN-non-CHECK lines use /// as the comment marker. The > idea is to make comments stand out and foster possible future lit/FileCheck >

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 464542. azat marked an inline comment as done. azat added a comment. Update comment in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files:

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added a comment. > The operator `""` and the identifier that follows should be two separate > tokens regardless if the identifier starts with an underscore. So, after some investigation, it turns out the clang lexer only combines an underscore-less UDL to a single `string_literal` token

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

rymiel added a comment. I think the above is especially relevant as Carbon may yet change everything about its syntax; for example, in this patch, `me` has been made a keyword, but that may change in the future: https://github.com/carbon-language/carbon-lang/pull/1382 CHANGES SINCE LAST

[PATCH] D135026: [clang-format] Handle C# interpolated verbatim string prefix @$

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

owenpan added a comment. I'm not against extending clang-format to support yet another language like Carbon, but we should probably wait until it has gained widespread usage? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134652/new/ https://reviews.llvm.org/D134652

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this is pretty simple since we get the

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D135023 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/ https://reviews.llvm.org/D135018 ___ cfe-commits mailing