[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:590 +// FIXME: may be incomplete +static unsigned CalculateTemplateDepthForConstraints(const Expr *Constr) { erichkeane wrote: > I'd like some sort of assert in the case where you don't

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

bruno added a comment. Thanks for working on this Troy, nice speed up. A bit more context for reviewers: we're probably unique on how we use hmaps, we have tons of them in a single compiler invocation. The other users of hmaps I've seen don't use more than a handful. This means that general

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rGebe9c7f3e2da: [HLSL] CodeGen hlsl cbuffer/tbuffer. (authored by python3kgae). Repository: rG LLVM

[PATCH] D135849: [clang][deps][lex] Avoid canonicalization of remapped framework directories (take 2)

jansvoboda11 created this revision. jansvoboda11 added a reviewer: bnbarham. Herald added subscribers: ributzka, hiraditya. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. An

[clang] ebe9c7f - [HLSL] CodeGen hlsl cbuffer/tbuffer.

Author: Xiang Li Date: 2022-10-12T21:17:38-07:00 New Revision: ebe9c7f3e2da779b984b336dadf37cc4ec2ae260 URL: https://github.com/llvm/llvm-project/commit/ebe9c7f3e2da779b984b336dadf37cc4ec2ae260 DIFF: https://github.com/llvm/llvm-project/commit/ebe9c7f3e2da779b984b336dadf37cc4ec2ae260.diff

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

dblaikie added a comment. In D135488#3854624 , @nickdesaulniers wrote: > Playing around with `llvm-dwarfdump` today, I think I found an interesting > example: > > Consider the following DWARF DIE: > > 0x00017e5e: DW_TAG_variable >

[clang] e231a58 - [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

Author: Kai Luo Date: 2022-10-13T12:03:55+08:00 New Revision: e231a580139a50aff639296c4b95a65e7d89cf1e URL: https://github.com/llvm/llvm-project/commit/e231a580139a50aff639296c4b95a65e7d89cf1e DIFF: https://github.com/llvm/llvm-project/commit/e231a580139a50aff639296c4b95a65e7d89cf1e.diff LOG:

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe231a580139a: [clang][Module][AIX] Mark test unsupported since objc doesnt have xcoff support (authored by lkail). Repository: rG LLVM Github

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Confirming LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135848/new/ https://reviews.llvm.org/D135848 ___

[PATCH] D135384: [AIX] Enable the use of the -pg flag

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comment; thanks! Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:39 +Triple

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail added inline comments. Comment at: clang/test/Modules/module-file-home-is-cwd.m:1 +// UNSUPPORTED: aix // RUN: cd %S hubert.reinterpretcast wrote: > We see GOFF in the same list. Nice one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail updated this revision to Diff 467356. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135848/new/ https://reviews.llvm.org/D135848 Files: clang/test/Modules/module-file-home-is-cwd.m Index: clang/test/Modules/module-file-home-is-cwd.m

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with comment (matches similar files already present in the directory). Comment at: clang/test/Modules/module-file-home-is-cwd.m:1 +//

[PATCH] D135848: [clang][Module][AIX] Mark test unsupported since objc doesn't have xcoff support

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, daltenty, stevewan. Herald added a subscriber: sunfish. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Fixed error

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 467351. francii added a comment. "Added check for __mcount on aix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:706 + std::tie(OldConstr, NewConstr) = + AdjustConstraintDepth::UnifyConstraintDepthFromDecl(*this, Old, OldConstr, + New, NewConstr);

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

hubert.reinterpretcast added a comment. > I reached out to the GCC author to confirm that the committee acknowledges > that there should be a change to temp.func.order p6.2.1, but no consensus on > what changes to make [3]. A more accurate description is that some changes elsewhere to overload

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:540 -- Add `RemoveSemicolon` option for removing `;` after a non-empty function definition. +- Add ``RemoveSemicolon`` option for removing ``;`` after a non-empty function definition. +- Add

[clang] 082593f - [HIP] Detect HIP for Debian/Fedora

Author: Yaxun (Sam) Liu Date: 2022-10-12T22:59:16-04:00 New Revision: 082593ff7aff68060bd66dccfa43493d07d9c255 URL: https://github.com/llvm/llvm-project/commit/082593ff7aff68060bd66dccfa43493d07d9c255 DIFF:

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

This revision was automatically updated to reflect the committed changes. Closed by commit rG082593ff7aff: [HIP] Detect HIP for Debian/Fedora (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

nickdesaulniers added a comment. Playing around with `llvm-dwarfdump` today, I think I found an interesting example: Consider the following DWARF DIE: 0x00017e5e: DW_TAG_variable DW_AT_location (0x2144:

[clang] be5c656 - [clang] Use std::underlying_type_t (NFC)

Author: Kazu Hirata Date: 2022-10-12T19:20:38-07:00 New Revision: be5c65635123b799a2e0bcf77b3b1c68a13bb742 URL: https://github.com/llvm/llvm-project/commit/be5c65635123b799a2e0bcf77b3b1c68a13bb742 DIFF: https://github.com/llvm/llvm-project/commit/be5c65635123b799a2e0bcf77b3b1c68a13bb742.diff

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:95 llvm::ConstantInt::get(SizeTy, 0)}; -auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str()); +auto ConstStr = CGM.GetAddrOfConstantCString(Str,

[PATCH] D135416: [clang][deps] Respect VFS overlays in canonical preprocessing mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG888daa9e83bc: [clang][deps] Respect VFS overlays in canonical preprocessing mode (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135414: [clang][deps] Don't share in-memory VFS across scans

This revision was automatically updated to reflect the committed changes. Closed by commit rG986725966268: [clang][deps] Dont share in-memory VFS across scans (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135414/new/

[clang] 888daa9 - [clang][deps] Respect VFS overlays in canonical preprocessing mode

Author: Jan Svoboda Date: 2022-10-12T18:40:34-07:00 New Revision: 888daa9e83bceb6cb8fda02f5f3719391f717154 URL: https://github.com/llvm/llvm-project/commit/888daa9e83bceb6cb8fda02f5f3719391f717154 DIFF: https://github.com/llvm/llvm-project/commit/888daa9e83bceb6cb8fda02f5f3719391f717154.diff

[clang] 9867259 - [clang][deps] Don't share in-memory VFS across scans

Author: Jan Svoboda Date: 2022-10-12T18:40:34-07:00 New Revision: 98672596626862e4b21319da7c01737bf7e20ae4 URL: https://github.com/llvm/llvm-project/commit/98672596626862e4b21319da7c01737bf7e20ae4 DIFF: https://github.com/llvm/llvm-project/commit/98672596626862e4b21319da7c01737bf7e20ae4.diff

[PATCH] D135841: [clang][deps][lex] Avoid canonicalization of remapped framework directories

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In D134923

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

efriedma accepted this revision. efriedma added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:112 +// Replace. +GV->replaceAllUsesWith(GEP); +// Erase GV. python3kgae wrote: >

[PATCH] D135414: [clang][deps] Don't share in-memory VFS across scans

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135414/new/ https://reviews.llvm.org/D135414

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:131 case Decl::RequiresExprBody: + case Decl::HLSLBuffer: // None of these decls require codegen support. efriedma wrote: > I'm a

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 467318. python3kgae marked an inline comment as done. python3kgae added a comment. Go llvm_unreachable is hit HLSLBuffer inside function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: shchenz, kbarton. Herald added a project: All. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation specifies that the

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic closed this revision. jpenix-quic added a comment. 0ec3ac9b7fbd Gah, I goofed and forgot to add the "Differential Revision" line--this has been committed at 0ec3ac9b7fbd15698af7289e1214e8ff3d82ec14

[PATCH] D135142: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135142/new/ https://reviews.llvm.org/D135142 ___ cfe-commits mailing list

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @LegalizeAdulthood @njames93 is there anything actionable that's left for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

tra created this revision. Herald added a subscriber: bixia. Herald added a project: All. tra retitled this revision from "Do not append terminating NUL to the binary string with embedded fatbin." to "Do not append terminating NUL to the string with embedded GPU binary.". tra added a reviewer:

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

efriedma added a comment. Any suggestions for what the error message should look like, if you aren't satisfied with the current messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134928/new/ https://reviews.llvm.org/D134928

[PATCH] D135421: Driver: Change default Android linker to lld.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135421/new/ https://reviews.llvm.org/D135421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

sammccall added a comment. FYI I've sent D135829 to block this check from running in clangd, after tracking it down as the cause of a >10x regression in reparse times in a project that inadvertently enabled it (`misc-*`). Looking at the implementation, this

[clang] 0ec3ac9 - [Flang] Add -fconvert option to swap endianness for unformatted files.

Author: Jonathon Penix Date: 2022-10-12T16:57:37-07:00 New Revision: 0ec3ac9b7fbd15698af7289e1214e8ff3d82ec14 URL: https://github.com/llvm/llvm-project/commit/0ec3ac9b7fbd15698af7289e1214e8ff3d82ec14 DIFF:

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

kees added a comment. In D135727#3853896 , @void wrote: > @kees @serge-sans-paille: It appears to me that a terminating array of size > > 2 *isn't* treated as a FAM in Clang, at least Clang warns about it. The first > failure above

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:131 case Decl::RequiresExprBody: + case Decl::HLSLBuffer: // None of these decls require codegen support. I'm a little confused by this. If it's possible to declare an HLSLBuffer

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135829: [clangd] Block clang-tidy misc-const-correctness check

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This

[PATCH] D135060: [HLSL] Add groupshare address space.

beanz added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:11 +// expected-warning@+1 {{'auto' type specifier is a C++11 extension}} +auto l = []() groupshared {}; + What happens to this if you set the language standard to hlsl 202x? I

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

rjmccall added a comment. I don't remember the history of the `-fcxx-abi` flag at all, so if that's a driver flag, you'll probably need to investigate it more to remove it. Maybe it was added for testing purposes and only made a driver flag accidentally. Repository: rG LLVM Github Monorepo

[clang] 2498964 - [clang][test] NFC, check in darwin-ld-platform-version-macos-requires-darwin.c should be more permissive

Author: Alex Lorenz Date: 2022-10-12T15:57:27-07:00 New Revision: 24989646a5216cc6f8c6d336a17e7cb2f5c60454 URL: https://github.com/llvm/llvm-project/commit/24989646a5216cc6f8c6d336a17e7cb2f5c60454 DIFF: https://github.com/llvm/llvm-project/commit/24989646a5216cc6f8c6d336a17e7cb2f5c60454.diff

[PATCH] D135822: [clang-tidy] Add option `IgnoreVoidReturnType` to `modernize-use-trailing-return-type`

Izaron added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:398-400 + auto F = functionDecl(unless(anyOf(hasTrailingReturn(), cxxConstructorDecl(), + cxxDestructorDecl(),

[PATCH] D135822: [clang-tidy] Add option `IgnoreVoidReturnType` to `modernize-use-trailing-return-type`

Izaron created this revision. Izaron added reviewers: salman-javed-nz, aaron.ballman, bernhardmgruber, bkramer, kbobyrev. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/SemaHLSL/group_shared.hlsl:57 + // expected-error@+1 {{no matching function for call to 'tfoo'}} + GSF gs2 = tfoo(gs); aaron.ballman wrote: > Some other Sema

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1555 + on the indirect branch may result in undefined behavior and should be + avoided. shafik wrote: > It would be helpful to provide an example of what is not supported. If you >

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 467285. python3kgae marked 2 inline comments as done. python3kgae added a comment. Add SubjectList<[Var]> and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

void updated this revision to Diff 467284. void added a comment. Update with example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135818/new/ https://reviews.llvm.org/D135818 Files: clang/docs/LanguageExtensions.rst Index:

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb updated this revision to Diff 467283. cjdb added a comment. undoes an unnessecary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135820/new/ https://reviews.llvm.org/D135820 Files: clang/include/clang/Basic/Diagnostic.td

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

yaxunl updated this revision to Diff 467282. yaxunl marked an inline comment as done. yaxunl added a comment. only check /usr and/usr/local for debian and redhat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135796/new/ https://reviews.llvm.org/D135796 Files:

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309 + ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local", + /*StrictChecking=*/true); tra wrote: > yaxunl

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ba360d499f6: [CMake] Fix FindGRPC cmake module to allow different layering (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

shafik added a comment. Thank you for updating the documents! Comment at: clang/docs/LanguageExtensions.rst:1555 + on the indirect branch may result in undefined behavior and should be + avoided. It would be helpful to provide an example of what is not

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. It would be ideal to be able to properly handle nested types like this, but for right now this is causing a crash in Swift-DocC, so this patch will at least get that

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

shafik added a comment. LGTM, looks mostly straight forward but I am not super familiar with this code so I will let Aaron also review it too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135816/new/ https://reviews.llvm.org/D135816

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a subscriber: arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The [Improving Clang's Diagnostics

[PATCH] D135060: [HLSL] Add groupshare address space.

beanz added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4063 + let Spellings = [Keyword<"groupshared">]; + let Documentation = [HLSLGroupSharedAddressSpaceDocs]; +} Shouldn't this have `let Subjects = SubjectList<[Var]>;`? I don't think we

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

void created this revision. void added a reviewer: nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135818 Files:

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

li.zhe.hua created this revision. li.zhe.hua added a reviewer: aaron.ballman. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `constexpr` support for: - The `getFromNodeKind` factory function -

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

This revision was automatically updated to reflect the committed changes. Closed by commit rG19a0a5674911: [HLSL] Add utility to convert environment to stage (authored by beanz). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang] 19a0a56 - [HLSL] Add utility to convert environment to stage

Author: Chris Bieneman Date: 2022-10-12T16:31:30-05:00 New Revision: 19a0a56749110dc92b39f583e46779ff23aceeba URL: https://github.com/llvm/llvm-project/commit/19a0a56749110dc92b39f583e46779ff23aceeba DIFF:

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

thesamesam added a comment. In D129755#3853809 , @aaronpuchert wrote: > @aaron.ballman, would like some feedback on the release notes. Should I > additionally write something under "Potentially Breaking Changes", or is it > enough to mention this

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void marked 2 inline comments as done. void added a comment. @kees @serge-sans-paille: It appears to me that a terminating array of size > 2 *isn't* treated as a FAM in Clang, at least Clang warns about it. The first failure above (`clang/test/Sema/array-bounds-ptr-arith.c`) shows that. It

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3853045 , @tarunprabhu wrote: > The tests still passed. No, it wasn't run. We need to understand why before proceeding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

awarzynski accepted this revision. awarzynski added a comment. The driver looks good, thanks for all the effort! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

beanz added inline comments. Comment at: clang/include/clang/Basic/HLSLRuntime.h:39 + return static_cast(Pipeline); +} + bogner wrote: > You're not actually introducing the dependency here (it was already there), > but neither `ShaderStage` in LangOptions.h

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. @aaron.ballman, would like some feedback on the release notes. Should I additionally write something under "Potentially Breaking Changes", or is it enough to mention this under "Improvements to Clang's diagnostics"? Though I guess we could also add this later on

[clang] 12c6a41 - [HIP] Fix unbundling archive

Author: Yaxun (Sam) Liu Date: 2022-10-12T16:36:03-04:00 New Revision: 12c6a41f5249fa97041754d38cac28877ed49611 URL: https://github.com/llvm/llvm-project/commit/12c6a41f5249fa97041754d38cac28877ed49611 DIFF:

[PATCH] D135724: [HIP] Fix unbundling archive

This revision was automatically updated to reflect the committed changes. Closed by commit rG12c6a41f5249: [HIP] Fix unbundling archive (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135724/new/

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

sammccall accepted this revision. sammccall added a comment. Thanks, LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135712/new/ https://reviews.llvm.org/D135712 ___ cfe-commits mailing list

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1569 + virtual bool areDefaultedSMFStillPOD(const LangOptions&) const; + rnk wrote: > Please add a doc comment for this, with some history about how previously > explicitly

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

shafik added a comment. In D135551#3853365 , @rnk wrote: > I think the status quo has real problems. We pretend that we can do both of > these: > > - Assert liberally, with the understanding that assertion failures lead to UB > (failed bad cast check,

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu updated this revision to Diff 467247. steven_wu added a comment. Turn generate_proto_sources back to function and forward argument more elegantly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135712/new/

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu added inline comments. Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName ProtoFile) +macro(generate_protos_source GeneratedSource ProtoFile)

[PATCH] D135763: [analyzer] Workaround crash on encountering Class non-type template parameters

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. This change look good to me. I am not entirely sure about the future plans though. We should be able to read the values out from the AST, so we do not need the store to map memregions

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

sammccall added inline comments. Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName ProtoFile) +macro(generate_protos_source GeneratedSource ProtoFile)

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu updated this revision to Diff 467243. steven_wu added a comment. Minor rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135712/new/ https://reviews.llvm.org/D135712 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

This revision was automatically updated to reflect the committed changes. Closed by commit rGec94f372d1c1: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker (authored by Qiongsi Wu qiongs...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ec94f37 - [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

Author: Qiongsi Wu Date: 2022-10-12T15:57:46-04:00 New Revision: ec94f372d1c13b40029519a50184258d4de24a13 URL: https://github.com/llvm/llvm-project/commit/ec94f372d1c13b40029519a50184258d4de24a13 DIFF: https://github.com/llvm/llvm-project/commit/ec94f372d1c13b40029519a50184258d4de24a13.diff

[libunwind] a353909 - Revert "[runtimes] Always define cxx_shared, cxx_static & other targets"

Author: Haowei Wu Date: 2022-10-12T12:54:48-07:00 New Revision: a3539090884c9159893c0b2b4c1dc34f23510707 URL: https://github.com/llvm/llvm-project/commit/a3539090884c9159893c0b2b4c1dc34f23510707 DIFF: https://github.com/llvm/llvm-project/commit/a3539090884c9159893c0b2b4c1dc34f23510707.diff

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. In D135740#3851405 , @sstwcw wrote: > Should I add a test with comments to be aligned like in the bug report? I > was not sure because I didn't find an existing test for alignment of comments. Yes you should.

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu added inline comments. Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName ProtoFile) +macro(generate_protos_source GeneratedSource ProtoFile)

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1189-1194 +// User defined literal without a space +if

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:540 -- Add `RemoveSemicolon` option for removing `;` after a non-empty function definition. +- Add ``RemoveSemicolon`` option for removing ``;`` after a non-empty function

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thanks! Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Even without the tooling aspect the addition of the static asserts is a strict improvement. looks good, thanks! Comment at: clang/include/clang/Basic/HLSLRuntime.h:39 +

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:950-952 + if (RestoredLineLength >= Style.ColumnLimit && Style.ColumnLimit != 0) { +break; + } Elide the braces. Comment at:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. In D134529#3853086 , @BertalanD wrote: > Does it deserve a mention in the Potentially Breaking Changes section of the > release notes? You are right. I was thinking the same after this discussion. I will add this to the

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

arsenm added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:598 } else { -assert(false && "Unhandled type in array initializer initlist"); +llvm_unreachable("Unhandled type in array initializer initlist"); }

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d72f445f799: [Clang] Do not crash when an invalid offload architecture is set (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8d72f44 - [Clang] Do not crash when an invalid offload architecture is set

Author: Joseph Huber Date: 2022-10-12T14:07:52-05:00 New Revision: 8d72f445f79992fd860a73ca4ebd78c1bcc6324b URL: https://github.com/llvm/llvm-project/commit/8d72f445f79992fd860a73ca4ebd78c1bcc6324b DIFF: https://github.com/llvm/llvm-project/commit/8d72f445f79992fd860a73ca4ebd78c1bcc6324b.diff

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler accepted this revision. klausler added a comment. The runtime parts look good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth added a comment. The premerge check is failing, because it can't apply the patch. Often this just means you need to rebase, so can you try rebasing your change and reuploading? Also, do you have commit access? you've made enough changes that its appropriate to request, which should

  1   2   >