[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e6b071509d6: Fix clang version check in SARIF diagnostics test (authored by yabinc, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

aaron.ballman added a comment. In D135896#3856506 , @yabinc wrote: > Thanks @aaron.ballman. I don’t have commit access, can you land this patch > for me? Please use “Yabin Cui yab...@google.com” to commit the change. Happy to do so, thank you for the

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:6490-6491 // C++11 [temp.arg.nontype]p1: // - an address constant expression of type std::nullptr_t if (Arg->getType()->isNullPtrType()) It's worth noting that the

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai updated this revision to Diff 467564. vsapsai added a comment. - Small fixes to address review comments. - Try to make diagnostics more understandable. - Check attributes on typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > royjacobson

[clang] 8c7b346 - [clang] Update ASM goto documentation to reflect how Clang differs from GCC

Author: Bill Wendling Date: 2022-10-13T12:05:40-07:00 New Revision: 8c7b3461a5346a66088d884500c2b3c2829b4652 URL: https://github.com/llvm/llvm-project/commit/8c7b3461a5346a66088d884500c2b3c2829b4652 DIFF: https://github.com/llvm/llvm-project/commit/8c7b3461a5346a66088d884500c2b3c2829b4652.diff

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

This revision was automatically updated to reflect the committed changes. void marked an inline comment as done. Closed by commit rG8c7b3461a534: [clang] Update ASM goto documentation to reflect how Clang differs from GCC (authored by void). Changed prior to commit:

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

void marked 2 inline comments as done. void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1553 + implementation`_ in + that Clang doesn't support outputs on the indirect branch. Use of an output + on

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

shafik added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1555 + on the indirect branch may result in undefined behavior and should be + avoided. void wrote: > shafik wrote: > > It would be helpful to provide an example of what is not

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

yabinc added a comment. Thanks @aaron.ballman. I don’t have commit access, can you land this patch for me? Please use “Yabin Cui yab...@google.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135896/new/

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration royjacobson wrote: > aaron.ballman

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen abandoned this revision. ychen added a comment. Per further discussions in D128745 , this is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134507/new/ https://reviews.llvm.org/D134507

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle updated this revision to Diff 467550. nhaehnle added a comment. - use the object library version of clangSupport if available Thank you for the pointers. Using this object library makes a lot of sense to me and it does appear to work. Judging by AddClang.cmake though, the object library

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:108 - S.Current = - new InterpFrame(S, const_cast(Func), S.Current, {}, {}); + S.Current = new

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135896/new/ https://reviews.llvm.org/D135896 ___ cfe-commits mailing list

[PATCH] D135025: [clang][Interp] Support base class constructors

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:258 + /// or nullptr if no such decl exists. + const CXXRecordDecl * getRecordDecl(const Expr *E) const { +QualType T = E->getType(); Comment at:

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

reames added a comment. Herald added subscribers: sunshaoce, StephenFan, arichardson. Herald added a project: All. Not knowing about this patch, I posted D135894 which addresses a small sub-set of this. If that goes in, I plan to iterative split off some

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

reames added a comment. In D135894#3856229 , @craig.topper wrote: > There's also this patch from @frasercrmck https://reviews.llvm.org/D107290 So there is; had not seen that. Looking at it, that patch seems to roll several items together. I'd

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

royjacobson added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > aaron.ballman

[PATCH] D135896: [clang] Fix clang version check in SARIF diagnostics test

yabinc created this revision. Herald added a project: All. yabinc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to allow future clang versions and use of LLVM_VERSION_PATCH. Repository: rG LLVM Github Monorepo

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

craig.topper added a comment. There's also this patch from @frasercrmck https://reviews.llvm.org/D107290 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135894/new/ https://reviews.llvm.org/D135894 ___

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54bfd0484615: Thread safety analysis: Support copy-elided production of scoped capabilities… (authored by aaronpuchert). Repository: rG LLVM

[clang] 54bfd04 - Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

Author: Aaron Puchert Date: 2022-10-13T19:36:15+02:00 New Revision: 54bfd04846156dbd5e0a6b88f539c3d4569a455f URL: https://github.com/llvm/llvm-project/commit/54bfd04846156dbd5e0a6b88f539c3d4569a455f DIFF: https://github.com/llvm/llvm-project/commit/54bfd04846156dbd5e0a6b88f539c3d4569a455f.diff

[PATCH] D135818: [clang] Update ASM goto documentation to reflect how Clang differs from GCC

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/LanguageExtensions.rst:1553 + implementation`_ in + that Clang doesn't

[PATCH] D135894: [clang][RISCV] Set vscale_range attribute based on presence of "v" extension

reames created this revision. reames added reviewers: asb, frasercrmck, craig.topper. Herald added subscribers: sunshaoce, VincentWu, ctetreau, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. Here's a reproducer of what's happening in our case. It's using the preprocessor because that's the easiest, but the real problem for us is that the debug info is pointing to the wrong file (and that it's different depending on the symlinkedness of the include). $ cat

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added subscribers: royjacobson, erichkeane. aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1512-1514 +def record_defaulted_copy_constructor_is_deleted(self): +"""Returns True if the cursor refers to a C++ record declaration +that has its default copy constructor

[PATCH] D135892: [clangd] Add missing readonly modifier for const generic parameters

tom-anders added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135892/new/ https://reviews.llvm.org/D135892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] a8124ee - [clangd] Add missing readonly modifier for const generic parameters

Author: Tom Praschan Date: 2022-10-13T21:09:25+02:00 New Revision: a8124eea9df513a5565805b480c227fa88751359 URL: https://github.com/llvm/llvm-project/commit/a8124eea9df513a5565805b480c227fa88751359 DIFF: https://github.com/llvm/llvm-project/commit/a8124eea9df513a5565805b480c227fa88751359.diff

[PATCH] D135892: [clangd] Add missing readonly modifier for const generic parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8124eea9df5: [clangd] Add missing readonly modifier for const generic parameters (authored by tom-anders). Repository: rG LLVM Github Monorepo

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

hans added a comment. Heads up that we're seeing a problem in Chromium that bisects to this change. (http://crbug.com/1373836) In our case what's happening is that the compiler is getting the name of an included file wrong, which ends up in the debug info (and also shows in the preprocessor

[clang] 576283c - [clang] Support `constexpr` for some `ASTNodeKind` member functions

Author: Eric Li Date: 2022-10-13T13:00:48-04:00 New Revision: 576283c3a8ef5078b3ec12fa442c14f3a1b5fea2 URL: https://github.com/llvm/llvm-project/commit/576283c3a8ef5078b3ec12fa442c14f3a1b5fea2 DIFF: https://github.com/llvm/llvm-project/commit/576283c3a8ef5078b3ec12fa442c14f3a1b5fea2.diff LOG:

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. li.zhe.hua marked an inline comment as done. Closed by commit rG576283c3a8ef: [clang] Support `constexpr` for some `ASTNodeKind` member functions (authored by

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467513. ymandel added a comment. Add explicit test for creation of multiple tops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files:

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/include/clang/AST/ASTTypeTraits.h:90-92 bool operator<(const ASTNodeKind ) const { return KindId < Other.KindId; } aaron.ballman wrote: > Any reason for

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

li.zhe.hua updated this revision to Diff 467512. li.zhe.hua added a comment. Appease clang-format, add constexpr to operator<. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135816/new/ https://reviews.llvm.org/D135816 Files:

[PATCH] D135892: [clangd] Add missing readonly modifier for const generic parameters

tom-anders created this revision. tom-anders added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467510. ymandel marked 6 inline comments as done. ymandel added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files:

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131701/new/ https://reviews.llvm.org/D131701

[PATCH] D135816: [clang] Support `constexpr` for some `ASTNodeKind` member functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor question. Comment at: clang/include/clang/AST/ASTTypeTraits.h:90-92 bool operator<(const ASTNodeKind ) const { return KindId <

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj updated this revision to Diff 467496. troyj added a comment. Addressed Bruno's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/new/ https://reviews.llvm.org/D135801 Files: clang/include/clang/Lex/HeaderMap.h

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:255 + /// lets us avoid scanning them all to find a match. + llvm::StringMap SearchDirHeaderMapIndex; + bruno wrote: > Did you end up getting data on the memory footprint of this

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. In D129755#3853904 , @thesamesam wrote: > In D129755#3853809 , @aaronpuchert > wrote: > >> @aaron.ballman, would like some feedback on the release notes. Should I >> additionally

[PATCH] D135885: [clang][LTO][NFC] Adding More Tests for AIX Options

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: MaskRay, w2yehia, daltenty. qiongsiwu1 added a project: clang. Herald added subscribers: ormris, StephenFan, steven_wu, hiraditya, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 467491. francii added a comment. Updated check for Func name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} ChuanqiXu wrote: > aaron.ballman wrote: > >

[PATCH] D134878: Update developer policy on potentially breaking changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8673444598be: Update developer policy on potentially breaking changes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

aaron.ballman added a comment. Please be sure to add `NFC` to the commit message so it's clear why there's no tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135820/new/ https://reviews.llvm.org/D135820

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135820/new/ https://reviews.llvm.org/D135820 ___ cfe-commits mailing list

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

pratlucas added inline comments. Comment at: clang/test/Preprocessor/init-arm.c:404 +// is specified +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi -target-feature +soft-float -target-feature +soft-float-abi < /dev/null | FileCheck -match-full-lines

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

probinson added subscribers: wristow, probinson. probinson added a comment. +wristow who has been tracking this kind of stuff for Sony. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 ___

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

probinson added a comment. dblaikie: > In the same way that an assert says "This condition should never be false" - > I use "should" in the same sense in both unreachable and assert, and I > believe that's the prevailing opinion of LLVM developers/the LLVM style guide. aaronballman: > I

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. Adding clang-vendors because of the potential for disruption from the changes. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed.

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#382 , @erichkeane wrote: > In D126907#3854983 , @cor3ntin > wrote: > >> @erichkeane I was looking at Daisy meta programming shenanigans and found >> this crashes

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:590 +// FIXME: may be incomplete +static unsigned CalculateTemplateDepthForConstraints(const Expr *Constr) { lime wrote: > erichkeane wrote: > > I'd like some sort of assert in the

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 467458. yusuke-kadowaki marked 3 inline comments as done. yusuke-kadowaki added a comment. Added more tests Removed braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm unopposed. I think the justification isn't particularly clear to me and doesn't seem discussed in that RFC that I can tell, but I don't really have a concern here. Give folks a

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3854983 , @cor3ntin wrote: > @erichkeane I was looking at Daisy meta programming shenanigans and found > this crashes https://cute.godbolt.org/z/6fWoEheKc - seems related to your > work, probably? It used to work

[PATCH] D135872: [clang-format] Handle unions like structs and classes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added

[clang] fcce256 - [Clang][LoongArch] Pass "f" and "d" features to cc1 to enable hard float

Author: Weining Lu Date: 2022-10-13T20:00:29+08:00 New Revision: fcce2562c177f0ad2aa03620be8675bef5c631d1 URL: https://github.com/llvm/llvm-project/commit/fcce2562c177f0ad2aa03620be8675bef5c631d1 DIFF: https://github.com/llvm/llvm-project/commit/fcce2562c177f0ad2aa03620be8675bef5c631d1.diff

[PATCH] D135866: [clang-format][NFC] Fix comment grammer in ContinuationIndenter

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, OwenBed, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1304 LLVMStyle.RequiresClausePosition = FormatStyle::RCPS_OwnLine; + LLVMStyle.RequiresExpressionIndentation = FormatStyle::REI_Keyword; LLVMStyle.SeparateDefinitionBlocks =

[PATCH] D135696: [pseudo] Document disambiguation design progress

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13f7f9c0660: [pseudo] Document disambiguation design progress (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135696/new/

[clang-tools-extra] b13f7f9 - [pseudo] Document disambiguation design progress

Author: Sam McCall Date: 2022-10-13T13:05:24+02:00 New Revision: b13f7f9c06604110709a968a2fece4b8d5192708 URL: https://github.com/llvm/llvm-project/commit/b13f7f9c06604110709a968a2fece4b8d5192708 DIFF: https://github.com/llvm/llvm-project/commit/b13f7f9c06604110709a968a2fece4b8d5192708.diff

[PATCH] D135696: [pseudo] Document disambiguation design progress

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the doc looks great, it covers everything we've discussed so far. In D135696#3850044 , @sammccall wrote: > The diagrams are rendered by

[clang] b6da16f - [clang][ExtractAPI] Ignore fully anonymous RecordDecls

Author: Daniel Grumberg Date: 2022-10-13T11:53:53+01:00 New Revision: b6da16ffb9d5a47c16fa377097809c6592132d34 URL: https://github.com/llvm/llvm-project/commit/b6da16ffb9d5a47c16fa377097809c6592132d34 DIFF:

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6da16ffb9d5: [clang][ExtractAPI] Ignore fully anonymous RecordDecls (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135804/new/

[PATCH] D135829: [clangd] Block clang-tidy misc-const-correctness check

This revision was automatically updated to reflect the committed changes. Closed by commit rGe78165f0ba1e: [clangd] Block clang-tidy misc-const-correctness check (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135829/new/

[clang-tools-extra] e78165f - [clangd] Block clang-tidy misc-const-correctness check

Author: Sam McCall Date: 2022-10-13T12:07:31+02:00 New Revision: e78165f0ba1e2fbf72b36a36c8560645b69a168a URL: https://github.com/llvm/llvm-project/commit/e78165f0ba1e2fbf72b36a36c8560645b69a168a DIFF: https://github.com/llvm/llvm-project/commit/e78165f0ba1e2fbf72b36a36c8560645b69a168a.diff

[PATCH] D135857: [clangd] Fix a crash in ExtractFunction tweak.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac10e5b347f: [clangd] Fix a crash in ExtractFunction tweak. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135857/new/

[clang-tools-extra] 7ac10e5 - [clangd] Fix a crash in ExtractFunction tweak.

Author: Haojian Wu Date: 2022-10-13T11:12:28+02:00 New Revision: 7ac10e5b347f3e22ae1dad5937de667e57c472be URL: https://github.com/llvm/llvm-project/commit/7ac10e5b347f3e22ae1dad5937de667e57c472be DIFF: https://github.com/llvm/llvm-project/commit/7ac10e5b347f3e22ae1dad5937de667e57c472be.diff

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. RefTypes are distinct categories for

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder updated this revision to Diff 467399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:479-480 + + llvm::copy_if(D->attrs(), std::back_inserter(HashableAttrs), +[](const Attr *A) { return !A->isImplicit(); }); +} aaron.ballman wrote: > ChuanqiXu wrote: > >

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3854980 , @ChuanqiXu wrote: > In D134267#3852136 , @boris wrote: > >>> For example, my experimental support for P1689 >>> is at: [...]. The

[PATCH] D135857: [clangd] Fix a crash in ExtractFunction tweak.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

cor3ntin added a comment. @erichkeane I was looking at Daisy meta programming shenanigans and found this crashes https://cute.godbolt.org/z/6fWoEheKc - seems related to your work, probably? It used to work in Clang 15. I thought you might want to know! Repository: rG LLVM Github Monorepo

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3852136 , @boris wrote: >> For example, my experimental support for P1689 >> is at: [...]. The implementation looks >> relatively trivial to me. The simplicity is pretty important.

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 467383. python3kgae marked an inline comment as done. python3kgae added a comment. Add hlsl202x test for C++ 11 features like lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/

[clang] c5d950f - [HLSL] Simplify code and fix unused variable warnings. NFC.

Author: Benjamin Kramer Date: 2022-10-13T09:46:32+02:00 New Revision: c5d950f4699ff0d9eee20fa144a2ef5f2deffa7b URL: https://github.com/llvm/llvm-project/commit/c5d950f4699ff0d9eee20fa144a2ef5f2deffa7b DIFF:

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:11 +// expected-warning@+1 {{'auto' type specifier is a C++11 extension}} +auto l = []() groupshared {}; + beanz wrote: > What

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

steakhal added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135136/new/ https://reviews.llvm.org/D135136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488

[clang] b062ee7 - [analyzer] Workaround crash on encountering Class non-type template parameters

Author: Balazs Benics Date: 2022-10-13T08:41:31+02:00 New Revision: b062ee7dc4515b0a42157717105839627d5542bb URL: https://github.com/llvm/llvm-project/commit/b062ee7dc4515b0a42157717105839627d5542bb DIFF: https://github.com/llvm/llvm-project/commit/b062ee7dc4515b0a42157717105839627d5542bb.diff

[PATCH] D135763: [analyzer] Workaround crash on encountering Class non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rGb062ee7dc451: [analyzer] Workaround crash on encountering Class non-type template parameters (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D135763?vs=467087=467366#toc

[PATCH] D135763: [analyzer] Workaround crash on encountering Class non-type template parameters

steakhal added a comment. In D135763#3853746 , @xazax.hun wrote: > This change look good to me. I am not entirely sure about the future plans > though. Me neither. That was just a thought. > We should be able to read the values out from the AST, so we

<    1   2