[clang] c004d75 - [clang][Interp] Disable some RVO tests

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:45:23+02:00 New Revision: c004d7534dcefcfebc3e07a7fa12f5492be80279 URL: https://github.com/llvm/llvm-project/commit/c004d7534dcefcfebc3e07a7fa12f5492be80279 DIFF: https://github.com/llvm/llvm-project/commit/c004d7534dcefcfebc3e07a7fa12f5492be80279.diff

[clang] 2f35705 - [Interp] Silence warning in release builds. NFC.

2022-10-14 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-10-14T10:38:32+02:00 New Revision: 2f357054d705459c534a74781e4dc24debe78fcb URL: https://github.com/llvm/llvm-project/commit/2f357054d705459c534a74781e4dc24debe78fcb DIFF:

[PATCH] D135951: [X86][WIP] SUPPORT RAO-INT

2022-10-14 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to the

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avxneconvert-builtins.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown -target-feature +avx2 -target-feature +avxneconvert \ +// RUN: -target-feature +avx512fp16 -emit-llvm -o - -Wall

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/avxvnniint8-builtins.c:1 +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avxvnniint8 -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D135937: [X86] Support -march=meteorlake

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1424 +def : ProcModel<"meteorlake", SLMModel, ProcessorFeatures.ADLFeatures, +ProcessorFeatures.TRMTuning>; This should be with the alderlake/raptorlake defs below (and use

[PATCH] D135936: [X86] Support -march=raptorlake

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: llvm/lib/Support/Host.cpp:828 + *Subtype = X86::INTEL_COREI7_RAPTORLAKE; + break; // Icelake Xeon: newline to separate the defs Comment at: llvm/lib/Target/X86/X86.td:1423

[PATCH] D134361: [clang][Interp] Fix copy constructors of structs with array members

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33b52836de6e: [clang][Interp] Fix using default copy constructors (authored by tbaeder). Changed prior to commit:

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5f205828e6: [clang][Interp] Implement nested struct initialization (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG0ddd13acc9e9: [clang][Interp] Implement This pointer passing to methods (authored by tbaeder). Changed

[PATCH] D134057: [clang][Interp] Start implementing record types

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG1942a2538b86: [clang][Interp] Start implementing record types (authored by tbaeder). Changed prior to

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1928da1ef73c: [clang][Interp] Dont run functions immediately after compiling them (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D135569?vs=466462=467706#toc Repository: rG

[clang] 33b5283 - [clang][Interp] Fix using default copy constructors

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 33b52836de6e093acea15f24b6ae633f969d194a URL: https://github.com/llvm/llvm-project/commit/33b52836de6e093acea15f24b6ae633f969d194a DIFF: https://github.com/llvm/llvm-project/commit/33b52836de6e093acea15f24b6ae633f969d194a.diff

[clang] cb5f205 - [clang][Interp] Implement nested struct initialization

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: cb5f205828e696fb23cfe3de57af83d151ffad38 URL: https://github.com/llvm/llvm-project/commit/cb5f205828e696fb23cfe3de57af83d151ffad38 DIFF: https://github.com/llvm/llvm-project/commit/cb5f205828e696fb23cfe3de57af83d151ffad38.diff

[clang] 0ddd13a - [clang][Interp] Implement This pointer passing to methods

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 0ddd13acc9e9b820c8f610c9006ef59aef8e5320 URL: https://github.com/llvm/llvm-project/commit/0ddd13acc9e9b820c8f610c9006ef59aef8e5320 DIFF: https://github.com/llvm/llvm-project/commit/0ddd13acc9e9b820c8f610c9006ef59aef8e5320.diff

[clang] 1942a25 - [clang][Interp] Start implementing record types

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 1942a2538b86fe55b9723800db950391cc05402b URL: https://github.com/llvm/llvm-project/commit/1942a2538b86fe55b9723800db950391cc05402b DIFF: https://github.com/llvm/llvm-project/commit/1942a2538b86fe55b9723800db950391cc05402b.diff

[clang] 1928da1 - [clang][Interp] Don't run functions immediately after compiling them

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 1928da1ef73c383ea4daeffb41691882bdb074c2 URL: https://github.com/llvm/llvm-project/commit/1928da1ef73c383ea4daeffb41691882bdb074c2 DIFF: https://github.com/llvm/llvm-project/commit/1928da1ef73c383ea4daeffb41691882bdb074c2.diff

[clang] 773b468 - [clang][Interp][NFC] Add a TODO comment

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:52+02:00 New Revision: 773b468543c8c5f0a226c0757a503cb9a40650a5 URL: https://github.com/llvm/llvm-project/commit/773b468543c8c5f0a226c0757a503cb9a40650a5 DIFF: https://github.com/llvm/llvm-project/commit/773b468543c8c5f0a226c0757a503cb9a40650a5.diff

[clang] 0e93b6b - [clang][Interp][NFC] Add more tests for if expressions

2022-10-14 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-10-14T10:21:53+02:00 New Revision: 0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f URL: https://github.com/llvm/llvm-project/commit/0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f DIFF: https://github.com/llvm/llvm-project/commit/0e93b6bd51a0f002e37e76d6efa8e71dde6d3e5f.diff

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/cmpccxadd-builtins-error.c:2 +// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown \ +// RUN: -target-feature +cmpccxadd -emit-llvm -fsyntax-only -verify + Add 32-bit test coverage

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

2022-10-14 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/avxifma-builtins.c:1 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +avxifma -emit-llvm -o - -Wall -Werror | FileCheck %s + 32-bit test coverage?

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

2022-10-14 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added a comment. Let me backtrack my previous question: I misremembered where AddChild is actually being called in the traversal (ASTNodeTraverser, not TextNodeDumper), so I'll see if adding this to the JSON output is feasible CHANGES SINCE LAST ACTION

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if (BO->getType()->isPointerType()) {

[PATCH] D135025: [clang][Interp] Support base class constructors

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:209 + static_assert(d.getA() == 20); + static_assert(d.getB() == 30); +}; aaron.ballman wrote: > I'd appreciate some more failure test cases,

[PATCH] D135025: [clang][Interp] Support base class constructors

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 467699. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

2022-10-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:33 +/// Indicates the relation between the reference and the target. +enum class RefType { + /// Target is explicit from the reference, e.g. function call. I'm

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

2022-10-14 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added inline comments. Comment at: clang/include/clang/AST/TextNodeDumper.h:337 + void VisitConstantArrayTypeLoc(ConstantArrayTypeLoc TL); + void VisitVariableArrayTypeLoc(VariableArrayTypeLoc TL); + void VisitDependentSizedArrayTypeLoc(DependentSizedArrayTypeLoc TL);

[PATCH] D135518: [clangAST] support TypeLoc in TextNodeDumper

2022-10-14 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj updated this revision to Diff 467698. upsj marked 6 inline comments as done. upsj added a comment. I incorporated the `cast`, `ASTContext` and `StringRef` suggestions. About JSONDumper, I was surprised to see that it doesn't seem to use `AddChild` for the AST hierarchy at all, so I'm not

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-10-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D129443#3857608 , @rymiel wrote: > Changing the default LLVM style would change the output of all the > requires-related test cases in `FormatTest.Concepts`. Should I change these > test cases to use the new indentation or

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Thanks for the reproducer! Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:748 + } else { +assert(false && "default initializer for non-primitive type"); + } shafik wrote: > I guess this covers both arrays and

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 467691. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new/ https://reviews.llvm.org/D135013 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp Index:

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

2022-10-14 Thread John McIver via Phabricator via cfe-commits
jmciver updated this revision to Diff 467690. jmciver edited the summary of this revision. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary) Resolve merge conflicts due to the adoption of the

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

2022-10-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:108 - S.Current = - new InterpFrame(S, const_cast(Func), S.Current, {}, {}); + S.Current = new InterpFrame(S, const_cast(Func), {}); // Result of

<    1   2   3