[PATCH] D136022: [clang] Add time profile for constant evaluation

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15257 + }); + // FIXME: Evaluating initializers for large array and record types can cause what about `Expr::EvaluateASRvalue` and `Expr::isPotentialConstantExpression`? Repository:

[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3861334 , @phosek wrote: > In D132975#3860896 , @Amir wrote: > >> In D132975#3763264 , @phosek wrote: >> >>> This was already on my list

[PATCH] D132434: Add noread_thread_id attribute to intrinsics

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. We prefer https://reviews.llvm.org/D135550 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132434/new/ https://reviews.llvm.org/D132434 ___

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu added a comment. We prefer https://reviews.llvm.org/D135550 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu added a comment. We prefer https://reviews.llvm.org/D135550 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 1104c70 - [C++20] [Coroutines] Add ReleaseNotes about addressing thread identifiaction problems

Author: Chuanqi Xu Date: 2022-10-17T10:46:14+08:00 New Revision: 1104c70f96de7abe90b4ff51870ed046862c79fb URL: https://github.com/llvm/llvm-project/commit/1104c70f96de7abe90b4ff51870ed046862c79fb DIFF: https://github.com/llvm/llvm-project/commit/1104c70f96de7abe90b4ff51870ed046862c79fb.diff

[PATCH] D132975: [CMake] Add clang-bolt target

phosek added a comment. In D132975#3860896 , @Amir wrote: > In D132975#3763264 , @phosek wrote: > >> This was already on my list of build system features I'd like to implement >> and I'm glad someone else is

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468109. pengfei added a comment. Fix lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee703b5cb134: [clang][PowerPC] PPC64 VAArg fix right-alignment for aggregates fit in register (authored by tingwang). Repository: rG LLVM Github

[clang] ee703b5 - [clang][PowerPC] PPC64 VAArg fix right-alignment for aggregates fit in register

Author: Ting Wang Date: 2022-10-16T22:01:47-04:00 New Revision: ee703b5cb134d182c2b589360714feab97f6a1cc URL: https://github.com/llvm/llvm-project/commit/ee703b5cb134d182c2b589360714feab97f6a1cc DIFF: https://github.com/llvm/llvm-project/commit/ee703b5cb134d182c2b589360714feab97f6a1cc.diff

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 added a reviewer: aprantl. eddyz87 added a comment. Hello Adrian, I've noticed that you was tagged as a reviewer in a somewhat related revision: https://reviews.llvm.org/D133060, so decided to tag you here. Could you please take a look? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. eddyz87 updated this revision to Diff 468102. eddyz87 added a comment. eddyz87 published this revision for review. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D135640: fix vectorization analysis msg for runtime checks

milthorpe updated this revision to Diff 468103. milthorpe added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update vectorization analysis msg in clang frontend test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136022: [clang] Add time profile for constant evaluation

jloser added a comment. I like the idea of this — +1 for the direction. I'd like to see some tests through before I approve. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3baadff896ed: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3baadff - [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

Author: Fangrui Song Date: 2022-10-16T13:15:44-07:00 New Revision: 3baadff896eddfa09fcd458d120bac95491992a7 URL: https://github.com/llvm/llvm-project/commit/3baadff896eddfa09fcd458d120bac95491992a7 DIFF: https://github.com/llvm/llvm-project/commit/3baadff896eddfa09fcd458d120bac95491992a7.diff

[PATCH] D136033: [clangd] Add an option to specify a workspece-level config file

sammccall added a comment. I have some concerns about adding an undefined "workspace" concept, and in general extending the config system in a way that's hard to use (because of the need to customize flags per workspace). Maybe best to discuss on the bug?

[clang] d72de36 - [clang] Use llvm::find (NFC)

Author: Kazu Hirata Date: 2022-10-16T12:33:47-07:00 New Revision: d72de36da3bc5b0bd98ea680147cacca57518831 URL: https://github.com/llvm/llvm-project/commit/d72de36da3bc5b0bd98ea680147cacca57518831 DIFF: https://github.com/llvm/llvm-project/commit/d72de36da3bc5b0bd98ea680147cacca57518831.diff

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

tschuett added a comment. We support Apple Clang 9.3, but `std:variant` ships with Apple Clang 10.0. :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135953/new/ https://reviews.llvm.org/D135953 ___

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2138 + /// directories specified by SearchDirs field. + bool findConfigFile(StringRef FileName, std::string ); + I'm sorry if I'm missing something obvious but is there a

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

tschuett added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64 +using SymbolLocation = std::variant; +/// A set of locations that provides the declaration, while indicating if sammccall wrote: > This is an important

[clang] 647e48c - [clang] Use std::clamp (NFC)

Author: Kazu Hirata Date: 2022-10-16T10:11:29-07:00 New Revision: 647e48cf5f6094ad874766c1471410641b1b86bd URL: https://github.com/llvm/llvm-project/commit/647e48cf5f6094ad874766c1471410641b1b86bd DIFF: https://github.com/llvm/llvm-project/commit/647e48cf5f6094ad874766c1471410641b1b86bd.diff

[clang] 4ad4487 - [clang] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2022-10-16T09:19:08-07:00 New Revision: 4ad44872c4e88f78a6d6906c345ad502dd92a455 URL: https://github.com/llvm/llvm-project/commit/4ad44872c4e88f78a6d6906c345ad502dd92a455 DIFF: https://github.com/llvm/llvm-project/commit/4ad44872c4e88f78a6d6906c345ad502dd92a455.diff

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei updated this revision to Diff 468080. pengfei added a comment. Fix lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/ https://reviews.llvm.org/D136040 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136040: [X86] Support PREFETCHI instructions

pengfei created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. For more details about these instructions, please refer to the

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. I think I located the problem. In the line 1014 of the file `SemaTemplateInstantiateDecl.cpp`, the requires clause is not instantiated as the parameters of the template parameter list, and these parameters have been instantiated with a shallower depth. So that's the

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

Izaron updated this revision to Diff 468068. Izaron added a comment. Changed `llvm_unreachable` to just `return false`. I thought it is more secure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136036/new/ https://reviews.llvm.org/D136036 Files:

[clang] dd3d8dd - [OpenMP][OpenMPIRBuilder] Migrate OffloadEntriesInfoManager from clang to OMPIRbuilder

Author: Jan Sjodin Date: 2022-10-16T08:32:40-04:00 New Revision: dd3d8ddb5f65ff73441276d7dec744c81e3bf9ca URL: https://github.com/llvm/llvm-project/commit/dd3d8ddb5f65ff73441276d7dec744c81e3bf9ca DIFF: https://github.com/llvm/llvm-project/commit/dd3d8ddb5f65ff73441276d7dec744c81e3bf9ca.diff

[PATCH] D136036: [Clang] Add __has_builtin_constexpr support

Izaron updated this revision to Diff 468063. Izaron added a comment. Slightly changed the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136036/new/ https://reviews.llvm.org/D136036 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D136036: [Clang] Add __has_builtin_constexpr support

Izaron added a comment. A builtin is considered "constexpr" if it has `E` in its attributes in `Builtins.def`. The list of constexpr builtins is consistent, the code in `ExprConstant.cpp` (where the actual constant evaluation of builtins is being done) guards it. If builtin is not marked with

[PATCH] D136036: [Clang] Add __has_builtin_constexpr support

Izaron created this revision. Izaron added reviewers: rsmith, aaron.ballman, cor3ntin, philnik, yaxunl, tra, cjdb. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `__has_builtin_constexpr` macro can

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:970 + if (!Pointer::hasSameArray(LHS, RHS)) { +// TODO: Diagnose. +return false; This is also not being diagnosed (only rejected) by the current interpreter. But would be nice to

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

tbaeder updated this revision to Diff 468060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Format/TokenAnnotator.cpp:3121 + return 1; +if (Right.is(tok::period)) + return 500; HazardyKnusperkeks wrote: >

[PATCH] D135858: [clang][Interp] Support pointer arithmethic in binary operators

tbaeder updated this revision to Diff 468058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Interp.h

[PATCH] D132975: [CMake] Add clang-bolt target

Amir added a comment. In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two > high level comments about your