[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. Ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.llvm.org/D131915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469112. jz10 added a comment. 1. use SmallVector fixed 2. "5 characters" ran clang-format, please check if that works CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136315: Diff 2

calebzulawski created this revision. Herald added a project: All. calebzulawski requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136315 Files:

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469110. jz10 added a comment. Thanks Johannes 1. use SmallVector fixed 2. "module 5 characters" ran clang-format , please check it that works CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files:

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. I grepped `options.td` and got (incomplete) list for options to take a output name: # -o and its alias -o -object_file_name= --output= /Fa (windows for assembly output filename) /Fe (windows for output executable file name) /Fi (windows for

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM except one minor in the testcase. Thanks for adding this improvement. Comment at: clang/test/Driver/debug-options.c:121 // RUN: %clang -### -c -g %s -target

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

mgorny added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:114-117 +target_link_libraries(clangBasic + PRIVATE + ${LLVM_ATOMIC_LIB} +) Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a bunch of tools, plus a few

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. Yeah, I am a little bit surprising/confusing to see why we're talking about the **behavior** of `-fmodule-file`. I guess the intention of @iains is to throw the option to prove `-fc++-module-file-path` (or `-fc++-module-file-output`) is the better. The point here is

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

mgorny added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:48 gen_decision_forest(${CMAKE_CURRENT_SOURCE_DIR}/quality/model CompletionModel clang::clangd::Example) +file(GLOB CompletionModel_files

[clang] 55c2137 - [testcase][OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

Author: Zi Xuan Wu (Zeson) Date: 2022-10-20T10:19:37+08:00 New Revision: 55c2137939d8e12c064cedcda21108c239dddf8e URL: https://github.com/llvm/llvm-project/commit/55c2137939d8e12c064cedcda21108c239dddf8e DIFF:

[PATCH] D136239: [testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

This revision was automatically updated to reflect the committed changes. Closed by commit rG55c2137939d8: [testcase][OpenMP] Fix the testcase error of check-all when… (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

arsenm added inline comments. Comment at: llvm/lib/IR/Verifier.cpp:5180 +int RW = cast(Call.getArgOperand(1))->getZExtValue(); +int Locality = cast(Call.getArgOperand(2))->getZExtValue(); +int Data = cast(Call.getArgOperand(3))->getZExtValue();

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:146 avxvnniintrin.h + avxvnniint8intrin.h bmi2intrin.h Move it before `avxvnniintrin.h` for the order? Comment at: llvm/lib/Support/X86TargetParser.cpp:584

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

estatemuch added a comment. Thank you for your contribution! It is quite beneficial to me! fireboy and watergirl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/ https://reviews.llvm.org/D112579

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

estatemuch added a comment. thanks for your post! It helps me so much! five nights at freddy's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382

[PATCH] D136023: [CMake] Disable BOLT instrumentation of Clang on instrumented build

This revision was automatically updated to reflect the committed changes. Closed by commit rG076240fa0624: [CMake] Disable BOLT instrumentation of Clang on instrumented build (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 076240f - [CMake] Disable BOLT instrumentation of Clang on instrumented build

Author: Amir Ayupov Date: 2022-10-19T18:24:05-07:00 New Revision: 076240fa062415b6470b79413559aff2bf5bf208 URL: https://github.com/llvm/llvm-project/commit/076240fa062415b6470b79413559aff2bf5bf208 DIFF: https://github.com/llvm/llvm-project/commit/076240fa062415b6470b79413559aff2bf5bf208.diff

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:980 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag)) +A->render(Args, CmdArgs); + Use

[PATCH] D134878: Update developer policy on potentially breaking changes

mehdi_amini added a comment. From what I saw when you posted the discourse thread initially, I understand you're targeting user-visible features, and mostly from the "toolchain" side of the project. However I find the language here to be potentially confusing for the API surface of the

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron updated this revision to Diff 469098. Izaron added a comment. Fix CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron added a comment. The test doesn't cover exactly all new traces though. For example I couldn't write a code that runs into the `EvaluateAsInt` method 樂 If you have an idea for some funky constexpr code that can be tested, please write here =) Repository: rG LLVM Github Monorepo

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62ca79102cf9: [X86][1/2] Support PREFETCHI instructions (authored by pengfei). Changed prior to commit:

[clang] 62ca791 - [X86][1/2] Support PREFETCHI instructions

Author: Phoebe Wang Date: 2022-10-20T08:46:01+08:00 New Revision: 62ca79102cf9646aa9ed0dac7f018432a68eedf1 URL: https://github.com/llvm/llvm-project/commit/62ca79102cf9646aa9ed0dac7f018432a68eedf1 DIFF: https://github.com/llvm/llvm-project/commit/62ca79102cf9646aa9ed0dac7f018432a68eedf1.diff

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron added a comment. In D136022#3861245 , @jloser wrote: > I'd like to see some tests through before I approve. Thanks for the greenlight! I added a test that compiles a chunk of code and then checks the time trace graph in a human-readable form.

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman

[PATCH] D136022: [clang] Add time profile for constant evaluation

Izaron updated this revision to Diff 469096. Izaron marked 4 inline comments as done. Izaron added a comment. Add time profiler test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022 Files:

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. I'm probably going to do something similar for `-gdwarf-N` as a follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136309/new/ https://reviews.llvm.org/D136309 ___

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers created this revision. nickdesaulniers added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've been working around

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

ributzka added inline comments. Comment at: clang/test/Modules/file-manager-lookup-count.m:73 +// RUN: FileCheck --input-file %t/stats %s +// CHECK: { +// CHECK-NEXT: "file-search.NumDirCacheMisses": 156, The content of the stats file may change over

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 469093. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136224/new/ https://reviews.llvm.org/D136224 Files: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:161 since they cannot be explicitly defaulted. The check also skips copy assignment operators - with nonstandard return types. The check is restricted to c++11-or-later. + with

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 469086. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136224/new/ https://reviews.llvm.org/D136224 Files: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 marked 2 inline comments as done. eddyz87 added inline comments. Comment at: llvm/lib/IR/Verifier.cpp:3473 !Call.getCalledFunction()->isInterposable() && + !Call.getCalledFunction()->isDeclaration() && Call.getCalledFunction()->getSubprogram())

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

eddyz87 updated this revision to Diff 469081. eddyz87 marked an inline comment as done. eddyz87 added a comment. Fixed test case to fail if `!Call.getCalledFunction()->isDeclaration()` condition is removed in `Verifier::visitCallBase`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:161 since they cannot be explicitly defaulted. The check also skips copy assignment operators - with nonstandard return types. The check is restricted to c++11-or-later. + with

[PATCH] D136293: [IncludeCleaner] Add public API

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Looks good, feel free to address/disregard design comments as you see fit. Comment at:

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 updated this revision to Diff 469077. jansvoboda11 added a comment. Add regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136019/new/ https://reviews.llvm.org/D136019 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae updated this revision to Diff 469074. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136134/new/ https://reviews.llvm.org/D136134 Files: clang/include/clang/Basic/HLSLRuntime.h

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3869678 , @dblaikie wrote: > In D134267#3869643 , @iains wrote: > >> In D134267#3869614 , @dblaikie >> wrote: >> >>> In D134267#3869162

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 469073. ayzhao added a comment. implement TreeTransform + add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. In D134267#3869643 , @iains wrote: > In D134267#3869614 , @dblaikie > wrote: > >> In D134267#3869162 , @iains wrote: >> >>> In D134267#3868830

[PATCH] D136106: [clang][RISCV] Set vscale_range attribute based on VLEN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8f3b113d05: [clang][RISCV] Set vscale_range attribute based on VLEN (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 9a8f3b1 - [clang][RISCV] Set vscale_range attribute based on VLEN

Author: Philip Reames Date: 2022-10-19T16:14:33-07:00 New Revision: 9a8f3b113d05d94d9aaacdf511365dde4e35ce4f URL: https://github.com/llvm/llvm-project/commit/9a8f3b113d05d94d9aaacdf511365dde4e35ce4f DIFF: https://github.com/llvm/llvm-project/commit/9a8f3b113d05d94d9aaacdf511365dde4e35ce4f.diff

[PATCH] D136162: [analyzer] Fix assertion failure in RegionStore within bindArray()

NoQ added a comment. > In this example, we try to store 42 to the Elem{buffer, 0}. In this case the natural question is, why does it go through `bindArray()`? We're not binding an array. Can we try to preserve the contract that `bindArray()` only deals with arrays? @martong's comment makes

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3869614 , @dblaikie wrote: > In D134267#3869162 , @iains wrote: > >> In D134267#3868830 , @dblaikie >> wrote: >> >>> I'm OK with

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. In D134267#3869162 , @iains wrote: > In D134267#3868830 , @dblaikie > wrote: > >> I'm OK with sticking with the existing `-fmodule-file` if that works for >> everyone. Yeah, it's short

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

alexander-shaposhnikov updated this revision to Diff 469063. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136224/new/ https://reviews.llvm.org/D136224 Files:

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3869201 , @aaron.ballman wrote: > In D134453#3868821 , @DoDoENT wrote: > >> In D134453#3868789 , @dblaikie >> wrote: >> >>> I still

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added inline comments. Comment at: openmp/libomptarget/src/api.cpp:264 + if (DepObj_Count > 0) { +DepObjs = new kmp_depend_info_t[DepObj_Count]; +for (int i = 0; i < DepObj_Count; i++) { Use an llvm::SmallVector Comment at:

[PATCH] D106876: Remove non-affecting module maps from PCM files.

dexonsmith added a comment. In D106876#3869447 , @jansvoboda11 wrote: > I agree that avoiding serializing non-affecting input files is the better > approach. Your code is more or less what I had in mind, thanks for sketching > it out! > The number of

[clang] 97b9130 - [clang] Disable assertion that can "easily happen"

Author: Jonas Devlieghere Date: 2022-10-19T15:08:56-07:00 New Revision: 97b91307b00e958bc1d511c93a8a6bef510485ac URL: https://github.com/llvm/llvm-project/commit/97b91307b00e958bc1d511c93a8a6bef510485ac DIFF:

[PATCH] D136290: [clang] Disable assertion that can "easily happen"

This revision was automatically updated to reflect the committed changes. Closed by commit rG97b91307b00e: [clang] Disable assertion that can easily happen (authored by JDevlieghere). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469060. jz10 added a comment. one minors fix, i.e. delete the depobj_list from TargetMemcpyArgsTy struct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3869520 , @tahonermann wrote: >> In a pre-scanned world, the build system does know the info for each source >> file (published and dependent modules) [which ought to dispel some of the >> concerns raised about not

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 469051. jz10 added a comment. Thanks Johannes and Shilei 1. "So, you are saying the task_with_deps function does *not* copy the dependences and therefore the array has to outlive the function?" I checked the omp_task_with_deps, it does some copy operations ,

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

tahonermann added a comment. > In a pre-scanned world, the build system does know the info for each source > file (published and dependent modules) [which ought to dispel some of the > concerns raised about not knowing about possible outputs for > implementation/interface cases]. > > In a

[PATCH] D134928: [Sema] Don't treat a non-null template argument as if it were null.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG795f67934d38: [Sema] Dont treat a non-null template argument as if it were null. (authored by efriedma). Changed prior to commit:

[clang] 795f679 - [Sema] Don't treat a non-null template argument as if it were null.

Author: Eli Friedman Date: 2022-10-19T14:40:52-07:00 New Revision: 795f67934d38c2c080aa65f5244dcbdccdbd1154 URL: https://github.com/llvm/llvm-project/commit/795f67934d38c2c080aa65f5244dcbdccdbd1154 DIFF: https://github.com/llvm/llvm-project/commit/795f67934d38c2c080aa65f5244dcbdccdbd1154.diff

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/test/ParserHLSL/group_shared_202x.hlsl:5-6 + +// expected-error@+1 {{return type cannot be qualified with address space}} +auto l = []() -> groupshared void {}; +//

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 updated this revision to Diff 469049. ZhiyaoMa98 marked an inline comment as done. ZhiyaoMa98 added a comment. Remove the unused `GA` variable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/ https://reviews.llvm.org/D136203 Files:

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 469048. python3kgae added a comment. Update comments and add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files:

[PATCH] D136293: [IncludeCleaner] Add public API

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Introduces walkUsed, a very simple version of the public API to

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136040/new/

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 469044. void added a comment. Reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/docs/ReleaseNotes.rst

[PATCH] D106876: Remove non-affecting module maps from PCM files.

jansvoboda11 added a comment. I agree that avoiding serializing non-affecting input files is the better approach. Your code is more or less what I had in mind, thanks for sketching it out! The number of ignored module maps is typically around 70 - 110 on macOS (when you allow system module

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nlopes requested changes to this revision. nlopes added a comment. > However, multiple loads of the same memory must be equal This premise is incorrect w.r.t. with current semantics, which say that loads return undef for uninit memory. As Nikita mentioned we are working towards changing this

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman updated this revision to Diff 469020. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 Files: clang/lib/Sema/SemaType.cpp clang/test/SemaObjCXX/Inputs/nullability-consistency-2.h Index:

[PATCH] D106876: Remove non-affecting module maps from PCM files.

dexonsmith added a comment. In D106876#3869247 , @dexonsmith wrote: > A further (more involved) approach would be to separate module maps into a > separate SourceManager, so that their source locations don't affect other > input files. Then only

[PATCH] D106876: Remove non-affecting module maps from PCM files.

dexonsmith added a comment. As an end goal, it seems strictly better for build systems / distribution / artifact storage / caching if the output PCM has been canonicalized as-if the module maps weren't found, rather than tracking both which module maps were discovered and which to ignore.

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

nikic requested changes to this revision. nikic added a reviewer: nlopes. nikic added a comment. This revision now requires changes to proceed. The current behavior here is intentional -- in fact, LLVM will move towards returning poison for loads from uninitialized memory in the future (though

[PATCH] D134453: Disambiguate type names when printing NTTP types

aaron.ballman added a comment. In D134453#3868821 , @DoDoENT wrote: > In D134453#3868789 , @dblaikie > wrote: > >> I still don't think "keep full NTTP type printing behind a policy, for those >> that want/need

[PATCH] D136078: [RFC] Use-after-return binary metadata.

melver added a comment. In D136078#3867627 , @dvyukov wrote: > Unrelated, but looking at the metadata format more closely, I think this can > benefit from LEB128-like varlen encoding. > Function size is small. > Features are very small. > Stack args

[PATCH] D136284: SROA should freeze undefs for loads with no prior stores

jamieschmeiser created this revision. jamieschmeiser added reviewers: nikic, tstellar. Herald added subscribers: nlopes, kosarev, kerbowa, hiraditya, arichardson, jvesely. Herald added a project: All. jamieschmeiser requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3868830 , @dblaikie wrote: > I'm OK with sticking with the existing `-fmodule-file` if that works for > everyone. Yeah, it's short and ambiguous in a space with many concepts of > what a "module file" is, but also the

[PATCH] D135657: add time traces for AST serialization

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d007d4ba21: [clang][modules] Add time traces for AST serialization (authored by Trass3r, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 12d007d - [clang][modules] Add time traces for AST serialization

Author: Andreas Hollandt Date: 2022-10-19T12:16:30-07:00 New Revision: 12d007d4ba218e21e92de30d00c6a890f3d8b5f8 URL: https://github.com/llvm/llvm-project/commit/12d007d4ba218e21e92de30d00c6a890f3d8b5f8 DIFF:

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. thesamesam requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously build system generated

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

thesamesam created this revision. thesamesam added reviewers: mgorny, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary at least on

[PATCH] D135060: [HLSL] Add groupshare address space.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:10083 } +// HLSL not support address space on a function return type declaration. +LangAS AddressSpace = NewFD->getReturnType().getAddressSpace();

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. @shafik PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468997. void added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. In D135920#3868170 , @aaron.ballman wrote: > Can you please add a release note to mention the diagnostic wording was > patched up? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added a comment. Thanks for the detailed write-up, very much appreciated. In D129755#3866887 , @rupprecht wrote: > 1. (2x) Returning a MutexLock-like structure, e.g. > > MutexLock Lock() { > return MutexLock(); > } > > this is

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, tblah wrote: > awarzynski wrote: > > What are these pragmas? Perhaps you can add a test that would include them? > I

[PATCH] D133668: [HLSL] Disable integer promotion to avoid int16_t being promoted to int for HLSL.

python3kgae updated this revision to Diff 468993. python3kgae marked an inline comment as done. python3kgae added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Move isPromotableIntegerType to ASTContext so it can access LangOpts. Repository: rG LLVM Github

[PATCH] D106876: Remove non-affecting module maps from PCM files.

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1549 +if (isModuleMap(File.getFileCharacteristic()) && +!isSystem(File.getFileCharacteristic()) && +!AffectingModuleMaps.empty() && Why do we never consider

[PATCH] D106876: Remove non-affecting module maps from PCM files.

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:183-184 +HS.getExistingFileInfo(File, /*WantExternal*/false); +if (!HFI || (HFI->isModuleHeader && !HFI->isCompilingModuleHeader)) + continue; + rsmith wrote:

[PATCH] D106876: Remove non-affecting module maps from PCM files.

jansvoboda11 added a comment. Herald added a project: All. Hi @ilyakuteev, this patch is causing some issues downstream. (See `clang/test/Modules/non-affecting-module-maps-source-locations.m` here .) I think they all boil down to the fact that a

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

rnk added a comment. I think I was confused in that conversation because I wasn't sure where in the pass pipeline this was going to run. I heard various statements like "lost after ISel" and to me, ISel is like the first step of codegen, it comes before register allocation. What you've done

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked 5 inline comments as done. gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 updated this revision to Diff 468973. ZhiyaoMa98 marked an inline comment as done. ZhiyaoMa98 added a comment. Updated the comment to reflect that now we allow using `-mlong-calls` with `-mexecute-only`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one small change. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:779 // Supported only on ARMv6T2 and ARMv7 and above. // Cannot be combined

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files:

[PATCH] D136271: [HLSL] Remove unused frontend-generated ID

beanz created this revision. beanz added a reviewer: python3kgae. Herald added subscribers: Anastasia, hiraditya. Herald added a project: All. beanz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. As @python3kgae pointed out we're

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. I'm OK with sticking with the existing `-fmodule-file` if that works for everyone. Yeah, it's short and ambiguous in a space with many concepts of what a "module file" is, but also the fact that it's a `-f` flag might help disambiguate it a bit - it's probably not the

[PATCH] D134453: Disambiguate type names when printing NTTP types

DoDoENT added a comment. In D134453#3868789 , @dblaikie wrote: > I still don't think "keep full NTTP type printing behind a policy, for those > that want/need that" is a policy we should add. String printed names aren't > meant to be a tool for type

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. > Then just assert we aren't execute-only in the non-movw path. When we are not execute-only, existing code handles it by using constant pools and we are all good. In the case where we are execute-only and long-calls at the same time, we assert that we have `movt`

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 updated this revision to Diff 468957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136203/new/ https://reviews.llvm.org/D136203 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Driver/arm-execute-only.c llvm/lib/Target/ARM/ARMISelLowering.cpp

  1   2   3   >