[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I haven't tested it but if it works for you and the test passes, LGTM. @MaskRay, would you be able to test and push it? I don't have a recent clang build tree handy. Repository:

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471717. paperchalice added a comment. Add test on Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp

[PATCH] D137005: [clang][CodeGen] Add noundef metadata to load insturctions (preliminary 2 of 2)

jmciver created this revision. jmciver added reviewers: nikic, efriedma, aqjune, rjmccall, jdoerfert, vitalybuka. Herald added a project: All. jmciver retitled this revision from "[clang][CodeGen] Add noundef metadata to scalar load insturctions (preliminary 2 of 2)" to "[clang][CodeGen] Add

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. I'll start fixing reported test failures tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410 ___ cfe-commits mailing list

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I think you should be able to test it via overriding `HOME` envvar. I suppose you can limit the test to Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 471713. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Context.cpp

[PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

arsenm closed this revision. arsenm added a comment. 0ebd4638af1f71788ca55f521ed8e1ed8cab518d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136959/new/ https://reviews.llvm.org/D136959

[clang] 0ebd463 - clang: Improve errors for DiagnosticInfoResourceLimit

Author: Matt Arsenault Date: 2022-10-28T21:42:57-07:00 New Revision: 0ebd4638af1f71788ca55f521ed8e1ed8cab518d URL: https://github.com/llvm/llvm-project/commit/0ebd4638af1f71788ca55f521ed8e1ed8cab518d DIFF:

[clang] c62745e - DiagnosticInfo: Report function location for resource limits

Author: Matt Arsenault Date: 2022-10-28T21:42:57-07:00 New Revision: c62745e1678e26185dc93ea30f858c91c03323f9 URL: https://github.com/llvm/llvm-project/commit/c62745e1678e26185dc93ea30f858c91c03323f9 DIFF:

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:970 + if (!Pointer::hasSameArray(LHS, RHS)) { +// TODO: Diagnose. +return false; shafik wrote: > tbaeder wrote: > > This is also not being diagnosed (only rejected) by the current

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

tbaeder updated this revision to Diff 471711. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135858/new/ https://reviews.llvm.org/D135858 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay added a comment. In D136940#3893638 , @paperchalice wrote: > I would appreciate if someone can commit this change. I am waiting on @mgorny 's opinion for

[clang] 0cc9710 - [Frontend] -MP: remove blank lines

Author: Fangrui Song Date: 2022-10-28T20:46:27-07:00 New Revision: 0cc9710a0dc0b1cc2e13aaa3778ba55cc0d37b84 URL: https://github.com/llvm/llvm-project/commit/0cc9710a0dc0b1cc2e13aaa3778ba55cc0d37b84 DIFF: https://github.com/llvm/llvm-project/commit/0cc9710a0dc0b1cc2e13aaa3778ba55cc0d37b84.diff

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver updated this revision to Diff 471708. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary) Add flag -enable-noundef-load-analysis and rebase with main. Refactored noundef metadata

[clang] ff9576f - [Frontend] Fix -MP when main file is

Author: Fangrui Song Date: 2022-10-28T20:35:29-07:00 New Revision: ff9576f74514b836e1ba0268409a2ecb919d7118 URL: https://github.com/llvm/llvm-project/commit/ff9576f74514b836e1ba0268409a2ecb919d7118 DIFF: https://github.com/llvm/llvm-project/commit/ff9576f74514b836e1ba0268409a2ecb919d7118.diff

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. I would appreciate if someone can commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. In D136940#3893391 , @MaskRay wrote: > `clang/test/Driver/config-file3.c` tests `--config-user-dir=` but I cannot > think of a portable way testing this. > `RUN: echo ~; %clang -### --config-user-dir=~ ...` doesn't work as

[PATCH] D136956: [clang][Interp] Implement BitXor opcode

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Besides the minor comment LGTM Comment at: clang/test/AST/Interp/literals.cpp:290 + static_assert((0 | gimme(12)) == 12, ""); + static_assert((12 ^ true) == 13, "");

[PATCH] D136817: [RISCV] Add H extension

kito-cheng marked an inline comment as done. kito-cheng added inline comments. Comment at: llvm/docs/RISCVUsage.rst:54 ``F``Supported + ``H``Supported ``M``Supported reames wrote: > If I'm reading the code

[PATCH] D136817: [RISCV] Add H extension

kito-cheng updated this revision to Diff 471701. kito-cheng added a comment. Changes: - Update doc, H is support assembly only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136817/new/ https://reviews.llvm.org/D136817 Files:

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith added a comment. In D136624#3893001 , @jansvoboda11 wrote: > I tried implementing your suggestion (merging ranges of adjacent > non-affecting files and avoiding `FileID` lookups), but the numbers from > `-ftime-trace` are very noisy. I got

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.cpp:46 + + Ptr += sizeof(InitMap *); for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) { aaron.ballman wrote: > shafik wrote: > > I believe `Ptr` is not longer valid b/c of

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping for reviewers as all comments should be addressed by now. In D129531#3873775 , @cor3ntin wrote: > It starting to look great. > Should we add an extension warning? Note that I'm not suggesting to support > that in

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 471694. ayzhao marked 2 inline comments as done. ayzhao added a comment. add C++20 extension diagnostics and some other code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added a comment. In D136786#3893485 , @andrew.w.kaylor wrote: > As a first principle, I'd like to clarify a "big picture" item that I was > trying to get at in my earlier comment. I'd like to be able to reason about > this from the

[clang] fd35e15 - [clang][test] Require x86 target in a couple new tests

Author: Ben Langmuir Date: 2022-10-28T17:00:18-07:00 New Revision: fd35e1506011fca925661312315b14f169a2e82a URL: https://github.com/llvm/llvm-project/commit/fd35e1506011fca925661312315b14f169a2e82a DIFF: https://github.com/llvm/llvm-project/commit/fd35e1506011fca925661312315b14f169a2e82a.diff

[clang] 1ad63dc - clang: Add required target to test

Author: Matt Arsenault Date: 2022-10-28T16:50:23-07:00 New Revision: 1ad63dc0b760d5a280500a4e9ebdc242468392bd URL: https://github.com/llvm/llvm-project/commit/1ad63dc0b760d5a280500a4e9ebdc242468392bd DIFF:

[PATCH] D128223: [clang] Linkage computation of static locals may require forcing visibility computation

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM. Doing the inner computation while observing visibility seems like the right thing to do in this case. Comment at: clang/lib/AST/Decl.cpp:1355 +

[clang] 7d568cd - AMDGPU: Register a null MC streamer for -emit-codegen-only

Author: Matt Arsenault Date: 2022-10-28T16:39:09-07:00 New Revision: 7d568cdc9d68ec295f1e141c8bcad344873f51cd URL: https://github.com/llvm/llvm-project/commit/7d568cdc9d68ec295f1e141c8bcad344873f51cd DIFF:

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

andrew.w.kaylor added a comment. In D136786#3892177 , @zahiraam wrote: >>> I'm not following entirely, but -funsafe-math-optimizations is just a >>> subset of -ffast-math, so checking only the properties that contribute to >>>

[clang] d3e99d6 - [Driver] Use addOptInFlag/addOptOutFlag. NFC

Author: Fangrui Song Date: 2022-10-28T16:15:14-07:00 New Revision: d3e99d61a42bbac0da6c56e34fc5a2139549616f URL: https://github.com/llvm/llvm-project/commit/d3e99d61a42bbac0da6c56e34fc5a2139549616f DIFF: https://github.com/llvm/llvm-project/commit/d3e99d61a42bbac0da6c56e34fc5a2139549616f.diff

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang created this revision. Herald added a subscriber: nlopes. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136998 Files:

[clang] e1f9983 - Move getenv for AS_SECURE_LOG_FILE to clang

Author: Ben Langmuir Date: 2022-10-28T16:08:04-07:00 New Revision: e1f998302276cf227de6c6029ea25b2dbb84f3d8 URL: https://github.com/llvm/llvm-project/commit/e1f998302276cf227de6c6029ea25b2dbb84f3d8 DIFF: https://github.com/llvm/llvm-project/commit/e1f998302276cf227de6c6029ea25b2dbb84f3d8.diff

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1f998302276: Move getenv for AS_SECURE_LOG_FILE to clang (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip &&

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

hubert.reinterpretcast added inline comments. BRANCHES main /clang/docs/ReleaseNotes.rst:612-613 Thanks! Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `clang/test/Driver/config-file3.c` tests `--config-user-dir=` but I cannot think of a portable way testing this. `RUN: echo ~; %clang -### --config-user-dir=~ ...` doesn't work as the

[clang] eb53661 - [Driver] Fix -fdebug-default-version= -Wunused-command-line-argument after D136707

Author: Fangrui Song Date: 2022-10-28T15:37:46-07:00 New Revision: eb536613a28b3070081900957553beb783448053 URL: https://github.com/llvm/llvm-project/commit/eb536613a28b3070081900957553beb783448053 DIFF: https://github.com/llvm/llvm-project/commit/eb536613a28b3070081900957553beb783448053.diff

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 471674. TIFitis marked an inline comment as done. TIFitis added a comment. Removed isDevice() check from function definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/

[Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

dblaikie marked an inline comment as done. dblaikie added inline comments. BRANCHES main /clang/docs/ReleaseNotes.rst:612-613 Oh, sure: 97c1b0094ad6f628927223b53300c9296ae72f44 Users: dblaikie (Author) https://reviews.llvm.org/rGe4ec6ce8a75c

[clang] 97c1b00 - Follow-up to Itanium ABI POD patchnotes

Author: David Blaikie Date: 2022-10-28T22:29:50Z New Revision: 97c1b0094ad6f628927223b53300c9296ae72f44 URL: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44 DIFF: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44.diff

Re: [Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Posted, awaiting approval. On Fri, Oct 28, 2022 at 5:23 AM Aaron Ballman wrote: > > Also, please be sure to post something to > https://discourse.llvm.org/c/announce/46 with the potentially-breaking > tag applied to it. > > ~Aaron > > On Thu, Oct 27, 2022 at 8:19 PM Hubert Tong via Phabricator

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4717 + if (!isDevice) +return; + jdoerfert wrote: > TIFitis wrote: > > jdoerfert wrote: > > > Why do we call it if isDevice is

[PATCH] D136707: [clang][Toolchains][Gnu] pass -gdwarf-* through to assembler

MaskRay added a comment. In D136707#3892300 , @jyknight wrote: > This change has caused `clang -Wall -fdebug-default-version=5 -c -xc > /dev/null -o /dev/null` to print the following warning, because it has moved > the read of the argument into a

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 471672. TIFitis added a comment. Added doxygen comment to explain why module must be passed to OMPIRBuilder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files:

[PATCH] D136981: [HIP] add float to fp16 convert functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36a025366215: [HIP] add float to fp16 convert functions (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 36a0253 - [HIP] add float to fp16 convert functions

Author: Yaxun (Sam) Liu Date: 2022-10-28T18:17:05-04:00 New Revision: 36a025366215d27bcb6e6ccbe08651593acc2cd9 URL: https://github.com/llvm/llvm-project/commit/36a025366215d27bcb6e6ccbe08651593acc2cd9 DIFF:

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

MaskRay accepted this revision. MaskRay added inline comments. Herald added a subscriber: StephenFan. Comment at: llvm/lib/MC/MCContext.cpp:77 AutoReset(DoAutoReset), TargetOptions(TargetOpts) { - SecureLogFile = AsSecureLogFileName; + SecureLogFile = TargetOptions ?

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

MaskRay added a comment. The `_GNU_SOURCE` definition needs to be guarded by `if (Opts.CPlusPlus)`. Comment at: clang/test/Driver/arm-baremetal-defines.cpp:1 +// RUN: %clang --target=arm-none-eabi -march=armv7-m %s -emit-llvm -S -c -o - 2>&1 | FileCheck %s +

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

tomhughes added a comment. More context: https://issuetracker.google.com/254916723 I take back my earlier comment about it applying for both C and C++. Checking locally I see the behavior @MaskRay describes: `_GNU_SOURCE` not defined: gcc -E -dD -o empty empty.c `_GNU_SOURCE` defined:

[PATCH] D136981: [HIP] add float to fp16 convert functions

b-sumner added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136981/new/ https://reviews.llvm.org/D136981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

abidh added a comment. In D136712#3892986 , @manojgupta wrote: > @tomhughes has more details on this but if we do not define it in clang > itself, we'll need to define it for every package manually at build time > since the usage goes deep inside

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. @rtrieu @hokein I just proposed a fix for this at https://reviews.llvm.org/D136977 At least for the repro posted above, this was a pre-existing bug with unexpanded packs appearing within sugar, which the present patch potentialized by preserving the type alias when

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

tschuett added a comment. Are malformed imports an issue or are they already covered? There is limit test coverage for import. Am I missing something? import import; import module; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136953/new/ https://reviews.llvm.org/D136953

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Modulo the import typo. I'm happy with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136953/new/ https://reviews.llvm.org/D136953

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ldionne added a comment. In D136533#3892949 , @ldionne wrote: > 2. Shipping this change does mean that anyone building anything with a new > Clang and a not-yet-updated libc++ with a deployment target before 10.15 (or > whatever first version we

[PATCH] D136981: [HIP] add float to fp16 convert functions

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added a project: All. yaxunl requested review of this revision. https://reviews.llvm.org/D136981 Files: clang/lib/Headers/__clang_hip_libdevice_declares.h Index: clang/lib/Headers/__clang_hip_libdevice_declares.h

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 added a comment. I tried implementing your suggestion (merging ranges of adjacent non-affecting files and avoiding `FileID` lookups), but the numbers from `-ftime-trace` are very noisy. I got more stable data by measuring clock cycles and instruction counts, but nothing conclusive

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta added a comment. @tomhughes has more details on this but if we do not define it in clang itself, we'll need to define it for every package manually at build time since the usage goes deep inside newlib headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 updated this revision to Diff 471641. jansvoboda11 added a comment. Avoid looking up `FileID` for an offset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136624/new/ https://reviews.llvm.org/D136624 Files:

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes #58679. Signed-off-by: Matheus Izvekov Depends on D136962 Repository: rG

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 471638. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

MaskRay added a comment. Is this an upstream GCC behavior or a behavior from some gcc-none-eabi distributions? GCC's C++ mode defines `_GNU_SOURCE` historically due to a libstdc++ limitation https://gcc.gnu.org/onlinedocs/libstdc++/faq.html#faq.predefined and nowadays "the ship has sailed" and

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ldionne added a comment. Ah, I understand. Thanks for explaining and sorry, I had only taken a quick look. So -- the reason why this isn't found by the libc++ CI is that it only triggers when we build on macOS, and our CI does not perform a bootstrapping build on macOS. In other words, we're

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

tschuett added a comment. Thx. Comment at: clang/test/Modules/reserved-names-1.cpp:42 + +// We can still use a reserved name on imoport. +import std; // expected-error {{module 'std' not found}} import? CHANGES SINCE LAST ACTION

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta added reviewers: MaskRay, efriedma. manojgupta added subscribers: MaskRay, efriedma. manojgupta added a comment. Herald added a subscriber: StephenFan. I am not sure who is a good reviewer for this. Starting with @MaskRay and @efriedma Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

aeubanks added a comment. see https://reviews.llvm.org/D110665 for how we get line/col from a function. basically, we have a map from function name hashes to source location available in clang if we don't have clang source information for functions available, there's not much more we can do

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:241-248 + // C++2b [module.unit]p1: ... The identifiers module and import shall not + // appear as identifiers in a module-name or module-partition. All + // module-names either beginning with an

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman updated this revision to Diff 471628. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136953/new/ https://reviews.llvm.org/D136953 Files:

[PATCH] D136894: Add clang-doc readme

paulkirth added a comment. I'm a bit tied up until next week, and looped in some other reviewers. I can take a look on Monday if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136894/new/ https://reviews.llvm.org/D136894

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip &&

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

erichkeane added a comment. In D133052#3892650 , @erichkeane wrote: > In D133052#3891768 , @usaxena95 > wrote: > >> My suggestion would be to properly handle cycles in >> `CheckConstraintSatisfaction`. This

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.cpp:46 + + Ptr += sizeof(InitMap *); for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) { shafik wrote: > I believe `Ptr` is not longer valid b/c of `free(IM)` b/c what

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.cpp:46 + + Ptr += sizeof(InitMap *); for (unsigned I = 0, NE = D->getNumElems(); I < NE; ++I) { I believe `Ptr` is not longer valid b/c of `free(IM)` b/c what `Ptr` points to has not

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

steakhal added inline comments. Comment at: clang/test/Analysis/svalbuilder-float-cast.c:18-19 *p += 1; // This should NOT be (float)$x + 1. Symbol $x was never casted to float. - // FIXME: Ideally, this should be $x + 1. - clang_analyzer_express(*p); //

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:241-248 + // C++2b [module.unit]p1: ... The identifiers module and import shall not + // appear as identifiers in a module-name or module-partition. All + // module-names either beginning with an

[clang] a75879d - Update the status of some C2x features

Author: Aaron Ballman Date: 2022-10-28T14:46:16-04:00 New Revision: a75879d9a992e23e097c27b2a9f100dc4d698928 URL: https://github.com/llvm/llvm-project/commit/a75879d9a992e23e097c27b2a9f100dc4d698928 DIFF: https://github.com/llvm/llvm-project/commit/a75879d9a992e23e097c27b2a9f100dc4d698928.diff

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:77 AutoReset(DoAutoReset), TargetOptions(TargetOpts) { - SecureLogFile = AsSecureLogFileName; + SecureLogFile = TargetOptions ? TargetOptions->AsSecureLogFile : ""; benlangmuir

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

erichkeane added a comment. In D133052#3891768 , @usaxena95 wrote: > My suggestion would be to properly handle cycles in > `CheckConstraintSatisfaction`. This problem goes beyond cycles introduced by > conversion. See #53213

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2000 "overridden virtual function is here">; +def err_conflicting_overriding_attributes : Error< + "virtual function %0 has different attributes " sdesmalen

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. In D134267#3876071 , @dblaikie wrote: > I'm getting a bit exhausted with all the words involved here & not sure how > to simplify/clarify this. > > If @ben.boeckel has particular use cases, it might be easier for him to be

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin updated this revision to Diff 471611. jsjodin added a comment. Remove debug code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136601/new/ https://reviews.llvm.org/D136601 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_codegen.cpp

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin added a comment. What is the procedure to redo a patch that was reverted? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1909 +CtorEntryInfo.ParentName = Twine(Buffer, "_ctor").toStringRef(Out); +llvm::errs() << "Registering var ctor: " << Twine(Buffer,

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin updated this revision to Diff 471610. jsjodin added a comment. Fix reference error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136601/new/ https://reviews.llvm.org/D136601 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_target_codegen.cpp

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:970 + if (!Pointer::hasSameArray(LHS, RHS)) { +// TODO: Diagnose. +return false; tbaeder wrote: > This is also not being diagnosed (only rejected) by the current interpreter. > But

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

shafik added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:69 +constexpr int const * ap1 = [0]; +constexpr int const * ap2 = ap1 + 3; // expected-error {{must be initialized by a constant expression}} \ + // expected-note

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman updated this revision to Diff 471608. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updated based on review feedback and reflection. I think the standards wording here is a bit unclear as to what's intended and I had misunderstood the wording

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:241 + // Pointer arithmethic special case. This is supported for one of + // LHS and RHS being a pointer type and the other being an integer type. + if (BO->getType()->isPointerType()) {

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Coincidentally 2 of the bugs were just fixed in b9a77b56d8 . I do not completely agree with the approach there though. We should be fixing the root cause instead of circumventing

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1909 +CtorEntryInfo.ParentName = Twine(Buffer, "_ctor").toStringRef(Out); +llvm::errs() << "Registering var ctor: " << Twine(Buffer, "_ctor") << "\n";

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

mikerice added a comment. In D136601#3892410 , @jsjodin wrote: > When I have a fix, is there a way for me to test my code on the buildbot? I > don't seem to be able to reproduce the problem on my machine. If you have access to valgrind it can be

[PATCH] D136859: [HIP] add fmax/fmin for fp16

This revision was automatically updated to reflect the committed changes. Closed by commit rG319444fcf586: [HIP] add fmax/fmin for fp16 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136859/new/

[clang] 319444f - [HIP] add fmax/fmin for fp16

Author: Yaxun (Sam) Liu Date: 2022-10-28T13:38:12-04:00 New Revision: 319444fcf586004c3ed851e20c9df8ca2888e6d5 URL: https://github.com/llvm/llvm-project/commit/319444fcf586004c3ed851e20c9df8ca2888e6d5 DIFF:

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:77 AutoReset(DoAutoReset), TargetOptions(TargetOpts) { - SecureLogFile = AsSecureLogFileName; + SecureLogFile = TargetOptions ? TargetOptions->AsSecureLogFile : ""; MaskRay

[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

benlangmuir updated this revision to Diff 471592. benlangmuir added a comment. - --target=, remove -o per review - Use "log_file" as path to try to avoid Windows path issue in driver test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136888/new/ https://reviews.llvm.org/D136888 Files:

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

jsjodin added a comment. In D136601#3889822 , @kda wrote: > The bracket builds have finished and they seem to have a conclusive result. > The test starts failing with this patch. > > Built at this patch:

[clang] b9a77b5 - [Concepts] Fix an assert when trying to form a recovery expr on a

Author: Erich Keane Date: 2022-10-28T10:25:34-07:00 New Revision: b9a77b56d83ac788beb7b1743e510ef8534354ca URL: https://github.com/llvm/llvm-project/commit/b9a77b56d83ac788beb7b1743e510ef8534354ca DIFF: https://github.com/llvm/llvm-project/commit/b9a77b56d83ac788beb7b1743e510ef8534354ca.diff

[PATCH] D136789: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69b2b7282e92: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager… (authored by aeubanks). Changed prior to commit:

[clang] 69b2b72 - [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

Author: Arthur Eubanks Date: 2022-10-28T10:24:00-07:00 New Revision: 69b2b7282e92a1b576b7bd26f3b16716a5027e8e URL: https://github.com/llvm/llvm-project/commit/69b2b7282e92a1b576b7bd26f3b16716a5027e8e DIFF:

  1   2   3   >