[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 473002. cor3ntin added a comment. - rename `/IsCheckingDefaultArgumentOrInitializer/IsCurrentlyCheckingDefaultArgumentOrInitializer` following offline discussion with Aaron - Address Shafik comments - Revert WS change - add comment explaining the

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames updated this revision to Diff 473001. reames added a comment. Fix silly typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137350/new/ https://reviews.llvm.org/D137350 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:437 + +// RUN: %clang -target riscv64 -march=rv64ixventanacondops -x c -E -dM %s \ +// RUN: -o - | FileCheck --check-prefix=CHECK-XVENTANACONDOPS-EXT %s Naming wise, is

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

tianshilei1992 added a comment. Can you verify if projects enabled by `LLVM_ENABLE_RUNTIMES` (not `LLVM_ENABLE_PROJECTS`) will still be installed properly, aka in LLVM's lib directory? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

mgorny added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

spupyrev added a comment. Thanks @HaoyuZhang for adding the flag and the documentation. I just edited the message a bit; otherwise looks good. Comment at: clang/docs/UsersManual.rst:2244 + [OPTIONAL] During the sampling, the profiles may have errors or missing + blocks.

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

reames created this revision. reames added reviewers: craig.topper, asb, frasercrmck, kito-cheng, jrtc27. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 472995. carlosgalvezp added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files:

[PATCH] D137348: -Wunsafe-buffer-usage: Introduce an abstraction for fixable code patterns.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:37 +#include "clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def" +#undef GADGETS + }; Whoops typo! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + //

[PATCH] D137348: -Wunsafe-buffer-usage: Introduce an abstraction for fixable code patterns.

NoQ created this revision. NoQ added reviewers: aaron.ballman, gribozavr2, xazax.hun, jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong, rnkovacs. Herald added a project: All. NoQ requested review of this revision. This patch introduces a hierarchy of

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Thanks for the review Shafik, I'll address the other comments later. Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:10 +{ +return undefined(); // expected-error {{not a constant expression}} \ +

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

NoQ added inline comments. Comment at: clang/docs/SafeBuffers.rst:114 + insufficient without such hardening. + (TODO: Will automatic fixits be able to suggest custom containers or views?) + (TODO: Explain how to implement such checks in a custom container?)

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tra added a comment. NVPTX has no current uses of this, so if the mangling needs to change, now would be the good time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://reviews.llvm.org/D136919

[PATCH] D137346: -Wunsafe-buffer-usage: A way to transition away from raw buffer accesses.

NoQ created this revision. NoQ added reviewers: aaron.ballman, gribozavr2, xazax.hun, jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong, rnkovacs. Herald added a project: All. NoQ requested review of this revision. This is the initial commit for

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dblaikie added a comment. This is a bit out of left field, but these comments reminded me of something - a long time ago I was working on fixing some Clang layering to potentially use explicit modules more in our internal build (& then hopefully in the upstream/external build) and one major

[PATCH] D136554: Implement CWG2631

shafik added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9602-9604 +return Ctx.Context == + ExpressionEvaluationContext::PotentiallyEvaluatedIfUsed || + Ctx.IsCheckingDefaultArgumentOrInitializer; aaron.ballman wrote:

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added a comment. Thank you for reporting the issue. It was fixed in fdab9f1203ee . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136090/new/

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D137240: [clang][Interp] Support alignof()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:444 +// alignment of the referenced type. +if (const ReferenceType *Ref =

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I think this is a more clear approach than the previous one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137082/new/ https://reviews.llvm.org/D137082

[PATCH] D136554: Implement CWG2631

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/docs/ReleaseNotes.rst:782-783 operator. -- ``clang_Cursor_getNumTemplateArguments``, ``clang_Cursor_getTemplateArgumentKind``, -

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some very minor nits. Comment at: clang/docs/ReleaseNotes.rst:618 + - Allow the use of `__noinline__` as a keyword (instead of

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added a comment. In D137251#3904618 , @Pierre-vh wrote: > Comments > > Not sure if the release note is in the right place though. > As for the test, I did something quite targeted/minimal, hope it's fine? LGTM. Thanks. Repository: rG LLVM

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

yaxunl added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, ); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName = Tok.getIdentifierInfo(); Pierre-vh wrote: >

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG with a test nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

MaskRay added inline comments. Comment at: clang/test/Driver/arm-baremetal-defines.cpp:1 +// RUN: %clang --target=arm-none-eabi -march=armv7-m %s -emit-llvm -S -c -o - 2>&1 | FileCheck %s + MaskRay wrote: > Move this to `test/Preprocessor/init-arm.c`

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

ymandel updated this revision to Diff 472978. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137334/new/ https://reviews.llvm.org/D137334 Files:

[PATCH] D136811: WIP: RFC: NFC: C++ Buffer Hardening user documentation.

aaron.ballman added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that

[PATCH] D137154: Adding nvvm_reflect clang builtin

arsenm added a comment. In D137154#3905711 , @yaxunl wrote: > LLVM does not maintain bitcode backward compatibility between major releases. > How do you make sure the clang/LLVM you are using is compatible with > libdevice? Yes it does? We support

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 created this revision. Herald added a project: All. Origami404 edited the summary of this revision. Origami404 edited the summary of this revision. Origami404 added reviewers: aaron.ballman, efriedma. Origami404 added a subscriber: inclyc. Origami404 published this revision for review.

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:73-74 +/// Returns: +/// `Same`:`Val1` is equivalent to `Val2`, according

[PATCH] D137154: Adding nvvm_reflect clang builtin

yaxunl added a comment. In D137154#3904810 , @hdelan wrote: > In DPC++ for CUDA we use libclc as a wrapper around CUDA SDK's libdevice. > Like libdevice we want to precompile libclc to bc for the CUDA backend > without specializing for a particular

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

bnbarham added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:147-163 /// Indicates whether the buffer itself was provided to override /// the actual file contents. /// /// When true, the original entry may be a virtual file that does not

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:365 if (IsSet1 == nullptr) - return true; + return IsSet2 ? ComparisonStatus::Same :

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

ymandel updated this revision to Diff 472975. ymandel marked 2 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137334/new/ https://reviews.llvm.org/D137334 Files:

[PATCH] D136848: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

balazske updated this revision to Diff 472971. balazske added a comment. Try to fix test failures on Windows pre-merge check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136848/new/ https://reviews.llvm.org/D136848 Files:

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

nickdesaulniers added a comment. In D137317#3905654 , @craig.topper wrote: > In D137317#3905643 , > @nickdesaulniers wrote: > >> Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose >>

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

craig.topper added a comment. In D137317#3905643 , @nickdesaulniers wrote: > Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose > `llvm::X86::CK_PentiumPro` as the lower bounds? Surely > `llvm::X86::CK_Pentium2` doesn't support CET?

[PATCH] D137338: Fix dupe word typos

sivachandra accepted this revision. sivachandra added a comment. Changes in the libc directory LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine, though looking at `llvm::X86::CPUKind`, why do you choose `llvm::X86::CK_PentiumPro` as the lower bounds? Surely `llvm::X86::CK_Pentium2` doesn't support CET?

[PATCH] D136894: Add clang-doc readme

brettw added a comment. I definitely wasn't intending to write "formal documentation" for clang-doc. I was trying to write some notes for a future contributor as I'm winding down my work here, and it seems nobody else is working on it or has any knowledge about it. Is there a place in LLVM for

[PATCH] D137338: Fix dupe word typos

tianshilei1992 added a comment. Changes to `openmp` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list

[PATCH] D137338: Fix dupe word typos

DavidSpickett added a comment. Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead. As others said, appreciate the effort but the review process doesn't scale well

[PATCH] D137338: Fix dupe word typos

ldionne accepted this revision. ldionne added a comment. Thanks for the fixes. LGTM for `libcxx/`, `libcxxabi/` and `libunwind/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338

[PATCH] D137338: Fix dupe word typos

aartbik added a comment. LGTM for sparse changes (note that you could have made your life a bit easier if you had broken this revision up at least over different projects, getting a global "LGTM" from somebody may be a bit hard now ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 472962. manojgupta added a comment. Restore back to C++ only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 472961. manojgupta added a comment. restore back to C++ only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D125860: [clang] Only use major version in resource dir

sylvestre.ledru added a comment. i hope not too many people rely on it. LGTM but please add it to the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 ___ cfe-commits mailing list

[clang] e7deca5 - [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based.

Author: David Green Date: 2022-11-03T16:06:35Z New Revision: e7deca525058778df15e7888ed24974a32c8686c URL: https://github.com/llvm/llvm-project/commit/e7deca525058778df15e7888ed24974a32c8686c DIFF: https://github.com/llvm/llvm-project/commit/e7deca525058778df15e7888ed24974a32c8686c.diff LOG:

[PATCH] D137256: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7deca525058: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based. (authored by dmgreen). Herald added a project: clang. Herald

[PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:52 +/// Indicates the result of a tentative comparison. +enum class ComparisonStatus { + Same, Alternative that I slightly prefer - `ComparisonResult`.

[PATCH] D137287: [Test] Fix CHECK typo.

probinson added a comment. Nice work! have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137338: Fix dupe word typos

foad added a comment. I committed the lib/Target/AMDGPU parts as 5073ae2a883f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338

[PATCH] D125860: [clang] Only use major version in resource dir

serge-sans-paille added a comment. The consensus in the discourse thread you mention is not super strong, but I tend to agree with that patch. +1 for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseAnonymousNamespaceCheck.cpp:31 +static bool isInAnonymousNamespace(const Decl *Decl) { + const auto *DC = Decl->getDeclContext(); + if (DC && DC->isNamespace()) {

[clang] 3edd188 - [AArch64] Add a baseline test for fp16 target intrinsics. NFC

Author: David Green Date: 2022-11-03T15:18:36Z New Revision: 3edd18876950693cbc69edda429f223616e3c052 URL: https://github.com/llvm/llvm-project/commit/3edd18876950693cbc69edda429f223616e3c052 DIFF: https://github.com/llvm/llvm-project/commit/3edd18876950693cbc69edda429f223616e3c052.diff LOG:

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3897568 , @mstorsjo wrote: > In D137107#3897326 , @rnk wrote: > >> Unless I'm missing something, I think Clang's behavior here is preferable to >> MSVC's. MSVC produces code

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 472948. carlosgalvezp added a comment. Add reference to undeprecation of static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. I noticed one other bug from testing this out on some C++ codebases. Specifically in pybind11 we have an object class which is a child of the handle object. The object class is non-trivially copyable, while the handle object is not. Therefore, when we do not want to

[PATCH] D125860: [clang] Only use major version in resource dir

mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay. mgorny added a comment. Herald added subscribers: Michael137, StephenFan. To be honest, I've never seen much purpose in the x.y.z directory naming and I feel like it's making packaging unnecessarily more complex, at

[PATCH] D137338: Fix dupe word typos

glider added subscribers: pcc, glider. glider added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:54 - /// Returns whether the given label label contains the label elem. + /// Returns whether the given label contains the label elem. int

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille updated this revision to Diff 472945. serge-sans-paille added a comment. + Release Note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 Files: bolt/CMakeLists.txt

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 472946. carlosgalvezp added a comment. Fix release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files:

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D137338: Fix dupe word typos

jhenderson added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere. This is going to be impossible to cleanly review as-is. Could it be broken into lots of smaller chunks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Use llvm::find_if instead of std::find_if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 ___ cfe-commits mailing list

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

sylvestre.ledru added a comment. Maybe add it to the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 ___ cfe-commits mailing list

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tschuett added subscribers: aaron.ballman, tschuett. tschuett added a comment. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://reviews.llvm.org/D136919 ___ cfe-commits

[clang] 9ea2b15 - [OpenMP][OMPIRBuilder] Migrate createOffloadEntriesAndInfoMetadata from clang to OpenMPIRBuilder

Author: Jan Sjodin Date: 2022-11-03T10:27:44-04:00 New Revision: 9ea2b150b5455b907ba3b9aa24703b5d4faabedd URL: https://github.com/llvm/llvm-project/commit/9ea2b150b5455b907ba3b9aa24703b5d4faabedd DIFF: https://github.com/llvm/llvm-project/commit/9ea2b150b5455b907ba3b9aa24703b5d4faabedd.diff

[clang] 37f8010 - Silence a "not all control paths return" MSVC warning; NFC

Author: Aaron Ballman Date: 2022-11-03T10:27:16-04:00 New Revision: 37f80101a9120c95eb3c1022b8cc4a390f561700 URL: https://github.com/llvm/llvm-project/commit/37f80101a9120c95eb3c1022b8cc4a390f561700 DIFF: https://github.com/llvm/llvm-project/commit/37f80101a9120c95eb3c1022b8cc4a390f561700.diff

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar, mgorny, sylvestre.ledru. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, cota, StephenFan, teijeong,

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:54 + /// A verbatim header spelling, a string quoted with <> or "" that can be + /// #included directly + Header(StringRef VerbatimSpelling) :

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

tschuett added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:25 namespace clang::include_cleaner { namespace { +using DeclCallback = There is a cuter way to use anonymous namespaces:

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet updated this revision to Diff 472925. kadircet marked 5 inline comments as done. kadircet added a comment. - Fix typo - Change comment - Use Types.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. > These workarounds are fine for me, but I wonder if it would be useful with a > more direct cmake option to tell it not look for these files at all. CMake has something like that built-in. I think it's `-DCMAKE_DISABLE_FIND_PACKAGE_LLVM=ON`. Repository: rG LLVM

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472922. cor3ntin added a comment. Tweak comment in source_location tests with a suggestion Aaron made offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw abandoned this revision. sstwcw added a comment. It does some more than D137052 . But the addition stuff is not very important and no one can review it. So I am closing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 472920. cor3ntin added a comment. Use the `getPotentiallyDecomposedVarDecl` everywhere it makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files:

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

pengfei updated this revision to Diff 472916. pengfei added a comment. Fix lit fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/new/ https://reviews.llvm.org/D137317 Files: clang/lib/Basic/Targets/X86.h Index:

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3905024 , @RKSimon wrote: > Do you think this patch needs to be expanded to handle ARM/AArch64/NVPTX - > all of which override getBFloat16Mangling in similar ways? I thought of that. It would be great if we can make

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ben.boeckel added a comment. In D137059#3904256 , @ChuanqiXu wrote: > In my mind, it is OK for CMake to support one-phase compilation model in the > short term. And the fact that clang also supports the 2-phase compilation > wouldn't affect CMake. Do

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. In D134267#3904257 , @ChuanqiXu wrote: > BTW, this patch should be discarded. And now we're pursuing D137059 > and D137058 > , where there is no modules

[clang] 964c494 - Remove an unused local variable, NFC.

Author: Haojian Wu Date: 2022-11-03T13:57:46+01:00 New Revision: 964c4948cd4adb8e5d436796b02eb4bcd0b9641f URL: https://github.com/llvm/llvm-project/commit/964c4948cd4adb8e5d436796b02eb4bcd0b9641f DIFF: https://github.com/llvm/llvm-project/commit/964c4948cd4adb8e5d436796b02eb4bcd0b9641f.diff

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. In D90121#3065063 , @dmikis wrote: > Since we used heavily patched version of clang-format (including this patch) > that problem didn't bugged us and I kinda moved on to

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Herald added a project: All. If you still want this to be landed, we need a name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the API for a model's

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472912. cor3ntin added a comment. Add tests for consteval calls in init captures in default parameters. Clang behavior deviates from the wording of CWG2631 as it is not clear how we can implement the intended behavior in that corner case without

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:63 +// FIXME: use a real Class! +using SymbolLocation = std::variant; + kadircet wrote: > let's move this to `AnalysisInternal.h`, as it isn't used

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than a year silence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 ___

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein updated this revision to Diff 472911. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137320/new/ https://reviews.llvm.org/D137320 Files:

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. You can reopen this, if you wish to continue working on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

RKSimon added reviewers: stuij, tra. RKSimon added a comment. Do you think this patch needs to be expanded to handle ARM/AArch64/NVPTX - all of which override getBFloat16Mangling in similar ways? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8ceb9f4e4bd: [C++20] Diagnose invalid and reserved module names (authored by aaron.ballman). Changed prior to commit:

[clang] b8ceb9f - [C++20] Diagnose invalid and reserved module names

Author: Aaron Ballman Date: 2022-11-03T08:29:59-04:00 New Revision: b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e URL: https://github.com/llvm/llvm-project/commit/b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e DIFF: https://github.com/llvm/llvm-project/commit/b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e.diff

[clang] 7429709 - [Clang] Implement CWG2358 Explicit capture of value

Author: Corentin Jabot Date: 2022-11-03T13:27:11+01:00 New Revision: 742970920b7a7fc2fe1cb6bca6fb04f03ab7d5d9 URL: https://github.com/llvm/llvm-project/commit/742970920b7a7fc2fe1cb6bca6fb04f03ab7d5d9 DIFF:

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

This revision was automatically updated to reflect the committed changes. Closed by commit rG742970920b7a: [Clang] Implement CWG2358 Explicit capture of value (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137172/new/

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3904925 , @RKSimon wrote: > What are the rules on this? Do we just handle this as an ABI breaking change > and document it in the release notes - or do we need to provide any > auto-upgrade path (with a warning?)?

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG691774d4030d: [clang-format][NFC] Fix document of AlignTrailingComments (authored by yusuke-kadowaki, committed by HazardyKnusperkeks).

<    1   2   3   >