[clang] d1f90b6 - [NFC] [C++20] [Modules] Rename ASTWriter::isWritingStdCXXNamedModules

Author: Chuanqi Xu Date: 2022-11-08T15:58:46+08:00 New Revision: d1f90b61292045d395ba5b94bc9098f4b5d4e55d URL: https://github.com/llvm/llvm-project/commit/d1f90b61292045d395ba5b94bc9098f4b5d4e55d DIFF: https://github.com/llvm/llvm-project/commit/d1f90b61292045d395ba5b94bc9098f4b5d4e55d.diff

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

This revision was automatically updated to reflect the committed changes. Closed by commit rG13f83365cdb5: [Driver] Add -fsample-profile-use-profi (authored by HaoyuZhang, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 13f8336 - [Driver] Add -fsample-profile-use-profi

Author: haoyuintel Date: 2022-11-08T15:51:38+08:00 New Revision: 13f83365cdb5bb752066ee8f4149ae24dfe46cf1 URL: https://github.com/llvm/llvm-project/commit/13f83365cdb5bb752066ee8f4149ae24dfe46cf1 DIFF: https://github.com/llvm/llvm-project/commit/13f83365cdb5bb752066ee8f4149ae24dfe46cf1.diff

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu updated this revision to Diff 473884. ChuanqiXu added a comment. Remove other logics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 Files: clang/include/clang/Frontend/FrontendActions.h

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, iains, dblaikie, Bigcheese. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) It's better to add a test that immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473875. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914066 , @owenpan wrote: > @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, > and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any > existing tests. > > Adding

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any existing tests. Adding `PPBranchLevel` (or `PPLevel` in your case) to `UnwrappedLine` and `AnnotatedLine` worked for me.

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

fcloutier created this revision. fcloutier added reviewers: ahatanak, dcoughlin, aaron.ballman. fcloutier added a project: clang. Herald added a project: All. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. The initial implementation

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. A rough implementation just for your reference: diff --git a/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp b/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp index 47e11b9a1eab..f91f969c2b17 100644 --- a/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp +++

Re: [PATCH] D136565: [clang] Instantiate alias templates with sugar

Given the broad impact of this in our code I'm inclined to revert the patch to unblock us. The test case I have so far is still too large, but I hope to get something shareable tomorrow. On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, < revi...@reviews.llvm.org> wrote: > mizvekov

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. @alexfh Thanks! While there is a huge increase in the amount of UsingTypes, it seems the total amount is still reasonable and does not explain the perf hit. Perhaps this is a case of bad hashing and they are all falling into the same bucket? cc @sam.mcall for

[PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913065 , @mizvekov wrote: > In D136565#3911884 , @alexfh wrote: > >> Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d >>

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. lgtm. Though `__PPC64__` is kept in https://reviews.llvm.org/D137511, we prefer to use `__powerpc64__` which is documented in https://reviews.llvm.org/D137511. Repository: rG LLVM

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. In D137514#3912626 , @dotnwat wrote: > In D137514#3911046 , @ChuanqiXu > wrote: > >> This is helpful. I feel it is OK to add the warning in the clang too. Are >> you interested in

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

cor3ntin added a comment. There is a C++ standard meeting this week so some folks won't be able to review it. Feel free to re-ping next week if nobody else replies. Because it's a fairly big change and I've been known to miss glaring things, I don't feel comfortable to approve it. But it looks

[libunwind] 32a2af4 - [CMake] Fix -Wstrict-prototypes

Author: Sam James Date: 2022-11-08T01:37:04Z New Revision: 32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d URL: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d DIFF: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d.diff LOG:

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

jkorous added a comment. @aaron.ballman We'd like to start making progress on the implementation in parallel to iterating on the documentation and this is our first patch: https://reviews.llvm.org/D137346 Since we'll have about 4 people working full-time on this it isn't reasonable to expect

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473819. Febbe added a comment. Added some tests. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files:

[PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. In D137338#3912135 , @aaron.ballman wrote: > In D137338#3907281 , @Rageking8 > wrote: > >> I am ok with you guys taking the parts of this revision that you reviewed >> and directly

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

This revision was automatically updated to reflect the committed changes. Closed by commit rG41ce74e6e983: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 41ce74e - [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

Author: Sami Tolvanen Date: 2022-11-07T23:05:28Z New Revision: 41ce74e6e983f523d44d3a80be5ae778c35df85a URL: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a DIFF: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a.diff

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64802e8d3e9: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D137269?vs=472753=473807#toc Repository:

[clang] f64802e - [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

Author: Amara Emerson Date: 2022-11-07T15:04:09-08:00 New Revision: f64802e8d3e9db299cad913ffcb734c8d35dc5f0 URL: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0 DIFF: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0.diff

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG428ac8f3a0f9: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e230aa29f7: [clangd] Perform system include extraction inside CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 428ac8f - [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

Author: Nathan Ridge Date: 2022-11-07T17:58:42-05:00 New Revision: 428ac8f3a0f9572fcff03c2fae62c4ae8420a0df URL: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df DIFF: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df.diff

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa22c563f12: [clangd] Pass the entire tooling::CompileCommand to CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 68e230a - [clangd] Perform system include extraction inside CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:39-05:00 New Revision: 68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 URL: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 DIFF: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69.diff

[clang-tools-extra] afa22c5 - [clangd] Pass the entire tooling::CompileCommand to CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:37-05:00 New Revision: afa22c563f12f22da93b8f172d18c7991392d071 URL: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071 DIFF: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071.diff

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

yln accepted this revision. yln added a comment. This revision is now accepted and ready to land. Looks harmless enough.. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llvm.org/D137484

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473789. ayzhao added a comment. s/pro20/post20/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h

[PATCH] D135721: [HLSL] Added HLSL this as a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference (authored by gracejennings, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 86674f6 - [HLSL] Added HLSL this as a reference

Author: Grace Jennings Date: 2022-11-07T13:50:08-08:00 New Revision: 86674f66cc78a1a121d43fe51f076cbfa8710b1a URL: https://github.com/llvm/llvm-project/commit/86674f66cc78a1a121d43fe51f076cbfa8710b1a DIFF:

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473779. ayzhao added a comment. remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473772. ayzhao added a comment. whoops, uploaded the wrong commit. should be fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D137531: [clang] Fix the GitHub issue #58674

cor3ntin added a comment. Thanks for working on this. I agree with Aaron, can you make the commit message clearer as to what is fixed, and mention in clang/docs/ReleaseNotes that the issue is fixed. Comment at: clang/lib/Sema/SemaExpr.cpp:2698-2704 + if (!SS.isEmpty()) +

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473770. Febbe added a comment. Fixed lValueReference detection in matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files:

[PATCH] D137584: Add const information about AST nodes used to construct CFG elements.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most constructors and destructors in CFG.h already specify const arguments, but

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Followup to D134378 . With PrintingPolicy::SuppressScope, we'd also

[clang] cd8c6ab - [NFC] clang-format part of TypePrinter.cpp

Author: Arthur Eubanks Date: 2022-11-07T13:20:36-08:00 New Revision: cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 URL: https://github.com/llvm/llvm-project/commit/cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 DIFF:

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

This revision was automatically updated to reflect the committed changes. Closed by commit rGcafe50daf525: Explicitly initialize opaque pointer mode in CodeGenAction (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137475/new/

[clang] cafe50d - Explicitly initialize opaque pointer mode in CodeGenAction

Author: Matthias Braun Date: 2022-11-07T12:31:28-08:00 New Revision: cafe50daf525971ffc3b8c5f2f6343d24e381384 URL: https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384 DIFF:

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added a comment. I'd like to see some test coverage for what these changes catch that wasn't caught before. On its face, this seems reasonable in that we don't want to bother running the interpreter (further) once we know we've hit an expression, declaration, or type that's not

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM, though I found a few minor things. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. In D137205#3913192 , @Febbe wrote: > In D137205#3912243 , @Skylion007 > wrote: > >> One other bug I found with this diff, is it seems to suggest calling >> std::move() on function

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3912243 , @Skylion007 wrote: > One other bug I found with this diff, is it seems to suggest calling > std::move() on function args that are references, despite the fact that > invalidating the reference to the input

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3909043 , @zahiraam wrote: > In D136786#3907235 , > @michele.scandale wrote: > >> In D136786#3903646 , @zahiraam >> wrote: >> >>>

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/TargetSupport/CMakeLists.txt:2 + +set(LLVM_TARGET_DEFINITIONS ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/RISCV.td) + tmatheson wrote: > Here `RISCVTargetSupportTableGen` depends on files in `lib/Target/RISCV`, >

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. In D136565#3911884 , @alexfh wrote: > Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d > causes > compilation timeout on some of our internal files. Hi

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137475/new/ https://reviews.llvm.org/D137475 ___

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

MatzeB updated this revision to Diff 473747. MatzeB retitled this revision from "Explicitly initialize opaque pointer mode when -fthinlto-index is used" to "Explicitly initialize opaque pointer mode in CodeGenAction". MatzeB edited the summary of this revision. MatzeB added a comment. address

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping, does anyone else have any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 ___ cfe-commits mailing list

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473746. ayzhao added a comment. rebase + update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang/AST/Decl.h

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added reviewers: bnbarham, keith. haowei added a comment. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 ___ cfe-commits mailing

[PATCH] D137491: [clang][NFC] Use c++17 style variable type traits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG108e41d96246: [clang][NFC] Use c++17 style variable type traits (authored by njames93). Changed prior to commit:

[clang] 108e41d - [clang][NFC] Use c++17 style variable type traits

Author: Nathan James Date: 2022-11-07T18:25:48Z New Revision: 108e41d962463ea1cb956d1a929692a5b49c0a80 URL: https://github.com/llvm/llvm-project/commit/108e41d962463ea1cb956d1a929692a5b49c0a80 DIFF: https://github.com/llvm/llvm-project/commit/108e41d962463ea1cb956d1a929692a5b49c0a80.diff LOG:

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 473738. fpetrogalli added a comment. When looping through the records in tablegen, I have added an extra (necessary) condition to make sure that the records we are processing are also derived from the class `ProcessorModel`. Repository: rG LLVM

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with nits Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:47 +// MESSAGELEN: 0x{{.+}} | LF_BUILDINFO [size = {{.+}}] +// MESSAGELEN-NOT: 0x{{.+}}:

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli added a comment. In D137516#3912842 , @lenary wrote: > In D137516#3912751 , @fpetrogalli > wrote: > >> @arsenm @frasercrmck @lenary - thank you for the feedback >> >> 1. The library could host

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:509 -def : ProcessorModel<"generic-rv32", NoSchedModel, [Feature32Bit]>; -def : ProcessorModel<"generic-rv64", NoSchedModel, [Feature64Bit]>; +class RISCVProcessorModelPROC { + string Enum = enum;

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912751 , @fpetrogalli wrote: > @arsenm @frasercrmck @lenary - thank you for the feedback > > 1. The library could host anything that needs to be auto-generated with > tablegen. If we add `MVT`s, the name

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

aykevl created this revision. aykevl added reviewers: benshi001, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. aykevl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These macros are defined in avr-gcc and are

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD added a comment. Upon additional modification to this code base I am tempt to prefer having a `NumberOfCategories` under the enum and make the sanity check explicit. I understand this is totally a problem of personal taste so definitely feel free to argue with me :) Repository: rG

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD created this revision. eopXD added a reviewer: SjoerdMeijer. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. This change allows extension of new categories be aware of adding more code

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta added a reviewer: hans. thieta added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 ___ cfe-commits mailing list

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli added a comment. @arsenm @frasercrmck @lenary - thank you for the feedback 1. The library could host anything that needs to be auto-generated with tablegen. If we add `MVT`s, the name `TargetSupport` becomes obsolete. 2. Therefore we could use a name like `AutoGenSupport` (or

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

MaskRay added a comment. In D137511#3911149 , @nemanjai wrote: > I am going to block this since the uses of the macros in > `clang/lib/Headers/ppc_wrappers` will likely cause build bot failures. clang/lib/Headers/ppc_wrappers was fixed yesterday. The

[PATCH] D137373: [AIX][p] Add 64-bit Test Case to Linker Tests

cebowleratibm added a comment. Suggest: [Test][AIX][p] Add 64-bit driver expected output No summary required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137373/new/ https://reviews.llvm.org/D137373

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

dotnwat added a comment. In D137514#3911046 , @ChuanqiXu wrote: > This is helpful. I feel it is OK to add the warning in the clang too. Are you > interested in that? Yes, but unfortunately I'm very time constrained until the end of the year. Is that

[PATCH] D137372: [AIX][pg] Add 32-bit Test Case to Linker Tests

cebowleratibm added a comment. Use the [Test] tag in the abstract. Suggest: "[Test][AIX][pg] Add 32-bit expected driver output" No need for a summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D137372

[PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

tmatheson created this revision. tmatheson added reviewers: lenary, pratlucas, DavidSpickett. Herald added subscribers: hiraditya, kristof.beyls, dschuff. Herald added a project: All. tmatheson requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits,

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

xazax.hun added inline comments. Comment at: clang/docs/SafeBuffers.rst:124 + - Array subscript expression on raw arrays or raw pointers, + - unless the index is a compile-time constant ``0``, + - Increment and decrement of a raw pointer with operators ``++`` and ``--``;

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 473708. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp clang/test/AST/Interp/cxx20.cpp Index:

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 473707. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo updated this revision to Diff 473706. abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. corrected the syntex of the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/

[PATCH] D137563: [clang][Interp] Check declarations for constexpr-ness in Load() instructions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refering to non-constexpr variables in a constant

[PATCH] D137562: [clang][Interp] Start supporting virtual base classes

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed on IRC. This is just the bare minimum

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/CodeLens.cpp:93 + if (auto Loc = declToLocation(P->getCanonicalDecl())) +Super.locations.emplace_back(*Loc); +} As noted in the previous PR it may be of low value, I guess only

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 473693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp

[clang] 6ebca03 - [Clang] Update test after wasm intrinsics attribute change (NFC)

Author: Nikita Popov Date: 2022-11-07T17:42:35+01:00 New Revision: 6ebca0302126c43ec8614d26aa444060e7a6da76 URL: https://github.com/llvm/llvm-project/commit/6ebca0302126c43ec8614d26aa444060e7a6da76 DIFF: https://github.com/llvm/llvm-project/commit/6ebca0302126c43ec8614d26aa444060e7a6da76.diff

[PATCH] D137531: [clang] Fix the GitHub issue #58674

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. FWIW, it'd help reviewers out if you would use a more descriptive title for the patch than just the GitHub issue number (it's easier for us to keep reviews straight when they have more concrete titles). I made a

[PATCH] D137558: [clang][Interp] Reject reinterpret_casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An appropriate diagnostic has already been emitted

[PATCH] D137240: [clang][Interp] Support alignof()

aaron.ballman accepted this revision. aaron.ballman added a comment. In D137240#3909034 , @tbaeder wrote: > It's not really all that interesting since the current interpreter already > does all the work, but it works like this. Ahhh okay, that makes

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

aaron.ballman added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii added a comment. In D137375#3906777 , @MaskRay wrote: > This needs a clang/test/Driver test. And, does this work with --sysroot= ? Thanks for your comment. It seems there will need to be a separate patch for `--sysroot`. From my initial

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

tmatheson added inline comments. Comment at: llvm/lib/TargetSupport/CMakeLists.txt:2 + +set(LLVM_TARGET_DEFINITIONS ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/RISCV.td) + Here `RISCVTargetSupportTableGen` depends on files in `lib/Target/RISCV`, meaning the folder

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 updated this revision to Diff 473684. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Rebase, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133890/new/ https://reviews.llvm.org/D133890 Files:

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. I have done the deduping @phosek requested, and changed the variable names from `CMAKE_*` to `LLVMPROJ_*` which hopefully satisfies everyone's criteria. Happy with other non `LLVM_` options too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137556: [POC] Clang implementation for AArch64 SME and some SME2 builtins

sdesmalen created this revision. Herald added subscribers: ecnelises, jdoerfert, mgrang, hiraditya, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 473679. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Dedup code, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files:

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. I'm not convinced we should be leaving any of the other Target Parser information in Support, if we are doing this, though this creates layering issues which I've been trying to unpick. If you try to take `llvm/Support/*TargetParser*`, you find a few places where there

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. One other bug I found with this diff, is it seems to suggest calling std::move() on function args that are references, despite the fact that invalidating the reference to the input arg could be undesirable. For instance take a function that takes in a reference to a

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r updated this revision to Diff 473662. Trass3r edited the summary of this revision. Trass3r added a comment. remove bases codelens for classes fix lit test exclude self from ref count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske updated this revision to Diff 473659. balazske added a comment. Added more functions to StdLibraryFunctionsChecker. This is redundant with the StreamChecker for now but makes possible to remove the NULL stream check from StreamChecker and reduce overlap of the checkers. This way no

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136790/new/ https://reviews.llvm.org/D136790 ___ cfe-commits mailing

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry created this revision. v1nh1shungry added reviewers: tom-anders, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

  1   2   >