[PATCH] D137309: [clang] Added Swift support for RISCV

colemancda added a comment. In D137309#3914550 , @asb wrote: > In D137309#3914494 , @colemancda > wrote: > >> RV32 is enabled as well. I'll add unit tests. > > Great, thanks. Is it really the case that

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 475349. sepavloff added a comment. Removed support of `--config file`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 475347. haowei added a comment. Unit test failures under Windows should be fixed now. Root->name will also use base FS's current directory instead of process current directory now. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. @jhuber6 Turns out a rebase on top of trunk had ~200 test conflicts. During my last update in Sep, I had resolved all of the clang test conflicts and failures, there were only llvm test failures. At this point, I checked out commit 92bc3fb5

[libunwind] c507269 - [libunwind][LoongArch] Add 64-bit LoongArch support

Author: zhanglimin Date: 2022-11-15T14:37:00+08:00 New Revision: c5072695127e767a76973cdbed683215df31fa40 URL: https://github.com/llvm/llvm-project/commit/c5072695127e767a76973cdbed683215df31fa40 DIFF: https://github.com/llvm/llvm-project/commit/c5072695127e767a76973cdbed683215df31fa40.diff

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 475341. dhruvachak edited the summary of this revision. dhruvachak added a comment. Herald added subscribers: kosarev, jvesely. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/

[PATCH] D136354: [Driver] Enable nested configuration files

MaskRay added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an

[PATCH] D137512: [clang] Add Swift support for MIPS

colemancda updated this revision to Diff 475337. colemancda added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137512/new/ https://reviews.llvm.org/D137512 Files: clang/lib/Basic/Targets/Mips.h

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d7c448df9a: Fix `unsafe-fp-math` attribute emission. (authored by michele.scandale). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136786/new/

[clang] b7d7c44 - Fix `unsafe-fp-math` attribute emission.

Author: Michele Scandale Date: 2022-11-14T20:40:57-08:00 New Revision: b7d7c448df9a4679c1dfa079911f863e32d8e41f URL: https://github.com/llvm/llvm-project/commit/b7d7c448df9a4679c1dfa079911f863e32d8e41f DIFF:

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin updated this revision to Diff 475333. gonglingqin added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137809/new/

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

gonglingqin added inline comments. Comment at: clang/test/CodeGen/LoongArch/intrinsic-error.c:11 +void dbar() { + return __builtin_loongarch_dbar(32768); // expected-error {{argument value 32768 is outside the valid range [0, 32767]}} +} SixWeining wrote: >

[clang] 9044226 - [NFC] [C++20] [Modules] Remove unused Global Module Fragment variables/arguments

Author: Chuanqi Xu Date: 2022-11-15T11:51:13+08:00 New Revision: 9044226ba2dab1c8c4e7fb352c4c5b4d399052b4 URL: https://github.com/llvm/llvm-project/commit/9044226ba2dab1c8c4e7fb352c4c5b4d399052b4 DIFF: https://github.com/llvm/llvm-project/commit/9044226ba2dab1c8c4e7fb352c4c5b4d399052b4.diff

[PATCH] D137809: [LoongArch] Add immediate operand validity check for __builtin_loongarch_dbar

SixWeining added inline comments. Comment at: clang/test/CodeGen/LoongArch/intrinsic-error.c:11 +void dbar() { + return __builtin_loongarch_dbar(32768); // expected-error {{argument value 32768 is outside the valid range [0, 32767]}} +} Also check lower bound.

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a comment. @bruno ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131938: [C++20] [Coroutines] Disable to take the address of labels in coroutines

avogelsgesang added a comment. Personally, I am fine with this change as in review right now. @ychen are you still planning to look further into this issue as part of your alternative patch https://reviews.llvm.org/D132084 ? Otherwise, I would propose that we merge @ChuanqiXu 's change for the

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added a comment. @MaskRay wondering if this is a good change to make for ELF as well, wdyt? Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

shafik added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:996 +MPM.addPass(PrintModulePass(*OS, "", CodeGenOpts.EmitLLVMUseLists, +true /* EmitLTOSummary */)); + } Nitpick, but we should be

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - EXPECT_EQ(StringRef("functionCall(paramA, paramB,\n" - "paramC);\n" - "void

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 475313. gedare added a comment. - FormatTest: restore Input variable to one test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files:

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak created this revision. ahatanak added reviewers: jansvoboda11, akyrtzi. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. Each line in the file is a JSON object that has the name of the main

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem created this revision. mnadeem added reviewers: vzakhari, awarzynski, kiranchandramohan. mnadeem added a project: Flang. Herald added subscribers: ctetreau, jdoerfert, s.egerton, simoncook, fedor.sergeev, kristof.beyls, dschuff. Herald added a reviewer: sscalpone. Herald added a project:

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

shafik added a comment. This looks reasonable to me but not confident enough to approve it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 ___ cfe-commits

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. Nice! I'd love someone else's eyes on this, but that's a great speedup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137960/new/

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

stella.stamenova added a comment. In D135128#3921902 , @jansvoboda11 wrote: > @stella.stamenova Any updates? We haven't had time to come up with a proper solution yet. One short-term solution (assuming there's urgency in making the change) would be to

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri added a comment. In D136806#3926319 , @arsenm wrote: > I think SROA after unroll is important. It's practically the main reason to > unroll Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1200-1201

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

lebedev.ri updated this revision to Diff 475311. lebedev.ri retitled this revision from "[Pipelines] Introduce SROA after (full) loop unrolling" to "[Pipelines] Introduce SROA after (final, full) loop unrolling". lebedev.ri added a reviewer: arsenm. lebedev.ri added a comment. Herald added

[clang] b2fbafc - [NFC][Clang] Autogenerate checklines in a test being affected by a patch

Author: Roman Lebedev Date: 2022-11-15T03:51:24+03:00 New Revision: b2fbafc911062ba74761d69d035ee8686125f2fc URL: https://github.com/llvm/llvm-project/commit/b2fbafc911062ba74761d69d035ee8686125f2fc DIFF: https://github.com/llvm/llvm-project/commit/b2fbafc911062ba74761d69d035ee8686125f2fc.diff

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added a comment. In D136998#3926368 , @efriedma wrote: > In D136998#3926321 , @rnk wrote: > >> In D136998#3906874 , @efriedma >> wrote: >> >>> Should we try to

[PATCH] D133633: [CMake] Add ClangBootstrap configuration

Amir updated this revision to Diff 475309. Amir added a comment. Move out toolchain tools back into CMAKE_ARGS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133633/new/ https://reviews.llvm.org/D133633 Files: clang/CMakeLists.txt

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. I have a problem with lambdas capturing by copy implicitly (`[=]()...`). It seems like, that child nodes are not reachable via a MatchFinder unless they are spelled in source. I actually don't know how to prevent a fix elegantly: My proposed idea is, to check the source

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

efriedma added a comment. In D136998#3926321 , @rnk wrote: > In D136998#3906874 , @efriedma > wrote: > >> Should we try to use this codepath for variadic lambdas as well? > > Yes! > >> Do we want to try to unify

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

owenpan added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1006 + +TEST(FormatStyle, GetStyleWithEmptyFileName) { + llvm::vfs::InMemoryFileSystem FS; HazardyKnusperkeks wrote: > owenpan wrote: > > Otherwise, the test will be skipped.

[PATCH] D137806: [AST] Fix class layout when using external layout under MS ABI.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137806/new/ https://reviews.llvm.org/D137806 ___

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

rnk added a comment. In D136998#3906874 , @efriedma wrote: > Should we try to use this codepath for variadic lambdas as well? Yes! > Do we want to try to unify our cloning code? > CodeGenFunction::GenerateVarArgsThunk has code doing something

[clang] 77bf0df - Revert "[opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm"

Author: Fangrui Song Date: 2022-11-14T15:51:03-08:00 New Revision: 77bf0df376d7fcd305d9576511e7d0806b96971a URL: https://github.com/llvm/llvm-project/commit/77bf0df376d7fcd305d9576511e7d0806b96971a DIFF: https://github.com/llvm/llvm-project/commit/77bf0df376d7fcd305d9576511e7d0806b96971a.diff

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Code change LGTM, i think the doc change should be dropped or reshaped though. Comment at: clang/docs/JSONCompilationDatabase.rst:89 same file, for example if the

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

benlangmuir added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1561 else // FIXME: The path should be taken from the FileEntryRef. PP->Diag(SourceLocation(), diag::err_module_unable_to_hash_content) jansvoboda11

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return std::make_unique(std::move(OS), tejohnson wrote: > I think you might need

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475296. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files:

[clang] bf8381a - [opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm

Author: Alexander Shaposhnikov Date: 2022-11-14T23:24:08Z New Revision: bf8381a8bce28fc69857645cc7e84a72317e693e URL: https://github.com/llvm/llvm-project/commit/bf8381a8bce28fc69857645cc7e84a72317e693e DIFF:

[PATCH] D137992: [asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

rsundahl created this revision. Herald added a project: All. rsundahl requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The clang flag -fsanitize-address-outline-instrumentation should not only pass

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Serialization/ASTWriter.cpp:1561 else // FIXME: The path should be taken from the FileEntryRef.

[PATCH] D137989: [clang][deps] Avoid leaking modulemap paths across unrelated imports

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use a FileEntryRef when retrieving modulemap paths in the

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

rjmccall added a subscriber: jyknight. rjmccall added a comment. I don't have a problem with adding a sanitizer like this. IIRC, though, there's a review process for adding new sanitizers; I don't remember if this is the normal RFC process or something more streamlined. Also, I know @jyknight

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue created this revision. xingxue added reviewers: rjmccall, hubert.reinterpretcast, daltenty, cebowleratibm. xingxue added a project: LLVM. Herald added a project: All. xingxue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

vitalybuka added a comment. In D137381#3924698 , @lebedev.ri wrote: > Can someone from @Sanitizers please comment? :) @vitalybuka ? @glider ? > @rsmith ? > > In D137381#3923911 , @MaskRay wrote: > >> I think

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:68 +/// `LatticeT` can optionally provide the following members: +/// * `bool widen(const LatticeT )` - chooses a lattice element that +/// approximates the join of

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 475269. akhuang added a comment. Fix calling convention of cloned function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D137980: [ARM] Pretend atomics are always lock-free for small widths.

efriedma created this revision. efriedma added reviewers: nikic, t.p.northover, john.brawn, joerg, tomhughes, alanphipps, aykevl. Herald added subscribers: s.egerton, simoncook, hiraditya, kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added

[clang] 8c15c17 - Revert "[opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm"

Author: Alexander Shaposhnikov Date: 2022-11-14T21:31:30Z New Revision: 8c15c17e3ba7916b2efb2a100495c710bae04fb6 URL: https://github.com/llvm/llvm-project/commit/8c15c17e3ba7916b2efb2a100495c710bae04fb6 DIFF:

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd created this revision. compnerd added reviewers: aaron.ballman, sammccall. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. We would previously reject valid input where GNU attributes preceded

[clang] ef9e624 - [opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm

Author: Alexander Shaposhnikov Date: 2022-11-14T21:11:07Z New Revision: ef9e624694c0f125c53f7d0d3472fd486bada57d URL: https://github.com/llvm/llvm-project/commit/ef9e624694c0f125c53f7d0d3472fd486bada57d DIFF:

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef9e624694c0: [opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm (authored by alexander-shaposhnikov). Changed prior to

[PATCH] D137883: [clang-format][NFC] Improve documentation of FixNamespaceComments

HazardyKnusperkeks updated this revision to Diff 475257. HazardyKnusperkeks marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137883/new/ https://reviews.llvm.org/D137883 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3073-3076 + /// If ``true``, clang-format will attempt to re-flow comments. That is it + /// will touch a comment and *reflow* long comments into new lines, trying to + /// obey the

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks updated this revision to Diff 475253. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137865/new/ https://reviews.llvm.org/D137865 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D137563: [clang][Interp] Check declarations for constexpr-ness in Load() instructions

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:101 +static bool CheckConstexpr(InterpState , CodePtr OpPC, const Pointer ) { + if (!S.inConstantContext()) Is `CheckConstexpr` descriptive enough? Would something like

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

alexander-shaposhnikov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:988 if (CodeGenOpts.PrepareForThinLTO && !CodeGenOpts.DisableLLVMPasses) { if (!CodeGenOpts.ThinLinkBitcodeFile.empty()) { ThinLinkOS =

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - EXPECT_EQ(StringRef("functionCall(paramA, paramB,\n" - "paramC);\n" -

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1006 + +TEST(FormatStyle, GetStyleWithEmptyFileName) { + llvm::vfs::InMemoryFileSystem FS; owenpan wrote: >

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added a comment. The naming convention used here for COFF is actually very similar to what is done for other ThinLTO save-temps output files, which are placed at the input module locations. We may want to just do this across the board. @MaskRay wdyt? A few other questions/comments

[PATCH] D137562: [clang][Interp] Start supporting virtual base classes

shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.cpp:126 + auto CtorSub = [=](unsigned SubOff, Descriptor *F, bool IsBase, + bool Recurse = true) { auto *Desc = reinterpret_cast(Ptr + SubOff) - 1; To recurse or

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da41fe69622: [cmake] Fix _GNU_SOURCE being added unconditionally (authored by Trass3r, committed by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8da41fe - [cmake] Fix _GNU_SOURCE being added unconditionally

Author: Andreas Hollandt Date: 2022-11-14T12:28:21-08:00 New Revision: 8da41fe69622f35e0a15b5a1754cd670e6057938 URL: https://github.com/llvm/llvm-project/commit/8da41fe69622f35e0a15b5a1754cd670e6057938 DIFF:

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475242. francii added a comment. Add sysroot check to aix-ld.c test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files:

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added a comment. In D137851#3925661 , @jdoerfert wrote: > Drive by: Please add commit messages to non trivial changes to explaining > what's going on. Thanks. Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

njames93 accepted this revision. njames93 added a comment. Lg, but can you address that one nit before landing Comment at: clang-tools-extra/docs/ReleaseNotes.rst:169 +- Change the behavior of :doc:`readability-const-return-type + ` to not Can this be moved

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

efriedma added a comment. I'm not quite sure I understand what's happening here. Does this actually avoid generating two copies of the function body if both the call operator and the conversion are used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137851: [OPENMP]Initial support for at clause

jdoerfert added a comment. Drive by: Please add commit messages to non trivial changes to explaining what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137972: [clang-tidy] Optionally ignore findings in macros in `readability-const-return-type`.

ymandel created this revision. ymandel added reviewers: njames93, thomasetter. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Adds support for options-controlled configuration

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'.

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475225. jyu2 added a comment. Thanks Alexey! Address Alexey comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

ymandel updated this revision to Diff 475224. ymandel added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137968/new/ https://reviews.llvm.org/D137968 Files:

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 﫢

stephanemoore updated this revision to Diff 475222. stephanemoore added a subscriber: Eugene.Zelenko. stephanemoore added a comment. Included namespace comment linter fixes from D137740 as advised by @Eugene.Zelenko, Repository: rG LLVM Github Monorepo

[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv

arsenm closed this revision. arsenm added a comment. 840a793375fec763c2b2781b82b764325635cc7a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137874/new/ https://reviews.llvm.org/D137874

[clang] 840a793 - clang/AMDGPU: Use Support's wrapper around getenv

Author: Matt Arsenault Date: 2022-11-14T11:07:31-08:00 New Revision: 840a793375fec763c2b2781b82b764325635cc7a URL: https://github.com/llvm/llvm-project/commit/840a793375fec763c2b2781b82b764325635cc7a DIFF:

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

ymandel created this revision. ymandel added reviewers: njames93, thomasetter. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Overrides are constrained by the signature of the

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. I'll hold off on submitting this until that bug is figured out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ cfe-commits

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Mon, Nov 14, 2022 at 1:14 PM Paul Eggert wrote: > > On 2022-11-14 04:41, Aaron Ballman wrote: > > it's generally a problem when autoconf relies on invalid > > language constructs > > Autoconf *must* rely on invalid language constructs, if only to test > whether the language constructs work.

Re: How can Autoconf help with the transition to stricter compilation defaults?

* Paul Eggert: > On 2022-11-14 04:41, Aaron Ballman wrote: >> it's generally a problem when autoconf relies on invalid >> language constructs > > Autoconf *must* rely on invalid language constructs, if only to test > whether the language constructs work. And Clang therefore must be > careful

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475203. francii added a comment. Add sysroot to test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-14 04:41, Aaron Ballman wrote: it's generally a problem when autoconf relies on invalid language constructs Autoconf *must* rely on invalid language constructs, if only to test whether the language constructs work. And Clang therefore must be careful about how it diagnoses invalid

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475197. francii added a comment. Remove check for -p Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475196. francii added a comment. Add profiled libraries check AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files:

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475194. francii added a comment. Fix mixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Dotdots were removed only when converting a relative path to absolute

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475187. francii added a comment. Herald added a subscriber: ormris. Removed check for sysroot, it is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1456 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib Worth a

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille added a comment. Compile time tracker record : https://llvm-compile-time-tracker.com/compare.php?from=f71d32a0eea47b3d2bb43d6be15cf09d47ef6971=b4df7d2a01aacd29ae539b04e72b3667e2362aa1=instructions:u The cost of preprocessing is hidden by the optimization time, but -O0 gives an

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille created this revision. serge-sans-paille added reviewers: lattner, nikic. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only reset "NeedsCleaning" flag in case of

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. > One thing that we did notice is that adding `-fno-global-isel` to cflags and > ldflags only had an effect when manually blowing away the thinlto cache. > Maybe whatever decides when to invalidate the thinlto cache needs to learn to > invalidate it when the

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 475180. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'.

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] cbcf123 - [LegacyPM] Remove cl::opts controlling optimization pass manager passes

Author: Arthur Eubanks Date: 2022-11-14T09:38:17-08:00 New Revision: cbcf123af293ee56876cce16dac83c3008478dae URL: https://github.com/llvm/llvm-project/commit/cbcf123af293ee56876cce16dac83c3008478dae DIFF:

  1   2   >